/sentry/provider/db/service/persistent/TestSentryStore.java
Lines 3574-3580 (patched)
<https://reviews.apache.org/r/63596/#comment270362>
Since this part is repeating through multiple files, is it helpful to
create a function and call the function?
- Xinran Tinney
On Nov. 29, 2017, 5:
.sh d58d5e5c
> bin/sentry 54e545aa
> pom.xml dd408d85
> sentry-command-line-tools/pom.xml PRE-CREATION
>
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryMain.java
> 3a981b2a
>
>
> Diff: https://reviews.apache.org/r/64259/diff/2/
>
>
> Testing
> ---
>
> mvn clean install, on cloudcat and all SUCCESS
>
>
> Thanks,
>
> Xinran Tinney
>
>
/sentry/provider/db/generic/tools/command/GenericShellCommand.java
Lines 112 (patched)
<https://reviews.apache.org/r/63668/#comment268425>
Hi, can this be done through calling client.listRolesByGroupName()?
- Xinran Tinney
On Nov. 8, 2017, 3:34 p.m., Colm O hEigeartaigh
r/64259/diff/1-2/
Testing
---
mvn clean install, on cloudcat and all SUCCESS
Thanks,
Xinran Tinney
e-common/src/main/java/org/apache/sentry/SentryMain.java
3a981b2a
sentry-main/pom.xml PRE-CREATION
Diff: https://reviews.apache.org/r/64259/diff/1/
Testing
---
mvn clean install, on cloudcat and all SUCCESS
Thanks,
Xinran Tinney
parent pom, log4j already has
1.2.16, should we just ignore version in the
child pom?
- Xinran
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64259/#review193957
-------
ps://reviews.apache.org/r/64259/diff/2-3/
Testing
---
mvn clean install, on cloudcat and all SUCCESS
Thanks,
Xinran Tinney
> On Jan. 2, 2018, 5:04 p.m., Steve Moist wrote:
> > pom.xml
> > Lines 117 (patched)
> > <https://reviews.apache.org/r/64890/diff/1/?file=1929483#file1929483line117>
> >
> > Looks like 4.2.1 is the latest version, any reason why we're not using
&g
quot;, I guess I should generate the
patch first and then test it
- Xinran
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64259/#review194789
-------
On Dec. 20, 2017, 4:54 p.m., Xinran Tinney wrote:
>
> ---
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64259/#review195083
---
On Jan. 5, 2018, 3:08 p.m., Xinran Tinney wrote:
>
> --
/65046/diff/3/
Changes: https://reviews.apache.org/r/65046/diff/2-3/
Testing
---
'mvn clean install' on testing cluster.
Thanks,
Xinran Tinney
-CREATION
Diff: https://reviews.apache.org/r/65028/diff/1/
Testing
---
'mvn clean install' on the cluster and all tests succeess.
Thanks,
Xinran Tinney
ean install, on cloudcat and all SUCCESS
Thanks,
Xinran Tinney
/tests/e2e/hive/TestUserManagement.java
fd8ec56
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUserManagement.java
fd8ec56
Diff: https://reviews.apache.org/r/65046/diff/1/
Testing
---
'mvn clean install' on testing cluster.
Thanks,
Xinran Tinney
: https://reviews.apache.org/r/65046/diff/4/
Changes: https://reviews.apache.org/r/65046/diff/3-4/
Testing
---
'mvn clean install' on testing cluster.
Thanks,
Xinran Tinney
-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/LeaderStatusMonitor.java
25a70bda
Diff: https://reviews.apache.org/r/65388/diff/1/
Testing
---
mvn clean install
Thanks,
Xinran Tinney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65487/#review196917
---
Ship it!
Ship It!
- Xinran Tinney
On Feb. 2, 2018, 7:31 p.m
<https://reviews.apache.org/r/65533/#comment277470>
can this string be created as a string variable so no need to hard coded
- Xinran Tinney
On Feb. 6, 2018, 7:06 p.m., kalyan kumar kalvagadda wrote:
>
> ---
> This is an auto
(patched)
<https://reviews.apache.org/r/65268/#comment277316>
should be a new line from "if"
- Xinran Tinney
On Feb. 7, 2018, 6:04 p.m., kalyan kumar kalvagadda wrote:
>
> ---
> This is an automatically g
> On Feb. 9, 2018, 9:17 p.m., Xinran Tinney wrote:
> > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
> > Lines 3423 (patched)
> > <https://reviews.apache.org/r/65268/diff/7/?file=195
ps://reviews.apache.org/r/65715/#review198001
-------
On Feb. 20, 2018, 8:37 p.m., Xinran Tinney wrote:
>
> ---
> This is an automatically generated e-mail.
tch.
- Xinran
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65715/#review197973
---
On Feb. 20, 2018, 8:37 p.m., Xinran Tinney wrote:
>
> ---
>
/sentry/binding/util/SentryAuthorizerUtil.java
Lines 228-229 (patched)
<https://reviews.apache.org/r/65642/#comment278068>
This is converting from long to int, will there be overflow?
- Xinran Tinney
On Feb. 17, 2018, 12:30 a.m., Na Li
> On Jan. 11, 2018, 11:19 p.m., Sergio Pena wrote:
> > It looks good.
> >
> > Did you test that all the commands which use SentryMain work correctly?
> > bin/sentry, bin/run_sentry.sh, bin/config_tool?
>
> Xinran Tinney wrote:
> I have not, how to ve
/TestHDFSIntegrationWithHA.java
96a2f901
Diff: https://reviews.apache.org/r/65715/diff/1/
Testing
---
mvn clean install all success
Thanks,
Xinran Tinney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65642/#review197807
---
Ship it!
Ship It!
- Xinran Tinney
On Feb. 20, 2018, 8:04
/sentry-provider-db/target/site/clover/clover.xml'
Thanks,
Xinran Tinney
/sentry/provider/common/ResourceAuthorizationProvider.java
Line 77 (original), 79 (patched)
<https://reviews.apache.org/r/64317/#comment273666>
There is another parameter 'roleSet' not mentioned here
- Xinran Tinney
On Dec. 29, 2017, 11:30 p.m., Zachary Amsden
ps://reviews.apache.org/r/64890/#review194640
-------
On Jan. 2, 2018, 4:43 p.m., Xinran Tinney wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64890/
> -
/SqoopAuthBinding.java
539ccc13
Diff: https://reviews.apache.org/r/67975/diff/1/
Testing
---
Thanks,
Xinran Tinney
nding.java
32a1fc15
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java
539ccc13
Diff: https://reviews.apache.org/r/67975/diff/2/
Changes: https://reviews.apache.org/r/67975/diff/1-2/
Testing
---
Thanks,
Xinran Tinney
kalvagadda, Na Li, Steve Moist, Sergio Pena, Vadim Spector, and Xinran Tinney.
Repository: sentry
Description
---
Since 2.0, the datanucleus version in Sentry changed from 3.2 to 4.1.
Based on the datanucleus documentation following config names are renamed.
Sentry has several places use those
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66337/#review201211
---
Ship it!
Ship It!
- Xinran Tinney
On March 28, 2018, 4:16
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66480/#review201210
---
Is SENTRY-2140 titled: Attribute based access control?
- Xinran
atched)
<https://reviews.apache.org/r/66590/#comment282339>
do we have coding style restrictions for long lines?
- Xinran Tinney
On April 12, 2018, 8:45 p.m., Steve Moist wrote:
>
> ---
> This is an automatically generated e-
/src/main/java/org/apache/sentry/provider/common/ProviderBackend.java
761fb527
Diff: https://reviews.apache.org/r/69201/diff/1/
Testing
---
mvn clean install
Thanks,
Xinran Tinney
36 matches
Mail list logo