Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51449/#review153970 --- Ship it! Ship It! - Hao Hao On Oct. 26, 2016, 8:04 a.m., Col

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51449/#review153930 --- Ship it! Ship It! - Alexander Kolbasov On Oct. 26, 2016, 8:0

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

> On Oct. 26, 2016, 4:07 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/TransactionManager.java, > > line 107 > > > > > > Do you

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

> On Oct. 26, 2016, 4:07 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java, > > line 262 > > > > > > Is this related on unrelated

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

> On Oct. 26, 2016, 4:18 a.m., Alexander Kolbasov wrote: > > This is pretty big patch, it would be better to avoid unrelated changes > > mixed up. Thanks for the comments, will remove the unrelated changes for the transaction refactor. - Colin --

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51449/ --- (Updated Oct. 26, 2016, 8:04 a.m.) Review request for sentry. Repository: sen

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51449/#review153848 --- This is pretty big patch, it would be better to avoid unrelated ch

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51449/#review153841 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51449/ --- (Updated Oct. 25, 2016, 3 a.m.) Review request for sentry. Repository: sentry

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

> On Oct. 23, 2016, 9:54 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/TransactionManager.java, > > line 94 > > > > > > I am not

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

> On Oct. 23, 2016, 9:55 p.m., Alexander Kolbasov wrote: > > Thank you very much for this change - it is very useful! > > What would be the commit message? The current one is a duplicate of the > > information in the JIRA - I think it should be enough to reference JIRA. Thanks for your review,

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51449/ --- (Updated Oct. 24, 2016, 8:14 a.m.) Review request for sentry. Repository: sen

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51449/#review153664 --- Thank you very much for this change - it is very useful! What wou

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51449/#review153663 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51449/ --- (Updated Oct. 20, 2016, 3:46 a.m.) Review request for sentry. Repository: sen

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51449/#review153038 --- It is a lot of repeated code - is it possible to have common code

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51449/ --- (Updated Oct. 14, 2016, 2:48 a.m.) Review request for sentry. Repository: sen