Re: Review Request 53520: SENTRY-1517: SentryStore shoud actually use function getMSentryRole to get roles

2016-12-01 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53520/#review157649 --- Ship it! Ship It! - Hao Hao On Dec. 1, 2016, 2:56 a.m., Alex

Re: Review Request 53520: SENTRY-1517: SentryStore shoud actually use function getMSentryRole to get roles

2016-11-30 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53520/ --- (Updated Dec. 1, 2016, 2:56 a.m.) Review request for sentry, Colm O hEigeartaig

Re: Review Request 53520: SENTRY-1517: SentryStore shoud actually use function getMSentryRole to get roles

2016-11-30 Thread Alexander Kolbasov
> On Dec. 1, 2016, 12:28 a.m., Hao Hao wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, > > line 253 > > > > > > Why do we need this?

Re: Review Request 53520: SENTRY-1517: SentryStore shoud actually use function getMSentryRole to get roles

2016-11-30 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53520/#review157507 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 53520: SENTRY-1517: SentryStore shoud actually use function getMSentryRole to get roles

2016-11-30 Thread Vadim Spector
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53520/#review157482 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen