Re: Review Request 65642: SENTRY-2141: Sentry Privilege TimeStamp is not converted to grantTime in HivePrivilegeInfo correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65642/#review197807 --- Ship it! Ship It! - Xinran Tinney On Feb. 20, 2018, 8:04

Re: Review Request 65642: SENTRY-2141: Sentry Privilege TimeStamp is not converted to grantTime in HivePrivilegeInfo correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65642/#review197802 --- Ship it! Ship It! - kalyan kumar kalvagadda On Feb. 20,

Re: Review Request 65642: SENTRY-2141: Sentry Privilege TimeStamp is not converted to grantTime in HivePrivilegeInfo correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65642/ --- (Updated Feb. 20, 2018, 8:04 p.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 65642: SENTRY-2141: Sentry Privilege TimeStamp is not converted to grantTime in HivePrivilegeInfo correctly

> On Feb. 20, 2018, 5:34 p.m., Xinran Tinney wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/util/SentryAuthorizerUtil.java > > Lines 228-229 (patched) > > > > > > This is

Re: Review Request 65642: SENTRY-2141: Sentry Privilege TimeStamp is not converted to grantTime in HivePrivilegeInfo correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65642/#review197787 ---

Re: Review Request 65642: SENTRY-2141: Sentry Privilege TimeStamp is not converted to grantTime in HivePrivilegeInfo correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65642/#review197780 ---

Re: Review Request 65642: SENTRY-2141: Sentry Privilege TimeStamp is not converted to grantTime in HivePrivilegeInfo correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65642/ --- (Updated Feb. 17, 2018, 12:30 a.m.) Review request for sentry, Arjun Mishra,

Re: Review Request 65642: SENTRY-2141: Sentry Privilege TimeStamp is not converted to grantTime in HivePrivilegeInfo correctly

> On Feb. 16, 2018, 4:59 p.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/util/SentryAuthorizerUtil.java > > Lines 226 (patched) > > > > > > Are you

Re: Review Request 65642: SENTRY-2141: Sentry Privilege TimeStamp is not converted to grantTime in HivePrivilegeInfo correctly

> On Feb. 16, 2018, 4:59 p.m., kalyan kumar kalvagadda wrote: > > test mode is set to true in TestCommonPrivilege. You can exend that test > > class to override that and add your test in that class. It's better to have > > a test. > > > > Do you know that standard proactice in other

Re: Review Request 65642: SENTRY-2141: Sentry Privilege TimeStamp is not converted to grantTime in HivePrivilegeInfo correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65642/#review197685 ---

Re: Review Request 65642: SENTRY-2141: Sentry Privilege TimeStamp is not converted to grantTime in HivePrivilegeInfo correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65642/#review197679 --- Ship it! Ship It! - Steve Moist On Feb. 14, 2018, 12:51

Re: Review Request 65642: SENTRY-2141: Sentry Privilege TimeStamp is not converted to grantTime in HivePrivilegeInfo correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65642/#review197678 --- test mode is set to true in TestCommonPrivilege. You can exend

Re: Review Request 65642: SENTRY-2141: Sentry Privilege TimeStamp is not converted to grantTime in HivePrivilegeInfo correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65642/#review197486 --- Ship it! Ship It! - Arjun Mishra On Feb. 14, 2018, 12:51

Re: Review Request 65642: SENTRY-2141: Sentry Privilege TimeStamp is not converted to grantTime in HivePrivilegeInfo correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65642/#review197485 --- Ship it! Ship It! - Arjun Mishra On Feb. 14, 2018, 12:51