Re: Review Request 52150: SENTRY-1478: Disable fencing in Sentry store for Active/Active

2016-10-03 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52150/#review151226 --- Ship it! Ship It! - Hao Hao On Sept. 30, 2016, 12:18 a.m.,

Re: Review Request 52150: SENTRY-1478: Disable fencing in Sentry store for Active/Active

2016-09-29 Thread Li Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52150/ --- (Updated Sept. 30, 2016, 12:18 a.m.) Review request for sentry, Alexander

Re: Review Request 52150: SENTRY-1478: Disable fencing in Sentry store for Active/Active

2016-09-22 Thread Anne Yu
> On Sept. 22, 2016, 7:56 p.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java, > > line 97 > > > > > > I think we may still want to keep the

Re: Review Request 52150: SENTRY-1478: Disable fencing in Sentry store for Active/Active

2016-09-22 Thread Li Li
> On Sept. 22, 2016, 7:56 p.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java, > > line 97 > > > > > > I think we may still want to keep the

Re: Review Request 52150: SENTRY-1478: Disable fencing in Sentry store for Active/Active

2016-09-22 Thread Li Li
> On Sept. 22, 2016, 6:34 p.m., Sravya Tirukkovalur wrote: > > Thanks for the patch Li Li! This change seems to be from design V2.1. I > > think it makes sense to mention that in the jira and also wait for a few > > days for the community to review the new design before moving ahead. What > >

Re: Review Request 52150: SENTRY-1478: Disable fencing in Sentry store for Active/Active

2016-09-22 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52150/#review150038 --- Not mean to object check-in this patch. Just a question, after