[GitHub] codecov-io commented on issue #279: SCB-336 1.add ut about find instance with tag 2.optimize find api

codecov-io commented on issue #279: SCB-336 1.add ut about find instance with tag 2.optimize find api URL: https://github.com/apache/incubator-servicecomb-service-center/pull/279#issuecomment-364032781 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/279?

[GitHub] coveralls commented on issue #279: SCB-336 1.add ut about find instance with tag 2.optimize find api

coveralls commented on issue #279: SCB-336 1.add ut about find instance with tag 2.optimize find api URL: https://github.com/apache/incubator-servicecomb-service-center/pull/279#issuecomment-364033007 [](https://coveralls.i

[GitHub] coveralls commented on issue #134: SCB-330 update document of pack

coveralls commented on issue #134: SCB-330 update document of pack URL: https://github.com/apache/incubator-servicecomb-saga/pull/134#issuecomment-364034015 [](https://coveralls.io/builds/15428886) Coverage increased

[GitHub] liubao68 commented on issue #551: [SCB-331] log optimization

liubao68 commented on issue #551: [SCB-331] log optimization URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/551#issuecomment-364035766 Need english speaker to check. I think it's not better than before. --

[GitHub] liubao68 commented on a change in pull request #549: [SCB-315] Resolve the Registry-Service UT test fail

liubao68 commented on a change in pull request #549: [SCB-315] Resolve the Registry-Service UT test fail URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/549#discussion_r165809804 ## File path: foundations/foundation-vertx/src/main/java/org/apache/servicecomb

[GitHub] liubao68 closed pull request #544: [SCB-325] report sdk version when register to SC

liubao68 closed pull request #544: [SCB-325] report sdk version when register to SC URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/544 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of pr

[GitHub] WillemJiang closed pull request #122: SCB-239 omega stateless

WillemJiang closed pull request #122: SCB-239 omega stateless URL: https://github.com/apache/incubator-servicecomb-saga/pull/122 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] WillemJiang commented on issue #117: SCB-224 support retry sub-transaction

WillemJiang commented on issue #117: SCB-224 support retry sub-transaction URL: https://github.com/apache/incubator-servicecomb-saga/pull/117#issuecomment-364043048 @zhang2014 Could you rebase the master branch? This is

[GitHub] WillemJiang closed pull request #134: SCB-330 update document of pack

WillemJiang closed pull request #134: SCB-330 update document of pack URL: https://github.com/apache/incubator-servicecomb-saga/pull/134 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] liubao68 commented on a change in pull request #552: [SCB-294]when send a request to a not exist microservice, edge will always try to find instances of it

liubao68 commented on a change in pull request #552: [SCB-294]when send a request to a not exist microservice, edge will always try to find instances of it URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/552#discussion_r166874639 ## File path: service-regis

[GitHub] coveralls commented on issue #553: [SCB-314] Support custom rest transport server compress and max heade?

coveralls commented on issue #553: [SCB-314] Support custom rest transport server compress and max heade? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/553#issuecomment-363718771 [](https://coverall

[GitHub] WillemJiang closed pull request #549: [SCB-315] Resolve the Registry-Service UT test fail

WillemJiang closed pull request #549: [SCB-315] Resolve the Registry-Service UT test fail URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/549 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] zhengyangyong commented on issue #550: [SCB-327] Update metrics publish data module

zhengyangyong commented on issue #550: [SCB-327] Update metrics publish data module URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/550#issuecomment-364108895 Rebase and resolved conflicts This is an a

[GitHub] coveralls commented on issue #550: [SCB-327] Update metrics publish data module

coveralls commented on issue #550: [SCB-327] Update metrics publish data module URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/550#issuecomment-363366448 [](https://coveralls.io/builds/15433378)

[GitHub] wujimin commented on a change in pull request #552: [SCB-294]when send a request to a not exist microservice, edge will always try to find instances of it

wujimin commented on a change in pull request #552: [SCB-294]when send a request to a not exist microservice, edge will always try to find instances of it URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/552#discussion_r167111736 ## File path: service-regist

[GitHub] wujimin commented on a change in pull request #552: [SCB-294]when send a request to a not exist microservice, edge will always try to find instances of it

wujimin commented on a change in pull request #552: [SCB-294]when send a request to a not exist microservice, edge will always try to find instances of it URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/552#discussion_r167112054 ## File path: service-regist

[GitHub] wujimin commented on a change in pull request #552: [SCB-294]when send a request to a not exist microservice, edge will always try to find instances of it

wujimin commented on a change in pull request #552: [SCB-294]when send a request to a not exist microservice, edge will always try to find instances of it URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/552#discussion_r167112433 ## File path: service-regist

[GitHub] wujimin commented on issue #548: [SCB-326] Using the EventManager directly

wujimin commented on issue #548: [SCB-326] Using the EventManager directly URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/548#issuecomment-364298547 need test do not merge now. This is an automated

[GitHub] wujimin commented on a change in pull request #552: [SCB-294]when send a request to a not exist microservice, edge will always try to find instances of it

wujimin commented on a change in pull request #552: [SCB-294]when send a request to a not exist microservice, edge will always try to find instances of it URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/552#discussion_r167113147 ## File path: service-regist

[GitHub] zhengyangyong commented on issue #548: [SCB-326] Using the EventManager directly

zhengyangyong commented on issue #548: [SCB-326] Using the EventManager directly URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/548#issuecomment-364299608 test result is here in comment : https://issues.apache.org/jira/projects/SCB/issues/SCB-326 --

[GitHub] wujimin commented on a change in pull request #553: [SCB-314] Support custom rest transport server compress and max heade?

wujimin commented on a change in pull request #553: [SCB-314] Support custom rest transport server compress and max heade? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/553#discussion_r167113792 ## File path: demo/demo-springmvc/springmvc-client/src/main/j

[GitHub] wujimin commented on a change in pull request #551: [SCB-331] log optimization

wujimin commented on a change in pull request #551: [SCB-331] log optimization URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/551#discussion_r167114260 ## File path: foundations/foundation-config/src/main/java/org/apache/servicecomb/config/ConfigUtil.java #

[GitHub] wujimin commented on a change in pull request #543: [SCB-324] Fault-Injection handler implementation

wujimin commented on a change in pull request #543: [SCB-324] Fault-Injection handler implementation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/543#discussion_r167115189 ## File path: handlers/handler-fault-injection/src/main/java/org/apache/servicecomb

[GitHub] zhengyangyong commented on issue #548: [SCB-326] Using the EventManager directly

zhengyangyong commented on issue #548: [SCB-326] Using the EventManager directly URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/548#issuecomment-364299608 Performance test show use custom EventBus has better performance than use EventBus in guava **may cause by g

[GitHub] zhengyangyong commented on issue #548: [SCB-326] Using the EventManager directly

zhengyangyong commented on issue #548: [SCB-326] Using the EventManager directly URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/548#issuecomment-364299608 Performance test show use custom EventBus has better performance than use EventBus in guava **may cause by g

[GitHub] WillemJiang commented on a change in pull request #550: [SCB-327] Update metrics publish data module

WillemJiang commented on a change in pull request #550: [SCB-327] Update metrics publish data module URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/550#discussion_r167116882 ## File path: metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/cor

[GitHub] zhengyangyong commented on issue #548: [SCB-326] Using the EventManager directly

zhengyangyong commented on issue #548: [SCB-326] Using the EventManager directly URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/548#issuecomment-364299608 Performance test show use custom EventBus has better performance than use EventBus in guava **May cause by g

[GitHub] liubao68 commented on a change in pull request #552: [SCB-294]when send a request to a not exist microservice, edge will always try to find instances of it

liubao68 commented on a change in pull request #552: [SCB-294]when send a request to a not exist microservice, edge will always try to find instances of it URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/552#discussion_r167117453 ## File path: service-regis

[GitHub] liubao68 commented on a change in pull request #552: [SCB-294]when send a request to a not exist microservice, edge will always try to find instances of it

liubao68 commented on a change in pull request #552: [SCB-294]when send a request to a not exist microservice, edge will always try to find instances of it URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/552#discussion_r167117609 ## File path: service-regis

[GitHub] liubao68 commented on a change in pull request #552: [SCB-294]when send a request to a not exist microservice, edge will always try to find instances of it

liubao68 commented on a change in pull request #552: [SCB-294]when send a request to a not exist microservice, edge will always try to find instances of it URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/552#discussion_r167117568 ## File path: service-regis

[GitHub] zhengyangyong commented on issue #548: [SCB-326] Using the EventManager directly

zhengyangyong commented on issue #548: [SCB-326] Using the EventManager directly URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/548#issuecomment-364299608 Performance test show use custom EventBus has better performance than use EventBus in guava **May cause by g

[GitHub] WillemJiang commented on a change in pull request #550: [SCB-327] Update metrics publish data module

WillemJiang commented on a change in pull request #550: [SCB-327] Update metrics publish data module URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/550#discussion_r167118327 ## File path: metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/cor

[GitHub] zhengyangyong commented on issue #548: [SCB-326] Using the EventManager directly

zhengyangyong commented on issue #548: [SCB-326] Using the EventManager directly URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/548#issuecomment-364299608 Performance test show use custom EventBus has better performance than use EventBus in guava May cause by gua

[GitHub] zhengyangyong commented on issue #548: [SCB-326] Using the EventManager directly

zhengyangyong commented on issue #548: [SCB-326] Using the EventManager directly URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/548#issuecomment-364299608 Performance test show use custom EventBus has better performance than use EventBus in guava May cause by gua

[GitHub] zhengyangyong closed pull request #548: [SCB-326] Using the EventManager directly

zhengyangyong closed pull request #548: [SCB-326] Using the EventManager directly URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/548 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of prov

[GitHub] coveralls commented on issue #552: [SCB-294]when send a request to a not exist microservice, edge will always try to find instances of it

coveralls commented on issue #552: [SCB-294]when send a request to a not exist microservice, edge will always try to find instances of it URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/552#issuecomment-363690800 [![Coverage Status](https://coveralls.io/builds/1

[GitHub] coveralls commented on issue #552: [SCB-294]when send a request to a not exist microservice, edge will always try to find instances of it

coveralls commented on issue #552: [SCB-294]when send a request to a not exist microservice, edge will always try to find instances of it URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/552#issuecomment-363690800 [![Coverage Status](https://coveralls.io/builds/1

[GitHub] jeho0815 commented on a change in pull request #553: [SCB-314] Support custom rest transport server compress and max heade?

jeho0815 commented on a change in pull request #553: [SCB-314] Support custom rest transport server compress and max heade? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/553#discussion_r167131025 ## File path: demo/demo-springmvc/springmvc-client/src/main/

[VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1

Hi All, This is a call for vote to release ServiceComb Service-Center (Incubating)  version 1.0.0-m1 Release Notes:  https://github.com/asifdxtreme/incubator-servicecomb-service-center/tree/master/docs/release-notes     Release Candidate:  https://dist.apache.org/repos/dist/dev/incubator/servicec

[GitHub] zhengyangyong commented on a change in pull request #550: [SCB-327] Update metrics publish data module

zhengyangyong commented on a change in pull request #550: [SCB-327] Update metrics publish data module URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/550#discussion_r167134471 ## File path: metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/c

[GitHub] zhengyangyong commented on a change in pull request #550: [SCB-327] Update metrics publish data module

zhengyangyong commented on a change in pull request #550: [SCB-327] Update metrics publish data module URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/550#discussion_r167134620 ## File path: metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/c

[GitHub] coveralls commented on issue #550: [SCB-327] Update metrics publish data module

coveralls commented on issue #550: [SCB-327] Update metrics publish data module URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/550#issuecomment-363366448 [](https://coveralls.io/builds/15446953)

[GitHub] jeho0815 opened a new pull request #553: [SCB-314] Support custom rest transport server compress and max heade?

jeho0815 opened a new pull request #553: [SCB-314] Support custom rest transport server compress and max heade? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/553 ?r size Follow this checklist to help us incorporate your contribution quickly and easily:

[GitHub] jeho0815 closed pull request #553: [SCB-314] Support custom rest transport server compress and max heade?

jeho0815 closed pull request #553: [SCB-314] Support custom rest transport server compress and max heade? URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/553 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed be

??????[VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1

+1 Tested build from source on linux/windows machine and tested user case to be OK -- -- ??: "Mohammad Asif Siddiqui"; : 2018??2??9??(??) 11:26 ??: "dev@servicecomb.apache.org"; : [VOTE] Release Apache ServiceComb Service-Ce