[GitHub] lexkong commented on issue #311: go build -o service-center get many errors

2018-03-18 Thread GitBox
lexkong commented on issue #311: go build -o service-center get many errors URL: https://github.com/apache/incubator-servicecomb-service-center/issues/311#issuecomment-373985539 thank you! i have build it success according #312

[GitHub] asifdxtreme commented on issue #311: go build -o service-center get many errors

2018-03-18 Thread GitBox
asifdxtreme commented on issue #311: go build -o service-center get many errors URL: https://github.com/apache/incubator-servicecomb-service-center/issues/311#issuecomment-373985670 Thanks @lexkong , we will go ahead and close the issue.

[GitHub] asifdxtreme closed issue #311: go build -o service-center get many errors

2018-03-18 Thread GitBox
asifdxtreme closed issue #311: go build -o service-center get many errors URL: https://github.com/apache/incubator-servicecomb-service-center/issues/311 This is an automated message from the Apache Git Service. To respond to

[GitHub] asifdxtreme commented on issue #312: did service center do some basic install test when developer commit code to master?

2018-03-18 Thread GitBox
asifdxtreme commented on issue #312: did service center do some basic install test when developer commit code to master? URL: https://github.com/apache/incubator-servicecomb-service-center/issues/312#issuecomment-373986292 Hi @lexkong I have raised another issue with this question

[GitHub] asifdxtreme closed issue #312: did service center do some basic install test when developer commit code to master?

2018-03-18 Thread GitBox
asifdxtreme closed issue #312: did service center do some basic install test when developer commit code to master? URL: https://github.com/apache/incubator-servicecomb-service-center/issues/312 This is an automated message

[GitHub] asifdxtreme opened a new issue #313: Routing the service-url's through api-gateway

2018-03-18 Thread GitBox
asifdxtreme opened a new issue #313: Routing the service-url's through api-gateway URL: https://github.com/apache/incubator-servicecomb-service-center/issues/313 Issue raised by @lexkong my problem is, we have a api gateway, and now we want to find service from service center, which is

[GitHub] asifdxtreme commented on issue #311: go build -o service-center get many errors

2018-03-18 Thread GitBox
asifdxtreme commented on issue #311: go build -o service-center get many errors URL: https://github.com/apache/incubator-servicecomb-service-center/issues/311#issuecomment-373985264 Please refere to my comment on this issue

[GitHub] asifdxtreme commented on issue #313: Routing the service-url's through api-gateway

2018-03-18 Thread GitBox
asifdxtreme commented on issue #313: Routing the service-url's through api-gateway URL: https://github.com/apache/incubator-servicecomb-service-center/issues/313#issuecomment-373986891 @lexhong Can you please let us know which microservice-sdk you are using? Currently we have

[GitHub] asifdxtreme commented on issue #313: Routing the service-url's through api-gateway

2018-03-18 Thread GitBox
asifdxtreme commented on issue #313: Routing the service-url's through api-gateway URL: https://github.com/apache/incubator-servicecomb-service-center/issues/313#issuecomment-373986891 @lexkong Can you please let us know which microservice-sdk you are using? Currently we have

[GitHub] asifdxtreme commented on issue #312: did service center do some basic install test when developer commit code to master?

2018-03-18 Thread GitBox
asifdxtreme commented on issue #312: did service center do some basic install test when developer commit code to master? URL: https://github.com/apache/incubator-servicecomb-service-center/issues/312#issuecomment-373984977 @lexkong We are sorry to hear that you were not able to build the

[GitHub] surelovemeng commented on issue #313: Routing the service-url's through api-gateway

2018-03-18 Thread GitBox
surelovemeng commented on issue #313: Routing the service-url's through api-gateway URL: https://github.com/apache/incubator-servicecomb-service-center/issues/313#issuecomment-373989853 you can reference to

[GitHub] lexkong commented on issue #313: Routing the service-url's through api-gateway

2018-03-18 Thread GitBox
lexkong commented on issue #313: Routing the service-url's through api-gateway URL: https://github.com/apache/incubator-servicecomb-service-center/issues/313#issuecomment-374013315 @asifdxtreme thanks for you help, i use go-sdk, i checked the docs, but it may not solve my problem, my

[GitHub] lexkong commented on issue #313: Routing the service-url's through api-gateway

2018-03-18 Thread GitBox
lexkong commented on issue #313: Routing the service-url's through api-gateway URL: https://github.com/apache/incubator-servicecomb-service-center/issues/313#issuecomment-374013315 @asifdxtreme thanks for you help, i checked the docs, but it may not solve my problem, my problem is:

[GitHub] lexkong commented on issue #313: Routing the service-url's through api-gateway

2018-03-18 Thread GitBox
lexkong commented on issue #313: Routing the service-url's through api-gateway URL: https://github.com/apache/incubator-servicecomb-service-center/issues/313#issuecomment-374013315 thanks for you help, i checked the docs, but it may not solve my problem, my problem is: currently we have a

[GitHub] lexkong commented on issue #313: Routing the service-url's through api-gateway

2018-03-18 Thread GitBox
lexkong commented on issue #313: Routing the service-url's through api-gateway URL: https://github.com/apache/incubator-servicecomb-service-center/issues/313#issuecomment-374013315 thanks for you help, i checked the docs, but it may not solve my problem, my problem is: currently we have a

[GitHub] lexkong opened a new issue #311: go build -o service-center get many errors

2018-03-18 Thread GitBox
lexkong opened a new issue #311: go build -o service-center get many errors URL: https://github.com/apache/incubator-servicecomb-service-center/issues/311 # github.com/coreos/etcd/clientv3 ../../coreos/etcd/clientv3/client.go:346: cannot use c.tokenCred (type *authTokenCredential) as

Re: [VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0 - Second Attempt

2018-03-18 Thread 李波
+1 Checklist: Build kit from src code success. Running saga demo booking success All test were passed. Best LiBo 2018-03-19 9:58 GMT+08:00 Eric Lee : > +1 > > Checked the signed keys and checksum. > Checked the demo. > Built the code from source. > All unit tests,

Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt

2018-03-18 Thread kirin wang
+1 Built the code from source. 2018-03-19 10:00 GMT+08:00 Eric Lee : > +1 > > Checked the signed keys and checksum. > Checked the samples. > Built the code from source. > All unit tests, integration tests are passed. > > 2018-03-19 9:57 GMT+08:00 Willem Jiang

Re: [VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0 - Second Attempt

2018-03-18 Thread kirin wang
+1 Checked the demo 2018-03-19 10:06 GMT+08:00 李波 : > +1 > > > Checklist: > > Build kit from src code success. > Running saga demo booking success > All test were passed. > > > Best > LiBo > > > > 2018-03-19 9:58 GMT+08:00 Eric Lee : > > > +1 > > >

Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt

2018-03-18 Thread Willem Jiang
+1 binding. I can build the kit from source. I checked the staging repo by running the Company example 1.x branch[1], all test were passed. [1]https://github.com/ServiceComb/ServiceComb-Company-WorkShop/tree/1.x Willem Jiang Blog: http://willemjiang.blogspot.com (English)

Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt

2018-03-18 Thread Mohammad Asif Siddiqui
+1 Binding I Checked - incubating in name - hashes and signatures is good - DISCLAIMER exists - can compile from source - checked for archive matching git tag - Source file have ASF headers - ran Integration test using release binary on windows and linux - ran java-chassis

Re: [VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0 - Second Attempt

2018-03-18 Thread Mohammad Asif Siddiqui
+1 Binding I Checked - incubating in name - hashes and signatures is good - DISCLAIMER/NOTICE/LICENSE exists - ran RAT tool - can make release kit from source - checked for archive matching git tag - Source file have ASF headers Regards Asif On 2018/03/16 19:01:29,

Re: [VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0 - Second Attempt

2018-03-18 Thread Sure
+1 LGTM -- Original -- From: Mohammad Asif Siddiqui Date: Mon,Mar 19,2018 0:25 PM To: dev Subject: Re: [VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0 - Second Attempt +1 Binding I

Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt

2018-03-18 Thread Sure
+1 LGTM -- Original -- From: Mohammad Asif Siddiqui Date: Sat,Mar 17,2018 2:52 AM To: dev Subject: Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt Hi All,

Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt

2018-03-18 Thread bismy
+1 Integrate 1.0.0-m1 to integration tests and all test case passed. -- Original -- From: "Mohammad Asif Siddiqui"; Date: Sat, Mar 17, 2018 02:52 AM To: "dev"; Subject: [VOTE] Release Apache ServiceComb

Re: [VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0 - Second Attempt

2018-03-18 Thread Mahesh Raju Somalaraju
+1 Non Binding - Ran java-chassis demos using service-center release binary. - Run the rat to verify the License header issue. Thanks & Regards -Mahesh Raju S On Sat, Mar 17, 2018 at 12:31 AM, Mohammad Asif Siddiqui < asifdxtr...@apache.org> wrote: > Hi All, > > This is a call for Vote to

[GitHub] tianxiaoliang opened a new issue #314: docker hub don't have document and simple description

2018-03-18 Thread GitBox
tianxiaoliang opened a new issue #314: docker hub don't have document and simple description URL: https://github.com/apache/incubator-servicecomb-service-center/issues/314 Like where is API doc, how to run image, it is lacking of document

Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt

2018-03-18 Thread Yang Bo
+1 1. Checked the binary and source releases' sha512sum and gpg signature. 2. Checked LICENSE/DISCLAIMER/NOTICE of binary and source release. 3. Run rat on binary and source release, some minor issues found. 4. Building from source following the README 5. Running service center and frontend

Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt

2018-03-18 Thread Willem Jiang
+1 (binding) Checked the signed Keys and checksum. Checked the binary with the examples. Run the rat to verify the License header issue. Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese) Twitter: willemjiang Weibo: 姜宁willem On Sat, Mar 17,

Re: [VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0 - Second Attempt

2018-03-18 Thread Yang Bo
+1 Checks I've done: 1. Checked sha512sum and GPG signature. 2. Run rat without filter on source and binary package. 3. Checked DISCLAIMER/NOTICE/LICENSE for source and binary package. 4. Checked that no unlicensed binary files are bundled in source and binary package. 5. Build from source

Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt

2018-03-18 Thread Eric Lee
+1 Checked the signed keys and checksum. Checked the samples. Built the code from source. All unit tests, integration tests are passed. 2018-03-19 9:57 GMT+08:00 Willem Jiang : > +1 binding. > > I can build the kit from source. > I checked the staging repo by running

[GitHub] WillemJiang commented on issue #314: docker hub don't have document and simple description

2018-03-18 Thread GitBox
WillemJiang commented on issue #314: docker hub don't have document and simple description URL: https://github.com/apache/incubator-servicecomb-service-center/issues/314#issuecomment-374083910 @tianxiaoliang Could file a [JIRA](http://issues.apache.org/jira/browse/SCB) for it?

Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt

2018-03-18 Thread Yang Bo
+1 Checks I've done: 1. Run rat without any filters. 2. Checked no images files(*.jpg,*.png) and font files (*.ttf) are included without permission in source and binary packages. 3. Checked that no JS files distributed in Java Chassis. 4. Checked LICENSE/NOTICE/DISCLAIMER for source and

Re: [VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0 - Second Attempt

2018-03-18 Thread Eric Lee
+1 Checked the signed keys and checksum. Checked the demo. Built the code from source. All unit tests, integration tests and acceptance tests are passed. 2018-03-19 9:27 GMT+08:00 Yang Bo : > +1 > > Checks I've done: > > 1. Checked sha512sum and GPG signature. > > 2. Run rat

Re: [VOTE] Release Apache ServiceComb Saga (incubating) version 0.1.0 - Second Attempt

2018-03-18 Thread Willem Jiang
+1 binding. Here are the checks that I done: Checked the signed key and checksum. Built the binary from source. Verified the nexus staging repo by running the demos. Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese) Twitter: willemjiang

[GitHub] little-cui closed pull request #309: SCB-389 SC does not re-create the tracing file.

2018-03-18 Thread GitBox
little-cui closed pull request #309: SCB-389 SC does not re-create the tracing file. URL: https://github.com/apache/incubator-servicecomb-service-center/pull/309 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] jeho0815 commented on a change in pull request #607: [SCB-406] Chassis must support standard parameter validation handler

2018-03-18 Thread GitBox
jeho0815 commented on a change in pull request #607: [SCB-406] Chassis must support standard parameter validation handler URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/607#discussion_r175322344 ## File path:

[GitHub] tianxiaoliang commented on issue #314: docker hub don't have document and simple description

2018-03-18 Thread GitBox
tianxiaoliang commented on issue #314: docker hub don't have document and simple description URL: https://github.com/apache/incubator-servicecomb-service-center/issues/314#issuecomment-374091921 ok, I will This is an

Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt

2018-03-18 Thread Mohammad Asif Siddiqui
+1 Binding I Checked - incubating in name - hashes and signatures is good - DISCLAIMER/NOTICE/LICENSE exists - ran RAT tool - can make release kit from source - checked for archive matching git tag - Source file have ASF headers - Ran the demo's using the source archive

Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt

2018-03-18 Thread Mahesh Raju Somalaraju
+1 Non Binding - Ran java-chassis demos using service-center release binary. - Run the rat to verify the License header issue. Thanks & Regards -Mahesh Raju S On Sat, Mar 17, 2018 at 12:08 AM, Mohammad Asif Siddiqui < asifdxtr...@apache.org> wrote: > Hi All, > > This is a call for Vote to

Re: [VOTE] Release Apache ServiceComb Java-Chassis (incubating) version 1.0.0-m1 - Second Attempt

2018-03-18 Thread Mahesh Raju Somalaraju
+1 Non Binding - Ran java-chassis demos using service-center release binary. - Run the rat to verify the License header issue. Thanks & Regards -Mahesh Raju S On Sat, Mar 17, 2018 at 12:22 AM, Mohammad Asif Siddiqui < asifdxtr...@apache.org> wrote: > Hi All, > > This is a call for Vote to

Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt

2018-03-18 Thread bismy
+1 run java-chassis integration tests against this candidate and all test cases passed. -- Original -- From: "Mohammad Asif Siddiqui"; Date: Sat, Mar 17, 2018 02:38 AM To: "dev"; Subject: [VOTE] Release