+1 non-binding
1. Release name OK
2. GPG signature and checksum OK
3. RAT check OK
4. Basic function test on linux/windows OK
On Mon, Jun 11, 2018 at 7:59 AM, Yang Bo wrote:
> +1 non-binding
>
>
> 1. Release name OK
> 2. GPG signature and checksum OK
> 3. Rat check OK
> 4. README OK
> 5.
Hi Team,
As we recently vote two committers, someone came to me ask about the what's
the criterial to become a committer. It's really a good question.
>From what I learned by participating bunch of Apache projects, the first
criterial is you need to do enough contribution to earn enough credit
+1 binding
Checks Done:
- incubating in name
- hashes and signatures is good
- DISCLAIMER/NOTICE/LICENSE exists
- ran RAT tool
- can make release kit from source
- checked for archive matching git tag
- Source file have ASF headers
- Ran the java-chassis and go-chassis demo's
+1 binding
Checks Done:
- incubating in name
- hashes and signatures is good
- DISCLAIMER/NOTICE/LICENSE exists
- can make release kit from source
- checked for archive matching git tag
- Source file have ASF headers
Regards
Mohammad Asif Siddiqui
On 2018/06/08
+1 binding.
For the source code I checked:
File name with incubating
Signed key and sha file are OK
License and Notice file is good
RAT check OK
DISCLAME file is there
No other code in the vendor directory
For the binary I checked:
File name with incubating
Signed key and sha
+1 Release this package as 1.0.0-m2
Download source from Release Candidate and build using GO 1.10, tested with
demo-Springmvc and Passed
Download windows binary from Release Candidate, tested with demo-Springmvc and
Passed
Source Code SHA checked Passed
Source Code Signature checked Passed
+1 non binding
Checks Done:
- release notes is correct
- source & binary release candidate is ok
- repository is ok
- licenses and notices are ok
-- --
??: "Mohammad Asif Siddiqui";
: 2018??6??8??(??) 2:29
??: "dev";
Hi Liubao，
As you are in the PPMC, your vote is the binding one.
Willem Jiang
Twitter: willemjiang
Weibo: 姜宁willem
On Mon, Jun 11, 2018 at 8:19 PM, bismy wrote:
> +1 non binding
>
> Checks Done:
> - release notes is correct
> - source & binary release candidate is ok
> - repository is ok
>
+1 binding
Checks Done:
- release notes is correct
- source & binary release candidate is ok
- repository is ok
- licenses and notices are ok
2018-06-11 21:55 GMT+08:00 Willem Jiang :
> Hi Liubao，
>
> As you are in the PPMC, your vote is the binding one.
>
>
> Willem Jiang
>
> Twitter:
