[GitHub] zhengyangyong commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype
zhengyangyong commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#discussion_r183934772 ## File path: archetypes/business-service-spring-boot-starter/README.md ## @@ -0,0 +1,36 @@ +## Welcome to use ServiceComb Java Chassis +This project(module) is generate by *org.apache.servicecomb.archetypes:business-service-spring-boot-starter-archetype*, it use **spring-boot-starter-provider** to develop service endpoint. + +### More works can be done further: +1. Modify "HelloEndpoint", add your business service logic, or create some new endpoints to provide your services. More details can be found : http://servicecomb.incubator.apache.org/users/use-servicecomb-in-spring-boot/ Review comment: Fixed This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhengyangyong commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype
zhengyangyong commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#discussion_r183934108 ## File path: archetypes/business-service-spring-boot-starter/README.md ## @@ -0,0 +1,36 @@ +## Welcome to use ServiceComb Java Chassis +This project(module) is generate by *org.apache.servicecomb.archetypes:business-service-spring-boot-starter-archetype*, it use **spring-boot-starter-provider** to develop service endpoint. + +### More works can be done further: +1. Modify "HelloEndpoint", add your business service logic, or create some new endpoints to provide your services. More details can be found : http://servicecomb.incubator.apache.org/users/use-servicecomb-in-spring-boot/ Review comment: 链接写错了。。。http://servicecomb.incubator.apache.org/users/develop-with-spring-boot-starter/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhengyangyong commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype
zhengyangyong commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#discussion_r183933958 ## File path: archetypes/business-service-spring-boot-starter/README.md ## @@ -0,0 +1,36 @@ +## Welcome to use ServiceComb Java Chassis +This project(module) is generate by *org.apache.servicecomb.archetypes:business-service-spring-boot-starter-archetype*, it use **spring-boot-starter-provider** to develop service endpoint. + +### More works can be done further: +1. Modify "HelloEndpoint", add your business service logic, or create some new endpoints to provide your services. More details can be found : http://servicecomb.incubator.apache.org/users/use-servicecomb-in-spring-boot/ Review comment: sorry ,I will check web site later This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhengyangyong commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype
zhengyangyong commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#discussion_r183296448 ## File path: archetypes/business-service-spring-boot-starter/README.md ## @@ -0,0 +1,18 @@ +## Welcome to use ServiceComb Java Chassis +This project(module) is generate by *org.apache.servicecomb.archetypes:business-service-spring-boot-starter-archetype*, it use **spring-boot-starter-provider** to develop service endpoint. + +### More works can be done further: +1. Modify "HelloEndpoint", add your business service logic, or create some new endpoints to provide your services. More details can be found : http://servicecomb.incubator.apache.org/users/use-servicecomb-in-spring-boot/ Review comment: I had add some content to explain relationship about Spring Boot and ServiceComb relationship This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhengyangyong commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype
zhengyangyong commented on a change in pull request #641: [SCB-470] add spring
boot starter provider archetype
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#discussion_r181260091
##
File path: archetypes/business-service-spring-boot-starter/pom.xml
##
@@ -0,0 +1,94 @@
+
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ org.apache.servicecomb.archetypes
+ business-service-spring-boot-starter
+ 4.0.0
+ 1.0.0-m2-SNAPSHOT
+
+
+1.0.0-m2-SNAPSHOT
+1.4.5.RELEASE
+
+
+
+
+
+org.apache.servicecomb
+java-chassis-dependencies
+${java-chassis.version}
+pom
+import
+
+
+
+
+
+
+ org.springframework.boot
Review comment:
org.springframework.boot
spring-boot-starter
ch.qos.logback
logback-classic
org.slf4j
log4j-over-slf4j
It had exclusions log dependency so "log4j:WARN No appenders could be found
for logger (org.jboss.logging). log4j:WARN Please initialize the log4j system
properly."
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] zhengyangyong commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype
zhengyangyong commented on a change in pull request #641: [SCB-470] add spring
boot starter provider archetype
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#discussion_r181008181
##
File path: archetypes/business-service-spring-boot-starter/pom.xml
##
@@ -0,0 +1,94 @@
+
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ org.apache.servicecomb.archetypes
+ business-service-spring-boot-starter
+ 4.0.0
+ 1.0.0-m2-SNAPSHOT
+
+
+1.0.0-m2-SNAPSHOT
+1.4.5.RELEASE
+
+
+
+
+
+org.apache.servicecomb
+java-chassis-dependencies
+${java-chassis.version}
+pom
+import
+
+
+
+
+
+
+ org.springframework.boot
Review comment:
if delete this dependency,application will be blocked
. ___ _ _
/\\ / ___'_ __ _ _(_)_ __ __ _ \ \ \ \
( ( )\___ | '_ | '_| | '_ \/ _` | \ \ \ \
\\/ ___)| |_)| | | | | || (_| | ) ) ) )
' || .__|_| |_|_| |_\__, | / / / /
=|_|==|___/=/_/_/_/
:: Spring Boot ::(v1.4.5.RELEASE)
log4j:WARN No appenders could be found for logger (org.jboss.logging).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for
more info.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] zhengyangyong commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype
zhengyangyong commented on a change in pull request #641: [SCB-470] add spring
boot starter provider archetype
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#discussion_r181004010
##
File path: archetypes/business-service-spring-boot-starter/pom.xml
##
@@ -0,0 +1,93 @@
+
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ org.apache.servicecomb.archetypes
+ business-service-spring-boot-starter
+ 4.0.0
+ 1.0.0-m2-SNAPSHOT
+
+
+1.0.0-m2-SNAPSHOT
+
+
+
+
+
+org.apache.servicecomb
+java-chassis-dependencies
+${java-chassis.version}
+pom
+import
+
+
+
+
+
+
+ org.springframework.boot
+ spring-boot-starter
+
+
+ org.apache.servicecomb
+ spring-boot-starter-provider
+
+
+ org.hibernate
+ hibernate-validator
+
+
+
+
+
+
+
+org.springframework.boot
+spring-boot-maven-plugin
+1.4.5.RELEASE
+
+
+
+ repackage
+
+
+ ${project.build.directory}/bin
+ exec
+
+
+
+
+
+
+org.apache.maven.plugins
+maven-jar-plugin
Review comment:
executable jar will package by "spring-boot-maven-plugin",not this
plugin,this plugin is only used for add . into class path.
i had test all
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] zhengyangyong commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype
zhengyangyong commented on a change in pull request #641: [SCB-470] add spring
boot starter provider archetype
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#discussion_r180976305
##
File path: archetypes/business-service-spring-boot-starter/pom.xml
##
@@ -0,0 +1,93 @@
+
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ org.apache.servicecomb.archetypes
+ business-service-spring-boot-starter
+ 4.0.0
+ 1.0.0-m2-SNAPSHOT
+
+
+1.0.0-m2-SNAPSHOT
+
+
+
+
+
+org.apache.servicecomb
+java-chassis-dependencies
+${java-chassis.version}
+pom
+import
+
+
+
+
+
+
+ org.springframework.boot
+ spring-boot-starter
+
+
+ org.apache.servicecomb
+ spring-boot-starter-provider
+
+
+ org.hibernate
+ hibernate-validator
+
+
+
+
+
+
+
+org.springframework.boot
+spring-boot-maven-plugin
+1.4.5.RELEASE
Review comment:
Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] zhengyangyong commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype
zhengyangyong commented on a change in pull request #641: [SCB-470] add spring
boot starter provider archetype
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#discussion_r180942756
##
File path: archetypes/business-service-spring-boot-starter/pom.xml
##
@@ -0,0 +1,93 @@
+
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ org.apache.servicecomb.archetypes
+ business-service-spring-boot-starter
+ 4.0.0
+ 1.0.0-m2-SNAPSHOT
+
+
+1.0.0-m2-SNAPSHOT
+
+
+
+
+
+org.apache.servicecomb
+java-chassis-dependencies
+${java-chassis.version}
+pom
+import
+
+
+
+
+
+
+ org.springframework.boot
+ spring-boot-starter
+
+
+ org.apache.servicecomb
+ spring-boot-starter-provider
+
+
+ org.hibernate
+ hibernate-validator
+
+
+
+
+
+
+
+org.springframework.boot
+spring-boot-maven-plugin
+1.4.5.RELEASE
Review comment:
it is only for package executable jar,and chassis is also dependency on
1.4.5.RELEASE,we may not change it for better
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] zhengyangyong commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype
zhengyangyong commented on a change in pull request #641: [SCB-470] add spring
boot starter provider archetype
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#discussion_r180942587
##
File path: archetypes/business-service-spring-boot-starter/pom.xml
##
@@ -0,0 +1,93 @@
+
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ org.apache.servicecomb.archetypes
+ business-service-spring-boot-starter
+ 4.0.0
+ 1.0.0-m2-SNAPSHOT
+
+
+1.0.0-m2-SNAPSHOT
+
+
+
+
+
+org.apache.servicecomb
+java-chassis-dependencies
+${java-chassis.version}
+pom
+import
+
+
+
+
+
+
+ org.springframework.boot
+ spring-boot-starter
+
+
+ org.apache.servicecomb
+ spring-boot-starter-provider
+
+
+ org.hibernate
+ hibernate-validator
+
+
+
+
+
+
+
+org.springframework.boot
+spring-boot-maven-plugin
+1.4.5.RELEASE
+
+
+
+ repackage
+
+
+ ${project.build.directory}/bin
+ exec
+
+
+
+
+
+
+org.apache.maven.plugins
+maven-jar-plugin
Review comment:
we need add . into class path, then " If you need to modify config setting
in "microservice.yaml" like service center address but don't want repackage the
executable jar, **you can direct place a new "microservice.yaml" file in same
folder, then settings will be overridden.** "
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] zhengyangyong commented on a change in pull request #641: [SCB-470] add spring boot starter provider archetype
zhengyangyong commented on a change in pull request #641: [SCB-470] add spring
boot starter provider archetype
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/641#discussion_r180942591
##
File path:
archetypes/business-service-spring-boot-starter/src/main/java/org/apache/servicecomb/archetypes/HelloConsumer.java
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.archetypes;
+
+import org.apache.servicecomb.provider.springmvc.reference.RestTemplateBuilder;
+import org.springframework.web.client.RestTemplate;
+
+public class HelloConsumer {
+ private final RestTemplate restTemplate = RestTemplateBuilder.create();
+
+ public void invokeHello() {
+restTemplate.getForObject("cse://business-service/hello", String.class);
Review comment:
Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
