fpapon closed pull request #40: Update how-to-contribute with gitbox
URL: https://github.com/apache/shiro-site/pull/40
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull
fpapon commented on issue #40: Update how-to-contribute with gitbox
URL: https://github.com/apache/shiro-site/pull/40#issuecomment-451724798
LGTM, thanks!
This is an automated message from the Apache Git Service.
To respond
[
https://issues.apache.org/jira/browse/SHIRO-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16735229#comment-16735229
]
Francois Papon commented on SHIRO-657:
--
May be we could use property holder?
> Add desc to
[
https://issues.apache.org/jira/browse/SHIRO-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16735219#comment-16735219
]
Brian Demers commented on SHIRO-657:
I like this idea, but it doesn't seem like it would be i18n
[
https://issues.apache.org/jira/browse/SHIRO-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16735218#comment-16735218
]
Junling Bu commented on SHIRO-657:
--
Currently I have to use another custom annotation in the place where
Junling Bu created SHIRO-657:
Summary: Add desc to RequiresPermissions
Key: SHIRO-657
URL: https://issues.apache.org/jira/browse/SHIRO-657
Project: Shiro
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/SHIRO-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16735399#comment-16735399
]
Junling Bu commented on SHIRO-657:
--
Well, it could be best if we support i18n.
Moreover, I hope shiro
