coheigea opened a new pull request #152: SHIRO-708 - Remove deprecated
shiro-cas module
URL: https://github.com/apache/shiro/pull/152
This is an automated message from the Apache Git Service.
To respond to the message,
Colm O hEigeartaigh created SHIRO-708:
-
Summary: Remove deprecated shiro-cas module
Key: SHIRO-708
URL: https://issues.apache.org/jira/browse/SHIRO-708
Project: Shiro
Issue Type:
asfgit commented on issue #152: SHIRO-708 - Remove deprecated shiro-cas module
URL: https://github.com/apache/shiro/pull/152#issuecomment-504437352
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/122/
bdemers commented on issue #152: SHIRO-708 - Remove deprecated shiro-cas module
URL: https://github.com/apache/shiro/pull/152#issuecomment-504506820
We need to think about how we message this. If the next version is 1.5 and
we remove a module that is a breaking change at a high level. But
asfgit commented on issue #152: SHIRO-708 - Remove deprecated shiro-cas module
URL: https://github.com/apache/shiro/pull/152#issuecomment-504506151
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/123/
fpapon commented on issue #152: SHIRO-708 - Remove deprecated shiro-cas module
URL: https://github.com/apache/shiro/pull/152#issuecomment-504505965
retest this please
This is an automated message from the Apache Git Service.
fpapon edited a comment on issue #152: SHIRO-708 - Remove deprecated shiro-cas
module
URL: https://github.com/apache/shiro/pull/152#issuecomment-504518074
@bdemers the module is deprecated in the current website page
https://shiro.apache.org/cas.html
Do you think it's good to remove
fpapon edited a comment on issue #152: SHIRO-708 - Remove deprecated shiro-cas
module
URL: https://github.com/apache/shiro/pull/152#issuecomment-504518074
@bdemers the module is deprecated in the current website page
https://shiro.apache.org/cas.html
Do you think it's good to remove
I have mixed feelings on the topic, I can see a case for and against.
For: it's been deprecated, it is in its own module, therefore it doesn't
directly affect the versioning of the other modules
Against: at a project level it is removing code would with signal a major
release.
On Fri, Jun 21,
