[jira] [Updated] (SHIRO-722) Add SameSite option to cookies

2019-09-12 Thread Francois Papon (Jira)
[ https://issues.apache.org/jira/browse/SHIRO-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francois Papon updated SHIRO-722: - Fix Version/s: 1.5.0 > Add SameSite option to cookies > -- > >

[GitHub] [shiro] boris-petrov edited a comment on issue #67: Add SameSite option to cookies

2019-09-12 Thread GitBox
boris-petrov edited a comment on issue #67: Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530730949 Also, what about the added methods? The test is failing because of that also. I can overload the `buildHeaderValue` and call the new one from the

[GitHub] [shiro] boris-petrov commented on issue #67: Add SameSite option to cookies

2019-09-12 Thread GitBox
boris-petrov commented on issue #67: Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530730949 Also, what about the added methods? The test is failing because of that also. I can overload the `addCookieHeader` and call the new one from the old one,

[GitHub] [shiro] asf-ci commented on issue #67: Add SameSite option to cookies

2019-09-12 Thread GitBox
asf-ci commented on issue #67: Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530750236 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/158/

[GitHub] [shiro] fpapon commented on issue #67: Add SameSite option to cookies

2019-09-12 Thread GitBox
fpapon commented on issue #67: Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530732144 @boris-petrov for me the `getSameSite` and `setSameSite` are not a problem. This is an

[GitHub] [shiro] boris-petrov commented on issue #67: Add SameSite option to cookies

2019-09-12 Thread GitBox
boris-petrov commented on issue #67: Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530730424 Do we want `NONE` as the default? Chrome is making `LAX` the default and that is more secure than `NONE`. Perhaps Shiro should do the same?

[GitHub] [shiro] bdemers commented on issue #67: [SHIRO-722] Add SameSite option to cookies

2019-09-12 Thread GitBox
bdemers commented on issue #67: [SHIRO-722] Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530858412 @boris-petrov great point on the default, it sounds like LAX might be the way to go, a quick google shows it's that will be the default starting

[GitHub] [shiro] fpapon merged pull request #67: [SHIRO-722] Add SameSite option to cookies

2019-09-12 Thread GitBox
fpapon merged pull request #67: [SHIRO-722] Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [shiro] bdemers commented on issue #67: [SHIRO-722] Add SameSite option to cookies

2019-09-12 Thread GitBox
bdemers commented on issue #67: [SHIRO-722] Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530867864 Thanks!! This is an automated message from the Apache Git Service. To respond to

[jira] [Resolved] (SHIRO-722) Add SameSite option to cookies

2019-09-12 Thread Francois Papon (Jira)
[ https://issues.apache.org/jira/browse/SHIRO-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francois Papon resolved SHIRO-722. -- Resolution: Resolved [~boris-petrov] thanks! > Add SameSite option to cookies >

[GitHub] [shiro-site] boris-petrov opened a new pull request #48: Add info about the SameSite cookie flag

2019-09-12 Thread GitBox
boris-petrov opened a new pull request #48: Add info about the SameSite cookie flag URL: https://github.com/apache/shiro-site/pull/48 Implementation of the flag is [here](https://github.com/apache/shiro/pull/67). This is an

[GitHub] [shiro] boris-petrov commented on issue #67: [SHIRO-722] Add SameSite option to cookies

2019-09-12 Thread GitBox
boris-petrov commented on issue #67: [SHIRO-722] Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530864987 @bdemers - done for both points. This is an automated message from the Apache

[GitHub] [shiro] asf-ci commented on issue #67: [SHIRO-722] Add SameSite option to cookies

2019-09-12 Thread GitBox
asf-ci commented on issue #67: [SHIRO-722] Add SameSite option to cookies URL: https://github.com/apache/shiro/pull/67#issuecomment-530872542 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/159/