[GitHub] fpapon closed pull request #40: Update how-to-contribute with gitbox

2019-01-06 Thread GitBox
fpapon closed pull request #40: Update how-to-contribute with gitbox URL: https://github.com/apache/shiro-site/pull/40 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] fpapon commented on issue #40: Update how-to-contribute with gitbox

2019-01-06 Thread GitBox
fpapon commented on issue #40: Update how-to-contribute with gitbox URL: https://github.com/apache/shiro-site/pull/40#issuecomment-451724798 LGTM, thanks! This is an automated message from the Apache Git Service. To respond

[GitHub] jbonofre opened a new pull request #40: Update how-to-contribute with gitbox

2019-01-05 Thread GitBox
jbonofre opened a new pull request #40: Update how-to-contribute with gitbox URL: https://github.com/apache/shiro-site/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] fpapon commented on issue #26: Update versions.vtl to Apache Shiro 1.4

2019-01-11 Thread GitBox
fpapon commented on issue #26: Update versions.vtl to Apache Shiro 1.4 URL: https://github.com/apache/shiro-site/pull/26#issuecomment-453574057 LGTM thanks! This is an automated message from the Apache Git Service. To respond

[GitHub] fpapon closed pull request #26: Update versions.vtl to Apache Shiro 1.4

2019-01-11 Thread GitBox
fpapon closed pull request #26: Update versions.vtl to Apache Shiro 1.4 URL: https://github.com/apache/shiro-site/pull/26 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] fpapon closed pull request #41: Update versions template

2019-01-11 Thread GitBox
fpapon closed pull request #41: Update versions template URL: https://github.com/apache/shiro-site/pull/41 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] fpapon commented on issue #41: Update versions template

2019-01-11 Thread GitBox
fpapon commented on issue #41: Update versions template URL: https://github.com/apache/shiro-site/pull/41#issuecomment-453579126 Update the version template with 1.3.x version and fix early maven dependencies version info

[GitHub] fpapon opened a new pull request #41: Update versions template

2019-01-11 Thread GitBox
fpapon opened a new pull request #41: Update versions template URL: https://github.com/apache/shiro-site/pull/41 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] fpapon commented on issue #26: Update versions.vtl to Apache Shiro 1.4

2019-01-11 Thread GitBox
fpapon commented on issue #26: Update versions.vtl to Apache Shiro 1.4 URL: https://github.com/apache/shiro-site/pull/26#issuecomment-453551287 I'm actually clean up PR so yes is still valid ;) This is an automated

[GitHub] fpapon commented on issue #26: Update versions.vtl to Apache Shiro 1.4

2019-01-11 Thread GitBox
fpapon commented on issue #26: Update versions.vtl to Apache Shiro 1.4 URL: https://github.com/apache/shiro-site/pull/26#issuecomment-453557996 Yes, it was only updating the latest version 1.4.0 on the pages but I want to check globally.

[GitHub] raupachz commented on issue #26: Update versions.vtl to Apache Shiro 1.4

2019-01-11 Thread GitBox
raupachz commented on issue #26: Update versions.vtl to Apache Shiro 1.4 URL: https://github.com/apache/shiro-site/pull/26#issuecomment-453550018 @fpapon Hi, there. :) Oh wow this is a really old PR. Is it still valid? This

[GitHub] raupachz commented on issue #26: Update versions.vtl to Apache Shiro 1.4

2019-01-11 Thread GitBox
raupachz commented on issue #26: Update versions.vtl to Apache Shiro 1.4 URL: https://github.com/apache/shiro-site/pull/26#issuecomment-453553008 Unfortunately, I am pretty much out of the loop of what I did back then. It was about fixing some version string on the homepage, right? I don't

[GitHub] fpapon commented on issue #26: Update versions.vtl to Apache Shiro 1.4

2019-01-11 Thread GitBox
fpapon commented on issue #26: Update versions.vtl to Apache Shiro 1.4 URL: https://github.com/apache/shiro-site/pull/26#issuecomment-453549404 @raupachz thanks for the PR! You have to use the master of SCMS: https://github.com/lhazlewood/scms.git Let me check and merge

[GitHub] fpapon closed pull request #39: Organize and clean-up get started page.

2019-01-11 Thread GitBox
fpapon closed pull request #39: Organize and clean-up get started page. URL: https://github.com/apache/shiro-site/pull/39 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] fpapon commented on issue #39: Organize and clean-up get started page.

2019-01-11 Thread GitBox
fpapon commented on issue #39: Organize and clean-up get started page. URL: https://github.com/apache/shiro-site/pull/39#issuecomment-453720960 LGTM thanks! This is an automated message from the Apache Git Service. To respond

[GitHub] [shiro] asfgit commented on issue #128: [SHIRO-683] Upgrade to spring-boot 1.5.19.RELEASE

2019-03-31 Thread GitBox
asfgit commented on issue #128: [SHIRO-683] Upgrade to spring-boot 1.5.19.RELEASE URL: https://github.com/apache/shiro/pull/128#issuecomment-478361697 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/68/

[GitHub] [shiro] jbonofre commented on issue #128: [SHIRO-683] Upgrade to spring-boot 1.5.19.RELEASE

2019-03-31 Thread GitBox
jbonofre commented on issue #128: [SHIRO-683] Upgrade to spring-boot 1.5.19.RELEASE URL: https://github.com/apache/shiro/pull/128#issuecomment-478440200 Why not upgrading for spring-boot 2 ? This is an automated message from

[GitHub] [shiro] fpapon merged pull request #128: [SHIRO-683] Upgrade to spring-boot 1.5.19.RELEASE

2019-03-31 Thread GitBox
fpapon merged pull request #128: [SHIRO-683] Upgrade to spring-boot 1.5.19.RELEASE URL: https://github.com/apache/shiro/pull/128 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [shiro] steinarb edited a comment on issue #63: Validate karaf features

2019-03-27 Thread GitBox
steinarb edited a comment on issue #63: Validate karaf features URL: https://github.com/apache/shiro/pull/63#issuecomment-477021869 Just FYI Re: shiro and karaf It's not finished yet (as in deployed to maven central), but this is a minimal JDBC-based user system for karaf (currently

[GitHub] [shiro] fpapon commented on issue #63: Validate karaf features

2019-03-27 Thread GitBox
fpapon commented on issue #63: Validate karaf features URL: https://github.com/apache/shiro/pull/63#issuecomment-477026428 @steinarb yes I know that the OSGi stuff on Shiro it's not finish yet ;) We want to release the 1.4.1 soon and prepare the next 1.5.0 with a full OSGi

[GitHub] [shiro] steinarb commented on issue #63: Validate karaf features

2019-03-27 Thread GitBox
steinarb commented on issue #63: Validate karaf features URL: https://github.com/apache/shiro/pull/63#issuecomment-477021869 Just FYI Re: shiro and karaf It's not finished yet (as in deployed to maven central), but this is a minimal JDBC-based user system for karaf (currently using

[GitHub] [shiro] asfgit commented on issue #88: [SHIRO-652] Upgrade Shiro Feature to Karaf 4.x

2019-03-26 Thread GitBox
asfgit commented on issue #88: [SHIRO-652] Upgrade Shiro Feature to Karaf 4.x URL: https://github.com/apache/shiro/pull/88#issuecomment-476772236 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/67/

[GitHub] [shiro] fpapon merged pull request #88: [SHIRO-652] Upgrade Shiro Feature to Karaf 4.x

2019-03-26 Thread GitBox
fpapon merged pull request #88: [SHIRO-652] Upgrade Shiro Feature to Karaf 4.x URL: https://github.com/apache/shiro/pull/88 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [shiro] tomsun28 opened a new pull request #127: fix the potential threat when use "uri = uri + '/' " to bypassed shi…

2019-03-24 Thread GitBox
tomsun28 opened a new pull request #127: fix the potential threat when use "uri = uri + '/' " to bypassed shi… URL: https://github.com/apache/shiro/pull/127 hi, the potential threat found when use shiro filter. in spring web, the ```requestURI :``` ```/resource/menus``` and

[GitHub] [shiro] asfgit commented on issue #127: fix the potential threat when use "uri = uri + '/' " to bypassed shi…

2019-03-24 Thread GitBox
asfgit commented on issue #127: fix the potential threat when use "uri = uri + '/' " to bypassed shi… URL: https://github.com/apache/shiro/pull/127#issuecomment-476063723 Refer to this link for build results (access rights to CI server needed):

[GitHub] [shiro] bdemers commented on issue #127: fix the potential threat when use "uri = uri + '/' " to bypassed shi…

2019-03-25 Thread GitBox
bdemers commented on issue #127: fix the potential threat when use "uri = uri + '/' " to bypassed shi… URL: https://github.com/apache/shiro/pull/127#issuecomment-476207936 Thanks @tomsun28! I have another spring filter related PR that i need to tweak, so I'll take a closer look at

[GitHub] [shiro] fpapon commented on issue #127: fix the potential threat when use "uri = uri + '/' " to bypassed shi…

2019-03-25 Thread GitBox
fpapon commented on issue #127: fix the potential threat when use "uri = uri + '/' " to bypassed shi… URL: https://github.com/apache/shiro/pull/127#issuecomment-476216443 @tomsun28 thanks for the PR! can you create a JIRA for this issue?

[GitHub] [shiro] tomsun28 commented on issue #127: fix the potential threat when use "uri = uri + '/' " to bypassed shi…

2019-03-25 Thread GitBox
tomsun28 commented on issue #127: fix the potential threat when use "uri = uri + '/' " to bypassed shi… URL: https://github.com/apache/shiro/pull/127#issuecomment-476288476 no sweat : ) ,the JIRA issue have been create

[GitHub] [shiro] fpapon commented on issue #128: [SHIRO-683] Upgrade to spring-boot 1.5.19.RELEASE

2019-03-31 Thread GitBox
fpapon commented on issue #128: [SHIRO-683] Upgrade to spring-boot 1.5.19.RELEASE URL: https://github.com/apache/shiro/pull/128#issuecomment-478441243 @jbonofre I made update because of OWASP check This is an automated

[GitHub] [shiro] fpapon commented on issue #128: [SHIRO-683] Upgrade to spring-boot 1.5.19.RELEASE

2019-03-31 Thread GitBox
fpapon commented on issue #128: [SHIRO-683] Upgrade to spring-boot 1.5.19.RELEASE URL: https://github.com/apache/shiro/pull/128#issuecomment-478441124 @jbonofre Shiro 1.4.1 is still on Java 1.6, we will upgrade to 2.x on the next 1.5.0 (Java 8)

[GitHub] [shiro] fpapon opened a new pull request #128: [SHIRO-683] Upgrade to spring-boot 1.5.19.RELEASE

2019-03-31 Thread GitBox
fpapon opened a new pull request #128: [SHIRO-683] Upgrade to spring-boot 1.5.19.RELEASE URL: https://github.com/apache/shiro/pull/128 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [shiro] fpapon commented on issue #88: [SHIRO-652] Upgrade Shiro Feature to Karaf 4.x

2019-03-26 Thread GitBox
fpapon commented on issue #88: [SHIRO-652] Upgrade Shiro Feature to Karaf 4.x URL: https://github.com/apache/shiro/pull/88#issuecomment-476970330 supercedes: - https://github.com/apache/shiro/pull/37 - https://github.com/apache/shiro/pull/42 -

[GitHub] [shiro] fpapon commented on issue #63: Validate karaf features

2019-03-26 Thread GitBox
fpapon commented on issue #63: Validate karaf features URL: https://github.com/apache/shiro/pull/63#issuecomment-476970758 @gnodet thanks for the PR! I made a new PR based on this with an upgrade of Spring version. https://github.com/apache/shiro/pull/88 I can close

[GitHub] [shiro] fpapon closed pull request #63: Validate karaf features

2019-03-26 Thread GitBox
fpapon closed pull request #63: Validate karaf features URL: https://github.com/apache/shiro/pull/63 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [shiro] fpapon commented on issue #37: Include version 4 of the war module for the shiro-web

2019-03-26 Thread GitBox
fpapon commented on issue #37: Include version 4 of the war module for the shiro-web URL: https://github.com/apache/shiro/pull/37#issuecomment-476971350 @amusarra thanks for the PR! It's include in: https://github.com/apache/shiro/pull/88 I close this one.

[GitHub] [shiro] fpapon closed pull request #43: Update features.xml

2019-03-26 Thread GitBox
fpapon closed pull request #43: Update features.xml URL: https://github.com/apache/shiro/pull/43 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [shiro] fpapon commented on issue #43: Update features.xml

2019-03-26 Thread GitBox
fpapon commented on issue #43: Update features.xml URL: https://github.com/apache/shiro/pull/43#issuecomment-476971121 @guilherfp thanks for the PR! It's include in: https://github.com/apache/shiro/pull/88 I close this one.

[GitHub] [shiro] fpapon closed pull request #37: Include version 4 of the war module for the shiro-web

2019-03-26 Thread GitBox
fpapon closed pull request #37: Include version 4 of the war module for the shiro-web URL: https://github.com/apache/shiro/pull/37 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [shiro] fpapon commented on issue #42: WIP: SHIRO-426 - Remove 'war' feature from feature.xml

2019-03-26 Thread GitBox
fpapon commented on issue #42: WIP: SHIRO-426 - Remove 'war' feature from feature.xml URL: https://github.com/apache/shiro/pull/42#issuecomment-476971566 @bdemers the war feature is now working and included in this PR: https://github.com/apache/shiro/pull/88 I close this one.

[GitHub] [shiro] fpapon closed pull request #42: WIP: SHIRO-426 - Remove 'war' feature from feature.xml

2019-03-26 Thread GitBox
fpapon closed pull request #42: WIP: SHIRO-426 - Remove 'war' feature from feature.xml URL: https://github.com/apache/shiro/pull/42 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] asfgit commented on issue #121: [SHIRO-673] Upgrade to maven-compiler-plugin 3.8.0

2019-02-24 Thread GitBox
asfgit commented on issue #121: [SHIRO-673] Upgrade to maven-compiler-plugin 3.8.0 URL: https://github.com/apache/shiro/pull/121#issuecomment-466743443 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/58/

[GitHub] fpapon opened a new pull request #123: [SHIRO-675] Upgrade to maven-surefire-plugins 3.0.0-M3

2019-02-24 Thread GitBox
fpapon opened a new pull request #123: [SHIRO-675] Upgrade to maven-surefire-plugins 3.0.0-M3 URL: https://github.com/apache/shiro/pull/123 Upgrade: - maven-surefire-plugin - maven-failsafe-plugin - maven-surefire-report-plugin

[GitHub] fpapon merged pull request #121: [SHIRO-673] Upgrade to maven-compiler-plugin 3.8.0

2019-02-24 Thread GitBox
fpapon merged pull request #121: [SHIRO-673] Upgrade to maven-compiler-plugin 3.8.0 URL: https://github.com/apache/shiro/pull/121 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] asfgit commented on issue #123: [SHIRO-675] Upgrade to maven-surefire-plugins 3.0.0-M3

2019-02-24 Thread GitBox
asfgit commented on issue #123: [SHIRO-675] Upgrade to maven-surefire-plugins 3.0.0-M3 URL: https://github.com/apache/shiro/pull/123#issuecomment-466753434 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/60/

[GitHub] asfgit commented on issue #122: [SHIRO-674] Upgrade maven-dependency-plugin to 3.1.1

2019-02-24 Thread GitBox
asfgit commented on issue #122: [SHIRO-674] Upgrade maven-dependency-plugin to 3.1.1 URL: https://github.com/apache/shiro/pull/122#issuecomment-466748589 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/59/

[GitHub] fpapon merged pull request #122: [SHIRO-674] Upgrade maven-dependency-plugin to 3.1.1

2019-02-24 Thread GitBox
fpapon merged pull request #122: [SHIRO-674] Upgrade maven-dependency-plugin to 3.1.1 URL: https://github.com/apache/shiro/pull/122 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] fpapon opened a new pull request #122: [SHIRO-674] Upgrade maven-dependency-plugin to 3.1.1

2019-02-24 Thread GitBox
fpapon opened a new pull request #122: [SHIRO-674] Upgrade maven-dependency-plugin to 3.1.1 URL: https://github.com/apache/shiro/pull/122 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] fpapon opened a new pull request #121: [SHIRO-673] Upgrade to maven-compiler-plugin 3.8.0

2019-02-23 Thread GitBox
fpapon opened a new pull request #121: [SHIRO-673] Upgrade to maven-compiler-plugin 3.8.0 URL: https://github.com/apache/shiro/pull/121 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] fpapon merged pull request #123: [SHIRO-675] Upgrade to maven-surefire-plugins 3.0.0-M3

2019-02-24 Thread GitBox
fpapon merged pull request #123: [SHIRO-675] Upgrade to maven-surefire-plugins 3.0.0-M3 URL: https://github.com/apache/shiro/pull/123 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] fpapon commented on issue #61: [SHIRO-670] ByteSource Serializable!

2019-02-24 Thread GitBox
fpapon commented on issue #61: [SHIRO-670] ByteSource Serializable! URL: https://github.com/apache/shiro/pull/61#issuecomment-466796489 @ChunMengLu can you explain why extend `Serializable` here please? This is an automated

[GitHub] fpapon opened a new pull request #124: [SHIRO-676] Upgrade to maven-jar-plugin 3.1.0

2019-02-24 Thread GitBox
fpapon opened a new pull request #124: [SHIRO-676] Upgrade to maven-jar-plugin 3.1.0 URL: https://github.com/apache/shiro/pull/124 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] asfgit commented on issue #124: [SHIRO-676] Upgrade to maven-jar-plugin 3.1.0

2019-02-24 Thread GitBox
asfgit commented on issue #124: [SHIRO-676] Upgrade to maven-jar-plugin 3.1.0 URL: https://github.com/apache/shiro/pull/124#issuecomment-466797424 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/61/

[GitHub] ChunMengLu commented on issue #61: [SHIRO-670] ByteSource Serializable!

2019-02-25 Thread GitBox
ChunMengLu commented on issue #61: [SHIRO-670] ByteSource Serializable! URL: https://github.com/apache/shiro/pull/61#issuecomment-467254254 > do you have a custom Session Cache Yes,last i use custom ByteSource. (最后我自定义了一个ByteSource实现。) ```java @Override protected

[GitHub] ChunMengLu commented on issue #61: [SHIRO-670] ByteSource Serializable!

2019-02-24 Thread GitBox
ChunMengLu commented on issue #61: [SHIRO-670] ByteSource Serializable! URL: https://github.com/apache/shiro/pull/61#issuecomment-466856187 > can you explain why extend `Serializable` here please? Password Hash salt,redis Serializable。

[GitHub] fpapon merged pull request #124: [SHIRO-676] Upgrade to maven-jar-plugin 3.1.0

2019-02-24 Thread GitBox
fpapon merged pull request #124: [SHIRO-676] Upgrade to maven-jar-plugin 3.1.0 URL: https://github.com/apache/shiro/pull/124 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] fpapon opened a new pull request #125: [SHIRO-677] Upgrade to versions-maven-plugin 2.7

2019-02-24 Thread GitBox
fpapon opened a new pull request #125: [SHIRO-677] Upgrade to versions-maven-plugin 2.7 URL: https://github.com/apache/shiro/pull/125 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] asfgit commented on issue #125: [SHIRO-677] Upgrade to versions-maven-plugin 2.7

2019-02-24 Thread GitBox
asfgit commented on issue #125: [SHIRO-677] Upgrade to versions-maven-plugin 2.7 URL: https://github.com/apache/shiro/pull/125#issuecomment-466863729 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/62/

[GitHub] fpapon merged pull request #125: [SHIRO-677] Upgrade to versions-maven-plugin 2.7

2019-02-24 Thread GitBox
fpapon merged pull request #125: [SHIRO-677] Upgrade to versions-maven-plugin 2.7 URL: https://github.com/apache/shiro/pull/125 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] bdemers commented on issue #61: [SHIRO-670] ByteSource Serializable!

2019-02-26 Thread GitBox
bdemers commented on issue #61: [SHIRO-670] ByteSource Serializable! URL: https://github.com/apache/shiro/pull/61#issuecomment-467475468 @ChunMengLu Lets take a step back. Are you seeing a unmarshalling error when reading an object from the cache/session?

[GitHub] bdemers commented on issue #61: [SHIRO-670] ByteSource Serializable!

2019-02-26 Thread GitBox
bdemers commented on issue #61: [SHIRO-670] ByteSource Serializable! URL: https://github.com/apache/shiro/pull/61#issuecomment-467475468 @ChunMengLu Lets take a step back. Are you seeing a unmarshalling error when reading an object from the cache/session?

[GitHub] fpapon commented on issue #65: [SHIRO-458] Replaced string equals with internal method that does not leak time

2019-02-20 Thread GitBox
fpapon commented on issue #65: [SHIRO-458] Replaced string equals with internal method that does not leak time URL: https://github.com/apache/shiro/pull/65#issuecomment-465886999 retest this please This is an automated

[GitHub] fpapon commented on issue #49: New AuthenticationStrategy - ShortCircuitFirstSuccessfulStrategy

2019-02-20 Thread GitBox
fpapon commented on issue #49: New AuthenticationStrategy - ShortCircuitFirstSuccessfulStrategy URL: https://github.com/apache/shiro/pull/49#issuecomment-465890881 @bdemers ok I will check the orther PR ;) This is an

[GitHub] asfgit commented on issue #50: [SHIRO-669] Included a boolean flag in FirstSuccessfulStrategy to break after first successful authentication

2019-02-21 Thread GitBox
asfgit commented on issue #50: [SHIRO-669] Included a boolean flag in FirstSuccessfulStrategy to break after first successful authentication URL: https://github.com/apache/shiro/pull/50#issuecomment-465928222 Refer to this link for build results (access rights to CI server needed):

[GitHub] bdemers commented on issue #71: [SHIRO-668] Catch unexpected errors which can lead to oom

2019-02-21 Thread GitBox
bdemers commented on issue #71: [SHIRO-668] Catch unexpected errors which can lead to oom URL: https://github.com/apache/shiro/pull/71#issuecomment-466039757 We might want to take another look at this one, catching `Throwable` might not be the best option. @cpetzka if you are still

[GitHub] fpapon commented on issue #50: [SHIRO-669] Included a boolean flag in FirstSuccessfulStrategy to break after first successful authentication

2019-02-20 Thread GitBox
fpapon commented on issue #50: [SHIRO-669] Included a boolean flag in FirstSuccessfulStrategy to break after first successful authentication URL: https://github.com/apache/shiro/pull/50#issuecomment-465889445 @ashokkumarta can you rebase to resolve conflicts please? Thanks!

[GitHub] bdemers commented on issue #8: Include ISIS Security extensions to Shiro for RBAC and SSO

2019-02-21 Thread GitBox
bdemers commented on issue #8: Include ISIS Security extensions to Shiro for RBAC and SSO URL: https://github.com/apache/shiro/pull/8#issuecomment-466033900 @fpapon I don't think this change is generic enough to live in the Shiro repo. There is probably some thing we could do on the

[GitHub] bdemers commented on issue #47: Idea: Add support for javax.annotation.security.RolesAllowed, PermitAll, and DenyAll

2019-02-21 Thread GitBox
bdemers commented on issue #47: Idea: Add support for javax.annotation.security.RolesAllowed, PermitAll, and DenyAll URL: https://github.com/apache/shiro/pull/47#issuecomment-466034854 @fpapon  I'll take another look at it for the next minor release

[GitHub] fpapon commented on issue #71: [SHIRO-668] Catch unexpected errors which can lead to oom

2019-02-20 Thread GitBox
fpapon commented on issue #71: [SHIRO-668] Catch unexpected errors which can lead to oom URL: https://github.com/apache/shiro/pull/71#issuecomment-465888201 @bdemers have you any objection for this PR? This is an automated

[GitHub] fpapon commented on issue #78: Adding another WildcardPermission test case

2019-02-20 Thread GitBox
fpapon commented on issue #78: Adding another WildcardPermission test case URL: https://github.com/apache/shiro/pull/78#issuecomment-465886209 restest this please This is an automated message from the Apache Git Service. To

[GitHub] asfgit commented on issue #65: [SHIRO-458] Replaced string equals with internal method that does not leak time

2019-02-21 Thread GitBox
asfgit commented on issue #65: [SHIRO-458] Replaced string equals with internal method that does not leak time URL: https://github.com/apache/shiro/pull/65#issuecomment-465904842 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #78: Adding another WildcardPermission test case

2019-02-20 Thread GitBox
asfgit commented on issue #78: Adding another WildcardPermission test case URL: https://github.com/apache/shiro/pull/78#issuecomment-465893896 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/50/

[GitHub] fpapon commented on issue #47: Idea: Add support for javax.annotation.security.RolesAllowed, PermitAll, and DenyAll

2019-02-20 Thread GitBox
fpapon commented on issue #47: Idea: Add support for javax.annotation.security.RolesAllowed, PermitAll, and DenyAll URL: https://github.com/apache/shiro/pull/47#issuecomment-465892702 @bdemers I think it could be usefull for migrate existing application to Shiro without source code

[GitHub] asfgit commented on issue #65: [SHIRO-458] Replaced string equals with internal method that does not leak time

2019-02-21 Thread GitBox
asfgit commented on issue #65: [SHIRO-458] Replaced string equals with internal method that does not leak time URL: https://github.com/apache/shiro/pull/65#issuecomment-465915457 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #47: Idea: Add support for javax.annotation.security.RolesAllowed, PermitAll, and DenyAll

2019-02-21 Thread GitBox
asfgit commented on issue #47: Idea: Add support for javax.annotation.security.RolesAllowed, PermitAll, and DenyAll URL: https://github.com/apache/shiro/pull/47#issuecomment-465941385 Refer to this link for build results (access rights to CI server needed):

[GitHub] fpapon commented on issue #8: Include ISIS Security extensions to Shiro for RBAC and SSO

2019-02-21 Thread GitBox
fpapon commented on issue #8: Include ISIS Security extensions to Shiro for RBAC and SSO URL: https://github.com/apache/shiro/pull/8#issuecomment-465948815 @bdemers do you think this PR can be merged from the patch? May be we could create a new PR from the patch. Thoughts?

[GitHub] asfgit commented on issue #8: Include ISIS Security extensions to Shiro for RBAC and SSO

2019-02-21 Thread GitBox
asfgit commented on issue #8: Include ISIS Security extensions to Shiro for RBAC and SSO URL: https://github.com/apache/shiro/pull/8#issuecomment-465949493 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/55/

[GitHub] cpetzka commented on issue #71: [SHIRO-668] Catch unexpected errors which can lead to oom

2019-02-21 Thread GitBox
cpetzka commented on issue #71: [SHIRO-668] Catch unexpected errors which can lead to oom URL: https://github.com/apache/shiro/pull/71#issuecomment-466054756 Sorry, I can't tell you what exception it was. I don't think it was logged. There were entries in the log every 5 minutes that the

[GitHub] fpapon commented on issue #71: [SHIRO-668] Catch unexpected errors which can lead to oom

2019-02-21 Thread GitBox
fpapon commented on issue #71: [SHIRO-668] Catch unexpected errors which can lead to oom URL: https://github.com/apache/shiro/pull/71#issuecomment-466118722 May be we can use a `UncaughtExceptionHandler` in the `Thread` initialization to have more informations. If there is a problem with

[GitHub] fpapon commented on issue #47: Idea: Add support for javax.annotation.security.RolesAllowed, PermitAll, and DenyAll

2019-02-21 Thread GitBox
fpapon commented on issue #47: Idea: Add support for javax.annotation.security.RolesAllowed, PermitAll, and DenyAll URL: https://github.com/apache/shiro/pull/47#issuecomment-466123173 @bdemers great! I created a Jira for this: https://issues.apache.org/jira/browse/SHIRO-671 Let me

[GitHub] bdemers commented on issue #49: New AuthenticationStrategy - ShortCircuitFirstSuccessfulStrategy

2019-02-20 Thread GitBox
bdemers commented on issue #49: New AuthenticationStrategy - ShortCircuitFirstSuccessfulStrategy URL: https://github.com/apache/shiro/pull/49#issuecomment-465658150 @fpapon I'm a fan of #50 instead of this one, we can then roll that into the default (only) behavior for 2.0. Thanks

[GitHub] fpapon commented on issue #61: [SHIRO-670] ByteSource Serializable!

2019-02-26 Thread GitBox
fpapon commented on issue #61: [SHIRO-670] ByteSource Serializable! URL: https://github.com/apache/shiro/pull/61#issuecomment-467719801 @DR-YangLong can you write in english please? This is an automated message from the

[GitHub] DR-YangLong commented on issue #61: [SHIRO-670] ByteSource Serializable!

2019-02-26 Thread GitBox
DR-YangLong commented on issue #61: [SHIRO-670] ByteSource Serializable! URL: https://github.com/apache/shiro/pull/61#issuecomment-467748242 if you just went share session,look at the interface

[GitHub] DR-YangLong commented on issue #61: [SHIRO-670] ByteSource Serializable!

2019-02-26 Thread GitBox
DR-YangLong commented on issue #61: [SHIRO-670] ByteSource Serializable! URL: https://github.com/apache/shiro/pull/61#issuecomment-467707521

[GitHub] fpapon opened a new pull request #119: [SHIRO-672] Upgrade to jacoco-maven-plugin 0.8.3

2019-02-23 Thread GitBox
fpapon opened a new pull request #119: [SHIRO-672] Upgrade to jacoco-maven-plugin 0.8.3 URL: https://github.com/apache/shiro/pull/119 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] asfgit commented on issue #119: [SHIRO-672] Upgrade to jacoco-maven-plugin 0.8.3

2019-02-23 Thread GitBox
asfgit commented on issue #119: [SHIRO-672] Upgrade to jacoco-maven-plugin 0.8.3 URL: https://github.com/apache/shiro/pull/119#issuecomment-466639768 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/56/

[GitHub] fpapon opened a new pull request #120: [SHIRO-662] Constant Name Change in AuthenticationRealm

2019-02-23 Thread GitBox
fpapon opened a new pull request #120: [SHIRO-662] Constant Name Change in AuthenticationRealm URL: https://github.com/apache/shiro/pull/120 Supercedes https://github.com/apache/shiro/pull/69 This fix the failing test.

[GitHub] fpapon merged pull request #119: [SHIRO-672] Upgrade to jacoco-maven-plugin 0.8.3

2019-02-23 Thread GitBox
fpapon merged pull request #119: [SHIRO-672] Upgrade to jacoco-maven-plugin 0.8.3 URL: https://github.com/apache/shiro/pull/119 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] cpetzka commented on issue #71: [SHIRO-668] Catch unexpected errors which can lead to oom

2019-02-25 Thread GitBox
cpetzka commented on issue #71: [SHIRO-668] Catch unexpected errors which can lead to oom URL: https://github.com/apache/shiro/pull/71#issuecomment-466934679 If the problem is only a short disconnect from SessionStore/Cache, a simple reboot would be sufficient. However, if it is always

[GitHub] ChunMengLu edited a comment on issue #61: [SHIRO-670] ByteSource Serializable!

2019-02-27 Thread GitBox
ChunMengLu edited a comment on issue #61: [SHIRO-670] ByteSource Serializable! URL: https://github.com/apache/shiro/pull/61#issuecomment-468153586 Two years ago, I was ok after I customized my ShiroByteSource. Or close this pull???

[GitHub] ChunMengLu commented on issue #61: [SHIRO-670] ByteSource Serializable!

2019-02-27 Thread GitBox
ChunMengLu commented on issue #61: [SHIRO-670] ByteSource Serializable! URL: https://github.com/apache/shiro/pull/61#issuecomment-468153586 Two years ago, I was ok after I customized my ShiroByteSource. This is an automated

[GitHub] ChunMengLu commented on issue #61: [SHIRO-670] ByteSource Serializable!

2019-02-27 Thread GitBox
ChunMengLu commented on issue #61: [SHIRO-670] ByteSource Serializable! URL: https://github.com/apache/shiro/pull/61#issuecomment-468153253 > if you just went share session,look at the interface

[GitHub] bdemers commented on issue #71: [SHIRO-668] Catch unexpected errors which can lead to oom

2019-02-25 Thread GitBox
bdemers commented on issue #71: [SHIRO-668] Catch unexpected errors which can lead to oom URL: https://github.com/apache/shiro/pull/71#issuecomment-467063801 Thanks @cpetzka I can see that. Maybe we should catch Runtimes, and re-throw everything else. That would allow temporary

[GitHub] bdemers commented on issue #61: [SHIRO-670] ByteSource Serializable!

2019-02-25 Thread GitBox
bdemers commented on issue #61: [SHIRO-670] ByteSource Serializable! URL: https://github.com/apache/shiro/pull/61#issuecomment-467068191 Not all implementations of ByteSource can be serializable. For example if the source was an input stream. That said, it should be easy store

[GitHub] fpapon commented on issue #120: [SHIRO-662] Constant Name Change in AuthenticationRealm

2019-02-23 Thread GitBox
fpapon commented on issue #120: [SHIRO-662] Constant Name Change in AuthenticationRealm URL: https://github.com/apache/shiro/pull/120#issuecomment-466641526 This close https://github.com/apache/shiro/pull/69 This is an

[GitHub] fpapon merged pull request #120: [SHIRO-662] Constant Name Change in AuthenticationRealm

2019-02-23 Thread GitBox
fpapon merged pull request #120: [SHIRO-662] Constant Name Change in AuthenticationRealm URL: https://github.com/apache/shiro/pull/120 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] asfgit commented on issue #120: [SHIRO-662] Constant Name Change in AuthenticationRealm

2019-02-23 Thread GitBox
asfgit commented on issue #120: [SHIRO-662] Constant Name Change in AuthenticationRealm URL: https://github.com/apache/shiro/pull/120#issuecomment-466641378 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/57/

[GitHub] fpapon commented on issue #69: [SHIRO-662] Constant Name Change in AuthenticationRealm

2019-02-23 Thread GitBox
fpapon commented on issue #69: [SHIRO-662] Constant Name Change in AuthenticationRealm URL: https://github.com/apache/shiro/pull/69#issuecomment-466641640 Fixed by https://github.com/apache/shiro/pull/120 This is an

[GitHub] fpapon closed pull request #69: [SHIRO-662] Constant Name Change in AuthenticationRealm

2019-02-23 Thread GitBox
fpapon closed pull request #69: [SHIRO-662] Constant Name Change in AuthenticationRealm URL: https://github.com/apache/shiro/pull/69 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [shiro] fpapon merged pull request #118: [SHIRO-667] Upgrade to Spring 4.3.22-RELEASE

2019-03-08 Thread GitBox
fpapon merged pull request #118: [SHIRO-667] Upgrade to Spring 4.3.22-RELEASE URL: https://github.com/apache/shiro/pull/118 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [shiro] asfgit commented on issue #85: Adding Spring's Filters to ShiroFilterFactorBean when using Java config

2019-03-09 Thread GitBox
asfgit commented on issue #85: Adding Spring's Filters to ShiroFilterFactorBean when using Java config URL: https://github.com/apache/shiro/pull/85#issuecomment-471194336 Refer to this link for build results (access rights to CI server needed):

  1   2   3   4   5   >