[GitHub] [shiro] fpapon commented on issue #137: Build

[GitBox]

fpapon commented on issue #137: Build
URL: https://github.com/apache/shiro/pull/137#issuecomment-497822375
 
 
   @bdemers are you ok with the lastest changes?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [shiro] fpapon commented on issue #137: Build

[GitBox]

fpapon commented on issue #137: Build
URL: https://github.com/apache/shiro/pull/137#issuecomment-496823457
 
 
   I made changes:
   - deactivate `jacoco` by default
   - activate `jacoco` with the `ci` profile
   - add a `fast` profile with unit tests and ITtests deactivated


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [shiro] fpapon commented on issue #137: Build

[GitBox]

fpapon commented on issue #137: Build
URL: https://github.com/apache/shiro/pull/137#issuecomment-496602102
 
 
   > Thanks for taking this on!
   > 
   > I think we should try to simplify this a little more to make this easier 
for contributors.
   > Maybe ending with something like `mvn clean install -Pci` or possibly 
three options "normal", `ci`, `fast`
   > Anything more advanced, and someone can start adding other maven plugin 
flags?
   > 
   > Thinking (typing) out loud, but my main concern is when submodules are 
hidden behind profiles, IDE's and cross project dependencies can start seeing 
issues that are not obvious at first. My personal pref is to to still process 
the module, but skip the tests via a profile (this assumes that the 
compile/packaging is fast enough to impact developers)
   > 
![Compiling](https://camo.githubusercontent.com/d34da8961642057a4b7ebaee28e365320049e461/68747470733a2f2f696d67732e786b63642e636f6d2f636f6d6963732f636f6d70696c696e672e706e67)
   
   Yeah I like it :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services