[GitHub] [shiro] steinarb commented on issue #138: Support base64 encoded salt in JdbcRealm

2019-08-02 Thread GitBox
steinarb commented on issue #138: Support base64 encoded salt in JdbcRealm
URL: https://github.com/apache/shiro/pull/138#issuecomment-517752959
 
 
   @fpapon rebased, conflict resolved, built with "mvn clean install" with no 
errors, and branch force-pushed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [shiro] steinarb commented on issue #138: Support base64 encoded salt in JdbcRealm

2019-08-02 Thread GitBox
steinarb commented on issue #138: Support base64 encoded salt in JdbcRealm
URL: https://github.com/apache/shiro/pull/138#issuecomment-517705111
 
 
   @bdemers  @fpapon  Should I resolve the conflict and re-push? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [shiro] steinarb commented on issue #138: Support base64 encoded salt in JdbcRealm

2019-07-27 Thread GitBox
steinarb commented on issue #138: Support base64 encoded salt in JdbcRealm
URL: https://github.com/apache/shiro/pull/138#issuecomment-515669920
 
 
   > Hi @steinarb , any update about the ICLA?
   
   Hi @fpapon I understood from the comment by @bdemers above that it was 
OK...? 
   
   In my INBOX there's received an automated response from 
secret...@apache.org, received 8 weeks ago, saying that "If you have been 
invited as a committer, please advise the (P)PMC that your ICLA has been filed."


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [shiro] steinarb commented on issue #138: Support base64 encoded salt in JdbcRealm

2019-05-30 Thread GitBox
steinarb commented on issue #138: Support base64 encoded salt in JdbcRealm
URL: https://github.com/apache/shiro/pull/138#issuecomment-497344471
 
 
   > @steinarb Looks good to me! can you sign an Apache CLA? 
https://www.apache.org/licenses/#contributor-license-agreements
   
   @bdemers I have filled out the ICLA PDF and printed it to another PDF and 
signed the result with gpg and sent both the PDF and the asc to 
secret...@apache.org (I wasn't able to fill out anything in the signature field 
in the PDF but I assume the .asc takes care of that...?)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services