[GitHub] [singa] XJDKC commented on pull request #708: SINGA-510 Improvement of Time Profiling Function

2020-05-22 Thread GitBox
XJDKC commented on pull request #708: URL: https://github.com/apache/singa/pull/708#issuecomment-632978715 OK This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [singa] XJDKC commented on a change in pull request #708: SINGA-510 Improvement of Time Profiling Function

2020-05-22 Thread GitBox
XJDKC commented on a change in pull request #708: URL: https://github.com/apache/singa/pull/708#discussion_r429511478 ## File path: src/core/scheduler/scheduler.cc ## @@ -325,9 +337,10 @@ void Graph::RunGraph() { } } + EvaluateTimeElapsed(); Review comment:

[GitHub] [singa] lgtm-com[bot] commented on pull request #697: New Model Layer Operator API

2020-05-22 Thread GitBox
lgtm-com[bot] commented on pull request #697: URL: https://github.com/apache/singa/pull/697#issuecomment-632984557 This pull request **introduces 5 alerts** and **fixes 11** when merging ac7ccd38bf3e4afae447f741aaee6a6348c281ab into 84de1af8428d3796e3f99b215570a54d6f975a94 - [view on

[GitHub] [singa] nudles commented on pull request #708: SINGA-510 Improvement of Time Profiling Function

2020-05-22 Thread GitBox
nudles commented on pull request #708: URL: https://github.com/apache/singa/pull/708#issuecomment-632977682 @XJDKC pls help review. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [singa] chrishkchris commented on a change in pull request #708: SINGA-510 Improvement of Time Profiling Function

2020-05-22 Thread GitBox
chrishkchris commented on a change in pull request #708: URL: https://github.com/apache/singa/pull/708#discussion_r429513662 ## File path: src/core/scheduler/scheduler.cc ## @@ -325,9 +337,10 @@ void Graph::RunGraph() { } } + EvaluateTimeElapsed(); Review comment:

[GitHub] [singa] chrishkchris commented on pull request #708: SINGA-510 Improvement of Time Profiling Function

2020-05-22 Thread GitBox
chrishkchris commented on pull request #708: URL: https://github.com/apache/singa/pull/708#issuecomment-632984166 Addressed the comments, a test: ``` root@71ac539cda77:~/dcsysh/singa/examples/cnn# python3 benchmark.py --verbosity 1

[GitHub] [singa] chrishkchris commented on a change in pull request #708: SINGA-510 Improvement of Time Profiling Function

2020-05-22 Thread GitBox
chrishkchris commented on a change in pull request #708: URL: https://github.com/apache/singa/pull/708#discussion_r429513576 ## File path: src/core/scheduler/scheduler.cc ## @@ -325,9 +337,10 @@ void Graph::RunGraph() { } } + EvaluateTimeElapsed(); + // increment

[GitHub] [singa] dcslin commented on pull request #697: New Model Layer Operator API

2020-05-22 Thread GitBox
dcslin commented on pull request #697: URL: https://github.com/apache/singa/pull/697#issuecomment-632984025 setup the overall framework for save load states This is an automated message from the Apache Git Service. To

[GitHub] [singa] chrishkchris commented on a change in pull request #708: SINGA-510 Improvement of Time Profiling Function

2020-05-22 Thread GitBox
chrishkchris commented on a change in pull request #708: URL: https://github.com/apache/singa/pull/708#discussion_r429513576 ## File path: src/core/scheduler/scheduler.cc ## @@ -325,9 +337,10 @@ void Graph::RunGraph() { } } + EvaluateTimeElapsed(); + // increment

[GitHub] [singa] agnesnatasya commented on issue #700: Expand the model zoo (example model set)

2020-05-22 Thread GitBox
agnesnatasya commented on issue #700: URL: https://github.com/apache/singa/issues/700#issuecomment-632762216 I will try to work on the ShuffleNet This is an automated message from the Apache Git Service. To respond to the

[GitHub] [singa] chrishkchris opened a new pull request #708: SINGA-510 Improvement of Time Profiling Function

2020-05-22 Thread GitBox
chrishkchris opened a new pull request #708: URL: https://github.com/apache/singa/pull/708 There are several improvement in the time profiling function 1. Greatly reduced the measurement overhead: In the new version, we synchronize the cudastream only one time at the end of iteration.

[GitHub] [singa] chrishkchris commented on pull request #708: SINGA-510 Improvement of Time Profiling Function

2020-05-22 Thread GitBox
chrishkchris commented on pull request #708: URL: https://github.com/apache/singa/pull/708#issuecomment-632817048 Results: ``` root@71ac539cda77:~/dcsysh/singa/examples/cnn# python3 benchmark.py --verbosity 1

[GitHub] [singa] dcslin commented on pull request #697: New Model Layer Operator API

2020-05-22 Thread GitBox
dcslin commented on pull request #697: URL: https://github.com/apache/singa/pull/697#issuecomment-632811131 consolidating some designs of layer method with rulin TODO: 5. [rulin & shicong] compile / do_init: separate the initialzation and forward propagation for each layers, create

[GitHub] [singa] lgtm-com[bot] commented on pull request #703: Refactor sonnx, test cases and examples

2020-05-22 Thread GitBox
lgtm-com[bot] commented on pull request #703: URL: https://github.com/apache/singa/pull/703#issuecomment-632892891 This pull request **introduces 7 alerts** and **fixes 1** when merging cfa8878316e69cb16939995980d04babc27af8c2 into 84de1af8428d3796e3f99b215570a54d6f975a94 - [view on

[GitHub] [singa] lgtm-com[bot] commented on pull request #703: Refactor sonnx, test cases and examples

2020-05-22 Thread GitBox
lgtm-com[bot] commented on pull request #703: URL: https://github.com/apache/singa/pull/703#issuecomment-632895642 This pull request **introduces 7 alerts** and **fixes 1** when merging 03c28cada62ee1acd3c5c9b17292a90d878ea98b into 84de1af8428d3796e3f99b215570a54d6f975a94 - [view on