[GitHub] [incubator-singa] ijingo opened a new pull request #450: SINGA-433 Preparation for V2.0 release

2019-04-01 Thread GitBox
ijingo opened a new pull request #450: SINGA-433 Preparation for V2.0 release URL: https://github.com/apache/incubator-singa/pull/450 * Add LICENSE headers to source files * Modify LICENSE file to add licenses information about following packs: 1. mkl-dnn 2. onnx

[GitHub] [incubator-singa] kaiping opened a new pull request #451: SINGA-374 Add license header to every README.md file

2019-04-02 Thread GitBox
kaiping opened a new pull request #451: SINGA-374 Add license header to every README.md file URL: https://github.com/apache/incubator-singa/pull/451 add license header to *.md files and *.ipynb files This is an automated

[GitHub] [incubator-singa] nudles merged pull request #451: SINGA-374 Add license header to every README.md file

2019-04-02 Thread GitBox
nudles merged pull request #451: SINGA-374 Add license header to every README.md file URL: https://github.com/apache/incubator-singa/pull/451 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-singa] nudles merged pull request #448: SINGA-437 Extra space in meta.yaml

2019-03-31 Thread GitBox
nudles merged pull request #448: SINGA-437 Extra space in meta.yaml URL: https://github.com/apache/incubator-singa/pull/448 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-singa] moazreyad opened a new pull request #447: SINGA-420 Add build command and links for C++ Doxygen documentation

2019-03-31 Thread GitBox
moazreyad opened a new pull request #447: SINGA-420 Add build command and links for C++ Doxygen documentation URL: https://github.com/apache/incubator-singa/pull/447 This is an automated message from the Apache Git Service.

[GitHub] [incubator-singa] nudles opened a new pull request #449: SINGA-432 Update depdent lib versions in conda-build config

2019-03-31 Thread GitBox
nudles opened a new pull request #449: SINGA-432 Update depdent lib versions in conda-build config URL: https://github.com/apache/incubator-singa/pull/449 add CUDA to the script env in meta.yml and update the bash test for CUDA in build.sh

[GitHub] [incubator-singa] wangsheng1001 commented on issue #446: SINGA-433 Preparation for V2.0 release

2019-04-03 Thread GitBox
wangsheng1001 commented on issue #446: SINGA-433 Preparation for V2.0 release URL: https://github.com/apache/incubator-singa/pull/446#issuecomment-479414121 @nudles committed This is an automated message from the Apache Git

[GitHub] [incubator-singa] ShichengChen opened a new pull request #444: singa-onnx SINGA-333

2019-03-21 Thread GitBox
ShichengChen opened a new pull request #444: singa-onnx SINGA-333 URL: https://github.com/apache/incubator-singa/pull/444 This pull request aims to let singa support onnx. Because old pull request has so much commit messages and not professional code, with the help from professor Wang,

[GitHub] [incubator-singa] ShichengChen closed pull request #416: singa-onnx

2019-03-21 Thread GitBox
ShichengChen closed pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-singa] nudles merged pull request #444: singa-onnx SINGA-333

2019-03-24 Thread GitBox
nudles merged pull request #444: singa-onnx SINGA-333 URL: https://github.com/apache/incubator-singa/pull/444 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-singa] nudles commented on a change in pull request #445: SINGA-433 updated documentation about docker, dockerfile for consitent, cudnn version in dockerfile

2019-04-03 Thread GitBox
nudles commented on a change in pull request #445: SINGA-433 updated documentation about docker, dockerfile for consitent, cudnn version in dockerfile URL: https://github.com/apache/incubator-singa/pull/445#discussion_r272016433 ## File path: cmake/Dependencies.cmake ##

[GitHub] [incubator-singa] dcslin commented on a change in pull request #445: SINGA-433 updated documentation about docker, dockerfile for consitent, cudnn version in dockerfile

2019-04-03 Thread GitBox
dcslin commented on a change in pull request #445: SINGA-433 updated documentation about docker, dockerfile for consitent, cudnn version in dockerfile URL: https://github.com/apache/incubator-singa/pull/445#discussion_r272013902 ## File path: cmake/Dependencies.cmake ##

[GitHub] [incubator-singa] nudles commented on a change in pull request #445: SINGA-433 updated documentation about docker, dockerfile for consitent, cudnn version in dockerfile

2019-04-03 Thread GitBox
nudles commented on a change in pull request #445: SINGA-433 updated documentation about docker, dockerfile for consitent, cudnn version in dockerfile URL: https://github.com/apache/incubator-singa/pull/445#discussion_r272011780 ## File path: cmake/Dependencies.cmake ##

[GitHub] [incubator-singa] nudles commented on a change in pull request #445: SINGA-433 updated documentation about docker, dockerfile for consitent, cudnn version in dockerfile

2019-04-03 Thread GitBox
nudles commented on a change in pull request #445: SINGA-433 updated documentation about docker, dockerfile for consitent, cudnn version in dockerfile URL: https://github.com/apache/incubator-singa/pull/445#discussion_r272011780 ## File path: cmake/Dependencies.cmake ##

[GitHub] [incubator-singa] nudles merged pull request #446: SINGA-433 Preparation for V2.0 release

2019-04-03 Thread GitBox
nudles merged pull request #446: SINGA-433 Preparation for V2.0 release URL: https://github.com/apache/incubator-singa/pull/446 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-singa] dcslin commented on a change in pull request #445: SINGA-433 updated documentation about docker, dockerfile for consitent, cudnn version in dockerfile

2019-04-04 Thread GitBox
dcslin commented on a change in pull request #445: SINGA-433 updated documentation about docker, dockerfile for consitent, cudnn version in dockerfile URL: https://github.com/apache/incubator-singa/pull/445#discussion_r272034982 ## File path: cmake/Dependencies.cmake ##

[GitHub] [incubator-singa] dcslin commented on a change in pull request #445: SINGA-433 updated documentation about docker, dockerfile for consitent, cudnn version in dockerfile

2019-04-04 Thread GitBox
dcslin commented on a change in pull request #445: SINGA-433 updated documentation about docker, dockerfile for consitent, cudnn version in dockerfile URL: https://github.com/apache/incubator-singa/pull/445#discussion_r272034982 ## File path: cmake/Dependencies.cmake ##

[GitHub] [incubator-singa] kaiping merged pull request #450: SINGA-433 Preparation for V2.0 release

2019-04-05 Thread GitBox
kaiping merged pull request #450: SINGA-433 Preparation for V2.0 release URL: https://github.com/apache/incubator-singa/pull/450 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-singa] nudles merged pull request #445: SINGA-433 updated documentation about docker, dockerfile for consitent, cudnn version in dockerfile

2019-04-05 Thread GitBox
nudles merged pull request #445: SINGA-433 updated documentation about docker, dockerfile for consitent, cudnn version in dockerfile URL: https://github.com/apache/incubator-singa/pull/445 This is an automated message from

[GitHub] [incubator-singa] wangsheng1001 opened a new pull request #446: SINGA-433 Preparation for V2.0 release

2019-03-31 Thread GitBox
wangsheng1001 opened a new pull request #446: SINGA-433 Preparation for V2.0 release URL: https://github.com/apache/incubator-singa/pull/446 Update release note This is an automated message from the Apache Git Service. To

[GitHub] [incubator-singa] kaiping merged pull request #449: SINGA-432 Update depdent lib versions in conda-build config

2019-04-01 Thread GitBox
kaiping merged pull request #449: SINGA-432 Update depdent lib versions in conda-build config URL: https://github.com/apache/incubator-singa/pull/449 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-singa] dcslin commented on a change in pull request #445: SINGA-433 updated documentation about docker, dockerfile for consitent, cudnn version in dockerfile

2019-03-31 Thread GitBox
dcslin commented on a change in pull request #445: SINGA-433 updated documentation about docker, dockerfile for consitent, cudnn version in dockerfile URL: https://github.com/apache/incubator-singa/pull/445#discussion_r270707618 ## File path: doc/en/docs/docker.md ## @@

[GitHub] [incubator-singa] nudles commented on issue #445: SINGA-433 updated documentation about docker, dockerfile for consitent, cudnn version in dockerfile

2019-03-31 Thread GitBox
nudles commented on issue #445: SINGA-433 updated documentation about docker, dockerfile for consitent, cudnn version in dockerfile URL: https://github.com/apache/incubator-singa/pull/445#issuecomment-478424372 1. for the cpu runtime, pls add the instructions to install singa via `conda

[GitHub] [incubator-singa] nudles merged pull request #447: SINGA-420 Add build command and links for C++ Doxygen documentation

2019-03-31 Thread GitBox
nudles merged pull request #447: SINGA-420 Add build command and links for C++ Doxygen documentation URL: https://github.com/apache/incubator-singa/pull/447 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-singa] YingHongBin opened a new pull request #448: SINGA-437 Extra space in meta.yaml

2019-03-31 Thread GitBox
YingHongBin opened a new pull request #448: SINGA-437 Extra space in meta.yaml URL: https://github.com/apache/incubator-singa/pull/448 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-singa] nudles commented on a change in pull request #445: SINGA-433 updated documentation about docker, dockerfile for consitent, cudnn version in dockerfile

2019-03-31 Thread GitBox
nudles commented on a change in pull request #445: SINGA-433 updated documentation about docker, dockerfile for consitent, cudnn version in dockerfile URL: https://github.com/apache/incubator-singa/pull/445#discussion_r270665355 ## File path: doc/en/docs/docker.md ## @@

[GitHub] [incubator-singa] nudles commented on issue #446: SINGA-433 Preparation for V2.0 release

2019-03-31 Thread GitBox
nudles commented on issue #446: SINGA-433 Preparation for V2.0 release URL: https://github.com/apache/incubator-singa/pull/446#issuecomment-478340426 could you pls 1. add a file RELEASE_NOTES_2.0.0.md here https://github.com/apache/incubator-singa/blob/master/doc/en/releases 2. add

[GitHub] [incubator-singa] dcslin opened a new pull request #445: Singa 433

2019-03-26 Thread GitBox
dcslin opened a new pull request #445: Singa 433 URL: https://github.com/apache/incubator-singa/pull/445 Hi team, this is to update docker doc as well as dockerfile arrangement to make them consistent This is an automated

[GitHub] [incubator-singa] dcslin commented on issue #445: SINGA-433 updated documentation about docker, dockerfile for consitent, cudnn version in dockerfile

2019-03-27 Thread GitBox
dcslin commented on issue #445: SINGA-433 updated documentation about docker, dockerfile for consitent, cudnn version in dockerfile URL: https://github.com/apache/incubator-singa/pull/445#issuecomment-477000768 tested dockerfiles, `cuda9, cuda10, mkldnn` and error free in unit test

[GitHub] moazreyad opened a new pull request #436: SINGA-428 Move Docker images under Apache user name

2019-02-20 Thread GitBox
moazreyad opened a new pull request #436: SINGA-428 Move Docker images under Apache user name URL: https://github.com/apache/incubator-singa/pull/436 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-singa] dcslin commented on issue #437: SINGA-429 update dockerfile for cuda cudnn update

2019-03-05 Thread GitBox
dcslin commented on issue #437: SINGA-429 update dockerfile for cuda cudnn update URL: https://github.com/apache/incubator-singa/pull/437#issuecomment-469723702 Hi @nudles , this is almost done. I have been stuck on a weird cmake behaviour and investigating it: make syntax error in

[GitHub] [incubator-singa] dcslin edited a comment on issue #437: SINGA-429 update dockerfile for cuda cudnn update

2019-03-05 Thread GitBox
dcslin edited a comment on issue #437: SINGA-429 update dockerfile for cuda cudnn update URL: https://github.com/apache/incubator-singa/pull/437#issuecomment-469723702 Hi @nudles , this is almost done. I have been stuck on a weird cmake(version > 3.12) behaviour and investigating it:

[GitHub] dcslin opened a new pull request #437: update dockerfile for cuda cudnn update

2019-03-01 Thread GitBox
dcslin opened a new pull request #437: update dockerfile for cuda cudnn update URL: https://github.com/apache/incubator-singa/pull/437 Hi team, Kindly find the changes below regarding update of cuda and cudnn version. - manual install cmake to 3.14, reason: as per testing and

[GitHub] dcslin commented on issue #437: update dockerfile for cuda cudnn update

2019-03-01 Thread GitBox
dcslin commented on issue #437: update dockerfile for cuda cudnn update URL: https://github.com/apache/incubator-singa/pull/437#issuecomment-468580743 Also, please kindly advise do we need cudnn 7.5? as mentioned in https://issues.apache.org/jira/browse/SINGA-429 However, the

[GitHub] [incubator-singa] nudles commented on issue #437: SINGA-429 update dockerfile for cuda cudnn update

2019-03-03 Thread GitBox
nudles commented on issue #437: SINGA-429 update dockerfile for cuda cudnn update URL: https://github.com/apache/incubator-singa/pull/437#issuecomment-469022821 pls add the command for compiling and installing singa. when the users pull the image and run the container, they should be

[GitHub] [incubator-singa] dcslin opened a new pull request #441: added cpu devel dockerfile, minor bug fix

2019-03-14 Thread GitBox
dcslin opened a new pull request #441: added cpu devel dockerfile, minor bug fix URL: https://github.com/apache/incubator-singa/pull/441 Hi team, CPU devel dockerfile is added. Bug fix, transpose unit test failed, mentioned https://github.com/apache/incubator-singa/pull/438

[GitHub] [incubator-singa] nudles edited a comment on issue #441: added cpu devel dockerfile, minor bug fix

2019-03-14 Thread GitBox
nudles edited a comment on issue #441: added cpu devel dockerfile, minor bug fix URL: https://github.com/apache/incubator-singa/pull/441#issuecomment-472753723 can you create a jira ticket and put the ticket number in the commit msg like [this

[GitHub] [incubator-singa] nudles commented on issue #441: added cpu devel dockerfile, minor bug fix

2019-03-14 Thread GitBox
nudles commented on issue #441: added cpu devel dockerfile, minor bug fix URL: https://github.com/apache/incubator-singa/pull/441#issuecomment-472753723 can you create a jira ticket and put the ticket number in the commit msg like [this

[GitHub] [incubator-singa] nudles opened a new pull request #442: Singa 432 Update depdent lib versions in conda-build config

2019-03-15 Thread GitBox
nudles opened a new pull request #442: Singa 432 Update depdent lib versions in conda-build config URL: https://github.com/apache/incubator-singa/pull/442 https://issues.apache.org/jira/browse/SINGA-432 This is an automated

[GitHub] [incubator-singa] ShichengChen commented on a change in pull request #416: singa-onnx

2019-03-11 Thread GitBox
ShichengChen commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264525378 ## File path: python/singa/sonnx.py ## @@ -258,8 +258,8 @@ def to_onnx_model(inputs, y, model_name='sonnx'): dependency =

[GitHub] [incubator-singa] ShichengChen commented on a change in pull request #416: singa-onnx

2019-03-11 Thread GitBox
ShichengChen commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264525214 ## File path: src/api/model_operation.i ## @@ -74,12 +74,16 @@ class CudnnConvHandle: public ConvHandle {

[GitHub] [incubator-singa] ShichengChen commented on a change in pull request #416: singa-onnx

2019-03-11 Thread GitBox
ShichengChen commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264525240 ## File path: src/api/model_operation.i ## @@ -118,6 +123,14 @@ class CudnnPoolingHandle : public PoolingHandle { int

[GitHub] [incubator-singa] ShichengChen commented on a change in pull request #416: singa-onnx

2019-03-11 Thread GitBox
ShichengChen commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264525670 ## File path: python/singa/sonnx.py ## @@ -319,14 +320,21 @@ def output_name(op):

[GitHub] [incubator-singa] dcslin commented on a change in pull request #437: SINGA-429 update dockerfile for cuda cudnn update

2019-03-10 Thread GitBox
dcslin commented on a change in pull request #437: SINGA-429 update dockerfile for cuda cudnn update URL: https://github.com/apache/incubator-singa/pull/437#discussion_r264051509 ## File path: tool/docker/devel/native/ubuntu/cuda10/py3/Dockerfile ## @@ -0,0 +1,87 @@ +#

[GitHub] [incubator-singa] nudles commented on a change in pull request #437: SINGA-429 update dockerfile for cuda cudnn update

2019-03-10 Thread GitBox
nudles commented on a change in pull request #437: SINGA-429 update dockerfile for cuda cudnn update URL: https://github.com/apache/incubator-singa/pull/437#discussion_r264042016 ## File path: tool/docker/devel/native/ubuntu/cuda10/py3/Dockerfile ## @@ -0,0 +1,87 @@ +#

[GitHub] [incubator-singa] nudles commented on a change in pull request #416: singa-onnx

2019-03-10 Thread GitBox
nudles commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264043364 ## File path: examples/onnx/cnnonnx2singa.py ## @@ -105,19 +105,13 @@ def accuracy(pred, target): model =

[GitHub] [incubator-singa] nudles commented on a change in pull request #416: singa-onnx

2019-03-10 Thread GitBox
nudles commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264043293 ## File path: python/singa/autograd.py ## @@ -1115,7 +1161,8 @@ def __init__(self, kernel_size, stride=None, padding=0): class

[GitHub] [incubator-singa] nudles commented on a change in pull request #416: singa-onnx

2019-03-10 Thread GitBox
nudles commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264043036 ## File path: python/singa/sonnx.py ## @@ -18,272 +18,359 @@ # - from __future__ import division -from singa import tensor

[GitHub] [incubator-singa] nudles commented on a change in pull request #416: singa-onnx

2019-03-10 Thread GitBox
nudles commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264043009 ## File path: python/singa/sonnx.py ## @@ -18,272 +18,359 @@ # - from __future__ import division -from singa import tensor

[GitHub] [incubator-singa] nudles commented on a change in pull request #416: singa-onnx

2019-03-10 Thread GitBox
nudles commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264043246 ## File path: python/singa/sonnx.py ## @@ -18,272 +18,359 @@ # - from __future__ import division -from singa import tensor

[GitHub] [incubator-singa] nudles commented on a change in pull request #416: singa-onnx

2019-03-10 Thread GitBox
nudles commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264043130 ## File path: python/singa/sonnx.py ## @@ -18,272 +18,359 @@ # - from __future__ import division -from singa import tensor

[GitHub] [incubator-singa] nudles commented on a change in pull request #416: singa-onnx

2019-03-10 Thread GitBox
nudles commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264043211 ## File path: python/singa/sonnx.py ## @@ -18,272 +18,359 @@ # - from __future__ import division -from singa import tensor

[GitHub] [incubator-singa] nudles commented on a change in pull request #416: singa-onnx

2019-03-10 Thread GitBox
nudles commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264043261 ## File path: python/singa/sonnx.py ## @@ -18,272 +18,359 @@ # - from __future__ import division -from singa import tensor

[GitHub] [incubator-singa] nudles commented on a change in pull request #416: singa-onnx

2019-03-10 Thread GitBox
nudles commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264043355 ## File path: examples/onnx/cnnonnx2singa.py ## @@ -105,19 +105,13 @@ def accuracy(pred, target): model =

[GitHub] [incubator-singa] nudles commented on a change in pull request #416: singa-onnx

2019-03-10 Thread GitBox
nudles commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264043050 ## File path: python/singa/sonnx.py ## @@ -18,272 +18,359 @@ # - from __future__ import division -from singa import tensor

[GitHub] [incubator-singa] nudles commented on a change in pull request #416: singa-onnx

2019-03-10 Thread GitBox
nudles commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264042979 ## File path: python/singa/sonnx.py ## @@ -18,272 +18,359 @@ # - from __future__ import division -from singa import tensor

[GitHub] [incubator-singa] nudles merged pull request #437: SINGA-429 update dockerfile for cuda cudnn update

2019-03-10 Thread GitBox
nudles merged pull request #437: SINGA-429 update dockerfile for cuda cudnn update URL: https://github.com/apache/incubator-singa/pull/437 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-singa] dcslin commented on a change in pull request #437: SINGA-429 update dockerfile for cuda cudnn update

2019-03-10 Thread GitBox
dcslin commented on a change in pull request #437: SINGA-429 update dockerfile for cuda cudnn update URL: https://github.com/apache/incubator-singa/pull/437#discussion_r264050420 ## File path: tool/docker/devel/native/ubuntu/cuda/py3/Dockerfile ## @@ -45,16 +46,21 @@ RUN

[GitHub] [incubator-singa] ShichengChen commented on a change in pull request #416: singa-onnx

2019-03-12 Thread GitBox
ShichengChen commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264957034 ## File path: python/singa/tensor.py ## @@ -107,9 +107,14 @@ def __init__(self, shape=(), device=None, dtype=float32,

[GitHub] [incubator-singa] nudles commented on a change in pull request #416: singa-onnx

2019-03-12 Thread GitBox
nudles commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264954977 ## File path: python/singa/tensor.py ## @@ -107,9 +107,14 @@ def __init__(self, shape=(), device=None, dtype=float32,

[GitHub] [incubator-singa] nudles commented on a change in pull request #416: singa-onnx

2019-03-12 Thread GitBox
nudles commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264953879 ## File path: python/singa/autograd.py ## @@ -614,10 +682,28 @@ def __call__(self, x): y = add_bias(y, self.b, axis=0)

[GitHub] [incubator-singa] ShichengChen commented on a change in pull request #416: singa-onnx

2019-03-12 Thread GitBox
ShichengChen commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264956297 ## File path: python/singa/autograd.py ## @@ -614,10 +682,28 @@ def __call__(self, x): y = add_bias(y, self.b,

[GitHub] [incubator-singa] ShichengChen commented on a change in pull request #416: singa-onnx

2019-03-11 Thread GitBox
ShichengChen commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264102137 ## File path: python/singa/sonnx.py ## @@ -325,7 +328,7 @@ def output_name(op, index):

[GitHub] [incubator-singa] ShichengChen commented on a change in pull request #416: singa-onnx

2019-03-11 Thread GitBox
ShichengChen commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r26410 ## File path: python/singa/sonnx.py ## @@ -257,24 +255,28 @@ def to_onnx_model(inputs, y, model_name='sonnx'): the

[GitHub] [incubator-singa] ShichengChen commented on a change in pull request #416: singa-onnx

2019-03-11 Thread GitBox
ShichengChen commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r26410 ## File path: python/singa/sonnx.py ## @@ -257,24 +255,28 @@ def to_onnx_model(inputs, y, model_name='sonnx'): the

[GitHub] [incubator-singa] ShichengChen commented on a change in pull request #416: singa-onnx

2019-03-11 Thread GitBox
ShichengChen commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264102092 ## File path: python/singa/sonnx.py ## @@ -257,24 +255,28 @@ def to_onnx_model(inputs, y, model_name='sonnx'): the

[GitHub] [incubator-singa] ShichengChen commented on a change in pull request #416: singa-onnx

2019-03-10 Thread GitBox
ShichengChen commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264080797 ## File path: examples/onnx/cnnonnx2singa.py ## @@ -105,19 +105,13 @@ def accuracy(pred, target): model =

[GitHub] [incubator-singa] ShichengChen commented on a change in pull request #416: singa-onnx

2019-03-11 Thread GitBox
ShichengChen commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264103343 ## File path: python/singa/tensor.py ## @@ -87,10 +87,10 @@ class Tensor(object): grad but not store

[GitHub] [incubator-singa] ShichengChen commented on a change in pull request #416: singa-onnx

2019-03-10 Thread GitBox
ShichengChen commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264079692 ## File path: python/singa/sonnx.py ## @@ -18,272 +18,359 @@ # - from __future__ import division -from singa import

[GitHub] [incubator-singa] nudles merged pull request #438: *fix bug: segmentation fault at test case

2019-03-10 Thread GitBox
nudles merged pull request #438: *fix bug: segmentation fault at test case URL: https://github.com/apache/incubator-singa/pull/438 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-singa] ShichengChen commented on a change in pull request #416: singa-onnx

2019-03-10 Thread GitBox
ShichengChen commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264080224 ## File path: python/singa/sonnx.py ## @@ -18,272 +18,359 @@ # - from __future__ import division -from singa import

[GitHub] [incubator-singa] ShichengChen commented on a change in pull request #416: singa-onnx

2019-03-10 Thread GitBox
ShichengChen commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264080289 ## File path: python/singa/autograd.py ## @@ -1115,7 +1161,8 @@ def __init__(self, kernel_size, stride=None, padding=0):

[GitHub] [incubator-singa] nudles commented on issue #438: *fix bug: segmentation fault at test case

2019-03-10 Thread GitBox
nudles commented on issue #438: *fix bug: segmentation fault at test case URL: https://github.com/apache/incubator-singa/pull/438#issuecomment-471398374 maybe the current transpose implementation is ok. T() and Tensor::Transpose() change itself. The global transpose return a view if

[GitHub] [incubator-singa] joddiy commented on issue #438: *fix bug: segmentation fault at test case

2019-03-10 Thread GitBox
joddiy commented on issue #438: *fix bug: segmentation fault at test case URL: https://github.com/apache/incubator-singa/pull/438#issuecomment-471400952 But the current transpose implementation cannot pass the test case. The test case ` Tensor o = t.T();

[GitHub] [incubator-singa] joddiy edited a comment on issue #438: *fix bug: segmentation fault at test case

2019-03-10 Thread GitBox
joddiy edited a comment on issue #438: *fix bug: segmentation fault at test case URL: https://github.com/apache/incubator-singa/pull/438#issuecomment-471400952 But the current transpose implementation cannot pass the test case. The test case ` Tensor o = t.T();\n

[GitHub] [incubator-singa] joddiy edited a comment on issue #438: *fix bug: segmentation fault at test case

2019-03-10 Thread GitBox
joddiy edited a comment on issue #438: *fix bug: segmentation fault at test case URL: https://github.com/apache/incubator-singa/pull/438#issuecomment-471400952 But the current transpose implementation cannot pass the test case. The test case ` Tensor o = t.T();

[GitHub] [incubator-singa] ShichengChen commented on a change in pull request #416: singa-onnx

2019-03-10 Thread GitBox
ShichengChen commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264079824 ## File path: python/singa/sonnx.py ## @@ -18,272 +18,359 @@ # - from __future__ import division -from singa import

[GitHub] [incubator-singa] ShichengChen commented on a change in pull request #416: singa-onnx

2019-03-10 Thread GitBox
ShichengChen commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264079768 ## File path: python/singa/sonnx.py ## @@ -18,272 +18,359 @@ # - from __future__ import division -from singa import

[GitHub] [incubator-singa] ShichengChen commented on a change in pull request #416: singa-onnx

2019-03-10 Thread GitBox
ShichengChen commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264079732 ## File path: python/singa/sonnx.py ## @@ -18,272 +18,359 @@ # - from __future__ import division -from singa import

[GitHub] [incubator-singa] joddiy commented on issue #438: *fix bug: segmentation fault at test case

2019-03-10 Thread GitBox
joddiy commented on issue #438: *fix bug: segmentation fault at test case URL: https://github.com/apache/incubator-singa/pull/438#issuecomment-471397731 The transpose is another problem, I think yisen will submit a new PR(otherwise I'll simbit a new PR to copy that).

[GitHub] [incubator-singa] ShichengChen commented on a change in pull request #416: singa-onnx

2019-03-11 Thread GitBox
ShichengChen commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264102485 ## File path: python/singa/tensor.py ## @@ -87,10 +87,10 @@ class Tensor(object): grad but not store

[GitHub] [incubator-singa] dcslin opened a new pull request #439: SINGA-429-cxx-flags

2019-03-11 Thread GitBox
dcslin opened a new pull request #439: SINGA-429-cxx-flags URL: https://github.com/apache/incubator-singa/pull/439 Hi, this is quick fix for `SYSTEM` flag for cmake issue. thank you for the review This is an automated

[GitHub] [incubator-singa] ShichengChen commented on a change in pull request #416: singa-onnx

2019-03-10 Thread GitBox
ShichengChen commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264080175 ## File path: python/singa/sonnx.py ## @@ -18,272 +18,359 @@ # - from __future__ import division -from singa import

[GitHub] [incubator-singa] ShichengChen commented on a change in pull request #416: singa-onnx

2019-03-10 Thread GitBox
ShichengChen commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264080031 ## File path: python/singa/sonnx.py ## @@ -18,272 +18,359 @@ # - from __future__ import division -from singa import

[GitHub] [incubator-singa] nudles commented on a change in pull request #416: singa-onnx

2019-03-10 Thread GitBox
nudles commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264083899 ## File path: python/singa/sonnx.py ## @@ -325,7 +328,7 @@ def output_name(op, index):

[GitHub] [incubator-singa] nudles commented on a change in pull request #416: singa-onnx

2019-03-10 Thread GitBox
nudles commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264083981 ## File path: python/singa/sonnx.py ## @@ -18,272 +18,359 @@ # - from __future__ import division -from singa import tensor

[GitHub] [incubator-singa] nudles commented on a change in pull request #416: singa-onnx

2019-03-10 Thread GitBox
nudles commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264083832 ## File path: python/singa/tensor.py ## @@ -87,10 +87,10 @@ class Tensor(object): grad but not store grad; But

[GitHub] [incubator-singa] nudles commented on a change in pull request #416: singa-onnx

2019-03-10 Thread GitBox
nudles commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264084037 ## File path: python/singa/sonnx.py ## @@ -257,24 +255,28 @@ def to_onnx_model(inputs, y, model_name='sonnx'): the onnx

[GitHub] [incubator-singa] nudles commented on issue #438: *fix bug: segmentation fault at test case

2019-03-10 Thread GitBox
nudles commented on issue #438: *fix bug: segmentation fault at test case URL: https://github.com/apache/incubator-singa/pull/438#issuecomment-471397115 The tranpose operation should return a new tensor that shares the data with this tensor if possible; otherwise return a new tensor that

[GitHub] [incubator-singa] dcslin opened a new pull request #440: hf:reshape error

2019-03-13 Thread GitBox
dcslin opened a new pull request #440: hf:reshape error URL: https://github.com/apache/incubator-singa/pull/440 Hi teams, This is to fix some broken `Reshape` after adding a extra restriction on reshaping. After this fix, unit_test all passing by directly compiling against

[GitHub] [incubator-singa] nudles merged pull request #440: hf:reshape error

2019-03-13 Thread GitBox
nudles merged pull request #440: hf:reshape error URL: https://github.com/apache/incubator-singa/pull/440 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-singa] moazreyad commented on issue #416: singa-onnx

2019-03-13 Thread GitBox
moazreyad commented on issue #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#issuecomment-472489883 It is very hard to follow this pull request. There are more than 130 comment. I think the singa-onnx task is too large to be implemented in one pull request. Also

[GitHub] [incubator-singa] nudles commented on issue #437: SINGA-429 update dockerfile for cuda cudnn update

2019-03-07 Thread GitBox
nudles commented on issue #437: SINGA-429 update dockerfile for cuda cudnn update URL: https://github.com/apache/incubator-singa/pull/437#issuecomment-470446774 MKLDNN is called when the code is running on CPU; cudnn is called when it is running on GPU. There should be no conflict.

[GitHub] [incubator-singa] joddiy opened a new pull request #438: *fix bug: segmentation fault at test case

2019-03-07 Thread GitBox
joddiy opened a new pull request #438: *fix bug: segmentation fault at test case URL: https://github.com/apache/incubator-singa/pull/438 *fix bug: - allow reshaping on an empty tensor then give it data will invoke segmentation fault. *how to fix: - when reshape, add a

[GitHub] [incubator-singa] nudles commented on issue #437: SINGA-429 update dockerfile for cuda cudnn update

2019-03-07 Thread GitBox
nudles commented on issue #437: SINGA-429 update dockerfile for cuda cudnn update URL: https://github.com/apache/incubator-singa/pull/437#issuecomment-470442965 how about mkldnn? can install it in the docker and let singa use it?

[GitHub] [incubator-singa] dcslin edited a comment on issue #437: SINGA-429 update dockerfile for cuda cudnn update

2019-03-07 Thread GitBox
dcslin edited a comment on issue #437: SINGA-429 update dockerfile for cuda cudnn update URL: https://github.com/apache/incubator-singa/pull/437#issuecomment-470446320 Hi @nudles , I am working on MKL, but I am trying make it optional, since for `src/model/operation/*`, MKLDNN actually

[GitHub] [incubator-singa] dcslin commented on issue #437: SINGA-429 update dockerfile for cuda cudnn update

2019-03-07 Thread GitBox
dcslin commented on issue #437: SINGA-429 update dockerfile for cuda cudnn update URL: https://github.com/apache/incubator-singa/pull/437#issuecomment-470446320 Hi @nudles , I am working on MKL, but I am trying make it optional, since for `src/model/operation/*`, MKLDNN actually

[GitHub] [incubator-singa] nudles commented on a change in pull request #416: singa-onnx

2019-03-07 Thread GitBox
nudles commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r263426576 ## File path: python/singa/sonnx.py ## @@ -0,0 +1,289 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [incubator-singa] dcslin commented on issue #437: SINGA-429 update dockerfile for cuda cudnn update

2019-03-08 Thread GitBox
dcslin commented on issue #437: SINGA-429 update dockerfile for cuda cudnn update URL: https://github.com/apache/incubator-singa/pull/437#issuecomment-470871863 HI @nudles , this is basically done: - [x] python3, cuda9, devel - [x] python3, cuda10, devel - [x] mkldnn enabled

[GitHub] [incubator-singa] dcslin edited a comment on issue #437: SINGA-429 update dockerfile for cuda cudnn update

2019-03-08 Thread GitBox
dcslin edited a comment on issue #437: SINGA-429 update dockerfile for cuda cudnn update URL: https://github.com/apache/incubator-singa/pull/437#issuecomment-470871863 HI @nudles , this is basically done: - [x] python3, cuda9, devel - [x] python3, cuda10, devel - [x] mkldnn

  1   2   3   4   5   6   7   8   >