[GitHub] [incubator-singa] joddiy commented on issue #438: *fix bug: segmentation fault at test case

2019-03-10 Thread GitBox 
joddiy commented on issue #438: *fix bug: segmentation fault at test case
URL: https://github.com/apache/incubator-singa/pull/438#issuecomment-471400952
 
 
   But the current transpose implementation cannot pass the test case. The test 
case
   `
 Tensor o = t.T();
 EXPECT_EQ(t.shape()[0],  o.shape()[1]);
 EXPECT_EQ(t.shape()[1],  o.shape()[0]);
   `
   seems the transpose func needs to return a new transposed tensor, rather 
than change itself. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-singa] joddiy commented on issue #438: *fix bug: segmentation fault at test case

2019-03-10 Thread GitBox 
joddiy commented on issue #438: *fix bug: segmentation fault at test case
URL: https://github.com/apache/incubator-singa/pull/438#issuecomment-471397731
 
 
   The transpose is another problem, I think yisen will submit a new 
PR(otherwise I'll simbit a new PR to copy that). 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services