[jira] [Commented] (SINGA-485) Code Coverage Analysis
[ https://issues.apache.org/jira/browse/SINGA-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929672#comment-16929672 ] ASF subversion and git services commented on SINGA-485: --- Commit bbd9015867de6fbb8845d12d455647dd1bb141a8 in incubator-singa's branch refs/heads/master from Moaz Reyad [ https://gitbox.apache.org/repos/asf?p=incubator-singa.git;h=bbd9015 ] SINGA-485 Add Ubuntu 16.04 and 18.04 to Travis CI build > Code Coverage Analysis > -- > > Key: SINGA-485 > URL: https://issues.apache.org/jira/browse/SINGA-485 > Project: Singa > Issue Type: Improvement >Reporter: Moaz Reyad >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > SINGA development and testing can be improved by using a [code > coverage|https://en.wikipedia.org/wiki/Code_coverage] tool. > Some Apache projects use [codecov|https://codecov.io/gh/apache?page=1], while > others use [coverall|https://coveralls.io/github/apache?page=1]. > This issue is open to choose a code coverage tool and add it to SINGA build > and test pipeline. > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (SINGA-485) Code Coverage Analysis
[ https://issues.apache.org/jira/browse/SINGA-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929674#comment-16929674 ] ASF subversion and git services commented on SINGA-485: --- Commit 8159e87e0ae4c8a78c5874b7abda83b667200bed in incubator-singa's branch refs/heads/master from Wei Wang [ https://gitbox.apache.org/repos/asf?p=incubator-singa.git;h=8159e87 ] Merge pull request #531 from moazreyad/SINGA-485 SINGA-485 Add code coverage with codecov > Code Coverage Analysis > -- > > Key: SINGA-485 > URL: https://issues.apache.org/jira/browse/SINGA-485 > Project: Singa > Issue Type: Improvement >Reporter: Moaz Reyad >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > SINGA development and testing can be improved by using a [code > coverage|https://en.wikipedia.org/wiki/Code_coverage] tool. > Some Apache projects use [codecov|https://codecov.io/gh/apache?page=1], while > others use [coverall|https://coveralls.io/github/apache?page=1]. > This issue is open to choose a code coverage tool and add it to SINGA build > and test pipeline. > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (SINGA-485) Code Coverage Analysis
[ https://issues.apache.org/jira/browse/SINGA-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929673#comment-16929673 ] ASF subversion and git services commented on SINGA-485: --- Commit 8159e87e0ae4c8a78c5874b7abda83b667200bed in incubator-singa's branch refs/heads/master from Wei Wang [ https://gitbox.apache.org/repos/asf?p=incubator-singa.git;h=8159e87 ] Merge pull request #531 from moazreyad/SINGA-485 SINGA-485 Add code coverage with codecov > Code Coverage Analysis > -- > > Key: SINGA-485 > URL: https://issues.apache.org/jira/browse/SINGA-485 > Project: Singa > Issue Type: Improvement >Reporter: Moaz Reyad >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > SINGA development and testing can be improved by using a [code > coverage|https://en.wikipedia.org/wiki/Code_coverage] tool. > Some Apache projects use [codecov|https://codecov.io/gh/apache?page=1], while > others use [coverall|https://coveralls.io/github/apache?page=1]. > This issue is open to choose a code coverage tool and add it to SINGA build > and test pipeline. > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (SINGA-485) Code Coverage Analysis
[ https://issues.apache.org/jira/browse/SINGA-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929671#comment-16929671 ] ASF subversion and git services commented on SINGA-485: --- Commit 5cf19022cffe6bdfcd028c005c6b33e29577aa45 in incubator-singa's branch refs/heads/master from Moaz Reyad [ https://gitbox.apache.org/repos/asf?p=incubator-singa.git;h=5cf1902 ] SINGA-485 Add code coverage with codecov > Code Coverage Analysis > -- > > Key: SINGA-485 > URL: https://issues.apache.org/jira/browse/SINGA-485 > Project: Singa > Issue Type: Improvement >Reporter: Moaz Reyad >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > SINGA development and testing can be improved by using a [code > coverage|https://en.wikipedia.org/wiki/Code_coverage] tool. > Some Apache projects use [codecov|https://codecov.io/gh/apache?page=1], while > others use [coverall|https://coveralls.io/github/apache?page=1]. > This issue is open to choose a code coverage tool and add it to SINGA build > and test pipeline. > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (SINGA-485) Code Coverage Analysis
[ https://issues.apache.org/jira/browse/SINGA-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923409#comment-16923409 ] Moaz Reyad commented on SINGA-485: -- ??In fact, the current travis configuration will run the unit tests for python via conda test?? Yes, the current Travis configuration runs Python unit tests (instead of C++ unit tests) in the C++ CI tasks. So there are two problems: # It does not run the C++ unit tests, which is supposed to happen because only [C++ language|https://github.com/apache/incubator-singa/blob/master/.travis.yml#L19] is given in the [build matrix|https://docs.travis-ci.com/user/build-matrix/]. # It runs Python unit tests on the C++ build machines that are not prepared to support Python. It installs Python on the C++ build machines instead of using Python CI build by adding language:python to the build matrix. It also seems to test both Python 2 and Python 3 in the same item. Some refactoring is required here in my opinion. ??Does the code coverage analysis give us a report on how to improve the code?? It will give a report on which parts of the code is not executed by the test. Here are some examples from Apache project that use [codecov|https://codecov.io/gh/apache?page=1] and [coverall|https://coveralls.io/github/apache?page=1]. > Code Coverage Analysis > -- > > Key: SINGA-485 > URL: https://issues.apache.org/jira/browse/SINGA-485 > Project: Singa > Issue Type: Improvement >Reporter: Moaz Reyad >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > SINGA development and testing can be improved by using a [code > coverage|https://en.wikipedia.org/wiki/Code_coverage] tool. > Some Apache projects use [codecov|https://codecov.io/gh/apache?page=1], while > others use [coverall|https://coveralls.io/github/apache?page=1]. > This issue is open to choose a code coverage tool and add it to SINGA build > and test pipeline. > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (SINGA-485) Code Coverage Analysis
[ https://issues.apache.org/jira/browse/SINGA-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921099#comment-16921099 ] wangwei commented on SINGA-485: --- In fact, the current travis configuration will run the unit tests for python via conda test [https://github.com/apache/incubator-singa/blob/master/tool/conda/singa/meta.yaml#L74] Does the code coverage analysis give us a report on how to improve the code? > Code Coverage Analysis > -- > > Key: SINGA-485 > URL: https://issues.apache.org/jira/browse/SINGA-485 > Project: Singa > Issue Type: Improvement >Reporter: Moaz Reyad >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > SINGA development and testing can be improved by using a [code > coverage|https://en.wikipedia.org/wiki/Code_coverage] tool. > Some Apache projects use [codecov|https://codecov.io/gh/apache?page=1], while > others use [coverall|https://coveralls.io/github/apache?page=1]. > This issue is open to choose a code coverage tool and add it to SINGA build > and test pipeline. > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (SINGA-485) Code Coverage Analysis
[
https://issues.apache.org/jira/browse/SINGA-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920922#comment-16920922
]
Moaz Reyad commented on SINGA-485:
--
Currently the Travis CI configuration performs only the build but no test is
enabled. It does not compile with {code:bash} ENABLE_TEST {code} option enabled.
To perform code coverage analysis, we need to:
* Enable the build of unit tests using -DENABLE_TEST=ON
* Run the unit tests
Note that the current configuration is for C++ only since it has the line
{code:bash} language: cpp {code}
It builds python and conda packages, but this does not help in the unit test of
C++ code. Later we need to add language:python to the travis build matrix and
move the python build/test under that item.
Any comments or discussion is welcome.
> Code Coverage Analysis
> --
>
> Key: SINGA-485
> URL: https://issues.apache.org/jira/browse/SINGA-485
> Project: Singa
> Issue Type: Improvement
>Reporter: Moaz Reyad
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> SINGA development and testing can be improved by using a [code
> coverage|https://en.wikipedia.org/wiki/Code_coverage] tool.
> Some Apache projects use [codecov|https://codecov.io/gh/apache?page=1], while
> others use [coverall|https://coveralls.io/github/apache?page=1].
> This issue is open to choose a code coverage tool and add it to SINGA build
> and test pipeline.
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (SINGA-485) Code Coverage Analysis
[
https://issues.apache.org/jira/browse/SINGA-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920049#comment-16920049
]
Moaz Reyad commented on SINGA-485:
--
I propose to use codecov with Travis CI integration.
However, the current Travis CI configuration needs some refactoring to improve
the test coverage.
[The
configuration|https://github.com/moazreyad/incubator-singa/blob/master/.travis.yml]
only tests the *build* process on Ubuntu 14.04 (trusty) and macOS 10.11.
The [installation
page|http://singa.apache.org/docs/installation.html#from-source] says:
{code:html}
The above commands have been tested on Ubuntu 16.04 and Mac OSX. Refer to the
Travis-CI page for more information.
{code}
But the test was actually done on 14.04 not 16.04.
I am going to add the build test for both Ubuntu 16.04 and Ubuntu 18.04 to the
Travis configuration.
> Code Coverage Analysis
> --
>
> Key: SINGA-485
> URL: https://issues.apache.org/jira/browse/SINGA-485
> Project: Singa
> Issue Type: Improvement
>Reporter: Moaz Reyad
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> SINGA development and testing can be improved by using a [code
> coverage|https://en.wikipedia.org/wiki/Code_coverage] tool.
> Some Apache projects use [codecov|https://codecov.io/gh/apache?page=1], while
> others use [coverall|https://coveralls.io/github/apache?page=1].
> This issue is open to choose a code coverage tool and add it to SINGA build
> and test pipeline.
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
