[GitHub] coveralls commented on issue #683: Submit related projects in NOTICE.

2017-12-16 Thread GitBox
coveralls commented on issue #683: Submit related projects in NOTICE. URL: https://github.com/apache/incubator-skywalking/pull/683#issuecomment-352225537 [![Coverage Status](https://coveralls.io/builds/14690525/badge)](https://coveralls.io/builds/14690525) Coverage remained the

[GitHub] coveralls commented on issue #683: Submit related projects in NOTICE.

2017-12-16 Thread GitBox
coveralls commented on issue #683: Submit related projects in NOTICE. URL: https://github.com/apache/incubator-skywalking/pull/683#issuecomment-352225538 [![Coverage Status](https://coveralls.io/builds/14690528/badge)](https://coveralls.io/builds/14690528) Coverage remained the

[GitHub] wu-sheng closed pull request #686: Style check header file value change.

2017-12-15 Thread GitBox
wu-sheng closed pull request #686: Style check header file value change. URL: https://github.com/apache/incubator-skywalking/pull/686 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] peng-yongsheng opened a new pull request #686: Style check header file value change.

2017-12-15 Thread GitBox
peng-yongsheng opened a new pull request #686: Style check header file value change. URL: https://github.com/apache/incubator-skywalking/pull/686 Do not use the propertie for checkstyle header file path that lead to the checkstyle plugin of IntelliJ idea not work.

[GitHub] coveralls commented on issue #686: Style check header file value change.

2017-12-15 Thread GitBox
coveralls commented on issue #686: Style check header file value change. URL: https://github.com/apache/incubator-skywalking/pull/686#issuecomment-352158957 [![Coverage Status](https://coveralls.io/builds/14684886/badge)](https://coveralls.io/builds/14684886) Coverage remained

[GitHub] suxiaoyong opened a new issue #687: ????plugin????

2017-12-16 Thread GitBox
suxiaoyong opened a new issue #687: plugin URL: https://github.com/apache/incubator-skywalking/issues/687 ??v3.2.6 ?plugin enhance?? ? ERROR 2017-12-16 17:54:58 SkyWalkingAgent :

[GitHub] wu-sheng commented on issue #687: [Agent] Custom plugin fails

2017-12-16 Thread GitBox
wu-sheng commented on issue #687: [Agent] Custom plugin fails URL: https://github.com/apache/incubator-skywalking/issues/687#issuecomment-352183315 Suggestion first, next time, when you want to post some codes, please use markdown format to write in the issue directly. It is good for

[GitHub] wu-sheng commented on issue #677: collector window script fail to start

2017-12-16 Thread GitBox
wu-sheng commented on issue #677: collector window script fail to start URL: https://github.com/apache/incubator-skywalking/issues/677#issuecomment-352192063 #678 has been merged. This is an automated message from the Apache

[GitHub] wu-sheng commented on issue #682: [Agent] InstMethodsInter throw NullPointerException

2017-12-16 Thread GitBox
wu-sheng commented on issue #682: [Agent] InstMethodsInter throw NullPointerException URL: https://github.com/apache/incubator-skywalking/issues/682#issuecomment-352183881 @ascrutae As a NPE, please fix it in 5.0.0 This is

[GitHub] peng-yongsheng closed pull request #688: Update README_ZH.md

2017-12-17 Thread GitBox
peng-yongsheng closed pull request #688: Update README_ZH.md URL: https://github.com/apache/incubator-skywalking/pull/688 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] wu-sheng opened a new issue #689: [Agent]Merge continue DB spans

2017-12-18 Thread GitBox
wu-sheng opened a new issue #689: [Agent]Merge continue DB spans URL: https://github.com/apache/incubator-skywalking/issues/689 Received feedback from community: * When a service calls DBs/Caches many times, even more than 100. So many spans are generated, which causes UI problems(hard

[GitHub] ascrutae opened a new pull request #676: [Agent] Fix issue that OkHttpClient plugin doesn't work

2017-12-14 Thread GitBox
ascrutae opened a new pull request #676: [Agent] Fix issue that OkHttpClient plugin doesn't work URL: https://github.com/apache/incubator-skywalking/pull/676 The skywalking plugin can't import any class in the framework jar. it cause some question about classloader.

[GitHub] ascrutae commented on issue #676: [Agent] Fix issue that OkHttpClient plugin doesn't work

2017-12-14 Thread GitBox
ascrutae commented on issue #676: [Agent] Fix issue that OkHttpClient plugin doesn't work URL: https://github.com/apache/incubator-skywalking/pull/676#issuecomment-351725912 @wu-sheng yeah. you are right. I had changed the constructor matcher to `any`, maybe the `any` matcher will more

[GitHub] myoss closed issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient

2017-12-14 Thread GitBox
myoss closed issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient URL: https://github.com/apache/incubator-skywalking/issues/675 This is an automated message from the Apache Git Service. To respond to

[GitHub] myoss commented on issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient

2017-12-14 Thread GitBox
myoss commented on issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient URL: https://github.com/apache/incubator-skywalking/issues/675#issuecomment-351733368 it's ok This is an automated message from the

[GitHub] myoss opened a new issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient

2017-12-14 Thread GitBox
myoss opened a new issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient URL: https://github.com/apache/incubator-skywalking/issues/675 Please answer these questions before submitting your issue. ### What version of sky-walking are you using? 5.0-2018-preview

[GitHub] peng-yongsheng commented on issue #673: [Collector] add prefix for all storage table name

2017-12-14 Thread GitBox
peng-yongsheng commented on issue #673: [Collector] add prefix for all storage table name URL: https://github.com/apache/incubator-skywalking/issues/673#issuecomment-351712699 Sorry, I misunderstand the word distinguish as distributed. I don't recommend every one to share

[GitHub] wu-sheng commented on issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient

2017-12-14 Thread GitBox
wu-sheng commented on issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient URL: https://github.com/apache/incubator-skywalking/issues/675#issuecomment-351712867 ```java @Override public ElementMatcher getConstructorMatcher() { return

[GitHub] ascrutae commented on issue #676: [Agent] Fix issue that OkHttpClient plugin doesn't work

2017-12-14 Thread GitBox
ascrutae commented on issue #676: [Agent] Fix issue that OkHttpClient plugin doesn't work URL: https://github.com/apache/incubator-skywalking/pull/676#issuecomment-351725912 @wu-sheng I had changed the constructor matcher to `any`, maybe the `any` matcher will more faster

[GitHub] wu-sheng commented on issue #676: [Agent] Fix issue that OkHttpClient plugin doesn't work

2017-12-14 Thread GitBox
wu-sheng commented on issue #676: [Agent] Fix issue that OkHttpClient plugin doesn't work URL: https://github.com/apache/incubator-skywalking/pull/676#issuecomment-351724187 > I am not sure that if this class would be changed in the next version since the newest version is 3.9.1

[GitHub] zone1511 opened a new issue #677: collector window script fail to start

2017-12-14 Thread GitBox
zone1511 opened a new issue #677: collector window script fail to start URL: https://github.com/apache/incubator-skywalking/issues/677 ### What did you do? If possible, provide a way for reproducing the error. e.g. demo application, component version. the file

[GitHub] wu-sheng commented on issue #676: [Agent] Fix issue that OkHttpClient plugin doesn't work

2017-12-14 Thread GitBox
wu-sheng commented on issue #676: [Agent] Fix issue that OkHttpClient plugin doesn't work URL: https://github.com/apache/incubator-skywalking/pull/676#issuecomment-351718822 > The skywalking plugin can't import any class in the framework jar. it cause some question about classloader.

[GitHub] ascrutae commented on issue #677: collector window script fail to start

2017-12-14 Thread GitBox
ascrutae commented on issue #677: collector window script fail to start URL: https://github.com/apache/incubator-skywalking/issues/677#issuecomment-351857052 which version are you used? This is an automated message from the

[GitHub] ascrutae opened a new pull request #678: [Collector] Fix issue that collector start failed in the Windows environment

2017-12-14 Thread GitBox
ascrutae opened a new pull request #678: [Collector] Fix issue that collector start failed in the Windows environment URL: https://github.com/apache/incubator-skywalking/pull/678 The bootstrap class in `collectorService.bat` is incorrect and collector start failed in the Windows

[GitHub] ascrutae commented on issue #677: collector window script fail to start

2017-12-14 Thread GitBox
ascrutae commented on issue #677: collector window script fail to start URL: https://github.com/apache/incubator-skywalking/issues/677#issuecomment-351860313 This is an issue If you use the `5.0-2018-prevision` version. and I try to fix is in PR #678.

[GitHub] ascrutae commented on issue #677: collector window script fail to start

2017-12-14 Thread GitBox
ascrutae commented on issue #677: collector window script fail to start URL: https://github.com/apache/incubator-skywalking/issues/677#issuecomment-351860313 This is an issue If you use the `5.0-2018-prevision` version. and I try to fix it in PR #678.

[GitHub] coveralls commented on issue #690: Change network protocol for 5.0

2017-12-18 Thread GitBox
coveralls commented on issue #690: Change network protocol for 5.0 URL: https://github.com/apache/incubator-skywalking/pull/690#issuecomment-352428231 [![Coverage Status](https://coveralls.io/builds/14703352/badge)](https://coveralls.io/builds/14703352) Coverage decreased

[GitHub] peng-yongsheng closed pull request #690: Change network protocol for 5.0

2017-12-18 Thread GitBox
peng-yongsheng closed pull request #690: Change network protocol for 5.0 URL: https://github.com/apache/incubator-skywalking/pull/690 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] wu-sheng opened a new pull request #690: Change network protocol for 5.0

2017-12-18 Thread GitBox
wu-sheng opened a new pull request #690: Change network protocol for 5.0 URL: https://github.com/apache/incubator-skywalking/pull/690 * Fix a C++ protocol issue: #662 * Support Cache Layer for UI and analysis. * Fix some wrong coding style in RocketMQ plugin.

[GitHub] wu-sheng commented on issue #662: [Protocol] ?? .proto ???? rpc register ? Register????

2017-12-18 Thread GitBox
wu-sheng commented on issue #662: [Protocol] ?? .proto rpc register ? Register URL: https://github.com/apache/incubator-skywalking/issues/662#issuecomment-352425556 This will be fixed by #690 , and released in 5.0.0-alpha.

[GitHub] wu-sheng closed issue #662: [Protocol] ?? .proto ???? rpc register ? Register????

2017-12-18 Thread GitBox
wu-sheng closed issue #662: [Protocol] ?? .proto rpc register ? Register URL: https://github.com/apache/incubator-skywalking/issues/662 This is an automated message from the Apache Git Service. To respond to the

[GitHub] KaiwenWang commented on issue #612: [Agent] Can skywalking support Hystrix

2017-12-18 Thread GitBox
KaiwenWang commented on issue #612: [Agent] Can skywalking support Hystrix URL: https://github.com/apache/incubator-skywalking/issues/612#issuecomment-352488592 expect the Hystrix plugin This is an automated message from the

[GitHub] wu-sheng closed issue #673: [Collector] add prefix for all storage table name

2017-12-18 Thread GitBox
wu-sheng closed issue #673: [Collector] add prefix for all storage table name URL: https://github.com/apache/incubator-skywalking/issues/673 This is an automated message from the Apache Git Service. To respond to the

[GitHub] wu-sheng commented on issue #673: [Collector] add prefix for all storage table name

2017-12-18 Thread GitBox
wu-sheng commented on issue #673: [Collector] add prefix for all storage table name URL: https://github.com/apache/incubator-skywalking/issues/673#issuecomment-352632061 As 2 PMC members(@wu-sheng @peng-yongsheng ) don't recommend sharing es. So sorry to say, we are not going to adjust

[GitHub] wu-sheng commented on issue #87: UI not functioning

2017-12-18 Thread GitBox
wu-sheng commented on issue #87: UI not functioning URL: https://github.com/apache/incubator-skywalking-ui/issues/87#issuecomment-352651776 You can use the 3.2.6 tag of UI and SkyWalking to make things work. e.g. UI 3.2.6 , https://github.com/apache/incubator-skywalking-ui/tree/v3.2.6

[GitHub] zone1511 opened a new issue #87: UI not functioning

2017-12-18 Thread GitBox
zone1511 opened a new issue #87: UI not functioning URL: https://github.com/apache/incubator-skywalking-ui/issues/87 Hi , does 5.0-2018-preview UI merged all code from 3.2.6 yet? Seems many code from 3.2.6 is not moved to 5.0-2018-preview

[GitHub] wu-sheng opened a new pull request #693: Try to fix a url

2017-12-19 Thread GitBox
wu-sheng opened a new pull request #693: Try to fix a url URL: https://github.com/apache/incubator-skywalking/pull/693 A wrong url, reported by community. This is an automated message from the Apache Git Service. To respond

[GitHub] wu-sheng opened a new pull request #86: Update readme.

2017-12-14 Thread GitBox
wu-sheng opened a new pull request #86: Update readme. URL: https://github.com/apache/incubator-skywalking-ui/pull/86 @hanahmily Add description about what you are doing, now, and put you as core team representative. This is

[GitHub] lytscu commented on issue #670: [Agent] Provide plugins for Apache httpcomponent AsyncClient 4.1 #588

2017-12-14 Thread GitBox
lytscu commented on issue #670: [Agent] Provide plugins for Apache httpcomponent AsyncClient 4.1 #588 URL: https://github.com/apache/incubator-skywalking/pull/670#issuecomment-351890764 #588 This is an automated message

[GitHub] wu-sheng closed pull request #681: Update version to 5.0.0-alpha

2017-12-14 Thread GitBox
wu-sheng closed pull request #681: Update version to 5.0.0-alpha URL: https://github.com/apache/incubator-skywalking/pull/681 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] wu-sheng commented on issue #681: Update version to 5.0.0-alpha

2017-12-14 Thread GitBox
wu-sheng commented on issue #681: Update version to 5.0.0-alpha URL: https://github.com/apache/incubator-skywalking/pull/681#issuecomment-351915740 @apache/skywalking-committers Please be adviced, everyone, I accept @hanahmily 's suggestion. I will adjust the version more common, and use

[GitHub] wu-sheng closed pull request #678: [Collector] Fix issue that collector start failed in the Windows environment

2017-12-14 Thread GitBox
wu-sheng closed pull request #678: [Collector] Fix issue that collector start failed in the Windows environment URL: https://github.com/apache/incubator-skywalking/pull/678 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] clevertension commented on issue #659: [Agent] Spring Bean Plugin

2017-12-14 Thread GitBox
clevertension commented on issue #659: [Agent] Spring Bean Plugin URL: https://github.com/apache/incubator-skywalking/issues/659#issuecomment-351890035 ok, i will work on it This is an automated message from the Apache Git

[GitHub] ascrutae commented on issue #680: oracle agant exception

2017-12-14 Thread GitBox
ascrutae commented on issue #680: oracle agant exception URL: https://github.com/apache/incubator-skywalking/issues/680#issuecomment-351891917 Could you show me the demo, and which version of agent are you used? This is an

[GitHub] wu-sheng closed pull request #679: Update readme and remove the annoucement

2017-12-14 Thread GitBox
wu-sheng closed pull request #679: Update readme and remove the annoucement URL: https://github.com/apache/incubator-skywalking/pull/679 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] coveralls commented on issue #679: Update readme and remove the annoucement

2017-12-14 Thread GitBox
coveralls commented on issue #679: Update readme and remove the annoucement URL: https://github.com/apache/incubator-skywalking/pull/679#issuecomment-351892058 [![Coverage Status](https://coveralls.io/builds/14667767/badge)](https://coveralls.io/builds/14667767) Changes Unknown

[GitHub] coveralls commented on issue #681: Update version to 5.0.0-alpha

2017-12-14 Thread GitBox
coveralls commented on issue #681: Update version to 5.0.0-alpha URL: https://github.com/apache/incubator-skywalking/pull/681#issuecomment-351908461 [![Coverage Status](https://coveralls.io/builds/14668691/badge)](https://coveralls.io/builds/14668691) Coverage remained the same

[GitHub] flydish2017 commented on issue #680: oracle agant exception

2017-12-14 Thread GitBox
flydish2017 commented on issue #680: oracle agant exception URL: https://github.com/apache/incubator-skywalking/issues/680#issuecomment-351892988 oracle? 11.2.0.4.0 This is an automated message from the Apache Git Service.

[GitHub] flydish2017 commented on issue #680: oracle agant exception

2017-12-14 Thread GitBox
flydish2017 commented on issue #680: oracle agant exception URL: https://github.com/apache/incubator-skywalking/issues/680#issuecomment-351893021 oracle version ? 11.2.0.4.0 This is an automated message from the Apache Git

[GitHub] flydish2017 commented on issue #680: oracle agant exception

2017-12-14 Thread GitBox
flydish2017 commented on issue #680: oracle agant exception URL: https://github.com/apache/incubator-skywalking/issues/680#issuecomment-351892988 oracle? 11.2.0.4.0 This is an automated message from the Apache Git Service.

[GitHub] wu-sheng commented on issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient

2017-12-14 Thread GitBox
wu-sheng commented on issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient URL: https://github.com/apache/incubator-skywalking/issues/675#issuecomment-351905741 @myoss Yes, it does. #676 has been merged. This issue will be solved in 5.0.0-alpha

[GitHub] myoss closed issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient

2017-12-14 Thread GitBox
myoss closed issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient URL: https://github.com/apache/incubator-skywalking/issues/675 This is an automated message from the Apache Git Service. To respond to

[GitHub] hanahmily closed pull request #86: Update readme.

2017-12-14 Thread GitBox
hanahmily closed pull request #86: Update readme. URL: https://github.com/apache/incubator-skywalking-ui/pull/86 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] hanahmily opened a new pull request #681: Update version to 5.0.0-alpha

2017-12-14 Thread GitBox
hanahmily opened a new pull request #681: Update version to 5.0.0-alpha URL: https://github.com/apache/incubator-skywalking/pull/681 This is a test of `mvn versions:set -DnewVersion=5.0.0-alpha` This is an automated message

[GitHub] myoss opened a new issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient

2017-12-14 Thread GitBox
myoss opened a new issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient URL: https://github.com/apache/incubator-skywalking/issues/675 Please answer these questions before submitting your issue. ### What version of sky-walking are you using? 5.0-2018-preview

[GitHub] myoss opened a new issue #682: [Agent] InstMethodsInter throw NullPointerException

2017-12-14 Thread GitBox
myoss opened a new issue #682: [Agent] InstMethodsInter throw NullPointerException URL: https://github.com/apache/incubator-skywalking/issues/682 Please answer these questions before submitting your issue. ### What version of sky-walking are you using? 3.2.6 # question

[GitHub] coveralls commented on issue #683: Submit related projects in NOTICE.

2017-12-14 Thread GitBox
coveralls commented on issue #683: Submit related projects in NOTICE. URL: https://github.com/apache/incubator-skywalking/pull/683#issuecomment-351926092 [![Coverage Status](https://coveralls.io/builds/14669710/badge)](https://coveralls.io/builds/14669710) Coverage remained the

[GitHub] coveralls commented on issue #679: Update readme and remove the annoucement

2017-12-14 Thread GitBox
coveralls commented on issue #679: Update readme and remove the annoucement URL: https://github.com/apache/incubator-skywalking/pull/679#issuecomment-351889205 [![Coverage Status](https://coveralls.io/builds/14667598/badge)](https://coveralls.io/builds/14667598) Changes Unknown

[GitHub] flydish2017 opened a new issue #680: oracle agant exception

2017-12-14 Thread GitBox
flydish2017 opened a new issue #680: oracle agant exception URL: https://github.com/apache/incubator-skywalking/issues/680 ### Cause: java.sql.SQLException: An SQLException was provoked by the following failure: java.lang.ClassCastException:

[GitHub] coveralls commented on issue #684: Add more descriptions about project.

2017-12-15 Thread GitBox
coveralls commented on issue #684: Add more descriptions about project. URL: https://github.com/apache/incubator-skywalking/pull/684#issuecomment-352048804 [![Coverage Status](https://coveralls.io/builds/14677003/badge)](https://coveralls.io/builds/14677003) Coverage remained

[GitHub] coveralls commented on issue #684: Add more descriptions about project.

2017-12-15 Thread GitBox
coveralls commented on issue #684: Add more descriptions about project. URL: https://github.com/apache/incubator-skywalking/pull/684#issuecomment-352039406 [![Coverage Status](https://coveralls.io/builds/14676440/badge)](https://coveralls.io/builds/14676440) Coverage remained

[GitHub] peng-yongsheng closed pull request #684: Add more descriptions about project.

2017-12-15 Thread GitBox
peng-yongsheng closed pull request #684: Add more descriptions about project. URL: https://github.com/apache/incubator-skywalking/pull/684 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] wu-sheng opened a new pull request #684: Add more descriptions about project.

2017-12-15 Thread GitBox
wu-sheng opened a new pull request #684: Add more descriptions about project. URL: https://github.com/apache/incubator-skywalking/pull/684 @peng-yongsheng As you suggestion, I update readme for adding new descriptions about microservice and container-oriented.

[GitHub] wu-sheng commented on issue #676: [Agent] Fix issue that OkHttpClient plugin doesn't work

2017-12-14 Thread GitBox
wu-sheng commented on issue #676: [Agent] Fix issue that OkHttpClient plugin doesn't work URL: https://github.com/apache/incubator-skywalking/pull/676#issuecomment-351721575 > The matcher match the first argument is enough. I just check the RealCall class in version 3.x. This class have

[GitHub] wu-sheng closed pull request #676: [Agent] Fix issue that OkHttpClient plugin doesn't work

2017-12-14 Thread GitBox
wu-sheng closed pull request #676: [Agent] Fix issue that OkHttpClient plugin doesn't work URL: https://github.com/apache/incubator-skywalking/pull/676 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] coveralls commented on issue #679: Update readme and remove the annoucement

2017-12-14 Thread GitBox
coveralls commented on issue #679: Update readme and remove the annoucement URL: https://github.com/apache/incubator-skywalking/pull/679#issuecomment-351878476 [![Coverage Status](https://coveralls.io/builds/14666914/badge)](https://coveralls.io/builds/14666914) Changes Unknown

[GitHub] coveralls commented on issue #685: Merge pull request #1 from apache/master

2017-12-15 Thread GitBox
coveralls commented on issue #685: Merge pull request #1 from apache/master URL: https://github.com/apache/incubator-skywalking/pull/685#issuecomment-352090282 [![Coverage Status](https://coveralls.io/builds/14679795/badge)](https://coveralls.io/builds/14679795) Coverage

[GitHub] wu-sheng commented on issue #659: [Agent] Spring Bean Plugin

2017-12-13 Thread GitBox
wu-sheng commented on issue #659: [Agent] Spring Bean Plugin URL: https://github.com/apache/incubator-skywalking/issues/659#issuecomment-351618695 @clevertension Not yet. If you are interesting, feel free to assign this issue to yourself, since you are already a committer. You have the

[GitHub] myoss opened a new issue #673: [Collector] add prefix for all storage table name

2017-12-13 Thread GitBox
myoss opened a new issue #673: [Collector] add prefix for all storage table name URL: https://github.com/apache/incubator-skywalking/issues/673 Table Name??? This is an automated message from the

[GitHub] ascrutae closed pull request #693: Try to fix a url

2017-12-19 Thread GitBox
ascrutae closed pull request #693: Try to fix a url URL: https://github.com/apache/incubator-skywalking/pull/693 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] coveralls commented on issue #693: Try to fix a url

2017-12-19 Thread GitBox
coveralls commented on issue #693: Try to fix a url URL: https://github.com/apache/incubator-skywalking/pull/693#issuecomment-352942296 [![Coverage Status](https://coveralls.io/builds/14733768/badge)](https://coveralls.io/builds/14733768) Coverage remained the same at 23.077%

[GitHub] songzhian opened a new issue #696: ??c/c++ ? register?????

2017-12-20 Thread GitBox
songzhian opened a new issue #696: ??c/c++ ? register? URL: https://github.com/apache/incubator-skywalking/issues/696 ?? "c/c++ ? register?" ??? ?? `service ApplicationRegisterService {` ` rpc batchRegister (Applications) returns (ApplicationMappings) {

[GitHub] songzhian opened a new issue #696: ??c/c++ ? register?????

2017-12-20 Thread GitBox
songzhian opened a new issue #696: ??c/c++ ? register? URL: https://github.com/apache/incubator-skywalking/issues/696 ?? "c/c++ ? register?" ??? ?? `service ApplicationRegisterService { rpc batchRegister (Applications) returns (ApplicationMappings) {

[GitHub] songzhian closed issue #696: ??c/c++ ? register?????

2017-12-20 Thread GitBox
songzhian closed issue #696: ??c/c++ ? register? URL: https://github.com/apache/incubator-skywalking/issues/696 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] wu-sheng commented on issue #694: [Agent] spring boot client start failed

2017-12-19 Thread GitBox
wu-sheng commented on issue #694: [Agent] spring boot client start failed URL: https://github.com/apache/incubator-skywalking/issues/694#issuecomment-352975089 ``` java.lang.NullPointerException at

[GitHub] coveralls commented on issue #695: Add new features for DataCarrier queue

2017-12-19 Thread GitBox
coveralls commented on issue #695: Add new features for DataCarrier queue URL: https://github.com/apache/incubator-skywalking/pull/695#issuecomment-352979853 [![Coverage Status](https://coveralls.io/builds/14736239/badge)](https://coveralls.io/builds/14736239) Coverage

[GitHub] coveralls commented on issue #670: [Agent] Provide plugins for Apache httpcomponent AsyncClient 4.1 #588

2017-12-19 Thread GitBox
coveralls commented on issue #670: [Agent] Provide plugins for Apache httpcomponent AsyncClient 4.1 #588 URL: https://github.com/apache/incubator-skywalking/pull/670#issuecomment-352989577 [![Coverage

[GitHub] wu-sheng commented on issue #87: UI not functioning

2017-12-18 Thread GitBox
wu-sheng commented on issue #87: UI not functioning URL: https://github.com/apache/incubator-skywalking-ui/issues/87#issuecomment-352615630 @zone1511 No, it won't. All UI codes are new, for the better visualization. This is

[GitHub] wu-sheng commented on issue #612: [Agent] Can skywalking support Hystrix

2017-12-18 Thread GitBox
wu-sheng commented on issue #612: [Agent] Can skywalking support Hystrix URL: https://github.com/apache/incubator-skywalking/issues/612#issuecomment-352616161 @KaiwenWang Received your feedback. Hope @ascrutae will have time to do so. He is working on automatic tests now.

[GitHub] coveralls commented on issue #670: [Agent] Provide plugins for Apache httpcomponent AsyncClient 4.1 #588

2017-12-18 Thread GitBox
coveralls commented on issue #670: [Agent] Provide plugins for Apache httpcomponent AsyncClient 4.1 #588 URL: https://github.com/apache/incubator-skywalking/pull/670#issuecomment-352618964 [![Coverage

[GitHub] wu-sheng commented on issue #325: Support config downstream from collector

2017-12-19 Thread GitBox
wu-sheng commented on issue #325: Support config downstream from collector URL: https://github.com/apache/incubator-skywalking/issues/325#issuecomment-352682590 @zone1511 In 5.x , but not 5.0, I suppose. This is an automated

[GitHub] wu-sheng commented on issue #682: [Agent] InstMethodsInter throw NullPointerException

2017-12-19 Thread GitBox
wu-sheng commented on issue #682: [Agent] InstMethodsInter throw NullPointerException URL: https://github.com/apache/incubator-skywalking/issues/682#issuecomment-352682443 @zone1511 This is an interesting found. Agent class loader should be 1:1 match the spring class loader. This should

[GitHub] ascrutae closed pull request #691: Fix npe

2017-12-19 Thread GitBox
ascrutae closed pull request #691: Fix npe URL: https://github.com/apache/incubator-skywalking/pull/691 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

[GitHub] zone1511 commented on issue #325: Support config downstream from collector

2017-12-19 Thread GitBox
zone1511 commented on issue #325: Support config downstream from collector URL: https://github.com/apache/incubator-skywalking/issues/325#issuecomment-352680988 Will this feature appear in 5.0? This is an automated message

[GitHub] wu-sheng commented on issue #682: [Agent] InstMethodsInter throw NullPointerException

2017-12-19 Thread GitBox
wu-sheng commented on issue #682: [Agent] InstMethodsInter throw NullPointerException URL: https://github.com/apache/incubator-skywalking/issues/682#issuecomment-352682443 @zone1511 This is an interesting found. Agent class loader should be 1:1 match the spring class loader. This should

[GitHub] wu-sheng commented on issue #682: [Agent] InstMethodsInter throw NullPointerException

2017-12-19 Thread GitBox
wu-sheng commented on issue #682: [Agent] InstMethodsInter throw NullPointerException URL: https://github.com/apache/incubator-skywalking/issues/682#issuecomment-352685259 @zone1511 This NPE caused by `EnhanceRequireObjectCache#nativeWebRequest` not init correctly.

[GitHub] zone1511 commented on issue #87: UI not functioning

2017-12-18 Thread GitBox
zone1511 commented on issue #87: UI not functioning URL: https://github.com/apache/incubator-skywalking-ui/issues/87#issuecomment-352642116 Hi PMC, Any target date to implement the new UI? With out the UI, the agent cannot work itself. I tried use old UI to view the data and found

[GitHub] zone1511 opened a new issue #692: Guide for build custom plugin

2017-12-19 Thread GitBox
zone1511 opened a new issue #692: Guide for build custom plugin URL: https://github.com/apache/incubator-skywalking/issues/692 Please answer these questions before submitting your issue. ### What version of sky-walking are you using? 5.0.0 ### What did you do? If I want

[GitHub] wu-sheng commented on issue #692: Guide for build custom plugin

2017-12-19 Thread GitBox
wu-sheng commented on issue #692: Guide for build custom plugin URL: https://github.com/apache/incubator-skywalking/issues/692#issuecomment-352714024 If you want to contribute a plugin, we can discuss that. We will allocate you an available id after you send the pull request.

[GitHub] wu-sheng commented on issue #683: Submit related projects in NOTICE.

2017-12-16 Thread GitBox
wu-sheng commented on issue #683: Submit related projects in NOTICE. URL: https://github.com/apache/incubator-skywalking/pull/683#issuecomment-352225073 @michaelsembwever The season I didn't add license, is because the two examples don't include that,

[GitHub] wu-sheng commented on issue #687: [Agent] Custom plugin fails

2017-12-16 Thread GitBox
wu-sheng commented on issue #687: [Agent] Custom plugin fails URL: https://github.com/apache/incubator-skywalking/issues/687#issuecomment-352183816 To resolve your issues, I want to know: Do you remove all existed plugins, we provided. Because I am not sure this caused your codes only, or

[GitHub] asfgit closed pull request #666: Update README.md

2017-12-13 Thread GitBox
asfgit closed pull request #666: Update README.md URL: https://github.com/apache/incubator-skywalking/pull/666 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] coveralls commented on issue #697: Make sure the log config works.

2017-12-21 Thread GitBox
coveralls commented on issue #697: Make sure the log config works. URL: https://github.com/apache/incubator-skywalking/pull/697#issuecomment-353286918 [![Coverage Status](https://coveralls.io/builds/14755671/badge)](https://coveralls.io/builds/14755671) Coverage increased

[GitHub] wu-sheng opened a new pull request #697: Make sure the log config works.

2017-12-21 Thread GitBox
wu-sheng opened a new pull request #697: Make sure the log config works. URL: https://github.com/apache/incubator-skywalking/pull/697 Based on #552. in current version, LogWriter is created before `Config.Logging.DIR` initialized, which means this config value didn't effect anything.

[GitHub] WangHouLing opened a new issue #698: Can I multiple agents on one box?

2017-12-21 Thread GitBox
WangHouLing opened a new issue #698: Can I multiple agents on one box? URL: https://github.com/apache/incubator-skywalking/issues/698 Hi, I want to run multiple agents on one box from the same skywalking agent installation. There is a problem is `agent.application_code` in

[GitHub] hanahmily commented on a change in pull request #707: Init ui-protocol

2017-12-30 Thread GitBox
hanahmily commented on a change in pull request #707: Init ui-protocol URL: https://github.com/apache/incubator-skywalking/pull/707#discussion_r159121157 ## File path: apm-protocol/apm-ui-protocol/src/main/resources/ui-graphql/README.md ## @@ -0,0 +1,34 @@ +# Abstract

[GitHub] hanahmily commented on a change in pull request #707: Init ui-protocol

2017-12-30 Thread GitBox
hanahmily commented on a change in pull request #707: Init ui-protocol URL: https://github.com/apache/incubator-skywalking/pull/707#discussion_r159121314 ## File path: apm-protocol/apm-ui-protocol/src/main/resources/ui-graphql/overview-layer.graphqls ## @@ -0,0 +1,37 @@

[GitHub] hanahmily commented on a change in pull request #707: Init ui-protocol

2017-12-30 Thread GitBox
hanahmily commented on a change in pull request #707: Init ui-protocol URL: https://github.com/apache/incubator-skywalking/pull/707#discussion_r159122274 ## File path: apm-protocol/apm-ui-protocol/src/main/resources/ui-graphql/README.md ## @@ -0,0 +1,34 @@ +# Abstract

[GitHub] coveralls commented on issue #707: Init ui-protocol

2017-12-30 Thread GitBox
coveralls commented on issue #707: Init ui-protocol URL: https://github.com/apache/incubator-skywalking/pull/707#issuecomment-354549745 [![Coverage Status](https://coveralls.io/builds/14848062/badge)](https://coveralls.io/builds/14848062) Coverage remained the same at 22.945%

[GitHub] hanahmily commented on a change in pull request #707: Init ui-protocol

2017-12-30 Thread GitBox
hanahmily commented on a change in pull request #707: Init ui-protocol URL: https://github.com/apache/incubator-skywalking/pull/707#discussion_r159121157 ## File path: apm-protocol/apm-ui-protocol/src/main/resources/ui-graphql/README.md ## @@ -0,0 +1,34 @@ +# Abstract

  1   2   3   4   5   6   7   8   9   10   >