peng-yongsheng closed pull request #812: Provide the getAlarmTrend query.
URL: https://github.com/apache/incubator-skywalking/pull/812
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/StorageModule.java
b/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/StorageModule.java
index 425a71614..714255a06 100644
---
a/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/StorageModule.java
+++
b/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/StorageModule.java
@@ -105,6 +105,7 @@
import
org.apache.skywalking.apm.collector.storage.dao.srmp.IServiceReferenceHourMetricPersistenceDAO;
import
org.apache.skywalking.apm.collector.storage.dao.srmp.IServiceReferenceMinuteMetricPersistenceDAO;
import
org.apache.skywalking.apm.collector.storage.dao.srmp.IServiceReferenceMonthMetricPersistenceDAO;
+import
org.apache.skywalking.apm.collector.storage.dao.ui.IApplicationAlarmListUIDAO;
import
org.apache.skywalking.apm.collector.storage.dao.ui.IApplicationAlarmUIDAO;
import
org.apache.skywalking.apm.collector.storage.dao.ui.IApplicationComponentUIDAO;
import
org.apache.skywalking.apm.collector.storage.dao.ui.IApplicationMappingUIDAO;
@@ -264,6 +265,7 @@ private void addUiDAO(List<Class> classes) {
classes.add(IApplicationAlarmUIDAO.class);
classes.add(IInstanceAlarmUIDAO.class);
classes.add(IServiceAlarmUIDAO.class);
+ classes.add(IApplicationAlarmListUIDAO.class);
}
private void addAlarmDAO(List<Class> classes) {
diff --git
a/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/dao/ui/IApplicationAlarmListUIDAO.java
b/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/dao/ui/IApplicationAlarmListUIDAO.java
new file mode 100644
index 000000000..3cd92773a
--- /dev/null
+++
b/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/dao/ui/IApplicationAlarmListUIDAO.java
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.collector.storage.dao.ui;
+
+import java.util.List;
+import org.apache.skywalking.apm.collector.storage.base.dao.DAO;
+import org.apache.skywalking.apm.collector.storage.ui.common.Step;
+
+/**
+ * @author peng-yongsheng
+ */
+public interface IApplicationAlarmListUIDAO extends DAO {
+
+ List<Integer> getAlarmedApplicationNum(Step step, long start, long end);
+}
diff --git
a/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/ui/overview/AlarmTrend.java
b/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/ui/overview/AlarmTrend.java
index 025d27df8..d040f30e0 100644
---
a/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/ui/overview/AlarmTrend.java
+++
b/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/ui/overview/AlarmTrend.java
@@ -18,11 +18,25 @@
package org.apache.skywalking.apm.collector.storage.ui.overview;
+import java.util.LinkedList;
import java.util.List;
/**
* @author peng-yongsheng
*/
public class AlarmTrend {
- public List<Integer> numOfAlarmRate;
+
+ private List<Integer> numOfAlarmRate;
+
+ public AlarmTrend() {
+ this.numOfAlarmRate = new LinkedList<>();
+ }
+
+ public List<Integer> getNumOfAlarmRate() {
+ return numOfAlarmRate;
+ }
+
+ public void setNumOfAlarmRate(List<Integer> numOfAlarmRate) {
+ this.numOfAlarmRate = numOfAlarmRate;
+ }
}
diff --git
a/apm-collector/apm-collector-storage/collector-storage-es-provider/src/main/java/org/apache/skywalking/apm/collector/storage/es/StorageModuleEsProvider.java
b/apm-collector/apm-collector-storage/collector-storage-es-provider/src/main/java/org/apache/skywalking/apm/collector/storage/es/StorageModuleEsProvider.java
index 419069e8f..a4eda177f 100644
---
a/apm-collector/apm-collector-storage/collector-storage-es-provider/src/main/java/org/apache/skywalking/apm/collector/storage/es/StorageModuleEsProvider.java
+++
b/apm-collector/apm-collector-storage/collector-storage-es-provider/src/main/java/org/apache/skywalking/apm/collector/storage/es/StorageModuleEsProvider.java
@@ -114,6 +114,7 @@
import
org.apache.skywalking.apm.collector.storage.dao.srmp.IServiceReferenceHourMetricPersistenceDAO;
import
org.apache.skywalking.apm.collector.storage.dao.srmp.IServiceReferenceMinuteMetricPersistenceDAO;
import
org.apache.skywalking.apm.collector.storage.dao.srmp.IServiceReferenceMonthMetricPersistenceDAO;
+import
org.apache.skywalking.apm.collector.storage.dao.ui.IApplicationAlarmListUIDAO;
import
org.apache.skywalking.apm.collector.storage.dao.ui.IApplicationAlarmUIDAO;
import
org.apache.skywalking.apm.collector.storage.dao.ui.IApplicationComponentUIDAO;
import
org.apache.skywalking.apm.collector.storage.dao.ui.IApplicationMappingUIDAO;
@@ -220,6 +221,7 @@
import
org.apache.skywalking.apm.collector.storage.es.dao.srmp.ServiceReferenceMinuteMetricEsPersistenceDAO;
import
org.apache.skywalking.apm.collector.storage.es.dao.srmp.ServiceReferenceMonthMetricEsPersistenceDAO;
import
org.apache.skywalking.apm.collector.storage.es.dao.ui.ApplicationAlarmEsUIDAO;
+import
org.apache.skywalking.apm.collector.storage.es.dao.ui.ApplicationAlarmListEsUIDAO;
import
org.apache.skywalking.apm.collector.storage.es.dao.ui.ApplicationComponentEsUIDAO;
import
org.apache.skywalking.apm.collector.storage.es.dao.ui.ApplicationMappingEsUIDAO;
import
org.apache.skywalking.apm.collector.storage.es.dao.ui.ApplicationMetricEsUIDAO;
@@ -430,6 +432,8 @@ private void registerUiDAO() throws
ServiceNotProvidedException {
this.registerServiceImplementation(IApplicationAlarmUIDAO.class, new
ApplicationAlarmEsUIDAO(elasticSearchClient));
this.registerServiceImplementation(IInstanceAlarmUIDAO.class, new
InstanceAlarmEsUIDAO(elasticSearchClient));
this.registerServiceImplementation(IServiceAlarmUIDAO.class, new
ServiceAlarmEsUIDAO(elasticSearchClient));
+
+ this.registerServiceImplementation(IApplicationAlarmListUIDAO.class,
new ApplicationAlarmListEsUIDAO(elasticSearchClient));
}
private void registerAlarmDAO() throws ServiceNotProvidedException {
diff --git
a/apm-collector/apm-collector-storage/collector-storage-es-provider/src/main/java/org/apache/skywalking/apm/collector/storage/es/dao/ui/ApplicationAlarmListEsUIDAO.java
b/apm-collector/apm-collector-storage/collector-storage-es-provider/src/main/java/org/apache/skywalking/apm/collector/storage/es/dao/ui/ApplicationAlarmListEsUIDAO.java
new file mode 100644
index 000000000..158bb82a7
--- /dev/null
+++
b/apm-collector/apm-collector-storage/collector-storage-es-provider/src/main/java/org/apache/skywalking/apm/collector/storage/es/dao/ui/ApplicationAlarmListEsUIDAO.java
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.collector.storage.es.dao.ui;
+
+import java.util.LinkedList;
+import java.util.List;
+import
org.apache.skywalking.apm.collector.client.elasticsearch.ElasticSearchClient;
+import
org.apache.skywalking.apm.collector.storage.dao.ui.IApplicationAlarmListUIDAO;
+import org.apache.skywalking.apm.collector.storage.es.base.dao.EsDAO;
+import
org.apache.skywalking.apm.collector.storage.table.alarm.ApplicationAlarmListTable;
+import org.apache.skywalking.apm.collector.storage.ui.common.Step;
+import
org.apache.skywalking.apm.collector.storage.utils.TimePyramidTableNameBuilder;
+import org.elasticsearch.action.search.SearchRequestBuilder;
+import org.elasticsearch.action.search.SearchResponse;
+import org.elasticsearch.action.search.SearchType;
+import org.elasticsearch.index.query.QueryBuilders;
+import org.elasticsearch.search.aggregations.AggregationBuilders;
+import org.elasticsearch.search.aggregations.bucket.terms.Terms;
+
+/**
+ * @author peng-yongsheng
+ */
+public class ApplicationAlarmListEsUIDAO extends EsDAO implements
IApplicationAlarmListUIDAO {
+
+ public ApplicationAlarmListEsUIDAO(ElasticSearchClient client) {
+ super(client);
+ }
+
+ @Override public List<Integer> getAlarmedApplicationNum(Step step, long
start, long end) {
+ String tableName = TimePyramidTableNameBuilder.build(step,
ApplicationAlarmListTable.TABLE);
+ SearchRequestBuilder searchRequestBuilder =
getClient().prepareSearch(tableName);
+ searchRequestBuilder.setTypes(ApplicationAlarmListTable.TABLE_TYPE);
+ searchRequestBuilder.setSearchType(SearchType.DFS_QUERY_THEN_FETCH);
+
searchRequestBuilder.setQuery(QueryBuilders.rangeQuery(ApplicationAlarmListTable.COLUMN_TIME_BUCKET).gte(start).lte(end));
+ searchRequestBuilder.setSize(0);
+
+
searchRequestBuilder.addAggregation(AggregationBuilders.terms(ApplicationAlarmListTable.COLUMN_TIME_BUCKET).field(ApplicationAlarmListTable.COLUMN_TIME_BUCKET).size(100)
+
.subAggregation(AggregationBuilders.terms(ApplicationAlarmListTable.COLUMN_APPLICATION_ID).field(ApplicationAlarmListTable.COLUMN_APPLICATION_ID).size(100)));
+
+ SearchResponse searchResponse =
searchRequestBuilder.execute().actionGet();
+
+ Terms timeBucketTerms =
searchResponse.getAggregations().get(ApplicationAlarmListTable.COLUMN_TIME_BUCKET);
+
+ List<Integer> alarmApplicationNum = new LinkedList<>();
+ for (Terms.Bucket timeBucketBucket : timeBucketTerms.getBuckets()) {
+ Terms applicationBucketTerms =
timeBucketBucket.getAggregations().get(ApplicationAlarmListTable.COLUMN_APPLICATION_ID);
+ int num = applicationBucketTerms.getBuckets().size();
+ alarmApplicationNum.add(num);
+ }
+
+ return alarmApplicationNum;
+ }
+}
diff --git
a/apm-collector/apm-collector-storage/collector-storage-h2-provider/src/main/java/org/apache/skywalking/apm/collector/storage/h2/StorageModuleH2Provider.java
b/apm-collector/apm-collector-storage/collector-storage-h2-provider/src/main/java/org/apache/skywalking/apm/collector/storage/h2/StorageModuleH2Provider.java
index 49124cdaf..43ba27ea6 100644
---
a/apm-collector/apm-collector-storage/collector-storage-h2-provider/src/main/java/org/apache/skywalking/apm/collector/storage/h2/StorageModuleH2Provider.java
+++
b/apm-collector/apm-collector-storage/collector-storage-h2-provider/src/main/java/org/apache/skywalking/apm/collector/storage/h2/StorageModuleH2Provider.java
@@ -110,6 +110,7 @@
import
org.apache.skywalking.apm.collector.storage.dao.srmp.IServiceReferenceHourMetricPersistenceDAO;
import
org.apache.skywalking.apm.collector.storage.dao.srmp.IServiceReferenceMinuteMetricPersistenceDAO;
import
org.apache.skywalking.apm.collector.storage.dao.srmp.IServiceReferenceMonthMetricPersistenceDAO;
+import
org.apache.skywalking.apm.collector.storage.dao.ui.IApplicationAlarmListUIDAO;
import
org.apache.skywalking.apm.collector.storage.dao.ui.IApplicationAlarmUIDAO;
import
org.apache.skywalking.apm.collector.storage.dao.ui.IApplicationComponentUIDAO;
import
org.apache.skywalking.apm.collector.storage.dao.ui.IApplicationMappingUIDAO;
@@ -216,6 +217,7 @@
import
org.apache.skywalking.apm.collector.storage.h2.dao.srmp.ServiceReferenceMinuteMetricH2PersistenceDAO;
import
org.apache.skywalking.apm.collector.storage.h2.dao.srmp.ServiceReferenceMonthMetricH2PersistenceDAO;
import
org.apache.skywalking.apm.collector.storage.h2.dao.ui.ApplicationAlarmH2UIDAO;
+import
org.apache.skywalking.apm.collector.storage.h2.dao.ui.ApplicationAlarmListH2UIDAO;
import
org.apache.skywalking.apm.collector.storage.h2.dao.ui.ApplicationComponentH2UIDAO;
import
org.apache.skywalking.apm.collector.storage.h2.dao.ui.ApplicationMappingH2UIDAO;
import
org.apache.skywalking.apm.collector.storage.h2.dao.ui.ApplicationMetricH2UIDAO;
@@ -406,6 +408,8 @@ private void registerUiDAO() throws
ServiceNotProvidedException {
this.registerServiceImplementation(IApplicationAlarmUIDAO.class, new
ApplicationAlarmH2UIDAO(h2Client));
this.registerServiceImplementation(IInstanceAlarmUIDAO.class, new
InstanceAlarmH2UIDAO(h2Client));
this.registerServiceImplementation(IServiceAlarmUIDAO.class, new
ServiceAlarmH2UIDAO(h2Client));
+
+ this.registerServiceImplementation(IApplicationAlarmListUIDAO.class,
new ApplicationAlarmListH2UIDAO(h2Client));
}
private void registerAlarmDAO() throws ServiceNotProvidedException {
diff --git
a/apm-collector/apm-collector-storage/collector-storage-h2-provider/src/main/java/org/apache/skywalking/apm/collector/storage/h2/dao/ui/ApplicationAlarmListH2UIDAO.java
b/apm-collector/apm-collector-storage/collector-storage-h2-provider/src/main/java/org/apache/skywalking/apm/collector/storage/h2/dao/ui/ApplicationAlarmListH2UIDAO.java
new file mode 100644
index 000000000..598144a2a
--- /dev/null
+++
b/apm-collector/apm-collector-storage/collector-storage-h2-provider/src/main/java/org/apache/skywalking/apm/collector/storage/h2/dao/ui/ApplicationAlarmListH2UIDAO.java
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.collector.storage.h2.dao.ui;
+
+import java.util.List;
+import org.apache.skywalking.apm.collector.client.h2.H2Client;
+import
org.apache.skywalking.apm.collector.storage.dao.ui.IApplicationAlarmListUIDAO;
+import org.apache.skywalking.apm.collector.storage.h2.base.dao.H2DAO;
+import org.apache.skywalking.apm.collector.storage.ui.common.Step;
+
+/**
+ * @author peng-yongsheng
+ */
+public class ApplicationAlarmListH2UIDAO extends H2DAO implements
IApplicationAlarmListUIDAO {
+
+ public ApplicationAlarmListH2UIDAO(H2Client client) {
+ super(client);
+ }
+
+ @Override public List<Integer> getAlarmedApplicationNum(Step step, long
start, long end) {
+ return null;
+ }
+}
diff --git
a/apm-collector/apm-collector-ui/collector-ui-jetty-provider/src/main/java/org/apache/skywalking/apm/collector/ui/query/OverViewLayerQuery.java
b/apm-collector/apm-collector-ui/collector-ui-jetty-provider/src/main/java/org/apache/skywalking/apm/collector/ui/query/OverViewLayerQuery.java
index 5f2059daf..c609e5d75 100644
---
a/apm-collector/apm-collector-ui/collector-ui-jetty-provider/src/main/java/org/apache/skywalking/apm/collector/ui/query/OverViewLayerQuery.java
+++
b/apm-collector/apm-collector-ui/collector-ui-jetty-provider/src/main/java/org/apache/skywalking/apm/collector/ui/query/OverViewLayerQuery.java
@@ -109,10 +109,13 @@ public ClusterBrief getClusterBrief(Duration duration)
throws ParseException {
}
public AlarmTrend getAlarmTrend(Duration duration) throws ParseException {
+ long startTimeBucket =
DurationUtils.INSTANCE.exchangeToTimeBucket(duration.getStart());
+ long endTimeBucket =
DurationUtils.INSTANCE.exchangeToTimeBucket(duration.getEnd());
+
long start =
DurationUtils.INSTANCE.durationToSecondTimeBucket(duration.getStep(),
duration.getStart());
long end =
DurationUtils.INSTANCE.durationToSecondTimeBucket(duration.getStep(),
duration.getEnd());
- return getAlarmService().getApplicationAlarmTrend(duration.getStep(),
start, end);
+ return getAlarmService().getApplicationAlarmTrend(duration.getStep(),
startTimeBucket, endTimeBucket, start, end);
}
public ConjecturalAppBrief getConjecturalApps(Duration duration) throws
ParseException {
diff --git
a/apm-collector/apm-collector-ui/collector-ui-jetty-provider/src/main/java/org/apache/skywalking/apm/collector/ui/service/AlarmService.java
b/apm-collector/apm-collector-ui/collector-ui-jetty-provider/src/main/java/org/apache/skywalking/apm/collector/ui/service/AlarmService.java
index 066d71c68..7ecd6f3ec 100644
---
a/apm-collector/apm-collector-ui/collector-ui-jetty-provider/src/main/java/org/apache/skywalking/apm/collector/ui/service/AlarmService.java
+++
b/apm-collector/apm-collector-ui/collector-ui-jetty-provider/src/main/java/org/apache/skywalking/apm/collector/ui/service/AlarmService.java
@@ -22,14 +22,15 @@
import java.util.List;
import org.apache.skywalking.apm.collector.core.module.ModuleManager;
import org.apache.skywalking.apm.collector.storage.StorageModule;
+import
org.apache.skywalking.apm.collector.storage.dao.ui.IApplicationAlarmListUIDAO;
import
org.apache.skywalking.apm.collector.storage.dao.ui.IApplicationAlarmUIDAO;
import org.apache.skywalking.apm.collector.storage.dao.ui.IInstanceAlarmUIDAO;
+import org.apache.skywalking.apm.collector.storage.dao.ui.IInstanceUIDAO;
import org.apache.skywalking.apm.collector.storage.dao.ui.IServiceAlarmUIDAO;
import org.apache.skywalking.apm.collector.storage.ui.alarm.Alarm;
+import org.apache.skywalking.apm.collector.storage.ui.application.Application;
import org.apache.skywalking.apm.collector.storage.ui.common.Step;
import org.apache.skywalking.apm.collector.storage.ui.overview.AlarmTrend;
-import org.apache.skywalking.apm.collector.storage.utils.DurationPoint;
-import org.apache.skywalking.apm.collector.ui.utils.DurationUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -40,14 +41,18 @@
private final Logger logger = LoggerFactory.getLogger(AlarmService.class);
+ private final IInstanceUIDAO instanceDAO;
private final IApplicationAlarmUIDAO applicationAlarmUIDAO;
private final IInstanceAlarmUIDAO instanceAlarmUIDAO;
private final IServiceAlarmUIDAO serviceAlarmUIDAO;
+ private final IApplicationAlarmListUIDAO applicationAlarmListUIDAO;
public AlarmService(ModuleManager moduleManager) {
+ this.instanceDAO =
moduleManager.find(StorageModule.NAME).getService(IInstanceUIDAO.class);
this.applicationAlarmUIDAO =
moduleManager.find(StorageModule.NAME).getService(IApplicationAlarmUIDAO.class);
this.instanceAlarmUIDAO =
moduleManager.find(StorageModule.NAME).getService(IInstanceAlarmUIDAO.class);
this.serviceAlarmUIDAO =
moduleManager.find(StorageModule.NAME).getService(IServiceAlarmUIDAO.class);
+ this.applicationAlarmListUIDAO =
moduleManager.find(StorageModule.NAME).getService(IApplicationAlarmListUIDAO.class);
}
public Alarm loadApplicationAlarmList(String keyword, long start, long end,
@@ -68,10 +73,15 @@ public Alarm loadServiceAlarmList(String keyword, long
start, long end,
return serviceAlarmUIDAO.loadAlarmList(keyword, start, end, limit,
from);
}
- public AlarmTrend getApplicationAlarmTrend(Step step, long start, long
end) throws ParseException {
- List<DurationPoint> durationPoints =
DurationUtils.INSTANCE.getDurationPoints(step, start, end);
+ public AlarmTrend getApplicationAlarmTrend(Step step, long
startTimeBucket, long endTimeBucket, long start,
+ long end) throws ParseException {
+ List<Application> applications = instanceDAO.getApplications(start,
end);
+ List<Integer> applicationNum =
applicationAlarmListUIDAO.getAlarmedApplicationNum(step, startTimeBucket,
endTimeBucket);
AlarmTrend alarmTrend = new AlarmTrend();
+ applicationNum.forEach(num -> {
+ alarmTrend.getNumOfAlarmRate().add((num * 10000) /
(applications.size()));
+ });
return alarmTrend;
}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
