wu-sheng commented on issue #771: Add [Agent] ServiceComb Plugin #437
URL:
https://github.com/apache/incubator-skywalking/pull/771#issuecomment-364871915
FYI @WillemJiang , the plugin is checked by our automatic mechanism and
merged.
---
wu-sheng commented on issue #771: Add [Agent] ServiceComb Plugin #437
URL:
https://github.com/apache/incubator-skywalking/pull/771#issuecomment-364871797
@lytscu Please add the `serviceComb` to supported list.
This is an auto
wu-sheng commented on issue #771: Add [Agent] ServiceComb Plugin #437
URL:
https://github.com/apache/incubator-skywalking/pull/771#issuecomment-364869452
@lytscu @ascrutae Seem like, ServiceComb 0.1.0 works out magically.
Thi
wu-sheng commented on issue #771: Add [Agent] ServiceComb Plugin #437
URL:
https://github.com/apache/incubator-skywalking/pull/771#issuecomment-364837800
Besides the comments need adjust, could you run the test cases again? And
post the results here? @ascrutae
I already sync/updat
wu-sheng commented on issue #771: Add [Agent] ServiceComb Plugin #437
URL:
https://github.com/apache/incubator-skywalking/pull/771#issuecomment-363270405
@lytscu Do you finish the plugin? And make the test works?
This is an a
wu-sheng commented on issue #771: Add [Agent] ServiceComb Plugin #437
URL:
https://github.com/apache/incubator-skywalking/pull/771#issuecomment-362512556
@ascrutae That explain makes sense.
@lytscu please pay attentiom. about you intercept point, make sure they are
in the main requ
wu-sheng commented on issue #771: Add [Agent] ServiceComb Plugin #437
URL:
https://github.com/apache/incubator-skywalking/pull/771#issuecomment-362462279
@ascrutae I can't follow you with the spans expected:
> Span-0: codefirstClient.codeFirstSpringmvcHello.say
Span-1: codefirst.codeF
wu-sheng commented on issue #771: Add [Agent] ServiceComb Plugin #437
URL:
https://github.com/apache/incubator-skywalking/pull/771#issuecomment-362461187
@ascrutae I don't think these can be caused by where you set the interceptor.
--
wu-sheng commented on issue #771: Add [Agent] ServiceComb Plugin #437
URL:
https://github.com/apache/incubator-skywalking/pull/771#issuecomment-362460890
@ascrutae @lytscu Why does the trace brake? Because of multi thread
situation? or header propagation?
-
wu-sheng commented on issue #771: Add [Agent] ServiceComb Plugin #437
URL:
https://github.com/apache/incubator-skywalking/pull/771#issuecomment-361472254
@lytscu @ascrutae Are the codes ready? Does any test report to provide?
wu-sheng commented on issue #771: Add [Agent] ServiceComb Plugin #437
URL:
https://github.com/apache/incubator-skywalking/pull/771#issuecomment-361044870
@lytscu @ascrutae What is the status of this pr? now.
This is an automa
wu-sheng commented on issue #771: Add [Agent] ServiceComb Plugin #437
URL:
https://github.com/apache/incubator-skywalking/pull/771#issuecomment-359464119
@lytscu I just fixed your pr comments:
```
- [x] New feature provided
```
-
12 matches
Mail list logo
