[GitHub] toniedzwiedz edited a comment on issue #7: Update README.md

2018-08-13 Thread GitBox
toniedzwiedz edited a comment on issue #7: Update README.md URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/7#issuecomment-412628211 Ah, it didn't occur to me to run the build after adding an image. Apparently the plugin treats the SVG as code. Raised #8

[GitHub] toniedzwiedz opened a new pull request #8: Update README.md [Apache license added to SVG file]

2018-08-13 Thread GitBox
toniedzwiedz opened a new pull request #8: Update README.md [Apache license added to SVG file] URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/8 - Add changelog for version 3.0.0 and above to README.md - Replace an image with outdated Cognifide and Apache

[GitHub] toniedzwiedz commented on issue #7: Update README.md

2018-08-13 Thread GitBox
toniedzwiedz commented on issue #7: Update README.md URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/7#issuecomment-412628211 Ah, it didn't occur to me to run the build after adding an image. Apparently the plugin treats the SVG as code. Raised #8

[GitHub] toniedzwiedz commented on issue #8: Update README.md [Apache license added to SVG file]

2018-08-13 Thread GitBox
toniedzwiedz commented on issue #8: Update README.md [Apache license added to SVG file] URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/8#issuecomment-412628369 @rombert added Apache 2.0 license header to the SVG, `mvn verify` is now successful.

[jira] [Commented] (SLING-7786) Use R7 configuration admin supporting named factory configurations

2018-08-13 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577878#comment-16577878 ] Carsten Ziegeler commented on SLING-7786: - While the already implemented approach works for the

[jira] [Commented] (SLING-2759) Provide an OpenId Connect Authentication Handler

2018-08-13 Thread Hasini Dilanka Witharana (JIRA)
[ https://issues.apache.org/jira/browse/SLING-2759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578055#comment-16578055 ] Hasini Dilanka Witharana commented on SLING-2759: - Implementation is attached in the git

[jira] [Updated] (SLING-7798) Switch from JSR-305 annotations to JetBrains Nullable/NotNull annotations

2018-08-13 Thread Stefan Seifert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated SLING-7798: -- Fix Version/s: Commons Messaging Mail 1.0.0 Commons Messaging 1.0.0

[jira] [Updated] (SLING-7798) Switch from JSR-305 annotations to JetBrains Nullable/NotNull annotations

2018-08-13 Thread Stefan Seifert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated SLING-7798: -- Fix Version/s: XSS Protection API 2.0.14 Validation Core 1.0.6

[jira] [Updated] (SLING-2759) Provide an OpenId Connect Authentication Handler

2018-08-13 Thread Hasini Dilanka Witharana (JIRA)
[ https://issues.apache.org/jira/browse/SLING-2759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hasini Dilanka Witharana updated SLING-2759: Attachment: oidc_handler_patch.diff > Provide an OpenId Connect

[jira] [Resolved] (SLING-7798) Switch from JSR-305 annotations to JetBrains Nullable/NotNull annotations

2018-08-13 Thread Stefan Seifert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-7798. --- Resolution: Fixed > Switch from JSR-305 annotations to JetBrains Nullable/NotNull

[jira] [Commented] (SLING-2759) Provide an OpenId Connect Authentication Handler

2018-08-13 Thread Hasini Dilanka Witharana (JIRA)
[ https://issues.apache.org/jira/browse/SLING-2759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578106#comment-16578106 ] Hasini Dilanka Witharana commented on SLING-2759: - Implementation is attached in the git

[jira] [Issue Comment Deleted] (SLING-2759) Provide an OpenId Connect Authentication Handler

2018-08-13 Thread Hasini Dilanka Witharana (JIRA)
[ https://issues.apache.org/jira/browse/SLING-2759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hasini Dilanka Witharana updated SLING-2759: Comment: was deleted (was: Implementation is attached in the git patch.

[RESULT] [VOTE] Release Apache Sling Engine 2.16.14

2018-08-13 Thread Julian Sedding
Hi all, The vote has passed with the following result: +1 (binding): Carsten Ziegeler, Daniel Klco, Radu Cotescu, Julian Sedding Thanks for voting. I will promote the artifacts to dist and the central Maven repository and update the news page. Regards Julian

[jira] [Updated] (SLING-2759) Provide an OpenId Connect Authentication Handler

2018-08-13 Thread Hasini Dilanka Witharana (JIRA)
[ https://issues.apache.org/jira/browse/SLING-2759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hasini Dilanka Witharana updated SLING-2759: Attachment: 0001-Implementing-OIDC-Flow.patch > Provide an OpenId Connect

Re: [VOTE] Release Apache Sling Engine 2.16.4

2018-08-13 Thread Julian Sedding
+1 Thanks for voting, I'll push out the release. BTW: sorry, I just realised that I had gotten the release version in the email wrong. It is 2.16.14, not 2.16.4. Regards Julian On Wed, Aug 8, 2018 at 4:02 PM Radu Cotescu wrote: > > +1 > > > On 8 Aug 2018, at 13:24, Julian Sedding wrote: > >

[jira] [Resolved] (SLING-7802) Mocks: Add Nullability annotations to mock API

2018-08-13 Thread Stefan Seifert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-7802. --- Resolution: Fixed

Re: [VOTE] Release Apache Sling Engine 2.16.4

2018-08-13 Thread Julian Sedding
I may finally get the release version right: it is 2.6.14. Fortunately the release artifacts are correctly versioned and JIRA is also correct. Sorry for the confusion! Regards Julian On Mon, Aug 13, 2018 at 1:12 PM Julian Sedding wrote: > > +1 > > Thanks for voting, I'll push out the release.

Re: [RESULT] [VOTE] Release Apache Sling Engine 2.16.14

2018-08-13 Thread Julian Sedding
I may finally get the release version right: it is 2.6.14. Fortunately the release artifacts are correctly versioned and JIRA is also correct. Sorry for the confusion! Regards Julian On Mon, Aug 13, 2018 at 1:14 PM Julian Sedding wrote: > > Hi all, > > The vote has passed with the following

Re: Sling Hackathon Sept. 13th, 2018 in Berlin

2018-08-13 Thread Robert Munteanu
These sound like great additions, would be nice to see you at the hackathon. Robert On Mon, 2018-08-13 at 12:51 +0300, Eugen Stan wrote: > Hi, > > I'm working on deploying Sling + Karaf in production so I think I > will > focus on this part: > > - making it easy to quick-start Sling for

[jira] [Created] (SLING-7821) Switch code signing to use the SAS CSP for Java Hash Signing

2018-08-13 Thread Robert Munteanu (JIRA)
Robert Munteanu created SLING-7821: -- Summary: Switch code signing to use the SAS CSP for Java Hash Signing Key: SLING-7821 URL: https://issues.apache.org/jira/browse/SLING-7821 Project: Sling

[jira] [Updated] (SLING-7798) Switch from JSR-305 annotations to JetBrains Nullable/NotNull annotations

2018-08-13 Thread Stefan Seifert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated SLING-7798: -- Description: follow-up from SLING-7312 and discussion from the [mailing

Re: Sling Hackathon Sept. 13th, 2018 in Berlin

2018-08-13 Thread Robert Munteanu
Hi Eugen, On Sat, 2018-08-11 at 20:44 +0300, Eugen Stan wrote: > Hi, > > I'm booking my flight and accomodations for Adapt.to and would like > to > know a shedule for the hackathon so I can plan better. > > I have flight options from Berlin Schönefeld @ 18:15 on 13.09 and > another, next day. >

[jira] [Updated] (SLING-7798) Switch from JSR-305 annotations to JetBrains Nullable/NotNull annotations

2018-08-13 Thread Stefan Seifert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated SLING-7798: -- Fix Version/s: Discovery Commons 1.0.22 MoM Jobs 1.0.2

[jira] [Updated] (SLING-7798) Switch from JSR-305 annotations to JetBrains Nullable/NotNull annotations

2018-08-13 Thread Stefan Seifert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated SLING-7798: -- Fix Version/s: Sling Models Impl 1.4.10 Scripting Core 2.0.56

[jira] [Assigned] (SLING-7798) Switch from JSR-305 annotations to JetBrains Nullable/NotNull annotations

2018-08-13 Thread Stefan Seifert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert reassigned SLING-7798: - Assignee: Stefan Seifert i'll give the script from julian a try on the remaining ones

[jira] [Updated] (SLING-7798) Switch from JSR-305 annotations to JetBrains Nullable/NotNull annotations

2018-08-13 Thread Stefan Seifert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated SLING-7798: -- Fix Version/s: JCR Resource 3.0.16 Resource Resolver 1.6.6

Re: Sling Hackathon Sept. 13th, 2018 in Berlin

2018-08-13 Thread Eugen Stan
Hi, I'm working on deploying Sling + Karaf in production so I think I will focus on this part: - making it easy to quick-start Sling for production use - some comon strategies on how to work with content - fix some issues around tooling and the process - right now I get a lot of error messages

[jira] [Resolved] (SLING-7803) JUnit5 Support for sling-mock and osgi-mock

2018-08-13 Thread Stefan Seifert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-7803. --- Resolution: Fixed it was not possible support both junit4 and junit5 with one single

[jira] [Closed] (SLING-7813) SlingHttpServletResponseImpl should log when setStatus is called after it is committed

2018-08-13 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding closed SLING-7813. - > SlingHttpServletResponseImpl should log when setStatus is called after it is > committed >

[jira] [Commented] (SLING-7803) JUnit5 Support for sling-mock and osgi-mock

2018-08-13 Thread Stefan Seifert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578190#comment-16578190 ] Stefan Seifert commented on SLING-7803: --- implemented:

[jira] [Commented] (SLING-7534) Release policy - stop providing MD5 signatures

2018-08-13 Thread Bertrand Delacretaz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578242#comment-16578242 ] Bertrand Delacretaz commented on SLING-7534: FWIW, in MPOM-205 the Apache Parent Pom is being

[jira] [Created] (SLING-7822) ResourceBuilder: Switch to OSGi annotations

2018-08-13 Thread Stefan Seifert (JIRA)
Stefan Seifert created SLING-7822: - Summary: ResourceBuilder: Switch to OSGi annotations Key: SLING-7822 URL: https://issues.apache.org/jira/browse/SLING-7822 Project: Sling Issue Type:

[GitHub] rombert commented on issue #7: Update README.md

2018-08-13 Thread GitBox
rombert commented on issue #7: Update README.md URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/7#issuecomment-412564161 Merged, thanks @toniedzwiedz ! I think in the future we should move this information into the Sling site, but for now this is a good start

[jira] [Updated] (SLING-7802) Mocks: Add Nullability annotations to mock API

2018-08-13 Thread Stefan Seifert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated SLING-7802: -- Fix Version/s: Resource Builder 1.0.4 > Mocks: Add Nullability annotations to mock API >

[jira] [Resolved] (SLING-7822) ResourceBuilder: Switch to OSGi annotations

2018-08-13 Thread Stefan Seifert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-7822. --- Resolution: Fixed

[GitHub] rombert commented on issue #7: Update README.md

2018-08-13 Thread GitBox
rombert commented on issue #7: Update README.md URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/7#issuecomment-412578296 @toniedzwiedz - I unfortunately had to revert the change due to a build failure: ``` 1 Unknown Licenses

[jira] [Updated] (SLING-7786) Use R7 configuration admin supporting named factory configurations

2018-08-13 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-7786: Fix Version/s: Installer Core 3.8.14 > Use R7 configuration admin supporting named factory

[jira] [Commented] (SLING-7786) Use R7 configuration admin supporting named factory configurations

2018-08-13 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578580#comment-16578580 ] Carsten Ziegeler commented on SLING-7786: - I've now chosen a different approach, the installer

Re: /etc/map units tests and the issue of recursive mapping

2018-08-13 Thread Robert Munteanu
On Mon, 2018-08-06 at 08:47 -0700, Andreas Schaefer wrote: > I extracted the Etc Mapping tests and added it to master including a > test that showcases the endless circular mapping: > > - EtcMappingResourceResolverTest.endless_circular_mapping() > > Create a ticket here: >