[VOTE] Release slingfeature-maven-plugin 1.1.2

2019-09-10 Thread davidb
Hi all, We solved 5 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12346050 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2127 You can use this UNIX script to download the release and verify the signatures:

Re: [VOTE] Release slingfeature-maven-plugin 1.1.2

2019-09-10 Thread davidb
+1 David On Tue, 10 Sep 2019 at 09:59, wrote: > Hi all, > > We solved 5 issues in this release: > https://issues.apache.org/jira/projects/SLING/versions/12346050 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2127 > > You can use this UNIX script to

[jira] [Created] (SLING-8693) Additional support for Anonymous v/s loggedin user experiences

2019-09-10 Thread Mayank Arora (Jira)
Mayank Arora created SLING-8693: --- Summary: Additional support for Anonymous v/s loggedin user experiences Key: SLING-8693 URL: https://issues.apache.org/jira/browse/SLING-8693 Project: Sling

Re: Release Validator Docker Image

2019-09-10 Thread Radu Cotescu
Hi Carsten, > On 9 Sep 2019, at 19:29, Carsten Ziegeler wrote: > > Can we maybe also remove the md5 files and create sha512 files, when the > checksum is correct? > The sha1 and md5 files seem to be generated by Nexus and not by our Maven release process. I quickly checked how the sha512

Re: Why get rid of the rewriter?

2019-09-10 Thread Carsten Ziegeler
Sounds good to me, now for the rewriter I would like to have something more special geared towards html thank a generic thing like SAX. So basically instead of getting the information that the element name is "a" and then you have to figure out that this is a link, you already get the

Re: Why get rid of the rewriter?

2019-09-10 Thread Jason E Bailey
+1 for the summary -- Jason On Tue, Sep 10, 2019, at 12:37 PM, Stefan Seifert wrote: > i try to write a first summary: > > - we have good use cases for a rewriter in general, but are unhappy > with the current implementation and it's way of configuration. the > whole thing is a bit "alien" to

Re: Release Validator Docker Image

2019-09-10 Thread Carsten Ziegeler
I think the value is already there today, we push manually to dist and having the sha512 there and not the md5 is already a win. It would be great to have this mirrored in the maven repository, but that probably needs those bugs to be fixed. Carsten Am 10.09.2019 um 13:16 schrieb Radu

Re: Why get rid of the rewriter?

2019-09-10 Thread Bertrand Delacretaz
Hi, On Mon, Sep 9, 2019 at 3:07 PM Jason E Bailey wrote: > ...Can anyone summarize why we are getting rid of it?... I'm not sure if we need to "get rid" of that module, even if some portion of Sling users stops using it. The proposal at [1] says the rewriter should be "deprecated and no longer

Re: Why get rid of the rewriter?

2019-09-10 Thread Ruben Reusser
As was pointed out before the rewriter is used in a lot of projects for other things than rewriting links (in our case we use it a lot to inject legal disclaimers or content fragment models) The bigger problem however is that it assumes hml == xml and hence can not deal with attributes with no

Re: Why get rid of the rewriter?

2019-09-10 Thread Konrad Windszus
The new url rewriter SPI will be perfectly supporting AOP. Konrad > Am 10.09.2019 um 16:09 schrieb Justin Edelson : > > I see that the same assumptions are being made here that were made a year > ago when this was discussed. I would strongly caution against assuming that > the "aspect developer"

Re: [VOTE] Release slingfeature-maven-plugin 1.1.2

2019-09-10 Thread Daniel Klco
+1 On Tue, Sep 10, 2019 at 7:28 AM Robert Munteanu wrote: > On Tue, 2019-09-10 at 09:59 +0100, dav...@apache.org wrote: > > Please vote to approve this release: > > +1 > > Robert >

Re: [VOTE] Release slingfeature-maven-plugin 1.1.2

2019-09-10 Thread Radu Cotescu
+1 > On 10 Sep 2019, at 10:59, dav...@apache.org wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Best regards, > > David Bosschaert

Re: Why get rid of the rewriter?

2019-09-10 Thread Carsten Ziegeler
The rewriter is a generic solution (for xhtml) which works independent of the scripting engine used. However, with engines like HTL which knows about HTML and has all the contextual information about the html elements, it is way more efficient to do any transformation whether its link

Re: [VOTE] Release slingfeature-maven-plugin 1.1.2

2019-09-10 Thread Carsten Ziegeler
+1 Carsten Am 10.09.2019 um 10:59 schrieb dav...@apache.org: Hi all, We solved 5 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12346050 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2127 You can use this UNIX script to

[jira] [Created] (SLING-8692) Slingfeature maven plugin: add option to decompress artifacts stored in the repository goal

2019-09-10 Thread Karl Pauls (Jira)
Karl Pauls created SLING-8692: - Summary: Slingfeature maven plugin: add option to decompress artifacts stored in the repository goal Key: SLING-8692 URL: https://issues.apache.org/jira/browse/SLING-8692

[jira] [Assigned] (SLING-8692) Slingfeature maven plugin: add option to decompress artifacts stored in the repository goal

2019-09-10 Thread David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-8692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Bosschaert reassigned SLING-8692: --- Assignee: David Bosschaert > Slingfeature maven plugin: add option to decompress

Re: [VOTE] Release slingfeature-maven-plugin 1.1.2

2019-09-10 Thread Robert Munteanu
On Tue, 2019-09-10 at 09:59 +0100, dav...@apache.org wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part

[Jenkins] Sling » sling-org-apache-sling-launchpad-testing » master #308 is BROKEN

2019-09-10 Thread Apache Jenkins Server
INFO] [jenkins-event-spy] Generated /home/jenkins/jenkins-slave/workspace/e-sling-launchpad-testing_master@tmp/withMavenbdcbeb84/maven-spy-20190910-125502-96642605128299413749.log [ERROR] Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.21.0:verify (default) on project org.apac

Re: Why get rid of the rewriter?

2019-09-10 Thread Justin Edelson
I see that the same assumptions are being made here that were made a year ago when this was discussed. I would strongly caution against assuming that the "aspect developer" and the "script developer" are the same person or even work for the same organization. The value of AOP programming styles,

Re: Release Validator Docker Image

2019-09-10 Thread Carsten Ziegeler
Sounds good to me, with the addition that it does not upload the md5 files to SVN and only creates the sha256 (or sha512?) if the check of the files is successful Carsten Am 10.09.2019 um 23:33 schrieb Robert Munteanu: On Tue, 2019-09-10 at 22:57 +0200, Carsten Ziegeler wrote: I think the

Re: Release Validator Docker Image

2019-09-10 Thread Robert Munteanu
On Tue, 2019-09-10 at 22:57 +0200, Carsten Ziegeler wrote: > I think the value is already there today, we push manually to dist > and > having the sha512 there and not the md5 is already a win. > It would be great to have this mirrored in the maven repository, but > that probably needs those

Re: Why get rid of the rewriter?

2019-09-10 Thread Julian Sedding
Another real-world use-case that was nicely solved using the rewriter is footnotes. Footnotes are collected by a rewriter and consecutive numbers injected into the markup. At the end of a page all collected footnote's texts were then rendered. Off the top of my head I cannot name another elegant

org-apache-sling-app-cms - start.sh & stop.sh

2019-09-10 Thread Miroslav Beranič
Hi all, I've followed documentation to build Sling CMS APP at org-apache-sling-app-cms/docs/building.md, where it says: To run the Sling CMS, build the code and copy the files builder/src/main/scripts/start.sh builder/src/main/scripts/stop.sh and builder/target/org.apache.sling.cms-{VERSION].jar

Re: Why get rid of the rewriter?

2019-09-10 Thread Konrad Windszus
Why can footnotes not be added as request attributes (either just as a numeric counter or a complex object depending on the use case)? > On 10. Sep 2019, at 16:55, Julian Sedding wrote: > > Another real-world use-case that was nicely solved using the rewriter > is footnotes. Footnotes are

RE: Why get rid of the rewriter?

2019-09-10 Thread Stefan Seifert
i try to write a first summary: - we have good use cases for a rewriter in general, but are unhappy with the current implementation and it's way of configuration. the whole thing is a bit "alien" to the other parts of sling. - a new rewriter implementation should be performant and with

Re: [VOTE] Release slingfeature-maven-plugin 1.1.2

2019-09-10 Thread Andreas Schaefer
+1 (non-binding) - Andy > On Sep 10, 2019, at 1:59 AM, dav...@apache.org wrote: > > Hi all, > > We solved 5 issues in this release: > https://issues.apache.org/jira/projects/SLING/versions/12346050 > > Staging repository: >

Re: Why get rid of the rewriter?

2019-09-10 Thread Jason E Bailey
I'm positive towards the concept of the rewriter, a utility that provides centralized features that addresses cross-cutting concerns with user generated content. I'm not a fan of the current implementation of the rewriter. 1. As Ruben pointed out, as of HTML5 html doesn't have anything to do

[jira] [Updated] (SLING-8683) Slingfeature maven plugin should be usable to wrap project artifacts in feature.

2019-09-10 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-8683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-8683: Fix Version/s: (was: slingfeature-maven-plugin 1.1.2)

RE: Why get rid of the rewriter?

2019-09-10 Thread Stefan Seifert
>What is the solution for rewriting URLs contained within the output of a >rich text editor? Similar to https://wcm.io/handler/richtext/? I hope that >downstream implementers of Sling will provide a pathway for replacing the >rewriter if it is removed. I would speculate this would result in a

Re: Why get rid of the rewriter?

2019-09-10 Thread Roy Teeuwen
I also used rewriting for various use cases ( for example creating disclaimer links at the bottom of the page based on whats on the page) To be honest, its just a nice wrapper around a filter, if you would take it away, people would just create a filter on page level that captures the response