[jira] [Commented] (SLING-8869) SimpleHttpDistributionTransport does not refresh the secret for token based implementations.

2019-12-02 Thread Ashish Chopra (Jira)
[ https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986649#comment-16986649 ] Ashish Chopra commented on SLING-8869: -- [~mohiaror], IIUC the patch, once the secret is associated

[VOTE] Release Apache Sling XSS Protection API 2.1.18

2019-12-02 Thread Radu Cotescu
Hi, We solved 3 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12346531 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2162/ You can use this UNIX script to download the release and verify the signatures:

Re: [VOTE] Release Apache Sling HTL Maven Plugin 1.3.2-1.4.0, Apache Sling Scripting HTL Engine 1.3.0-1.4.0, Apache Sling Scripting HTL JS Use Provider 1.1.0, Apache Sling Scripting JavaScript 3.1.0,

2019-12-02 Thread Andreas Schaefer
+1 (non-binding) - Andy > On Dec 2, 2019, at 8:07 AM, Radu Cotescu wrote: > > Hi, > > We solved 2 issues in these releases: > https://issues.apache.org/jira/browse/SLING/fixforversion/12346551 > https://issues.apache.org/jira/browse/SLING/fixforversion/12346559 >

[VOTE] Release Apache Sling Scripting JSP 2.4.0

2019-12-02 Thread Radu Cotescu
Hi, We solved 1 issue in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12346563 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2164/ You can use this UNIX script to download the release and verify the signatures:

[VOTE] Release Apache Sling HTL Maven Plugin 1.3.2-1.4.0, Apache Sling Scripting HTL Engine 1.3.0-1.4.0, Apache Sling Scripting HTL JS Use Provider 1.1.0, Apache Sling Scripting JavaScript 3.1.0, Apac

2019-12-02 Thread Radu Cotescu
Hi, We solved 2 issues in these releases: https://issues.apache.org/jira/browse/SLING/fixforversion/12346551 https://issues.apache.org/jira/browse/SLING/fixforversion/12346559 https://issues.apache.org/jira/browse/SLING/fixforversion/12346560

Re: [VOTE] Release Apache Sling XSS Protection API 2.1.18

2019-12-02 Thread Andreas Schaefer
+1 (non-binding) - Andy > On Dec 2, 2019, at 8:03 AM, Radu Cotescu wrote: > > Hi, > > We solved 3 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12346531 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2162/ >

Re: [VOTE] Release Apache Sling Scripting JSP 2.4.0

2019-12-02 Thread Andreas Schaefer
+1 (non-binding) - Andy > On Dec 2, 2019, at 8:04 AM, Radu Cotescu wrote: > > Hi, > > We solved 1 issue in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12346563 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2164/ > >

[jira] [Resolved] (SLING-8592) Onboard content parser modules on SonarCloud

2019-12-02 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-8592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu resolved SLING-8592. - Resolution: Done > Onboard content parser modules on SonarCloud >

[jira] [Closed] (SLING-8592) Onboard content parser modules on SonarCloud

2019-12-02 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-8592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu closed SLING-8592. --- > Onboard content parser modules on SonarCloud > > >

Re: [VOTE] Release Apache Sling XSS Protection API 2.1.18

2019-12-02 Thread Nicolas Peltier
+1 Le lun. 2 déc. 2019 à 17:04, Radu Cotescu a écrit : > Hi, > > We solved 3 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12346531 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2162/ > > You can use this UNIX

Re: [VOTE] Release Apache Sling Scripting JSP 2.4.0

2019-12-02 Thread Nicolas Peltier
+1 Le lun. 2 déc. 2019 à 17:04, Radu Cotescu a écrit : > Hi, > > We solved 1 issue in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12346563 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2164/ > > You can use this UNIX

Re: [VOTE] Release Apache Sling HTL Maven Plugin 1.3.2-1.4.0, Apache Sling Scripting HTL Engine 1.3.0-1.4.0, Apache Sling Scripting HTL JS Use Provider 1.1.0, Apache Sling Scripting JavaScript 3.1.0,

2019-12-02 Thread Nicolas Peltier
+1 Le lun. 2 déc. 2019 à 17:13, Radu Cotescu a écrit : > Hi, > > We solved 2 issues in these releases: > https://issues.apache.org/jira/browse/SLING/fixforversion/12346551 > https://issues.apache.org/jira/browse/SLING/fixforversion/12346559 >

Re: [VOTE] Release Apache Sling JCR Resource Resolver 3.0.20

2019-12-02 Thread Daniel Klco
+1 On Mon, Dec 2, 2019 at 7:37 AM Nicolas Peltier wrote: > Hi, > > We solved 4 issues in this > release:https://issues.apache.org/jira/projects/SLING/versions/12345025 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2161/ > > You can use this UNIX

Re: [VOTE] Release Apache Sling XSS Protection API 2.1.18

2019-12-02 Thread Daniel Klco
+1 On Mon, Dec 2, 2019 at 11:28 AM Andreas Schaefer wrote: > +1 (non-binding) > > - Andy > > > On Dec 2, 2019, at 8:03 AM, Radu Cotescu wrote: > > > > Hi, > > > > We solved 3 issues in this release: > > https://issues.apache.org/jira/browse/SLING/fixforversion/12346531 > > > > Staging

Re: [VOTE] Release Apache Sling Scripting JSP 2.4.0

2019-12-02 Thread Daniel Klco
+1 On Mon, Dec 2, 2019 at 11:32 AM Andreas Schaefer wrote: > +1 (non-binding) > > - Andy > > > On Dec 2, 2019, at 8:04 AM, Radu Cotescu wrote: > > > > Hi, > > > > We solved 1 issue in this release: > > https://issues.apache.org/jira/browse/SLING/fixforversion/12346563 > > > > Staging

[jira] [Comment Edited] (SLING-8869) SimpleHttpDistributionTransport does not refresh the secret for token based implementations.

2019-12-02 Thread Mohit Arora (Jira)
[ https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985903#comment-16985903 ] Mohit Arora edited comment on SLING-8869 at 12/2/19 8:37 AM: - Attached a

[jira] [Commented] (SLING-8869) SimpleHttpDistributionTransport does not refresh the secret for token based implementations.

2019-12-02 Thread Mohit Arora (Jira)
[ https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985903#comment-16985903 ] Mohit Arora commented on SLING-8869: Attached a sample patch to resolve the issue.   cc -

[jira] [Updated] (SLING-8869) SimpleHttpDistributionTransport does not refresh the secret for token based implementations.

2019-12-02 Thread Mohit Arora (Jira)
[ https://issues.apache.org/jira/browse/SLING-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohit Arora updated SLING-8869: --- Attachment: SLING-8869.patch > SimpleHttpDistributionTransport does not refresh the secret for token

Re: can we squash unreleased history?

2019-12-02 Thread Radu Cotescu
Hello Nicolas, > On 2 Dec 2019, at 11:49, Nicolas Peltier wrote: > > Is it possible at all to squash the 3 commits related to SLING-8761 and > push --force them? > If there is any chance to mess things up a bit more, i'll just go ahead > with the release. > It’s too late to rewrite the

Re: can we squash unreleased history?

2019-12-02 Thread Bertrand Delacretaz
Hi Nicolas, On Mon, Dec 2, 2019 at 11:49 AM Nicolas Peltier wrote: > ...Is it possible at all to squash the 3 commits related to SLING-8761 and > push --force them?... Possible maybe (I don't know if the repository settings allow that) but desirable no, IMO. I think we should use force push

[jira] [Created] (SLING-8869) SimpleHttpDistributionTransport does not refresh the secret for token based implementations.

2019-12-02 Thread Mohit Arora (Jira)
Mohit Arora created SLING-8869: -- Summary: SimpleHttpDistributionTransport does not refresh the secret for token based implementations. Key: SLING-8869 URL: https://issues.apache.org/jira/browse/SLING-8869

can we squash unreleased history?

2019-12-02 Thread Nicolas Peltier
Hey am about to start a release process for jcr resource bundle, but in the resolution of a ticket i messed up in the history basically not squashing review commits [0], which kind of pollute it. Is it possible at all to squash the 3 commits related to SLING-8761 and push --force them? If there

[jira] [Comment Edited] (SLING-8868) DistributionPackage built using DistributionPackageBuilder.getPackage doesn't contain correct DIstributionPackageInfo

2019-12-02 Thread Ashish Chopra (Jira)
[ https://issues.apache.org/jira/browse/SLING-8868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985202#comment-16985202 ] Ashish Chopra edited comment on SLING-8868 at 12/2/19 10:30 AM: PR at

[jira] [Updated] (SLING-8867) Enhance the pageContext with the values provided by the SlingBindings

2019-12-02 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-8867: Description: SLING-8737 brought support for using lazily evaluated bindings. The JSP script

[jira] [Resolved] (SLING-8865) Enhance the HTL runtime and script engine to take advantage of the support for lazy bindings

2019-12-02 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-8865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu resolved SLING-8865. - Resolution: Fixed Implemented in: * [commit

Re: [apache/sling-org-apache-sling-scripting-jsp] SLING-8867 - Enhance the pageContext with the values provided by the SlingBindings (#3)

2019-12-02 Thread Bertrand Delacretaz
On Fri, Nov 29, 2019 at 4:39 PM Radu Cotescu wrote: > > wrapped the default PageContext in order to be able to provide the JSP > scripts with bindings entries, through the pageContext... I think it would be good to add a brief comment to SlingJspPageContext, to explain why it's here and mention

[VOTE] Release Apache Sling JCR Resource Resolver 3.0.20

2019-12-02 Thread Nicolas Peltier
Hi, We solved 4 issues in this release:https://issues.apache.org/jira/projects/SLING/versions/12345025 Staging repository:https://repository.apache.org/content/repositories/orgapachesling-2161/ You can use this UNIX script to download the release and verify the

[GitHub] [sling-org-apache-sling-scripting-javascript] raducotescu merged pull request #1: SLING-8865 - Enhance the HTL runtime and script engine to take advantage of the support for lazy bindings

2019-12-02 Thread GitBox
raducotescu merged pull request #1: SLING-8865 - Enhance the HTL runtime and script engine to take advantage of the support for lazy bindings URL: https://github.com/apache/sling-org-apache-sling-scripting-javascript/pull/1

[jira] [Created] (SLING-8870) The number of errors per jar should be reported

2019-12-02 Thread Robert Munteanu (Jira)
Robert Munteanu created SLING-8870: -- Summary: The number of errors per jar should be reported Key: SLING-8870 URL: https://issues.apache.org/jira/browse/SLING-8870 Project: Sling Issue

[GitHub] [sling-org-apache-sling-scripting-sightly-js-provider] raducotescu merged pull request #1: SLING-8865 - Enhance the HTL runtime and script engine to take advantage of the support for lazy bin

2019-12-02 Thread GitBox
raducotescu merged pull request #1: SLING-8865 - Enhance the HTL runtime and script engine to take advantage of the support for lazy bindings URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-js-provider/pull/1

Re: can we squash unreleased history?

2019-12-02 Thread Nicolas Peltier
ok, thanks guys! Le lun. 2 déc. 2019 à 12:00, Bertrand Delacretaz a écrit : > Hi Nicolas, > > On Mon, Dec 2, 2019 at 11:49 AM Nicolas Peltier > wrote: > > ...Is it possible at all to squash the 3 commits related to SLING-8761 > and > > push --force them?... > > Possible maybe (I don't know if

[jira] [Resolved] (SLING-8870) The number of errors per jar should be reported

2019-12-02 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-8870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-8870. Resolution: Fixed Fixed with [sling-slingfeature-maven-plugin commit

Re: [apache/sling-org-apache-sling-scripting-jsp] SLING-8867 - Enhance the pageContext with the values provided by the SlingBindings (#3)

2019-12-02 Thread Radu Cotescu
Hi Bertrand, > On 2 Dec 2019, at 12:54, Bertrand Delacretaz wrote: > > On Fri, Nov 29, 2019 at 4:39 PM Radu Cotescu wrote: >> >> wrapped the default PageContext in order to be able to provide the JSP >> scripts with bindings entries, through the pageContext... > > I think it would be good to

[jira] [Resolved] (SLING-8867) Enhance the pageContext with the values provided by the SlingBindings

2019-12-02 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu resolved SLING-8867. - Resolution: Fixed Implemented in [commit

[jira] [Resolved] (SLING-8860) Issue a warning when data-sly-test is passed a constant value for evaluation

2019-12-02 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-8860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu resolved SLING-8860. - Resolution: Fixed Implemented in [commit

[jira] [Assigned] (SLING-8075) Sling Upgrade Feature

2019-12-02 Thread Dan Klco (Jira)
[ https://issues.apache.org/jira/browse/SLING-8075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco reassigned SLING-8075: --- Assignee: Dan Klco (was: Dan Klco) > Sling Upgrade Feature > - > >

[jira] [Created] (SLING-8871) CMS - Upload Click Handler Registered Multiple Times

2019-12-02 Thread Dan Klco (Jira)
Dan Klco created SLING-8871: --- Summary: CMS - Upload Click Handler Registered Multiple Times Key: SLING-8871 URL: https://issues.apache.org/jira/browse/SLING-8871 Project: Sling Issue Type: Bug

[jira] [Created] (SLING-8872) CMS - Fails to Extract JPEG Metadata

2019-12-02 Thread Dan Klco (Jira)
Dan Klco created SLING-8872: --- Summary: CMS - Fails to Extract JPEG Metadata Key: SLING-8872 URL: https://issues.apache.org/jira/browse/SLING-8872 Project: Sling Issue Type: Bug Affects

[jira] [Resolved] (SLING-8872) CMS - Fails to Extract JPEG Metadata

2019-12-02 Thread Dan Klco (Jira)
[ https://issues.apache.org/jira/browse/SLING-8872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-8872. - Resolution: Fixed Fixed in:

[jira] [Created] (SLING-8873) Validate the sourceId property at build time

2019-12-02 Thread Robert Munteanu (Jira)
Robert Munteanu created SLING-8873: -- Summary: Validate the sourceId property at build time Key: SLING-8873 URL: https://issues.apache.org/jira/browse/SLING-8873 Project: Sling Issue Type:

[jira] [Commented] (SLING-8874) Support a manifest property that indicates alternate source artifacts

2019-12-02 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-8874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986103#comment-16986103 ] Robert Munteanu commented on SLING-8874: [~cziegeler] - WDYT? > Support a manifest property that

[jira] [Created] (SLING-8874) Support a manifest property that indicates alternate source artifacts

2019-12-02 Thread Robert Munteanu (Jira)
Robert Munteanu created SLING-8874: -- Summary: Support a manifest property that indicates alternate source artifacts Key: SLING-8874 URL: https://issues.apache.org/jira/browse/SLING-8874 Project:

[jira] [Updated] (SLING-7954) Switch from legacy commons collections 3 to commons collections 4

2019-12-02 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-7954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-7954: Fix Version/s: (was: Scripting JavaScript 3.0.6) Scripting JavaScript 3.1.2

[jira] [Resolved] (SLING-8871) CMS - Upload Click Handler Registered Multiple Times

2019-12-02 Thread Dan Klco (Jira)
[ https://issues.apache.org/jira/browse/SLING-8871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-8871. - Resolution: Fixed Fixed in 

Re: [VOTE] Release Apache Sling JCR Resource Resolver 3.0.20

2019-12-02 Thread Andreas Schaefer
+1 (non-binding) - Andy > On Dec 2, 2019, at 10:30 AM, Daniel Klco wrote: > > +1 > > On Mon, Dec 2, 2019 at 7:37 AM Nicolas Peltier wrote: > >> Hi, >> >> We solved 4 issues in this >> release:https://issues.apache.org/jira/projects/SLING/versions/12345025 >> >> Staging repository: >>

Re: [VOTE] Release Apache Sling HTL Maven Plugin 1.3.2-1.4.0, Apache Sling Scripting HTL Engine 1.3.0-1.4.0, Apache Sling Scripting HTL JS Use Provider 1.1.0, Apache Sling Scripting JavaScript 3.1.0,

2019-12-02 Thread Daniel Klco
+1 On Mon, Dec 2, 2019 at 11:57 AM Andreas Schaefer wrote: > +1 (non-binding) > > - Andy > > > On Dec 2, 2019, at 8:07 AM, Radu Cotescu wrote: > > > > Hi, > > > > We solved 2 issues in these releases: > > https://issues.apache.org/jira/browse/SLING/fixforversion/12346551 > >