[GitHub] [sling-org-apache-sling-graphql-core] etugarev commented on a change in pull request #1: Feature/sling 9550 all scalars

2020-06-30 Thread GitBox
etugarev commented on a change in pull request #1: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/1#discussion_r447483580 ## File path: src/test/java/org/apache/sling/graphql/core/mocks/URLScalarConverter.java ## @@ -41,4 +41,14 @@ final

[GitHub] [sling-org-apache-sling-graphql-core] etugarev commented on a change in pull request #1: Feature/sling 9550 all scalars

2020-06-30 Thread GitBox
etugarev commented on a change in pull request #1: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/1#discussion_r447126408 ## File path: src/main/java/org/apache/sling/graphql/core/scalars/SlingScalarsProvider.java ## @@ -46,55 +49,17 @@

[GitHub] [sling-org-apache-sling-graphql-core] bdelacretaz commented on pull request #1: Feature/sling 9550 all scalars

2020-06-30 Thread GitBox
bdelacretaz commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/1#issuecomment-651638364 We used to have a similar design for the SlingDataFetcher initially, with a single OSGi provider service which provided multiple data fetchers.

[GitHub] [sling-org-apache-sling-graphql-core] bdelacretaz edited a comment on pull request #1: Feature/sling 9550 all scalars

2020-06-30 Thread GitBox
bdelacretaz edited a comment on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/1#issuecomment-651638364 We used to have a similar design for the SlingDataFetcher initially, with a single OSGi provider service which provided multiple data fetchers.

RE: Exposing generic XML as Sling resource

2020-06-30 Thread Stefan Seifert
fsresource is using the contentparser-api as well (although in a slightly older version which was not split up in api+impl at that time). in fact i started the contentparser implementation to have a common codebase for parsing JSON and XML-style content data in both fsresource and sling mocks.

Re: Exposing generic XML as Sling resource

2020-06-30 Thread Bertrand Delacretaz
Hi Julian, On Mon, Jun 29, 2020 at 6:37 PM Julian Reschke wrote: > ...I was pointed > to ... I don't know these modules very well but I think https://github.com/apache/sling-org-apache-sling-contentparser-api is a more generic XML (or

[GitHub] [sling-org-apache-sling-graphql-core] stefangrimm commented on pull request #1: Feature/sling 9550 all scalars

2020-06-30 Thread GitBox
stefangrimm commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/1#issuecomment-651733264 @bdelacretaz We need something like the suggested alternative to decouple what we're implementing on AEM's side from the Sling Core implementation.

[GitHub] [sling-org-apache-sling-graphql-core] etugarev commented on a change in pull request #1: Feature/sling 9550 all scalars

2020-06-30 Thread GitBox
etugarev commented on a change in pull request #1: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/1#discussion_r447483580 ## File path: src/test/java/org/apache/sling/graphql/core/mocks/URLScalarConverter.java ## @@ -41,4 +41,14 @@ final

[jira] [Comment Edited] (SLING-9031) Support OR logic for run mode support

2020-06-30 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-9031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144912#comment-17144912 ] Konrad Windszus edited comment on SLING-9031 at 6/30/20, 11:33 AM: ---

[jira] [Commented] (SLING-9031) Support OR logic for run mode support

2020-06-30 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-9031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148565#comment-17148565 ] Konrad Windszus commented on SLING-9031: First part merged in

[GitHub] [sling-org-apache-sling-settings] kwin merged pull request #1: SLING-9031 SLING-8548 helper method to check active run modes against

2020-06-30 Thread GitBox
kwin merged pull request #1: URL: https://github.com/apache/sling-org-apache-sling-settings/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [sling-org-apache-sling-settings] sonarcloud[bot] commented on pull request #1: SLING-9031 SLING-8548 helper method to check active run modes against

2020-06-30 Thread GitBox
sonarcloud[bot] commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-settings/pull/1#issuecomment-651734508 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-settings=1=false=BUG)

[jira] [Commented] (SLING-7772) add other scripting options for pipe expressions

2020-06-30 Thread Nicolas Peltier (Jira)
[ https://issues.apache.org/jira/browse/SLING-7772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148665#comment-17148665 ] Nicolas Peltier commented on SLING-7772: ho [~bdelacretaz] just saw your comment, so yeah, using

[jira] [Updated] (SLING-9547) markdown renderer for pipe configurations

2020-06-30 Thread Nicolas Peltier (Jira)
[ https://issues.apache.org/jira/browse/SLING-9547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-9547: --- Affects Version/s: (was: Pipes 4.0.0) > markdown renderer for pipe configurations >

[jira] [Updated] (SLING-9547) markdown renderer for pipe configurations

2020-06-30 Thread Nicolas Peltier (Jira)
[ https://issues.apache.org/jira/browse/SLING-9547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-9547: --- Fix Version/s: Pipes 4.0.0 > markdown renderer for pipe configurations >

[jira] [Created] (SLING-9559) Provide agent state via DistributionIdle

2020-06-30 Thread Christian Schneider (Jira)
Christian Schneider created SLING-9559: -- Summary: Provide agent state via DistributionIdle Key: SLING-9559 URL: https://issues.apache.org/jira/browse/SLING-9559 Project: Sling Issue

[jira] [Updated] (SLING-9561) Settings: Switch to DS 1.4 and component properties

2020-06-30 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-9561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-9561: --- Component/s: General > Settings: Switch to DS 1.4 and component properties >

[jira] [Created] (SLING-9561) Settings: Switch to DS 1.4 and component properties

2020-06-30 Thread Konrad Windszus (Jira)
Konrad Windszus created SLING-9561: -- Summary: Settings: Switch to DS 1.4 and component properties Key: SLING-9561 URL: https://issues.apache.org/jira/browse/SLING-9561 Project: Sling Issue

[GitHub] [sling-org-apache-sling-graphql-core] stefangrimm commented on pull request #1: Feature/sling 9550 all scalars

2020-06-30 Thread GitBox
stefangrimm commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/1#issuecomment-651853634 I will see if I can come up with something along the existing implementation and check if it really works (biggest problem I see is that we can't

[jira] [Assigned] (SLING-7772) add other scripting options for pipe expressions

2020-06-30 Thread Nicolas Peltier (Jira)
[ https://issues.apache.org/jira/browse/SLING-7772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier reassigned SLING-7772: -- Assignee: Nicolas Peltier > add other scripting options for pipe expressions >

[jira] [Created] (SLING-9560) Configure BookKeeper via a BookKeeperConfig class

2020-06-30 Thread Christian Schneider (Jira)
Christian Schneider created SLING-9560: -- Summary: Configure BookKeeper via a BookKeeperConfig class Key: SLING-9560 URL: https://issues.apache.org/jira/browse/SLING-9560 Project: Sling

[GitHub] [sling-org-apache-sling-api] kwin merged pull request #22: SLING-9555 add constants for values of property "resource.change.types"

2020-06-30 Thread GitBox
kwin merged pull request #22: URL: https://github.com/apache/sling-org-apache-sling-api/pull/22 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [sling-org-apache-sling-api] sonarcloud[bot] removed a comment on pull request #22: SLING-9555 add constants for values of property "resource.change.types"

2020-06-30 Thread GitBox
sonarcloud[bot] removed a comment on pull request #22: URL: https://github.com/apache/sling-org-apache-sling-api/pull/22#issuecomment-651091510 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api=22=false=BUG)

[GitHub] [sling-org-apache-sling-api] sonarcloud[bot] commented on pull request #22: SLING-9555 add constants for values of property "resource.change.types"

2020-06-30 Thread GitBox
sonarcloud[bot] commented on pull request #22: URL: https://github.com/apache/sling-org-apache-sling-api/pull/22#issuecomment-651818824 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api=22=false=BUG)

kickstart-maven-plugin vs feature-launcher-maven-plugin (was: [VOTE] Release Apache Sling Feature Launcher Maven Plugin 0.1.0)

2020-06-30 Thread Robert Munteanu
Hi Andy, I started a discussion at [1] regarding why I think a new plugin is preferrable, even though we have the slingfeature and kickstart plugins. I believe that the kickstart tooling is 'batteries-included' and suitable for Sling applications, while the feature-launcher plugin is usable also

[GitHub] [sling-org-apache-sling-graphql-core] bdelacretaz commented on pull request #1: Feature/sling 9550 all scalars

2020-06-30 Thread GitBox
bdelacretaz commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/1#issuecomment-651796659 Let me know if the previous comment makes sense in your context, if you need me to provide an example of the wrappers that I mentioned, or if smaller

[GitHub] [sling-org-apache-sling-graphql-core] bdelacretaz commented on pull request #1: Feature/sling 9550 all scalars

2020-06-30 Thread GitBox
bdelacretaz commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/1#issuecomment-651796131 > I guess we could register multiple instance of the same SlingScalarConverter-implementing wrapper component (one for each scalar) manually within

[jira] [Resolved] (SLING-9555) Define ResourceChange.ChangeType also as constant string values

2020-06-30 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-9555. Resolution: Fixed > Define ResourceChange.ChangeType also as constant string values >

[jira] [Commented] (SLING-9555) Define ResourceChange.ChangeType also as constant string values

2020-06-30 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148714#comment-17148714 ] Konrad Windszus commented on SLING-9555: Fixed in

[GitHub] [sling-org-apache-sling-graphql-core] stefangrimm commented on pull request #1: Feature/sling 9550 all scalars

2020-06-30 Thread GitBox
stefangrimm commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/1#issuecomment-651771074 Also, in addition to my previous comment: IMHO scalars should not be defined globally, but per endpoint. Typically, they are part of the

[jira] [Resolved] (SLING-7772) add other scripting options for pipe expressions

2020-06-30 Thread Nicolas Peltier (Jira)
[ https://issues.apache.org/jira/browse/SLING-7772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-7772. Fix Version/s: Pipes 3.2.0 Resolution: Fixed fixed in

[jira] [Updated] (SLING-9561) Settings: Switch to DS 1.4 and component properties

2020-06-30 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-9561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-9561: --- Description: Currently SlingSettings is still relying on manual registration of services and

[jira] [Assigned] (SLING-9561) Settings: Switch to DS 1.4 and component properties

2020-06-30 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-9561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-9561: -- Assignee: Konrad Windszus > Settings: Switch to DS 1.4 and component properties >

Re: kickstart-maven-plugin vs feature-launcher-maven-plugin (was: [VOTE] Release Apache Sling Feature Launcher Maven Plugin 0.1.0)

2020-06-30 Thread Andreas Schaefer
Hi Robert > On Jun 30, 2020, at 5:41 AM, Robert Munteanu wrote: > > Hi Andy, > > I started a discussion at [1] regarding why I think a new plugin is > preferrable, even though we have the slingfeature and kickstart > plugins. > > I believe that the kickstart tooling is 'batteries-included'

[GitHub] [sling-whiteboard] sonarcloud[bot] commented on pull request #62: Saml2 auth handler/upgrade sling12 open samlv4 java11

2020-06-30 Thread GitBox
sonarcloud[bot] commented on pull request #62: URL: https://github.com/apache/sling-whiteboard/pull/62#issuecomment-652013724 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=BUG)

[GitHub] [sling-whiteboard] sonarcloud[bot] removed a comment on pull request #62: Saml2 auth handler/upgrade sling12 open samlv4 java11

2020-06-30 Thread GitBox
sonarcloud[bot] removed a comment on pull request #62: URL: https://github.com/apache/sling-whiteboard/pull/62#issuecomment-650422235 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=BUG)