[GitHub] bcsott opened a new pull request #1: SLING-7241 Fix SciptEngineManager

2017-11-14 Thread GitBox
bcsott opened a new pull request #1: SLING-7241 Fix SciptEngineManager URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/1 Using this constructor instead of the empty one will return Nashorn engine even if not attached to system bundle. Detail & how to repoduce issue see

[GitHub] rombert opened a new pull request #1: Fix converting latest Sling Starter app

2017-11-28 Thread GitBox
rombert opened a new pull request #1: Fix converting latest Sling Starter app URL: https://github.com/apache/sling-whiteboard/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] cziegeler closed pull request #2: Fix ArtifactId.toMvnId to be symmetrical with fromMvnId

2017-11-28 Thread GitBox
cziegeler closed pull request #2: Fix ArtifactId.toMvnId to be symmetrical with fromMvnId URL: https://github.com/apache/sling-whiteboard/pull/2 This is an automated message from the Apache Git Service. To respond to the

[GitHub] rombert opened a new pull request #2: Fix ArtifactId.toMvnId to be symmetrical with fromMvnId

2017-11-28 Thread GitBox
rombert opened a new pull request #2: Fix ArtifactId.toMvnId to be symmetrical with fromMvnId URL: https://github.com/apache/sling-whiteboard/pull/2 The fromMvnId method expects the values in the `groupId:artifactId[:packaging[:classifier]]:version` format, but toMvnId was outputting

[GitHub] cziegeler closed pull request #1: Fix converting latest Sling Starter app

2017-11-28 Thread GitBox
cziegeler closed pull request #1: Fix converting latest Sling Starter app URL: https://github.com/apache/sling-whiteboard/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] npeltier closed pull request #1: SLING-7241 Fix SciptEngineManager

2017-11-24 Thread GitBox
npeltier closed pull request #1: SLING-7241 Fix SciptEngineManager URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/1 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] bcsott opened a new pull request #2: SLING-7241 ScriptEngine Initialization & Cleanup

2017-11-24 Thread GitBox
bcsott opened a new pull request #2: SLING-7241 ScriptEngine Initialization & Cleanup URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/2 Separated the ScriptEngine initialisation (L251) Sort methods This

[GitHub] npeltier closed pull request #2: SLING-7241 ScriptEngine Initialization & Cleanup

2017-11-27 Thread GitBox
npeltier closed pull request #2: SLING-7241 ScriptEngine Initialization & Cleanup URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/2 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] karlpauls commented on a change in pull request #1: SLING-7134 - Script execution order is not deterministic on Java 9

2017-12-04 Thread GitBox
karlpauls commented on a change in pull request #1: SLING-7134 - Script execution order is not deterministic on Java 9 URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/1#discussion_r154778051 ## File path:

[GitHub] karlpauls commented on a change in pull request #1: SLING-7134 - Script execution order is not deterministic on Java 9

2017-12-04 Thread GitBox
karlpauls commented on a change in pull request #1: SLING-7134 - Script execution order is not deterministic on Java 9 URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/1#discussion_r154778051 ## File path:

[GitHub] karlpauls commented on a change in pull request #1: SLING-7134 - Script execution order is not deterministic on Java 9

2017-12-04 Thread GitBox
karlpauls commented on a change in pull request #1: SLING-7134 - Script execution order is not deterministic on Java 9 URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/1#discussion_r154778051 ## File path:

[GitHub] karlpauls commented on issue #1: SLING-7134 - Script execution order is not deterministic on Java 9

2017-12-04 Thread GitBox
karlpauls commented on issue #1: SLING-7134 - Script execution order is not deterministic on Java 9 URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/1#issuecomment-349126870 I just pushed an update with my proposals mentioned in the above comments namely,

[GitHub] karlpauls commented on issue #1: SLING-7134 - Script execution order is not deterministic on Java 9

2017-12-04 Thread GitBox
karlpauls commented on issue #1: SLING-7134 - Script execution order is not deterministic on Java 9 URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/1#issuecomment-349126870 I just pushed an update with my proposals mentioned in the above comments namely,

[GitHub] karlpauls commented on a change in pull request #1: SLING-7134 - Script execution order is not deterministic on Java 9

2017-12-04 Thread GitBox
karlpauls commented on a change in pull request #1: SLING-7134 - Script execution order is not deterministic on Java 9 URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/1#discussion_r154792623 ## File path:

[GitHub] kwin closed pull request #1: SLING-7299 do not always attach built artifact

2017-12-13 Thread GitBox
kwin closed pull request #1: SLING-7299 do not always attach built artifact URL: https://github.com/apache/sling-slingstart-maven-plugin/pull/1 This is an automated message from the Apache Git Service. To respond to the

[GitHub] kwin closed pull request #2: SLING-7302 consider the project's artifact itself for the

2017-12-13 Thread GitBox
kwin closed pull request #2: SLING-7302 consider the project's artifact itself for the URL: https://github.com/apache/sling-slingstart-maven-plugin/pull/2 This is an automated message from the Apache Git Service. To respond

[GitHub] jsedding commented on a change in pull request #1: SLING-7313 refresh the resource type resolver as well

2017-12-18 Thread GitBox
jsedding commented on a change in pull request #1: SLING-7313 refresh the resource type resolver as well URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/1#discussion_r157258185 ## File path:

[GitHub] jsedding commented on a change in pull request #1: SLING-7313 refresh the resource type resolver as well

2017-12-18 Thread GitBox
jsedding commented on a change in pull request #1: SLING-7313 refresh the resource type resolver as well URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/1#discussion_r157257991 ## File path:

[GitHub] rombert commented on issue #1: SLING-7308 - Sling 9 Compatibility

2017-12-14 Thread GitBox
rombert commented on issue #1: SLING-7308 - Sling 9 Compatibility URL: https://github.com/apache/sling-samples/pull/1#issuecomment-351702010 Thanks for the fix, @auniverseaway ! This is an automated message from the Apache

[GitHub] justinedelson closed pull request #2: SLING-7307 - remove embedded BeanUtils

2017-12-13 Thread GitBox
justinedelson closed pull request #2: SLING-7307 - remove embedded BeanUtils URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/2 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] kwin opened a new pull request #1: SLING-7313 refresh the resource type resolver as well

2017-12-14 Thread GitBox
kwin opened a new pull request #1: SLING-7313 refresh the resource type resolver as well URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/1 This is an automated message from the Apache Git

[GitHub] kwin commented on a change in pull request #1: SLING-7313 refresh the resource type resolver as well

2017-12-18 Thread GitBox
kwin commented on a change in pull request #1: SLING-7313 refresh the resource type resolver as well URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/1#discussion_r157487797 ## File path:

[GitHub] kwin commented on a change in pull request #1: SLING-7313 refresh the resource type resolver as well

2017-12-18 Thread GitBox
kwin commented on a change in pull request #1: SLING-7313 refresh the resource type resolver as well URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/1#discussion_r157487858 ## File path:

[GitHub] kwin commented on issue #1: SLING-7313 refresh the resource type resolver as well

2017-12-18 Thread GitBox
kwin commented on issue #1: SLING-7313 refresh the resource type resolver as well URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/1#issuecomment-352504439 @jsedding Please check again. The only thing I am not sure about is concurrency here. May this context be

[GitHub] kwin commented on a change in pull request #1: SLING-7299 do not always attach built artifact

2017-12-15 Thread GitBox
kwin commented on a change in pull request #1: SLING-7299 do not always attach built artifact URL: https://github.com/apache/sling-slingstart-maven-plugin/pull/1#discussion_r157144904 ## File path: src/main/java/org/apache/sling/maven/slingstart/PackageMojo.java ## @@

[GitHub] raducotescu commented on a change in pull request #1: SLING-7299 do not always attach built artifact

2017-12-15 Thread GitBox
raducotescu commented on a change in pull request #1: SLING-7299 do not always attach built artifact URL: https://github.com/apache/sling-slingstart-maven-plugin/pull/1#discussion_r157144422 ## File path: src/main/java/org/apache/sling/maven/slingstart/PackageMojo.java ##

[GitHub] auniverseaway opened a new pull request #1: SLING-7308 - Sling 9 Compatibility

2017-12-13 Thread GitBox
auniverseaway opened a new pull request #1: SLING-7308 - Sling 9 Compatibility URL: https://github.com/apache/sling-samples/pull/1 It appears initial content loader has changed in Sling 9 which caused this sample to break HTL rendering. Resolves: SLING-7308

[GitHub] chetanmeh closed pull request #1: SLING-3049 - Make Logback Stacktrace Packaging data support OSGi aware

2017-11-20 Thread GitBox
chetanmeh closed pull request #1: SLING-3049 - Make Logback Stacktrace Packaging data support OSGi aware URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/1 This is an automated message from the Apache

[GitHub] chetanmeh commented on issue #1: SLING-3049 - Make Logback Stacktrace Packaging data support OSGi aware

2017-11-20 Thread GitBox
chetanmeh commented on issue #1: SLING-3049 - Make Logback Stacktrace Packaging data support OSGi aware URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/1#issuecomment-345706219 Changes merged to master via rebase

[GitHub] karlpauls closed pull request #1: SLING-7232: Add the http.bridge bundle to the webapp

2017-11-21 Thread GitBox
karlpauls closed pull request #1: SLING-7232: Add the http.bridge bundle to the webapp URL: https://github.com/apache/sling-org-apache-sling-starter/pull/1 This is an automated message from the Apache Git Service. To

[GitHub] karlpauls closed pull request #1: SLING-7186: Improve java9 system package handling

2017-11-13 Thread GitBox
karlpauls closed pull request #1: SLING-7186: Improve java9 system package handling URL: https://github.com/apache/sling-org-apache-sling-launchpad-base/pull/1 This is an automated message from the Apache Git Service. To

[GitHub] karlpauls closed pull request #2: SLING-7232: Remove the http.bridge bundle from the webapp base

2017-11-13 Thread GitBox
karlpauls closed pull request #2: SLING-7232: Remove the http.bridge bundle from the webapp base URL: https://github.com/apache/sling-org-apache-sling-launchpad-base/pull/2 This is an automated message from the Apache Git

[GitHub] karlpauls opened a new pull request #1: SLING-7186: Improve java9 system package handling

2017-11-07 Thread GitBox
karlpauls opened a new pull request #1: SLING-7186: Improve java9 system package handling URL: https://github.com/apache/sling-org-apache-sling-launchpad-base/pull/1 Update to the latest felix framework snapshot and work in changes to use the new java9 support.

[GitHub] karlpauls opened a new pull request #1: SLING-7046: Add --add-modules java.se.ee to the testing when running ?

2017-11-09 Thread GitBox
karlpauls opened a new pull request #1: SLING-7046: Add --add-modules java.se.ee to the testing when running ? URL: https://github.com/apache/sling-org-apache-sling-launchpad-testing/pull/1 ?on java9 This is an automated

[GitHub] karlpauls opened a new pull request #1: SLING-7232: Add the http.bridge bundle to the webapp

2017-11-09 Thread GitBox
karlpauls opened a new pull request #1: SLING-7232: Add the http.bridge bundle to the webapp URL: https://github.com/apache/sling-org-apache-sling-starter/pull/1 This is an automated message from the Apache Git Service. To

[GitHub] karlpauls opened a new pull request #2: SLING-7232: Remove the http.bridge bundle from the webapp base

2017-11-09 Thread GitBox
karlpauls opened a new pull request #2: SLING-7232: Remove the http.bridge bundle from the webapp base URL: https://github.com/apache/sling-org-apache-sling-launchpad-base/pull/2 This is an automated message from the Apache

[GitHub] mreutegg opened a new pull request #1: SLING-7233: MockConfigurationAdmin ignores configuration PID

2017-11-08 Thread GitBox
mreutegg opened a new pull request #1: SLING-7233: MockConfigurationAdmin ignores configuration PID URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/1 This is an automated message from the Apache

[GitHub] stefanseifert closed pull request #1: SLING-7233: MockConfigurationAdmin ignores configuration PID

2017-11-08 Thread GitBox
stefanseifert closed pull request #1: SLING-7233: MockConfigurationAdmin ignores configuration PID URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/1 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed

[GitHub] kwin commented on a change in pull request #1: SLING-5668 - Leverage ServletRequestListener.requestDestroyed for cal?

2017-12-07 Thread GitBox
kwin commented on a change in pull request #1: SLING-5668 - Leverage ServletRequestListener.requestDestroyed for cal? URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/1#discussion_r155650246 ## File path:

[GitHub] justinedelson commented on issue #1: SLING-5668 - Leverage ServletRequestListener.requestDestroyed for cal?

2017-12-07 Thread GitBox
justinedelson commented on issue #1: SLING-5668 - Leverage ServletRequestListener.requestDestroyed for cal? URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/1#issuecomment-350119997 I've made the requested changes.

[GitHub] justinedelson closed pull request #1: SLING-5668 - Leverage ServletRequestListener.requestDestroyed for cal?

2017-12-08 Thread GitBox
justinedelson closed pull request #1: SLING-5668 - Leverage ServletRequestListener.requestDestroyed for cal? URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/1 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed

[GitHub] kwin commented on a change in pull request #1: SLING-5668 - Leverage ServletRequestListener.requestDestroyed for cal?

2017-12-07 Thread GitBox
kwin commented on a change in pull request #1: SLING-5668 - Leverage ServletRequestListener.requestDestroyed for cal? URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/1#discussion_r155639654 ## File path:

[GitHub] kwin commented on a change in pull request #1: SLING-5668 - Leverage ServletRequestListener.requestDestroyed for cal?

2017-12-07 Thread GitBox
kwin commented on a change in pull request #1: SLING-5668 - Leverage ServletRequestListener.requestDestroyed for cal? URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/1#discussion_r155640522 ## File path:

[GitHub] kwin commented on a change in pull request #1: SLING-7194 AdapterManager sorts AdapterFactory implementations lowest ranking first

2017-12-07 Thread GitBox
kwin commented on a change in pull request #1: SLING-7194 AdapterManager sorts AdapterFactory implementations lowest ranking first URL: https://github.com/apache/sling-org-apache-sling-adapter/pull/1#discussion_r155640841 ## File path:

[GitHub] justinedelson commented on issue #1: SLING-5668 - Leverage ServletRequestListener.requestDestroyed for cal?

2017-12-07 Thread GitBox
justinedelson commented on issue #1: SLING-5668 - Leverage ServletRequestListener.requestDestroyed for cal? URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/1#issuecomment-350094660 An IT is a good idea, although I'm not sure how to do it since the request would be

[GitHub] justinedelson commented on a change in pull request #1: SLING-5668 - Leverage ServletRequestListener.requestDestroyed for cal?

2017-12-07 Thread GitBox
justinedelson commented on a change in pull request #1: SLING-5668 - Leverage ServletRequestListener.requestDestroyed for cal? URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/1#discussion_r155641644 ## File path:

[GitHub] kwin commented on a change in pull request #1: SLING-5668 - Leverage ServletRequestListener.requestDestroyed for cal?

2017-12-07 Thread GitBox
kwin commented on a change in pull request #1: SLING-5668 - Leverage ServletRequestListener.requestDestroyed for cal? URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/1#discussion_r155643099 ## File path:

[GitHub] justinedelson commented on a change in pull request #1: SLING-5668 - Leverage ServletRequestListener.requestDestroyed for cal?

2017-12-07 Thread GitBox
justinedelson commented on a change in pull request #1: SLING-5668 - Leverage ServletRequestListener.requestDestroyed for cal? URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/1#discussion_r155643426 ## File path:

[GitHub] justinedelson commented on a change in pull request #1: SLING-5668 - Leverage ServletRequestListener.requestDestroyed for cal?

2017-12-07 Thread GitBox
justinedelson commented on a change in pull request #1: SLING-5668 - Leverage ServletRequestListener.requestDestroyed for cal? URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/1#discussion_r155646620 ## File path:

[GitHub] karlpauls commented on a change in pull request #1: SLING-7134 - Script execution order is not deterministic on Java 9

2017-12-04 Thread GitBox
karlpauls commented on a change in pull request #1: SLING-7134 - Script execution order is not deterministic on Java 9 URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/1#discussion_r154648012 ## File path:

[GitHub] karlpauls commented on a change in pull request #1: SLING-7134 - Script execution order is not deterministic on Java 9

2017-12-04 Thread GitBox
karlpauls commented on a change in pull request #1: SLING-7134 - Script execution order is not deterministic on Java 9 URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/1#discussion_r154648472 ## File path:

[GitHub] raducotescu commented on a change in pull request #1: SLING-7134 - Script execution order is not deterministic on Java 9

2017-12-04 Thread GitBox
raducotescu commented on a change in pull request #1: SLING-7134 - Script execution order is not deterministic on Java 9 URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/1#discussion_r154671227 ## File path:

[GitHub] raducotescu commented on a change in pull request #1: SLING-7134 - Script execution order is not deterministic on Java 9

2017-12-04 Thread GitBox
raducotescu commented on a change in pull request #1: SLING-7134 - Script execution order is not deterministic on Java 9 URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/1#discussion_r154671227 ## File path:

[GitHub] santiagozky opened a new pull request #1: SLING-7289 remove validator from ValidatorMap

2017-12-07 Thread GitBox
santiagozky opened a new pull request #1: SLING-7289 remove validator from ValidatorMap URL: https://github.com/apache/sling-org-apache-sling-validation-core/pull/1 This is an automated message from the Apache Git Service.

[GitHub] kwin closed pull request #1: SLING-7289 remove validator from ValidatorMap

2017-12-07 Thread GitBox
kwin closed pull request #1: SLING-7289 remove validator from ValidatorMap URL: https://github.com/apache/sling-org-apache-sling-validation-core/pull/1 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] stefanseifert opened a new pull request #1: SLING-7194 AdapterManager sorts AdapterFactory implementations lowest ranking first

2017-12-07 Thread GitBox
stefanseifert opened a new pull request #1: SLING-7194 AdapterManager sorts AdapterFactory implementations lowest ranking first URL: https://github.com/apache/sling-org-apache-sling-adapter/pull/1 This is an automated

[GitHub] justinedelson opened a new pull request #1: SLING-5668 - Leverage ServletRequestListener.requestDestroyed for cal?

2017-12-07 Thread GitBox
justinedelson opened a new pull request #1: SLING-5668 - Leverage ServletRequestListener.requestDestroyed for cal? URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/1 ?ling DisposalCallback in case the model was created from a request

[GitHub] kwin commented on a change in pull request #1: SLING-7194 AdapterManager sorts AdapterFactory implementations lowest ranking first

2017-12-07 Thread GitBox
kwin commented on a change in pull request #1: SLING-7194 AdapterManager sorts AdapterFactory implementations lowest ranking first URL: https://github.com/apache/sling-org-apache-sling-adapter/pull/1#discussion_r155612447 ## File path:

[GitHub] stefanseifert commented on a change in pull request #1: SLING-7194 AdapterManager sorts AdapterFactory implementations lowest ranking first

2017-12-07 Thread GitBox
stefanseifert commented on a change in pull request #1: SLING-7194 AdapterManager sorts AdapterFactory implementations lowest ranking first URL: https://github.com/apache/sling-org-apache-sling-adapter/pull/1#discussion_r155625674 ## File path:

[GitHub] rombert closed pull request #1: SLING-7046: Add --add-modules java.se.ee to the testing when running ?

2017-12-06 Thread GitBox
rombert closed pull request #1: SLING-7046: Add --add-modules java.se.ee to the testing when running ? URL: https://github.com/apache/sling-org-apache-sling-launchpad-testing/pull/1 This is an automated message from the

[GitHub] karlpauls closed pull request #1: SLING-7134 - Script execution order is not deterministic on Java 9

2017-12-05 Thread GitBox
karlpauls closed pull request #1: SLING-7134 - Script execution order is not deterministic on Java 9 URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/1 This is an automated message from the Apache

[GitHub] kwin closed pull request #2: SLING-7298 get rid of pax-exam for the IT

2017-12-09 Thread GitBox
kwin closed pull request #2: SLING-7298 get rid of pax-exam for the IT URL: https://github.com/apache/sling-org-apache-sling-validation-core/pull/2 This is an automated message from the Apache Git Service. To respond to the

[GitHub] kwin opened a new pull request #1: SLING-7299 do not always attach built artifact

2017-12-09 Thread GitBox
kwin opened a new pull request #1: SLING-7299 do not always attach built artifact URL: https://github.com/apache/sling-slingstart-maven-plugin/pull/1 introduce new parameter "attachArtifact" (default=true) to allow to prevent attaching artifacts (only in case packaging != slingstart)

[GitHub] kwin opened a new pull request #2: SLING-7298 get rid of pax-exam for the IT

2017-12-09 Thread GitBox
kwin opened a new pull request #2: SLING-7298 get rid of pax-exam for the IT URL: https://github.com/apache/sling-org-apache-sling-validation-core/pull/2 instead rely on a slightly modified Sling Launchpad, built and started with slingstart-maven-plugin.

[GitHub] kwin opened a new pull request #2: SLING-7302 consider the project's artifact itself for the

2017-12-10 Thread GitBox
kwin opened a new pull request #2: SLING-7302 consider the project's artifact itself for the URL: https://github.com/apache/sling-slingstart-maven-plugin/pull/2 PomArtifactVersionResolver add some test cases and extend javadoc

[GitHub] stefanseifert closed pull request #1: SLING-7194 AdapterManager sorts AdapterFactory implementations lowest ranking first

2017-12-12 Thread GitBox
stefanseifert closed pull request #1: SLING-7194 AdapterManager sorts AdapterFactory implementations lowest ranking first URL: https://github.com/apache/sling-org-apache-sling-adapter/pull/1 This is an automated message

[GitHub] stefanseifert commented on issue #1: SLING-7194 AdapterManager sorts AdapterFactory implementations lowest ranking first

2017-12-12 Thread GitBox
stefanseifert commented on issue #1: SLING-7194 AdapterManager sorts AdapterFactory implementations lowest ranking first URL: https://github.com/apache/sling-org-apache-sling-adapter/pull/1#issuecomment-351035335 this PR is obsolete - as discussed in SLING-7194 we do not change the

[GitHub] justinedelson opened a new pull request #2: SLING-7307 - remove embedded BeanUtils

2017-12-12 Thread GitBox
justinedelson opened a new pull request #2: SLING-7307 - remove embedded BeanUtils URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/2 This is an automated message from the Apache Git Service. To

[GitHub] raducotescu opened a new pull request #1: SLING-7134 - Script execution order is not deterministic on Java 9

2017-12-03 Thread GitBox
raducotescu opened a new pull request #1: SLING-7134 - Script execution order is not deterministic on Java 9 URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/1 * reimplemented the former o.a.s.scripting.core.impl.ScriptEngineManagerFactory,

[GitHub] kwin commented on a change in pull request #1: SLING-7134 - Script execution order is not deterministic on Java 9

2017-12-03 Thread GitBox
kwin commented on a change in pull request #1: SLING-7134 - Script execution order is not deterministic on Java 9 URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/1#discussion_r154532013 ## File path:

[GitHub] raducotescu commented on a change in pull request #1: SLING-7134 - Script execution order is not deterministic on Java 9

2017-12-03 Thread GitBox
raducotescu commented on a change in pull request #1: SLING-7134 - Script execution order is not deterministic on Java 9 URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/1#discussion_r154532142 ## File path:

[GitHub] trekawek closed pull request #2: Fix OSGi package export version

2018-05-07 Thread GitBox
trekawek closed pull request #2: Fix OSGi package export version URL: https://github.com/apache/sling-org-apache-sling-query/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] trekawek commented on issue #2: Fix OSGi package export version

2018-05-07 Thread GitBox
trekawek commented on issue #2: Fix OSGi package export version URL: https://github.com/apache/sling-org-apache-sling-query/pull/2#issuecomment-387048403 OK, so the `impl` package is treated in a special way. Cool, thanks for this!

[GitHub] DominikSuess opened a new pull request #7: SLING-7544 - fixing potential race between intialization and addition…

2018-05-04 Thread GitBox
DominikSuess opened a new pull request #7: SLING-7544 - fixing potential race between intialization and addition… URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/7 … of updated aliases This is an

[GitHub] dulvac opened a new pull request #3: SLING-7669 StartupManager overwrites the frameworkstartlevel property…

2018-05-15 Thread GitBox
dulvac opened a new pull request #3: SLING-7669 StartupManager overwrites the frameworkstartlevel property… URL: https://github.com/apache/sling-org-apache-sling-launchpad-base/pull/3 … and there is no way to retrieve the intended target start level

[GitHub] chetanmeh commented on a change in pull request #3: SLING-7669 StartupManager overwrites the frameworkstartlevel property…

2018-05-17 Thread GitBox
chetanmeh commented on a change in pull request #3: SLING-7669 StartupManager overwrites the frameworkstartlevel property… URL: https://github.com/apache/sling-org-apache-sling-launchpad-base/pull/3#discussion_r189160190 ## File path:

[GitHub] chetanmeh commented on a change in pull request #3: SLING-7669 StartupManager overwrites the frameworkstartlevel property…

2018-05-17 Thread GitBox
chetanmeh commented on a change in pull request #3: SLING-7669 StartupManager overwrites the frameworkstartlevel property… URL: https://github.com/apache/sling-org-apache-sling-launchpad-base/pull/3#discussion_r189160079 ## File path:

[GitHub] LukeGrover opened a new pull request #3: SLING-7673 - Add null check for transformerConfiguration

2018-05-17 Thread GitBox
LukeGrover opened a new pull request #3: SLING-7673 - Add null check for transformerConfiguration URL: https://github.com/apache/sling-org-apache-sling-rewriter/pull/3 **Jira Ticket:** https://issues.apache.org/jira/browse/SLING-7673 **Issue:** transformerConfiguration

[GitHub] rombert commented on issue #3: SLING-7673 - Add null check for transformerConfiguration

2018-05-17 Thread GitBox
rombert commented on issue #3: SLING-7673 - Add null check for transformerConfiguration URL: https://github.com/apache/sling-org-apache-sling-rewriter/pull/3#issuecomment-389821419 Looks good to me, thanks for the contribution @LukeGrover !

[GitHub] rombert closed pull request #3: SLING-7673 - Add null check for transformerConfiguration

2018-05-17 Thread GitBox
rombert closed pull request #3: SLING-7673 - Add null check for transformerConfiguration URL: https://github.com/apache/sling-org-apache-sling-rewriter/pull/3 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] paul-bjorkstrand commented on issue #6: SLING-7586 - using weak references as cache values to avoid memory leak

2018-05-23 Thread GitBox
paul-bjorkstrand commented on issue #6: SLING-7586 - using weak references as cache values to avoid memory leak URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/6#issuecomment-391569488 Not sure if this is the best approach. If the leak is related to the

[GitHub] rombert commented on issue #1: trivial - Fix Json Writer for extensions

2018-05-23 Thread GitBox
rombert commented on issue #1: trivial - Fix Json Writer for extensions URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/1#issuecomment-391318189 Thanks for the PR @andreituicu . It would be great to get a Jira issue and a test, as this impacts the runtime behaviour.

[GitHub] andreituicu opened a new pull request #1: trivial - Fix Json Writer for extensions

2018-05-23 Thread GitBox
andreituicu opened a new pull request #1: trivial - Fix Json Writer for extensions URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/1 This is an automated message from the Apache Git Service. To respond

[GitHub] bosschaert closed pull request #1: SLING-7677 - FeatureJSONWriter uses isOptional instead of isRequired

2018-05-24 Thread GitBox
bosschaert closed pull request #1: SLING-7677 - FeatureJSONWriter uses isOptional instead of isRequired URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/1 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[GitHub] bosschaert commented on issue #1: SLING-7677 - FeatureJSONWriter uses isOptional instead of isRequired

2018-05-24 Thread GitBox
bosschaert commented on issue #1: SLING-7677 - FeatureJSONWriter uses isOptional instead of isRequired URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/1#issuecomment-391633367 Thanks for your contribution, JIRA and tests @andreituicu ! I've applied your changes.

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox
rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190517370 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox
rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190518625 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox
rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190518810 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox
rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190518767 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox
rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190520244 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox
rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190523798 ## File path: oidc-handler/ui/src/main/resources/SLING-INF/content/login/login.html ## @@ -0,0 +1,56 @@ +

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox
rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190521759 ## File path: oidc-handler/core/src/main/java/org/apache/sling/oidchandler/core/SimpleDSComponent.java ## @@

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox
rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190518465 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox
rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190524124 ## File path: oidc-handler/ui/src/main/resources/SLING-INF/scripts/html.esp ## @@ -0,0 +1,37 @@ + Review

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox
rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190524060 ## File path: oidc-handler/ui/src/main/resources/SLING-INF/nodetypes/nodetypes.cnd ## @@ -0,0 +1,32 @@ +//

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox
rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190518251 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox
rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190520984 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox
rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190518736 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox
rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190520925 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

2018-05-24 Thread GitBox
rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190518177 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0;

  1   2   3   4   5   6   7   8   9   10   >