[GitHub] [sling-parent] kwin merged pull request #15: SLING-10160 generate source-release.zip for both parent poms

2021-02-25 Thread GitBox
kwin merged pull request #15: URL: https://github.com/apache/sling-parent/pull/15 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [sling-org-apache-sling-feature-launcher] stbischof opened a new pull request #16: remove duplicat arg line

2021-02-25 Thread GitBox
stbischof opened a new pull request #16: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/16 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] commented on pull request #16: remove duplicat arg line

2021-02-25 Thread GitBox
sonarcloud[bot] commented on pull request #16: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/16#issuecomment-786463185 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher&pullRe

[GitHub] [sling-org-apache-sling-resourceresolver] kwin commented on a change in pull request #42: SLING-10167 Ensure only valid absolute paths (not ending with "/") are used in JCR queries for loadin

2021-02-26 Thread GitBox
kwin commented on a change in pull request #42: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/42#discussion_r583485646 ## File path: src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverFactoryActivator.java ## @@ -313,10 +314,11

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls opened a new pull request #60: SLING-10172: read GAV from pom.xml and escape artifactid

2021-02-26 Thread GitBox
karlpauls opened a new pull request #60: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/60 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #60: SLING-10172: read GAV from pom.xml and escape artifactid

2021-02-26 Thread GitBox
sonarcloud[bot] commented on pull request #60: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/60#issuecomment-786732527 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #60: SLING-10172: read GAV from pom.xml and escape artifactid

2021-02-26 Thread GitBox
sonarcloud[bot] removed a comment on pull request #60: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/60#issuecomment-786732527 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpco

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #60: SLING-10172: read GAV from pom.xml and escape artifactid

2021-02-26 Thread GitBox
sonarcloud[bot] commented on pull request #60: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/60#issuecomment-786733268 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls merged pull request #60: SLING-10172: read GAV from pom.xml and escape artifactid

2021-02-26 Thread GitBox
karlpauls merged pull request #60: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/60 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [sling-org-apache-sling-resourceresolver] stefanseifert commented on a change in pull request #42: SLING-10167 Ensure only valid absolute paths (not ending with "/") are used in JCR queries f

2021-02-26 Thread GitBox
stefanseifert commented on a change in pull request #42: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/42#discussion_r583785384 ## File path: src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java ## @@ -1036,8 +1037,9 @@ pr

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #42: SLING-10167 Ensure only valid absolute paths (not ending with "/") are used in JCR queries for loading

2021-02-26 Thread GitBox
sonarcloud[bot] commented on pull request #42: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/42#issuecomment-786773654 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRe

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] removed a comment on pull request #42: SLING-10167 Ensure only valid absolute paths (not ending with "/") are used in JCR queries for

2021-02-26 Thread GitBox
sonarcloud[bot] removed a comment on pull request #42: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/42#issuecomment-786129481 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolve

[GitHub] [sling-org-apache-sling-feature-launcher] stbischof opened a new pull request #17: enhance cli parsing

2021-02-26 Thread GitBox
stbischof opened a new pull request #17: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/17 - extract opts as Constants - add longOpt to Options - fix plural in description - use Builder-pattern to build Options - set numberOfArgs , valueSeparator(',')

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] commented on pull request #17: enhance cli parsing

2021-02-26 Thread GitBox
sonarcloud[bot] commented on pull request #17: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/17#issuecomment-786893300 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher&pullRequest=1

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] commented on pull request #17: enhance cli parsing

2021-02-26 Thread GitBox
sonarcloud[bot] commented on pull request #17: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/17#issuecomment-786936741 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher&pullRe

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] removed a comment on pull request #17: enhance cli parsing

2021-02-26 Thread GitBox
sonarcloud[bot] removed a comment on pull request #17: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/17#issuecomment-786893300 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher&pullR

[GitHub] [sling-org-apache-sling-feature-launcher] stbischof opened a new pull request #18: Provide a Dockerfile

2021-02-27 Thread GitBox
stbischof opened a new pull request #18: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18 image is able to delegates all launcher cli-options using env example (podman way): ``` buildah bud -t sling-launcher:1.1.17-snapshot podman run -it --r

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] commented on pull request #18: Provide a Dockerfile

2021-02-27 Thread GitBox
sonarcloud[bot] commented on pull request #18: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18#issuecomment-787065214 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher&pullRe

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] commented on pull request #17: enhance cli parsing

2021-02-27 Thread GitBox
sonarcloud[bot] commented on pull request #17: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/17#issuecomment-787067758 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher&pullRe

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] removed a comment on pull request #17: enhance cli parsing

2021-02-27 Thread GitBox
sonarcloud[bot] removed a comment on pull request #17: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/17#issuecomment-786936741 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launche

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] commented on pull request #17: enhance cli parsing

2021-02-27 Thread GitBox
sonarcloud[bot] commented on pull request #17: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/17#issuecomment-787068656 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher&pullRe

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] removed a comment on pull request #17: enhance cli parsing

2021-02-27 Thread GitBox
sonarcloud[bot] removed a comment on pull request #17: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/17#issuecomment-787067758 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launche

[GitHub] [sling-org-apache-sling-scripting-sightly] sonarcloud[bot] removed a comment on pull request #10: SLING-4443 - Whitespace removal for Sightly HTML output

2021-02-27 Thread GitBox
sonarcloud[bot] removed a comment on pull request #10: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/10#issuecomment-782862152 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sigh

[GitHub] [sling-org-apache-sling-scripting-sightly] sonarcloud[bot] commented on pull request #10: SLING-4443 - Whitespace removal for Sightly HTML output

2021-02-27 Thread GitBox
sonarcloud[bot] commented on pull request #10: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/10#issuecomment-787221559 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly&pull

[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] removed a comment on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…

2021-02-27 Thread GitBox
sonarcloud[bot] removed a comment on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-785061460 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullR

[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…

2021-02-27 Thread GitBox
sonarcloud[bot] commented on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-787221668 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] commented on pull request #6: SLING-10155 add configuration to include or exclude specific ScriptEngineFactory

2021-02-27 Thread GitBox
sonarcloud[bot] commented on pull request #6: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/6#issuecomment-787221699 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] removed a comment on pull request #6: SLING-10155 add configuration to include or exclude specific ScriptEngineFactory

2021-02-27 Thread GitBox
sonarcloud[bot] removed a comment on pull request #6: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/6#issuecomment-785454293 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] removed a comment on pull request #5: SLING-10147 scripting variables implementation details are exposed to not authorized users

2021-02-27 Thread GitBox
sonarcloud[bot] removed a comment on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/5#issuecomment-785062804 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pull

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] commented on pull request #5: SLING-10147 scripting variables implementation details are exposed to not authorized users

2021-02-27 Thread GitBox
sonarcloud[bot] commented on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/5#issuecomment-787221951 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] removed a comment on pull request #7: SLING-10147 block unauthorized access to SlingBindingsVariablesListJsonServlet

2021-02-27 Thread GitBox
sonarcloud[bot] removed a comment on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/7#issuecomment-785361742 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pull

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] commented on pull request #7: SLING-10147 block unauthorized access to SlingBindingsVariablesListJsonServlet

2021-02-27 Thread GitBox
sonarcloud[bot] commented on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/7#issuecomment-787222080 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=

[GitHub] [sling-org-apache-sling-resourcemerger] jsedding commented on a change in pull request #4: SLING-10150 improve handling of multivalue hides

2021-02-28 Thread GitBox
jsedding commented on a change in pull request #4: URL: https://github.com/apache/sling-org-apache-sling-resourcemerger/pull/4#discussion_r583546499 ## File path: src/main/java/org/apache/sling/resourcemerger/impl/HideItemPredicate.java ## @@ -0,0 +1,92 @@ +/* + * Licensed to

[GitHub] [sling-org-apache-sling-servlets-post] rombert commented on pull request #12: SLING-10169: Enabling servlet.post.autoCheckout breaks POST requests when one of the ancestor nodes is not access

2021-03-01 Thread GitBox
rombert commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/12#issuecomment-787989430 @joerghoh - you recently touched this area, what's your take on the change? This is an

[GitHub] [sling-org-apache-sling-auth-core] anchela opened a new pull request #7: SLING-10164 : Add basic metrics to SlingAuthenticator

2021-03-02 Thread GitBox
anchela opened a new pull request #7: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/7 (initial proposal with minimal testing) This is an automated message from the Apache Git Service. To respond to the

[GitHub] [sling-org-apache-sling-auth-core] anchela commented on pull request #7: SLING-10164 : Add basic metrics to SlingAuthenticator

2021-03-02 Thread GitBox
anchela commented on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/7#issuecomment-788798595 @cziegeler , compared to the original draft attached in jira, i slightly modified the metric names (dropping org.apache) and also added some very limited tes

[GitHub] [sling-org-apache-sling-auth-core] sonarcloud[bot] commented on pull request #7: SLING-10164 : Add basic metrics to SlingAuthenticator

2021-03-02 Thread GitBox
sonarcloud[bot] commented on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/7#issuecomment-788799329 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=7&resolved

[GitHub] [sling-org-apache-sling-resourceresolver] stefanseifert merged pull request #42: SLING-10167 Ensure only valid absolute paths (not ending with "/") are used in JCR queries for loading existin

2021-03-02 Thread GitBox
stefanseifert merged pull request #42: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/42 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [sling-org-apache-sling-engine] npeltier opened a new pull request #13: SLING-10179 better handling of doFilter misusage

2021-03-02 Thread GitBox
npeltier opened a new pull request #13: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/13 - in case doFilter is called more than once by a custom filter, an explicit IllegalStateException will be thrown, instead of an ArrayIndexOutOfBoundsException, - added unit test

[GitHub] [sling-org-apache-sling-engine] sonarcloud[bot] commented on pull request #13: SLING-10179 better handling of doFilter misusage

2021-03-02 Thread GitBox
sonarcloud[bot] commented on pull request #13: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/13#issuecomment-789031531 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=13&resolved=fa

[GitHub] [sling-site] npeltier opened a new pull request #56: SLING-10179 update Filter doc

2021-03-02 Thread GitBox
npeltier opened a new pull request #56: URL: https://github.com/apache/sling-site/pull/56 - states the necessity of calling doFilter one and only once, - adds exception that would happen otherwise This is an automated mess

[GitHub] [sling-org-apache-sling-engine] npeltier merged pull request #13: SLING-10179 better handling of doFilter misusage

2021-03-02 Thread GitBox
npeltier merged pull request #13: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/13 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [sling-whiteboard] cmrockwell opened a new pull request #70: Sling 9397/improve test coverage

2021-03-02 Thread GitBox
cmrockwell opened a new pull request #70: URL: https://github.com/apache/sling-whiteboard/pull/70 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [sling-whiteboard] cmrockwell merged pull request #70: Sling 9397/improve test coverage

2021-03-02 Thread GitBox
cmrockwell merged pull request #70: URL: https://github.com/apache/sling-whiteboard/pull/70 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [sling-whiteboard] sonarcloud[bot] commented on pull request #70: Sling 9397/improve test coverage

2021-03-02 Thread GitBox
sonarcloud[bot] commented on pull request #70: URL: https://github.com/apache/sling-whiteboard/pull/70#issuecomment-789266394 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard&pullRequest=70&resolved=false&types=BUG) [](https://

[GitHub] [sling-whiteboard] sonarcloud[bot] commented on pull request #69: Sling 9397/update removed saml config service

2021-03-02 Thread GitBox
sonarcloud[bot] commented on pull request #69: URL: https://github.com/apache/sling-whiteboard/pull/69#issuecomment-789267105 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard&pullRequest=69&resolved=false&types=BUG) [](https://sonarcl

[GitHub] [sling-whiteboard] sonarcloud[bot] removed a comment on pull request #69: Sling 9397/update removed saml config service

2021-03-02 Thread GitBox
sonarcloud[bot] removed a comment on pull request #69: URL: https://github.com/apache/sling-whiteboard/pull/69#issuecomment-782549342 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard&pullRequest=69&resolved=false&types=BUG) [](https:/

[GitHub] [sling-site] npeltier merged pull request #56: SLING-10179 update Filter doc

2021-03-03 Thread GitBox
npeltier merged pull request #56: URL: https://github.com/apache/sling-site/pull/56 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] removed a comment on pull request #12: SLING-10169: Enabling servlet.post.autoCheckout breaks POST requests when one of the ancestor nod

2021-03-03 Thread GitBox
sonarcloud[bot] removed a comment on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/12#issuecomment-786364570 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pull

[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] commented on pull request #12: SLING-10169: Enabling servlet.post.autoCheckout breaks POST requests when one of the ancestor nodes is no

2021-03-03 Thread GitBox
sonarcloud[bot] commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/12#issuecomment-789698737 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=

[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] commented on pull request #11: SLING-10087 convert more persistenceexceptions

2021-03-03 Thread GitBox
sonarcloud[bot] commented on pull request #11: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/11#issuecomment-789699262 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&reso

[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] removed a comment on pull request #11: SLING-10087 convert more persistenceexceptions

2021-03-03 Thread GitBox
sonarcloud[bot] removed a comment on pull request #11: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/11#issuecomment-785059124 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest

[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] removed a comment on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…

2021-03-03 Thread GitBox
sonarcloud[bot] removed a comment on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-787221668 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullR

[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…

2021-03-03 Thread GitBox
sonarcloud[bot] commented on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-789701754 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] removed a comment on pull request #5: SLING-10147 scripting variables implementation details are exposed to not authorized users

2021-03-03 Thread GitBox
sonarcloud[bot] removed a comment on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/5#issuecomment-787221951 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pull

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] commented on pull request #5: SLING-10147 scripting variables implementation details are exposed to not authorized users

2021-03-03 Thread GitBox
sonarcloud[bot] commented on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/5#issuecomment-789703132 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=

[GitHub] [sling-org-apache-sling-models-impl] henrykuijpers commented on pull request #17: SLING-8706 - Injections for java.util.Optional<> should be automatically optional

2021-03-03 Thread GitBox
henrykuijpers commented on pull request #17: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/17#issuecomment-789796687 Is anything still needed to merge this in, @justinedelson ? This is an automated m

[GitHub] [sling-org-apache-sling-models-impl] henrykuijpers commented on pull request #11: SLING-8069: allow non public constructors

2021-03-03 Thread GitBox
henrykuijpers commented on pull request #11: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/11#issuecomment-789797395 It would be really nice to have this, @justinedelson . Can this be merged in? It would prevent our developers from instantiating Sling Models by cal

[GitHub] [sling-org-apache-sling-servlets-post] joerghoh commented on pull request #12: SLING-10169: Enabling servlet.post.autoCheckout breaks POST requests when one of the ancestor nodes is not acces

2021-03-03 Thread GitBox
joerghoh commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/12#issuecomment-790023513 makes sense from my point of view. This is an automated message from the Apache Git S

[GitHub] [sling-org-apache-sling-feature-inventoryprinter] stbischof opened a new pull request #3: fix url to felix-dev

2021-03-03 Thread GitBox
stbischof opened a new pull request #3: URL: https://github.com/apache/sling-org-apache-sling-feature-inventoryprinter/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [sling-org-apache-sling-feature-inventoryprinter] sonarcloud[bot] commented on pull request #3: fix url to felix-dev

2021-03-03 Thread GitBox
sonarcloud[bot] commented on pull request #3: URL: https://github.com/apache/sling-org-apache-sling-feature-inventoryprinter/pull/3#issuecomment-790353565 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-inventory

[GitHub] [sling-org-apache-sling-feature-inventoryprinter] rombert merged pull request #3: fix url to felix-dev

2021-03-04 Thread GitBox
rombert merged pull request #3: URL: https://github.com/apache/sling-org-apache-sling-feature-inventoryprinter/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [sling-org-apache-sling-feature-inventoryprinter] rombert commented on pull request #3: fix url to felix-dev

2021-03-04 Thread GitBox
rombert commented on pull request #3: URL: https://github.com/apache/sling-org-apache-sling-feature-inventoryprinter/pull/3#issuecomment-790452310 Thanks for the fix @stbischof ! This is an automated message from the Apache

[GitHub] [sling-org-apache-sling-servlets-post] rombert merged pull request #12: SLING-10169: Enabling servlet.post.autoCheckout breaks POST requests when one of the ancestor nodes is not accessible

2021-03-04 Thread GitBox
rombert merged pull request #12: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/12 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [sling-org-apache-sling-servlets-post] rombert commented on pull request #12: SLING-10169: Enabling servlet.post.autoCheckout breaks POST requests when one of the ancestor nodes is not access

2021-03-04 Thread GitBox
rombert commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/12#issuecomment-790503117 Thanks for the review @joerghoh and for the contribuition @sdumitriu ! This is an auto

[GitHub] [sling-org-apache-sling-scripting-bundle-tracker-it] raducotescu merged pull request #1: SLING-10012 precompiled tempates test

2021-03-04 Thread GitBox
raducotescu merged pull request #1: URL: https://github.com/apache/sling-org-apache-sling-scripting-bundle-tracker-it/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [sling-org-apache-sling-scripting-bundle-tracker-it] sonarcloud[bot] commented on pull request #1: SLING-10012 precompiled tempates test

2021-03-04 Thread GitBox
sonarcloud[bot] commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-scripting-bundle-tracker-it/pull/1#issuecomment-790673279 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-bund

[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] removed a comment on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…

2021-03-04 Thread GitBox
sonarcloud[bot] removed a comment on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-789701754 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullR

[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…

2021-03-04 Thread GitBox
sonarcloud[bot] commented on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-790865953 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7

[GitHub] [sling-org-apache-sling-jcr-repoinit] enapps-enorman opened a new pull request #13: SLING-10192 Add option to set/edit properties on users and groups

2021-03-05 Thread GitBox
enapps-enorman opened a new pull request #13: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/13 For: [SLING-10192](https://issues.apache.org/jira/browse/SLING-10192) Use Case: repoinit should be able to set properties on users and groups that were just create

[GitHub] [sling-org-apache-sling-jcr-repoinit] sonarcloud[bot] commented on pull request #13: SLING-10192 Add option to set/edit properties on users and groups

2021-03-05 Thread GitBox
sonarcloud[bot] commented on pull request #13: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/13#issuecomment-791574228 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-repoinit&pullRequest=13

[GitHub] [sling-whiteboard] cmrockwell opened a new pull request #71: Sling 9397/improve test coverage

2021-03-06 Thread GitBox
cmrockwell opened a new pull request #71: URL: https://github.com/apache/sling-whiteboard/pull/71 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [sling-whiteboard] cmrockwell closed pull request #71: Sling 9397/improve test coverage

2021-03-06 Thread GitBox
cmrockwell closed pull request #71: URL: https://github.com/apache/sling-whiteboard/pull/71 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [sling-whiteboard] sonarcloud[bot] removed a comment on pull request #69: Sling 9397/update removed saml config service

2021-03-06 Thread GitBox
sonarcloud[bot] removed a comment on pull request #69: URL: https://github.com/apache/sling-whiteboard/pull/69#issuecomment-789267105 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard&pullRequest=69&resolved=false&types=BUG) [](https:/

[GitHub] [sling-whiteboard] sonarcloud[bot] commented on pull request #69: Sling 9397/update removed saml config service

2021-03-06 Thread GitBox
sonarcloud[bot] commented on pull request #69: URL: https://github.com/apache/sling-whiteboard/pull/69#issuecomment-792227349 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard&pullRequest=69&resolved=false&types=BUG) [](https://sonarcl

[GitHub] [sling-whiteboard] sonarcloud[bot] removed a comment on pull request #69: Sling 9397/update removed saml config service

2021-03-07 Thread GitBox
sonarcloud[bot] removed a comment on pull request #69: URL: https://github.com/apache/sling-whiteboard/pull/69#issuecomment-792227349 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard&pullRequest=69&resolved=false&types=BUG) [](https:/

[GitHub] [sling-whiteboard] sonarcloud[bot] commented on pull request #69: Sling 9397/update removed saml config service

2021-03-07 Thread GitBox
sonarcloud[bot] commented on pull request #69: URL: https://github.com/apache/sling-whiteboard/pull/69#issuecomment-792322990 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard&pullRequest=69&resolved=false&types=BUG) [](https://sonarcl

[GitHub] [sling-whiteboard] sonarcloud[bot] removed a comment on pull request #69: Sling 9397/update removed saml config service

2021-03-07 Thread GitBox
sonarcloud[bot] removed a comment on pull request #69: URL: https://github.com/apache/sling-whiteboard/pull/69#issuecomment-792322990 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard&pullRequest=69&resolved=false&types=BUG) [](https:/

[GitHub] [sling-whiteboard] sonarcloud[bot] commented on pull request #69: Sling 9397/update removed saml config service

2021-03-07 Thread GitBox
sonarcloud[bot] commented on pull request #69: URL: https://github.com/apache/sling-whiteboard/pull/69#issuecomment-792335533 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard&pullRequest=69&resolved=false&types=BUG) [](https://sonarcl

[GitHub] [sling-whiteboard] sonarcloud[bot] commented on pull request #69: Sling 9397/update removed saml config service

2021-03-07 Thread GitBox
sonarcloud[bot] commented on pull request #69: URL: https://github.com/apache/sling-whiteboard/pull/69#issuecomment-792336217 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard&pullRequest=69&resolved=false&types=BUG) [](https://sonarcl

[GitHub] [sling-whiteboard] sonarcloud[bot] removed a comment on pull request #69: Sling 9397/update removed saml config service

2021-03-07 Thread GitBox
sonarcloud[bot] removed a comment on pull request #69: URL: https://github.com/apache/sling-whiteboard/pull/69#issuecomment-792335533 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard&pullRequest=69&resolved=false&types=BUG) [](https:/

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] commented on pull request #6: SLING-10155 add configuration to include or exclude specific ScriptEngineFactory

2021-03-07 Thread GitBox
sonarcloud[bot] commented on pull request #6: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/6#issuecomment-792336503 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] removed a comment on pull request #6: SLING-10155 add configuration to include or exclude specific ScriptEngineFactory

2021-03-07 Thread GitBox
sonarcloud[bot] removed a comment on pull request #6: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/6#issuecomment-787221699 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pull

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] removed a comment on pull request #7: SLING-10147 block unauthorized access to SlingBindingsVariablesListJsonServlet

2021-03-07 Thread GitBox
sonarcloud[bot] removed a comment on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/7#issuecomment-787222080 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pull

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] commented on pull request #7: SLING-10147 block unauthorized access to SlingBindingsVariablesListJsonServlet

2021-03-07 Thread GitBox
sonarcloud[bot] commented on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/7#issuecomment-792336653 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] removed a comment on pull request #5: SLING-10147 scripting variables implementation details are exposed to not authorized users

2021-03-07 Thread GitBox
sonarcloud[bot] removed a comment on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/5#issuecomment-789703132 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pull

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] commented on pull request #5: SLING-10147 scripting variables implementation details are exposed to not authorized users

2021-03-07 Thread GitBox
sonarcloud[bot] commented on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/5#issuecomment-792336824 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=

[GitHub] [sling-whiteboard] sonarcloud[bot] commented on pull request #69: Sling 9397/update removed saml config service

2021-03-07 Thread GitBox
sonarcloud[bot] commented on pull request #69: URL: https://github.com/apache/sling-whiteboard/pull/69#issuecomment-792340617 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard&pullRequest=69&resolved=false&types=BUG) [](https://sonarcl

[GitHub] [sling-whiteboard] sonarcloud[bot] removed a comment on pull request #69: Sling 9397/update removed saml config service

2021-03-07 Thread GitBox
sonarcloud[bot] removed a comment on pull request #69: URL: https://github.com/apache/sling-whiteboard/pull/69#issuecomment-792336217 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard&pullRequest=69&resolved=false&types=BUG) [](https:/

[GitHub] [sling-org-apache-sling-resourcemerger] henrykuijpers commented on a change in pull request #3: SLING-10150 - sling:hideChildren incorrectly hiding parent of parent, when asterisk is used in

2021-03-08 Thread GitBox
henrykuijpers commented on a change in pull request #3: URL: https://github.com/apache/sling-org-apache-sling-resourcemerger/pull/3#discussion_r589268139 ## File path: src/main/java/org/apache/sling/resourcemerger/impl/MergingResourceProvider.java ## @@ -110,17 +110,14 @@ pub

[GitHub] [sling-org-apache-sling-resourcemerger] kwin commented on a change in pull request #3: SLING-10150 - sling:hideChildren incorrectly hiding parent of parent, when asterisk is used in combinati

2021-03-08 Thread GitBox
kwin commented on a change in pull request #3: URL: https://github.com/apache/sling-org-apache-sling-resourcemerger/pull/3#discussion_r589297188 ## File path: src/main/java/org/apache/sling/resourcemerger/impl/MergingResourceProvider.java ## @@ -110,17 +110,14 @@ public Paren

[GitHub] [sling-org-apache-sling-testing-osgi-mock] stefanseifert merged pull request #6: Add test case to show volatile list reference having incorrect order

2021-03-08 Thread GitBox
stefanseifert merged pull request #6: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [sling-org-apache-sling-dynamic-include] santiagozky closed pull request #19: Extend the IncludeGenerator interface with the Sling Request

2021-03-08 Thread GitBox
santiagozky closed pull request #19: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/19 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [sling-org-apache-sling-dynamic-include] santiagozky commented on pull request #19: Extend the IncludeGenerator interface with the Sling Request

2021-03-08 Thread GitBox
santiagozky commented on pull request #19: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/19#issuecomment-792823558 sorry I never updated this. fell out of priority for me and havent have time to get around it. -

[GitHub] [sling-org-apache-sling-resourcemerger] kwin commented on pull request #4: SLING-10150 improve handling of multivalue hides

2021-03-08 Thread GitBox
kwin commented on pull request #4: URL: https://github.com/apache/sling-org-apache-sling-resourcemerger/pull/4#issuecomment-792889066 > Please integrate the added unit test of #3 as well. Done in https://github.com/apache/sling-org-apache-sling-resourcemerger/pull/4/commits/ab7a6795

[GitHub] [sling-org-apache-sling-dynamic-include] sonarcloud[bot] commented on pull request #19: Extend the IncludeGenerator interface with the Sling Request

2021-03-08 Thread GitBox
sonarcloud[bot] commented on pull request #19: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/19#issuecomment-792904228 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=19&

[GitHub] [sling-org-apache-sling-dynamic-include] sonarcloud[bot] removed a comment on pull request #19: Extend the IncludeGenerator interface with the Sling Request

2021-03-08 Thread GitBox
sonarcloud[bot] removed a comment on pull request #19: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/19#issuecomment-792904228 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullReq

[GitHub] [sling-org-apache-sling-dynamic-include] sonarcloud[bot] commented on pull request #19: Extend the IncludeGenerator interface with the Sling Request

2021-03-08 Thread GitBox
sonarcloud[bot] commented on pull request #19: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/19#issuecomment-792916447 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=19&

[GitHub] [sling-org-apache-sling-resourcemerger] kwin merged pull request #5: SLING-5469 add mixin for resource merger properties

2021-03-08 Thread GitBox
kwin merged pull request #5: URL: https://github.com/apache/sling-org-apache-sling-resourcemerger/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [sling-org-apache-sling-resourcemerger] kwin commented on a change in pull request #4: SLING-10150 improve handling of multivalue hides

2021-03-08 Thread GitBox
kwin commented on a change in pull request #4: URL: https://github.com/apache/sling-org-apache-sling-resourcemerger/pull/4#discussion_r589669041 ## File path: pom.xml ## @@ -130,5 +134,10 @@ 4.1 test + +org.slf4j +

  1   2   3   4   5   6   7   8   9   10   >