[jira] [Commented] (SLING-2883) proper encode properties - and filter anything like jcr:created...

2013-05-24 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13666251#comment-13666251
 ] 

Carsten Ziegeler commented on SLING-2883:
-

The resource implementation should already encode all illegal characters - the 
only exception I know is a slash. And if key should contain a : or maybe 
start with jcr:... - you never know what users are using

 proper encode properties - and filter anything like jcr:created...
 --

 Key: SLING-2883
 URL: https://issues.apache.org/jira/browse/SLING-2883
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Affects Versions: Discovery Impl 1.0.0
Reporter: Stefan Egli
Assignee: Stefan Egli

 properties provided by PropertyProviders in discovery.impl are currently 
 handed 1:1 as name (key) to jcr/repository. This will not work for special 
 characters. A proper encoding must be implemented.
 Similarly, any jcr name including ':' (eg 'jcr:created' etc) must not be 
 treated as a property and not be made visible to the users of the 
 discovery.api - the filter done as a hotfix in SLING-2880 is not sufficient.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (SLING-2883) proper encode properties - and filter anything like jcr:created...

2013-05-24 Thread Stefan Egli (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13666270#comment-13666270
 ] 

Stefan Egli commented on SLING-2883:


Good to know! I confirmed this: using a : gets properly encoded - a / 
though causes troubles. So we should deal with / in some way. Filtering 
jcr:created and jcr:createdBy (which are now newly showing up since it's 
now a sling:Folder since SLING-2879 - vs an nt:unstructured before) is not 
critical IMO.

 proper encode properties - and filter anything like jcr:created...
 --

 Key: SLING-2883
 URL: https://issues.apache.org/jira/browse/SLING-2883
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Affects Versions: Discovery Impl 1.0.0
Reporter: Stefan Egli
Assignee: Stefan Egli

 properties provided by PropertyProviders in discovery.impl are currently 
 handed 1:1 as name (key) to jcr/repository. This will not work for special 
 characters. A proper encoding must be implemented.
 Similarly, any jcr name including ':' (eg 'jcr:created' etc) must not be 
 treated as a property and not be made visible to the users of the 
 discovery.api - the filter done as a hotfix in SLING-2880 is not sufficient.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira