[jira] [Commented] (SLING-3558) Updating of sling:VanityPath mixins is ignored by sling resource resolution
[ https://issues.apache.org/jira/browse/SLING-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15575705#comment-15575705 ] Carsten Ziegeler commented on SLING-3558: - [~asanso] I think the handling of vanity paths is slightly broken in MapEntries. On initial startup, a query is performed, explicitely searching for resources with the mixin set and only those are used During runtime, the mixin is not checked at all anymore - so if a new node with the correct property - but without the mixin - is added, it gets picked up. Therefore after removal of the mixin, the vanity path is still used. I think we should change the implementation to use the vanitypath property on any resource regardless if the mixin is set, other resource providers don't have the concept of mixins > Updating of sling:VanityPath mixins is ignored by sling resource resolution > --- > > Key: SLING-3558 > URL: https://issues.apache.org/jira/browse/SLING-3558 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Reporter: Antonio Sanso >Priority: Critical > > Updating (adding/removing) of sling:VanityPath mixins is ignored by sling > resource resolution. The reason behind it is that the event handler in the > MapEntries doesn't listen for sling:VanityPath (mixin) but only for > sling:vanityPath (property name). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-3558) Updating of sling:VanityPath mixins is ignored by sling resource resolution
[ https://issues.apache.org/jira/browse/SLING-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15575701#comment-15575701 ] Carsten Ziegeler commented on SLING-3558: - I've enabled and adjusted the test in rev 1764935 > Updating of sling:VanityPath mixins is ignored by sling resource resolution > --- > > Key: SLING-3558 > URL: https://issues.apache.org/jira/browse/SLING-3558 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Reporter: Antonio Sanso >Priority: Critical > > Updating (adding/removing) of sling:VanityPath mixins is ignored by sling > resource resolution. The reason behind it is that the event handler in the > MapEntries doesn't listen for sling:VanityPath (mixin) but only for > sling:vanityPath (property name). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-3558) Updating of sling:VanityPath mixins is ignored by sling resource resolution
[ https://issues.apache.org/jira/browse/SLING-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360086#comment-14360086 ] Carsten Ziegeler commented on SLING-3558: - [~asanso] You mentioned that this is addresses with SLING-3505 above. So can this one be closed? > Updating of sling:VanityPath mixins is ignored by sling resource resolution > --- > > Key: SLING-3558 > URL: https://issues.apache.org/jira/browse/SLING-3558 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Reporter: Antonio Sanso >Priority: Critical > > Updating (adding/removing) of sling:VanityPath mixins is ignored by sling > resource resolution. The reason behind it is that the event handler in the > MapEntries doesn't listen for sling:VanityPath (mixin) but only for > sling:vanityPath (property name). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-3558) Updating of sling:VanityPath mixins is ignored by sling resource resolution
[ https://issues.apache.org/jira/browse/SLING-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997471#comment-13997471 ] Antonio Sanso commented on SLING-3558: -- why not :) ? If I remove a sling:VanityPath mixin from a node i would expect that that vanityPath is not anymore enabled. Unless I got a wrong understanding of the feature. BTW see also the test i commttied... > Updating of sling:VanityPath mixins is ignored by sling resource resolution > --- > > Key: SLING-3558 > URL: https://issues.apache.org/jira/browse/SLING-3558 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Reporter: Antonio Sanso >Priority: Critical > > Updating (adding/removing) of sling:VanityPath mixins is ignored by sling > resource resolution. The reason behind it is that the event handler in the > MapEntries doesn't listen for sling:VanityPath (mixin) but only for > sling:vanityPath (property name). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3558) Updating of sling:VanityPath mixins is ignored by sling resource resolution
[ https://issues.apache.org/jira/browse/SLING-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997539#comment-13997539 ] Justin Edelson commented on SLING-3558: --- OK. I get it now... The issue is specifically to removing the mixin. The reference to adding the mixin threw me off. I agree that removing the mixin should cause the vanity path to no longer be operative. > Updating of sling:VanityPath mixins is ignored by sling resource resolution > --- > > Key: SLING-3558 > URL: https://issues.apache.org/jira/browse/SLING-3558 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Reporter: Antonio Sanso >Priority: Critical > > Updating (adding/removing) of sling:VanityPath mixins is ignored by sling > resource resolution. The reason behind it is that the event handler in the > MapEntries doesn't listen for sling:VanityPath (mixin) but only for > sling:vanityPath (property name). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3558) Updating of sling:VanityPath mixins is ignored by sling resource resolution
[ https://issues.apache.org/jira/browse/SLING-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997470#comment-13997470 ] Justin Edelson commented on SLING-3558: --- Why is this a problem? > Updating of sling:VanityPath mixins is ignored by sling resource resolution > --- > > Key: SLING-3558 > URL: https://issues.apache.org/jira/browse/SLING-3558 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Reporter: Antonio Sanso >Priority: Critical > > Updating (adding/removing) of sling:VanityPath mixins is ignored by sling > resource resolution. The reason behind it is that the event handler in the > MapEntries doesn't listen for sling:VanityPath (mixin) but only for > sling:vanityPath (property name). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3558) Updating of sling:VanityPath mixins is ignored by sling resource resolution
[ https://issues.apache.org/jira/browse/SLING-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997338#comment-13997338 ] Antonio Sanso commented on SLING-3558: -- added showcase test in rev. 1594485 . This issue will be address together with SLING-3505 > Updating of sling:VanityPath mixins is ignored by sling resource resolution > --- > > Key: SLING-3558 > URL: https://issues.apache.org/jira/browse/SLING-3558 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Reporter: Antonio Sanso >Priority: Critical > > Updating (adding/removing) of sling:VanityPath mixins is ignored by sling > resource resolution. The reason behind it is that the event handler in the > MapEntries doesn't listen for sling:VanityPath (mixin) but only for > sling:vanityPath (property name). -- This message was sent by Atlassian JIRA (v6.2#6252)
