[jira] [Commented] (SLING-5932) Move Web Console Plugin to separate bundle
[ https://issues.apache.org/jira/browse/SLING-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15590900#comment-15590900 ] Carsten Ziegeler commented on SLING-5932: - Lgtm, thanks [~chetanm] > Move Web Console Plugin to separate bundle > -- > > Key: SLING-5932 > URL: https://issues.apache.org/jira/browse/SLING-5932 > Project: Sling > Issue Type: Improvement > Components: Commons >Affects Versions: Commons Log 4.0.6 >Reporter: Carsten Ziegeler >Assignee: Chetan Mehrotra > Fix For: Commons Log 5.0.0, Commons Log WebConsole 1.0.0 > > > The log implementation currently contains a web console plugin which uses a > dynamic package import. Once the log impl is wired to a bundle providing the > servlet api and that bundle is updated/removed, it causes the log > implementation to refresh, which usually means a complete restart of the > system (as every bunde uses logging). > We should reduce this coupling and remove any dependency to the servlet api > from the logging implementation -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-5932) Move Web Console Plugin to separate bundle
[ https://issues.apache.org/jira/browse/SLING-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571263#comment-15571263 ] Chetan Mehrotra commented on SLING-5932: Thanks again for the apache-snapshots tip. Build works fine now at https://builds.apache.org/job/sling-bundles-commons-log-webconsole-1.7/3/console > Move Web Console Plugin to separate bundle > -- > > Key: SLING-5932 > URL: https://issues.apache.org/jira/browse/SLING-5932 > Project: Sling > Issue Type: Improvement > Components: Commons >Affects Versions: Commons Log 4.0.6 >Reporter: Carsten Ziegeler >Assignee: Chetan Mehrotra > Fix For: Commons Log 5.0.0, Commons Log WebConsole 1.0.0 > > > The log implementation currently contains a web console plugin which uses a > dynamic package import. Once the log impl is wired to a bundle providing the > servlet api and that bundle is updated/removed, it causes the log > implementation to refresh, which usually means a complete restart of the > system (as every bunde uses logging). > We should reduce this coupling and remove any dependency to the servlet api > from the logging implementation -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-5932) Move Web Console Plugin to separate bundle
[ https://issues.apache.org/jira/browse/SLING-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571240#comment-15571240 ] Robert Munteanu commented on SLING-5932: Glad to help. Also I think you need some special handling since you use SNAPSHOT references in your pax-exam tests. See SLING-6079 for how to handle this. > Move Web Console Plugin to separate bundle > -- > > Key: SLING-5932 > URL: https://issues.apache.org/jira/browse/SLING-5932 > Project: Sling > Issue Type: Improvement > Components: Commons >Affects Versions: Commons Log 4.0.6 >Reporter: Carsten Ziegeler >Assignee: Chetan Mehrotra > Fix For: Commons Log 5.0.0, Commons Log WebConsole 1.0.0 > > > The log implementation currently contains a web console plugin which uses a > dynamic package import. Once the log impl is wired to a bundle providing the > servlet api and that bundle is updated/removed, it causes the log > implementation to refresh, which usually means a complete restart of the > system (as every bunde uses logging). > We should reduce this coupling and remove any dependency to the servlet api > from the logging implementation -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-5932) Move Web Console Plugin to separate bundle
[ https://issues.apache.org/jira/browse/SLING-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571076#comment-15571076 ] Chetan Mehrotra commented on SLING-5932: Thanks [~rombert] for details. Did the change in http://svn.apache.org/viewvc?rev=1764609&view=rev > Move Web Console Plugin to separate bundle > -- > > Key: SLING-5932 > URL: https://issues.apache.org/jira/browse/SLING-5932 > Project: Sling > Issue Type: Improvement > Components: Commons >Affects Versions: Commons Log 4.0.6 >Reporter: Carsten Ziegeler >Assignee: Chetan Mehrotra > Fix For: Commons Log 5.0.0, Commons Log WebConsole 1.0.0 > > > The log implementation currently contains a web console plugin which uses a > dynamic package import. Once the log impl is wired to a bundle providing the > servlet api and that bundle is updated/removed, it causes the log > implementation to refresh, which usually means a complete restart of the > system (as every bunde uses logging). > We should reduce this coupling and remove any dependency to the servlet api > from the logging implementation -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-5932) Move Web Console Plugin to separate bundle
[ https://issues.apache.org/jira/browse/SLING-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571051#comment-15571051 ] Robert Munteanu commented on SLING-5932: [~chetanm] - you need to add a new job to [tooling/jenkins/create_jobs.groovy|https://svn.apache.org/repos/asf/sling/trunk/tooling/jenkins/create_jobs.groovy], see https://cwiki.apache.org/confluence/display/SLING/Sling+Jenkins+Setup#SlingJenkinsSetup-Managingjobs for more details. Once that is committed to SVN, on the next sling-seed-build execution the job(s) will be created. > Move Web Console Plugin to separate bundle > -- > > Key: SLING-5932 > URL: https://issues.apache.org/jira/browse/SLING-5932 > Project: Sling > Issue Type: Improvement > Components: Commons >Affects Versions: Commons Log 4.0.6 >Reporter: Carsten Ziegeler >Assignee: Chetan Mehrotra > Fix For: Commons Log 5.0.0, Commons Log WebConsole 1.0.0 > > > The log implementation currently contains a web console plugin which uses a > dynamic package import. Once the log impl is wired to a bundle providing the > servlet api and that bundle is updated/removed, it causes the log > implementation to refresh, which usually means a complete restart of the > system (as every bunde uses logging). > We should reduce this coupling and remove any dependency to the servlet api > from the logging implementation -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-5932) Move Web Console Plugin to separate bundle
[
https://issues.apache.org/jira/browse/SLING-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570739#comment-15570739
]
Chetan Mehrotra commented on SLING-5932:
Changes done at r1764489. See details at
https://github.com/apache/sling/commit/beccc1c17d1ba3210c4c0655e031c3cc296a23f2
Moved the logic related to WebConsole request handling to a new module
bundle/commons/log-webconsole. Commons log now registers a service {{LogPanel}}
which takes a {{PrintWriter}} and renders the Sling Log Panel view. This class
does not depend on servlet classes. Instead log-webconsole bundle now registers
a {{LogWebConsolePlugin}} which deal with servlet api and extracts the request
params and passes them on the {{LogPanel}}
*org.apache.sling.commons.log*
Import/Export
{noformat}
[IMPEXP]
Import-Package
ch.qos.logback.classic.*{version=[1.1,2)}
javax.management {resolution:=optional}
javax.naming {resolution:=optional}
javax.net
javax.net.ssl
javax.sql {resolution:=optional}
javax.xml.namespace
javax.xml.parsers {resolution:=optional}
javax.xml.stream
javax.xml.stream.events
org.apache.sling.commons.log.logback.webconsole{version=[1.0,1.1)}
org.osgi.framework{version=1.3}
org.osgi.util.tracker {version=[1.4,2)}
org.slf4j {version=[1.6,1.8)}
org.slf4j.helpers {version=[1.6,2)}
org.slf4j.spi {version=[1.6,1.8)}
org.xml.sax {resolution:=optional}
org.xml.sax.helpers {resolution:=optional}
sun.reflect {resolution:=optional}
Export-Package
ch.qos.logback.classic.*{version=1.1.2, imported-as=[1.1,2)}
org.apache.sling.commons.log.logback {version=1.0}
org.apache.sling.commons.log.logback.webconsole{version=1.0,
imported-as=[1.0,1.1)}
org.slf4j.impl{version=1.6.4}
{noformat}
*org.apache.sling.commons.log.webconsole*
{noformat}
[IMPEXP]
Import-Package
javax.servlet {version=2.3}
javax.servlet.http{version=2.3}
org.apache.felix.webconsole {version=[3.1,4)}
org.apache.sling.commons.log.logback.webconsole{version=[1.0,2)}
org.osgi.framework{version=[1.7,2)}
org.osgi.util.tracker {version=[1.5,2)}
{noformat}
[~cziegeler] Can you review the changes done once?
[~rombert] What changes I need to make to have the new bundle used for build
> Move Web Console Plugin to separate bundle
> --
>
> Key: SLING-5932
> URL: https://issues.apache.org/jira/browse/SLING-5932
> Project: Sling
> Issue Type: Improvement
> Components: Commons
>Affects Versions: Commons Log 4.0.6
>Reporter: Carsten Ziegeler
>Assignee: Chetan Mehrotra
> Fix For: Commons Log 5.0.0
>
>
> The log implementation currently contains a web console plugin which uses a
> dynamic package import. Once the log impl is wired to a bundle providing the
> servlet api and that bundle is updated/removed, it causes the log
> implementation to refresh, which usually means a complete restart of the
> system (as every bunde uses logging).
> We should reduce this coupling and remove any dependency to the servlet api
> from the logging implementation
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
