[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

[ https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047942#comment-16047942 ] Nitin Nizhawan commented on SLING-6422: --- Thanks > Allow for specifying oak restrictions with

[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

[ https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047939#comment-16047939 ] Bertrand Delacretaz commented on SLING-6422: I have added a few examples with restrictions at

[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

[ https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047904#comment-16047904 ] Nitin Nizhawan commented on SLING-6422: --- [~bdelacretaz] Comparison function looks good to me, yes

[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

[ https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047851#comment-16047851 ] Bertrand Delacretaz commented on SLING-6422: I understand we might have assumptions about the

[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

[ https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047830#comment-16047830 ] ASF GitHub Bot commented on SLING-6422: --- GitHub user bdelacretaz opened a pull request:

[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

[ https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047529#comment-16047529 ] Nitin Nizhawan commented on SLING-6422: --- [~bdelacretaz] I further verified that vault package

[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

[ https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047496#comment-16047496 ] Bertrand Delacretaz commented on SLING-6422: IMO assuming that the arrays are ordered is

[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

[ https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046950#comment-16046950 ] Nitin Nizhawan commented on SLING-6422: --- Hi [~bdelacretaz] That is an interesting point. IIUC, you

[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

[ https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046600#comment-16046600 ] Bertrand Delacretaz commented on SLING-6422: [~nitin.nizhawan] the {{sameRestrictions}} method

[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

[ https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046582#comment-16046582 ] Bertrand Delacretaz commented on SLING-6422: bq. ...i would have expected you to be able to

[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

[ https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046573#comment-16046573 ] angela commented on SLING-6422: --- [~nitin.nizhawan], had a quick look and it didn't spot any major issues.

[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

[ https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046526#comment-16046526 ] Nitin Nizhawan commented on SLING-6422: --- [~anchela] Not an issue. I have raised a fresh PR

[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

[ https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046509#comment-16046509 ] ASF GitHub Bot commented on SLING-6422: --- GitHub user nitin-nizhawan opened a pull request:

[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

[ https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046502#comment-16046502 ] Bertrand Delacretaz commented on SLING-6422: I can merge the patch but would prefer [~anchela]

[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

[ https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046500#comment-16046500 ] angela commented on SLING-6422: --- [~nitin.nizhawan], sorry... it lost the context in order to be able to

[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

[ https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046399#comment-16046399 ] Nitin Nizhawan commented on SLING-6422: --- [~bdelacretaz] [~anchela] Updated patch after resolving

[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

[ https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018654#comment-16018654 ] ASF GitHub Bot commented on SLING-6422: --- GitHub user nitin-nizhawan opened a pull request:

[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

[ https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018653#comment-16018653 ] ASF GitHub Bot commented on SLING-6422: --- Github user nitin-nizhawan closed the pull request at:

[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

[ https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017454#comment-16017454 ] angela commented on SLING-6422: --- [~nitin.nizhawan], oh... my bad... i didn't summit the commits :-( should

[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

[ https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017326#comment-16017326 ] Nitin Nizhawan commented on SLING-6422: --- [~anchela] Thanks for your review. For some reason I am

[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

[ https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017113#comment-16017113 ] angela commented on SLING-6422: --- [~nitin.nizhawan], i commented on the pull request on github. the patch

[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

[ https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016082#comment-16016082 ] Nitin Nizhawan commented on SLING-6422: --- Also tagging [~anchela] and [~chetanm] for review CC:

[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

[ https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015683#comment-16015683 ] ASF GitHub Bot commented on SLING-6422: --- GitHub user nitin-nizhawan opened a pull request:

[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

[ https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15812120#comment-15812120 ] Bertrand Delacretaz commented on SLING-6422: I have committed your patch in

[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

[ https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15802079#comment-15802079 ] ASF GitHub Bot commented on SLING-6422: --- GitHub user nitin-nizhawan opened a pull request:

[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

[ https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15770701#comment-15770701 ] Bertrand Delacretaz commented on SLING-6422: The existing parser needs to be adapted anyway,

[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

[ https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15770607#comment-15770607 ] Timothee Maret commented on SLING-6422: --- bq. Note that supporting just the generic restriction(name,

[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

[ https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15768852#comment-15768852 ] Nitin Nizhawan commented on SLING-6422: --- +1 , in addition to this, do we think that we need to add

[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

[ https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15767221#comment-15767221 ] Bertrand Delacretaz commented on SLING-6422: The first step is to define a suitable syntax in