[jira] [Commented] (SLING-7545) Groovy Scripting Engine not loading in Apache Sling 10

2018-11-07 Thread Robert Munteanu (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678289#comment-16678289
 ] 

Robert Munteanu commented on SLING-7545:


[~fortuna] - Sling 11 contains the latest version of scripting.core - there was 
no release done with the fixes for this bug. I've made a note to start a 
release this week.

> Groovy Scripting Engine not loading in Apache Sling 10
> --
>
> Key: SLING-7545
> URL: https://issues.apache.org/jira/browse/SLING-7545
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting Core 2.0.54
>Reporter: Ben Fortuna
>Assignee: Bertrand Delacretaz
>Priority: Major
> Fix For: Scripting Core 2.0.56
>
>
> With the latest release of Apache Sling (10) the Groovy Scripting engine is 
> no longer loading.
> The impact is that scripts with a (*.groovy) extension aren't rendering.
> This works with Apache Sling 9, so I believe there was a change in the Apache 
> Sling Scripting Core that broke the Groovy implementation.
>  
> How to reproduce:
> Load groovy-all JAR into Apache Sling as a bundle, under the url 
> [http://localhost:8080/system/console/status-slingscripting] the following 
> should display:
> {code:java}
> Groovy Scripting Engine 2.0
> -
> - Language : Groovy, 2.4.14
> - Extensions : groovy
> - MIME Types : application/x-groovy
> - Names : groovy, Groovy{code}
>  
> This works with Apache Sling 9, not with Sling 10



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7545) Groovy Scripting Engine not loading in Apache Sling 10

2018-11-07 Thread Ben Fortuna (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678230#comment-16678230
 ] 

Ben Fortuna commented on SLING-7545:


[~bdelacretaz] just curious to note that the latest Sling release (V11) doesn't 
include the latest sling-scripting-core bundle (still using 2.0.54).

Any reason why this fix wasn't included? Many thanks.

> Groovy Scripting Engine not loading in Apache Sling 10
> --
>
> Key: SLING-7545
> URL: https://issues.apache.org/jira/browse/SLING-7545
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting Core 2.0.54
>Reporter: Ben Fortuna
>Assignee: Bertrand Delacretaz
>Priority: Major
> Fix For: Scripting Core 2.0.56
>
>
> With the latest release of Apache Sling (10) the Groovy Scripting engine is 
> no longer loading.
> The impact is that scripts with a (*.groovy) extension aren't rendering.
> This works with Apache Sling 9, so I believe there was a change in the Apache 
> Sling Scripting Core that broke the Groovy implementation.
>  
> How to reproduce:
> Load groovy-all JAR into Apache Sling as a bundle, under the url 
> [http://localhost:8080/system/console/status-slingscripting] the following 
> should display:
> {code:java}
> Groovy Scripting Engine 2.0
> -
> - Language : Groovy, 2.4.14
> - Extensions : groovy
> - MIME Types : application/x-groovy
> - Names : groovy, Groovy{code}
>  
> This works with Apache Sling 9, not with Sling 10



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7545) Groovy Scripting Engine not loading in Apache Sling 10

2018-03-21 Thread Bertrand Delacretaz (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407784#comment-16407784
 ] 

Bertrand Delacretaz commented on SLING-7545:


I have also added an integration test that would have exposed this regression:

https://github.com/apache/sling-org-apache-sling-scripting-core/blob/master/src/test/java/org/apache/sling/scripting/core/impl/jsr223/Jsr223ScriptEngineBundleIT.java

> Groovy Scripting Engine not loading in Apache Sling 10
> --
>
> Key: SLING-7545
> URL: https://issues.apache.org/jira/browse/SLING-7545
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting Core 2.0.54
>Reporter: Ben Fortuna
>Assignee: Bertrand Delacretaz
>Priority: Major
> Fix For: Scripting Core 2.0.56
>
>
> With the latest release of Apache Sling (10) the Groovy Scripting engine is 
> no longer loading.
> The impact is that scripts with a (*.groovy) extension aren't rendering.
> This works with Apache Sling 9, so I believe there was a change in the Apache 
> Sling Scripting Core that broke the Groovy implementation.
>  
> How to reproduce:
> Load groovy-all JAR into Apache Sling as a bundle, under the url 
> [http://localhost:8080/system/console/status-slingscripting] the following 
> should display:
> {code:java}
> Groovy Scripting Engine 2.0
> -
> - Language : Groovy, 2.4.14
> - Extensions : groovy
> - MIME Types : application/x-groovy
> - Names : groovy, Groovy{code}
>  
> This works with Apache Sling 9, not with Sling 10



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7545) Groovy Scripting Engine not loading in Apache Sling 10

2018-03-20 Thread Bertrand Delacretaz (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406431#comment-16406431
 ] 

Bertrand Delacretaz commented on SLING-7545:


Thanks [~kwin], I was wondering about that indeed, should have asked.

I have removed the {{BundleListener.class}} element of the services annotation, 
in commit 0339ac9

> Groovy Scripting Engine not loading in Apache Sling 10
> --
>
> Key: SLING-7545
> URL: https://issues.apache.org/jira/browse/SLING-7545
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting Core 2.0.54
>Reporter: Ben Fortuna
>Assignee: Bertrand Delacretaz
>Priority: Major
> Fix For: Scripting Core 2.0.56
>
>
> With the latest release of Apache Sling (10) the Groovy Scripting engine is 
> no longer loading.
> The impact is that scripts with a (*.groovy) extension aren't rendering.
> This works with Apache Sling 9, so I believe there was a change in the Apache 
> Sling Scripting Core that broke the Groovy implementation.
>  
> How to reproduce:
> Load groovy-all JAR into Apache Sling as a bundle, under the url 
> [http://localhost:8080/system/console/status-slingscripting] the following 
> should display:
> {code:java}
> Groovy Scripting Engine 2.0
> -
> - Language : Groovy, 2.4.14
> - Extensions : groovy
> - MIME Types : application/x-groovy
> - Names : groovy, Groovy{code}
>  
> This works with Apache Sling 9, not with Sling 10



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7545) Groovy Scripting Engine not loading in Apache Sling 10

2018-03-20 Thread Konrad Windszus (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406404#comment-16406404
 ] 

Konrad Windszus commented on SLING-7545:


[~bdelacretaz] I don't think that a {{BundleListener}} should be registered as 
a regular service 
(https://github.com/apache/sling-org-apache-sling-scripting-core/blob/7f6145e79666c49844c49e9ce0d49d7954713a88/src/main/java/org/apache/sling/scripting/core/impl/jsr223/SlingScriptEngineManager.java#L60)
 as the registration according to the Javadoc should be only done via 
getBundleContext().addBundleListener(); WDYT?

> Groovy Scripting Engine not loading in Apache Sling 10
> --
>
> Key: SLING-7545
> URL: https://issues.apache.org/jira/browse/SLING-7545
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting Core 2.0.54
>Reporter: Ben Fortuna
>Assignee: Bertrand Delacretaz
>Priority: Major
> Fix For: Scripting Core 2.0.56
>
>
> With the latest release of Apache Sling (10) the Groovy Scripting engine is 
> no longer loading.
> The impact is that scripts with a (*.groovy) extension aren't rendering.
> This works with Apache Sling 9, so I believe there was a change in the Apache 
> Sling Scripting Core that broke the Groovy implementation.
>  
> How to reproduce:
> Load groovy-all JAR into Apache Sling as a bundle, under the url 
> [http://localhost:8080/system/console/status-slingscripting] the following 
> should display:
> {code:java}
> Groovy Scripting Engine 2.0
> -
> - Language : Groovy, 2.4.14
> - Extensions : groovy
> - MIME Types : application/x-groovy
> - Names : groovy, Groovy{code}
>  
> This works with Apache Sling 9, not with Sling 10



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7545) Groovy Scripting Engine not loading in Apache Sling 10

2018-03-20 Thread Ben Fortuna (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406245#comment-16406245
 ] 

Ben Fortuna commented on SLING-7545:


[~rombert] Sling 9 uses version 2.0.46, which does work.

[~bdelacretaz] I've built and installed from master branch and it works. Just 
had to restart the Groovy bundle after installing.

> Groovy Scripting Engine not loading in Apache Sling 10
> --
>
> Key: SLING-7545
> URL: https://issues.apache.org/jira/browse/SLING-7545
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting Core 2.0.54
>Reporter: Ben Fortuna
>Priority: Major
> Fix For: Scripting Core 2.0.56
>
>
> With the latest release of Apache Sling (10) the Groovy Scripting engine is 
> no longer loading.
> The impact is that scripts with a (*.groovy) extension aren't rendering.
> This works with Apache Sling 9, so I believe there was a change in the Apache 
> Sling Scripting Core that broke the Groovy implementation.
>  
> How to reproduce:
> Load groovy-all JAR into Apache Sling as a bundle, under the url 
> [http://localhost:8080/system/console/status-slingscripting] the following 
> should display:
> {code:java}
> Groovy Scripting Engine 2.0
> -
> - Language : Groovy, 2.4.14
> - Extensions : groovy
> - MIME Types : application/x-groovy
> - Names : groovy, Groovy{code}
>  
> This works with Apache Sling 9, not with Sling 10



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7545) Groovy Scripting Engine not loading in Apache Sling 10

2018-03-20 Thread Bertrand Delacretaz (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406192#comment-16406192
 ] 

Bertrand Delacretaz commented on SLING-7545:


I think this commit fixes this:

https://github.com/apache/sling-org-apache-sling-scripting-core/commit/7f6145e79666c49844c49e9ce0d49d7954713a88

For some reason the {{SlingScriptEngineManager}} was not registered as a 
{{BundleListener}} anymore but that's needed to correctly handle scripting 
bundles like {{groovy-all.jar}}.

[~fortuna] could you try with this fix? You'll need to build the master branch 
of https://github.com/apache/sling-org-apache-sling-scripting-core for that.

> Groovy Scripting Engine not loading in Apache Sling 10
> --
>
> Key: SLING-7545
> URL: https://issues.apache.org/jira/browse/SLING-7545
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting Core 2.0.54
>Reporter: Ben Fortuna
>Priority: Major
>
> With the latest release of Apache Sling (10) the Groovy Scripting engine is 
> no longer loading.
> The impact is that scripts with a (*.groovy) extension aren't rendering.
> This works with Apache Sling 9, so I believe there was a change in the Apache 
> Sling Scripting Core that broke the Groovy implementation.
>  
> How to reproduce:
> Load groovy-all JAR into Apache Sling as a bundle, under the url 
> [http://localhost:8080/system/console/status-slingscripting] the following 
> should display:
> {code:java}
> Groovy Scripting Engine 2.0
> -
> - Language : Groovy, 2.4.14
> - Extensions : groovy
> - MIME Types : application/x-groovy
> - Names : groovy, Groovy{code}
>  
> This works with Apache Sling 9, not with Sling 10



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7545) Groovy Scripting Engine not loading in Apache Sling 10

2018-03-20 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406076#comment-16406076
 ] 

Robert Munteanu commented on SLING-7545:


[~fortuna] - does rolling back to an older version work? If it does, which is 
the newest version that works?

> Groovy Scripting Engine not loading in Apache Sling 10
> --
>
> Key: SLING-7545
> URL: https://issues.apache.org/jira/browse/SLING-7545
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting Core 2.0.54
>Reporter: Ben Fortuna
>Priority: Major
>
> With the latest release of Apache Sling (10) the Groovy Scripting engine is 
> no longer loading.
> The impact is that scripts with a (*.groovy) extension aren't rendering.
> This works with Apache Sling 9, so I believe there was a change in the Apache 
> Sling Scripting Core that broke the Groovy implementation.
>  
> How to reproduce:
> Load groovy-all JAR into Apache Sling as a bundle, under the url 
> [http://localhost:8080/system/console/status-slingscripting] the following 
> should display:
> {code:java}
> Groovy Scripting Engine 2.0
> -
> - Language : Groovy, 2.4.14
> - Extensions : groovy
> - MIME Types : application/x-groovy
> - Names : groovy, Groovy{code}
>  
> This works with Apache Sling 9, not with Sling 10



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7545) Groovy Scripting Engine not loading in Apache Sling 10

2018-03-19 Thread Ben Fortuna (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405599#comment-16405599
 ] 

Ben Fortuna commented on SLING-7545:


Possibly caused by changes to sling-sciprting-core in last release (2.0.54):
 * SLING-7311
 * ...

> Groovy Scripting Engine not loading in Apache Sling 10
> --
>
> Key: SLING-7545
> URL: https://issues.apache.org/jira/browse/SLING-7545
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting Core 2.0.54
>Reporter: Ben Fortuna
>Priority: Major
>
> With the latest release of Apache Sling (10) the Groovy Scripting engine is 
> no longer loading.
> The impact is that scripts with a (*.groovy) extension aren't rendering.
> This works with Apache Sling 9, so I believe there was a change in the Apache 
> Sling Scripting Core that broke the Groovy implementation.
>  
> How to reproduce:
> Load groovy-all JAR into Apache Sling as a bundle, under the url 
> [http://localhost:8080/system/console/status-slingscripting] the following 
> should display:
> {code:java}
> Groovy Scripting Engine 2.0
> -
> - Language : Groovy, 2.4.14
> - Extensions : groovy
> - MIME Types : application/x-groovy
> - Names : groovy, Groovy{code}
>  
> This works with Apache Sling 9, not with Sling 10



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)