Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

rombert commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/8#issuecomment-2060868380 Thanks for your patience @sufyanharoon, I started a release vote: https://lists.apache.org/thread/lfkj8cjfswcp3nnqx3s1mxrmd99rs1wl -- This is an automated

Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

rombert merged PR #8: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

sufyanharoon commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/8#issuecomment-2060740880 @rombert LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

sonarcloud[bot] commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/8#issuecomment-2060672290 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

rombert commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/8#issuecomment-2060615568 Thanks for the revierw @sufyanharoon . I made the additional change now, let me know if that solves the issue completely. -- This is an automated message

Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

sufyanharoon commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/8#issuecomment-2060088293 Thanks @rombert. Later on, I had changed the scope to runtime as these are not needed for compile but needed at runtime for tests to run. Similar to

Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

sonarcloud[bot] commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/8#issuecomment-2059914892 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

rombert commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/8#issuecomment-2059430499 @sufyanharoon - I added a small comment on top of your changes from #7 , hope this is fine. -- This is an automated message from the Apache Git Service. To

Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

rombert commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/7#issuecomment-2059409129 Hm, why did this get closed? I don't remember deleting this branch. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

rombert closed pull request #7: SLING-11633 - Compile with Java 11 URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

sonarcloud[bot] commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/7#issuecomment-2058609691 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

sufyanharoon commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/7#issuecomment-2055066934 @rombert, yes adding the two additional jars to the class path should fix this issue but before we upgraded to Java 11, it used to work seamlessly. This

Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

rombert commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/7#issuecomment-2049712912 @sufyanharoon - I agree that it can be used as a plain jar, but if you build it you will see that it's an OSGi bundle -

Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

sufyanharoon commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/7#issuecomment-2045119495 @rombert, teleporter is not a bundle and is not supposed to be deployed in OSGI container. It is a jar which provides a test framework and is supposed to

Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

rombert commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/7#issuecomment-2044726714 @sufyanharoon - I'm not an expert of the module here, but I see it's packaged as a bundle as well, so we should not explicitly declare dependencies and rather

Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

sufyanharoon commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/7#issuecomment-2044717676 >What problem does this solve? When using the latest build of teleporter in tests, these dependencies were not coming transitively. When added in tests,

Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

sonarcloud[bot] commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/7#issuecomment-2044556812 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

sufyanharoon commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/7#issuecomment-2044550283 @rombert Please review and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

rombert merged PR #5: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

sonarcloud[bot] commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/5#issuecomment-2042660900 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

rombert commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/5#issuecomment-2042649905 @sufyanharoon - FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] SLING-11633 Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

rombert commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/4#issuecomment-2042614227 @sufyanharoon - I'll start a release vote today, thanks for the reminder. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] SLING-11633 Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

sufyanharoon commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/4#issuecomment-2042306162 Thanks @rombert. Can you please help in release this component as well? Or whom should I reach out to for release? -- This is an automated message from

Re: [PR] SLING-11633 Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

rombert merged PR #4: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] SLING-11633 Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

sonarcloud[bot] commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/4#issuecomment-1985394188 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] SLING-11633 Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

sufyanharoon commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/4#issuecomment-1985389084 @rombert I have refreshed the PR. Please review and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] SLING-11633 Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

sufyanharoon commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/4#issuecomment-1985362787 @rombert yes, I meant the spotless-maven-plugin only. First I tried to update to parent version 60 and then this plugin enforced the formatting changes. I

Re: [PR] SLING-11633 Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

rombert commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/4#issuecomment-1983151463 > @sufyanharoon - can you please disable that plug-in and ensure that there are no formatting changes? Did you mean the spotless-maven-plugin? IIRC that

Re: [PR] SLING-11633 Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

rombert commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/4#issuecomment-1983018716 @sufyanharoon - can you please disable that plug-in and ensure that there are no formatting changes? -- This is an automated message from the Apache Git

Re: [PR] SLING-11633 Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

sufyanharoon commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/4#issuecomment-1982439294 @rombert I didn't add the white spaces intentionally. There is a plugin (I am forgetting the name) configured when aligning with latest parent-pom which

Re: [PR] SLING-11633 Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

rombert commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/4#issuecomment-1961317550 @sufyanharoon - thanks for the PR. You asked me about > Detected JDK version 11.0.16-1 (JAVA_HOME=/usr/local/asfpackages/java/adoptium-jdk-11.0.16.1+1)

Re: [PR] SLING-11633 Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

sonarcloud[bot] commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/4#issuecomment-1940410525 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] SLING-11633 Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

sufyanharoon commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/4#issuecomment-1938536348 @rombert , I am trying to run this PR and it is failing in Jenkins with the following issue `Detected JDK version 11.0.16-1

Re: [PR] SLING-11633 Compile with Java 11 [sling-org-apache-sling-junit-teleporter]

sufyanharoon commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/4#issuecomment-1938411088 @bdelacretaz, can you please review it? This is needed for running tests with Java 11 using teleporter. -- This is an automated message from the Apache