[Bug 7509] Missing free(3) in error path

[bugzilla-daemon]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7509

--- Comment #5 from Kevin A. McGrail  ---
Fixing the last missing opt not freed.

Trunk: Committed revision 1838778.
3.4: Committed revision 1838779.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7509] Missing free(3) in error path

[bugzilla-daemon]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7509

--- Comment #4 from RW  ---
I don't see the point of this. The author very likely made a decision not to
bother freeing these small strings as they can't add up to more than the size
of the ARGV variables. On average you are probably wasting more memory on the
free() calls than you gain on the heap.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7509] Missing free(3) in error path

[bugzilla-daemon]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7509

Giovanni Bechis  changed:

   What|Removed |Added

 CC||giova...@paclan.it

--- Comment #3 from Giovanni Bechis  ---
Created attachment 5488
  --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5488=edit
More free(3) call

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7509] Missing free(3) in error path

[bugzilla-daemon]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7509

RW  changed:

   What|Removed |Added

 CC||rwmailli...@googlemail.com

--- Comment #2 from RW  ---
Is it just the error path? I don't see where it's ever freed.

It actually makes no practical difference whether opt is freed or not.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7509] Missing free(3) in error path

[bugzilla-daemon]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7509

Kevin A. McGrail  changed:

   What|Removed |Added

 CC||kmcgr...@apache.org
 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Kevin A. McGrail  ---
Thanks Giovanni.  It's very helpful with these patches and your BZ grooming.  I
look forward to looking at your bigger patches and having you earn committer
karma sooner than later.

Trunk: 
Committed revision 1816708.
3.4:
Committed revision 1816710.

-- 
You are receiving this mail because:
You are the assignee for the bug.