I also agree with Reynold and Xiao.
Although I love that new feature, Spark 2.4 branch-cut was made a long time
ago.
We cannot backport new features at this stage at RC4.
In addition, could you split Apache SPARK issue IDs, Ilan? It's confusing
during discussion.
(1) [SPARK-23257][K8S]
We need to strictly follow the backport and release policy. We can't merge
such a new feature into a RC branch or a minor release (e.g., 2.4.1).
Cheers,
Xiao
Bolke de Bruin 于2018年10月16日周二 下午12:48写道:
> Chiming in here. We are in the same boat as Bloomberg.
>
> (But being a release manager
Chiming in here. We are in the same boat as Bloomberg.
(But being a release manager often myself I understand the trade-off)
B.
Op di 16 okt. 2018 21:24 schreef Ilan Filonenko :
> On Erik's note, would SPARK-23257 be included in, say, 2.4.1? When would
> the next RC be? I would like to propose
On Erik's note, would SPARK-23257 be included in, say, 2.4.1? When would
the next RC be? I would like to propose the inclusion of the Kerberos
feature sooner rather than later as it would increase Spark-on-K8S adoption
in production workloads while bringing greater feature parity with Yarn and
SPARK-23257 merged more recently than I realized. If that isn't on
branch-2.4 then the first question is how soon on the release sequence that
can be adopted
On Tue, Oct 16, 2018 at 9:33 AM Reynold Xin wrote:
> We shouldn’t merge new features into release branches anymore.
>
> On Tue, Oct 16,
Yep, the Kerberos support for k8s is in the master but not in branch-2.4. I
see no reason to get the integration tests into 2.4, which depend on the
feature in the master.
On Tue, Oct 16, 2018 at 9:32 AM Rob Vesse wrote:
> Right now the Kerberos support for Spark on K8S is only on master AFAICT
We shouldn’t merge new features into release branches anymore.
On Tue, Oct 16, 2018 at 6:32 PM Rob Vesse wrote:
> Right now the Kerberos support for Spark on K8S is only on master AFAICT
> i.e. the feature is not present on branch-2.4
>
>
>
> Therefore I don’t see any point in adding the tests
Right now the Kerberos support for Spark on K8S is only on master AFAICT i.e.
the feature is not present on branch-2.4
Therefore I don’t see any point in adding the tests into branch-2.4 unless the
plan is to also merge the Kerberos support to branch-2.4
Rob
From: Erik Erlandson
I’m in favor of it. If you check the PR it’s a few isolated script changes and
all test-only changes. Should have low impact on release but much better
integration test coverage.
From: Erik Erlandson
Sent: Tuesday, October 16, 2018 8:20 AM
To: dev
Subject: