Re: [R] discuss: removing lint-r checks for old branches

2018-08-19 Thread Hyukjin Kwon
t;> >> >> -- >> *From:* shane knapp >> *Sent:* Friday, August 10, 2018 4:04 PM >> *To:* Sean Owen >> *Cc:* Shivaram Venkataraman; Reynold Xin; dev >> *Subject:* Re: [R] discuss: removing lint-r checks for old branches >> &

Re: [R] discuss: removing lint-r checks for old branches

2018-08-11 Thread shane knapp
n; Reynold Xin; dev > *Subject:* Re: [R] discuss: removing lint-r checks for old branches > > /agreemsg > > On Fri, Aug 10, 2018 at 4:02 PM, Sean Owen wrote: > >> Seems OK to proceed with shutting off lintr, as it was masking those. >> >> On Fri, Aug 10, 201

Re: [R] discuss: removing lint-r checks for old branches

2018-08-11 Thread Felix Cheung
: Shivaram Venkataraman; Reynold Xin; dev Subject: Re: [R] discuss: removing lint-r checks for old branches /agreemsg On Fri, Aug 10, 2018 at 4:02 PM, Sean Owen mailto:sro...@gmail.com>> wrote: Seems OK to proceed with shutting off lintr, as it was masking those. On Fri, Aug 10, 2018 at 6:01 PM

Re: [R] discuss: removing lint-r checks for old branches

2018-08-10 Thread shane knapp
ugh... R unit tests failed on both of these builds. https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94583/artifact/R/target/ https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94584/artifact/R/target/ On Fri, Aug 10, 2018 at 1:58 PM, Shivaram Venkataraman <

Re: [R] discuss: removing lint-r checks for old branches

2018-08-10 Thread shane knapp
/agreemsg On Fri, Aug 10, 2018 at 4:02 PM, Sean Owen wrote: > Seems OK to proceed with shutting off lintr, as it was masking those. > > On Fri, Aug 10, 2018 at 6:01 PM shane knapp wrote: > >> ugh... R unit tests failed on both of these builds. >> https://amplab.cs.berkeley.edu/jenkins//job/

Re: [R] discuss: removing lint-r checks for old branches

2018-08-10 Thread Sean Owen
Seems OK to proceed with shutting off lintr, as it was masking those. On Fri, Aug 10, 2018 at 6:01 PM shane knapp wrote: > ugh... R unit tests failed on both of these builds. > > https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94583/artifact/R/target/ > >

Re: [R] discuss: removing lint-r checks for old branches

2018-08-10 Thread Shivaram Venkataraman
Sounds good to me as well. Thanks Shane. Shivaram On Fri, Aug 10, 2018 at 1:40 PM Reynold Xin wrote: > > SGTM > > On Fri, Aug 10, 2018 at 1:39 PM shane knapp wrote: >> >> https://issues.apache.org/jira/browse/SPARK-25089 >> >> basically since these branches are old, and there will be a greater

Re: [R] discuss: removing lint-r checks for old branches

2018-08-10 Thread Reynold Xin
SGTM On Fri, Aug 10, 2018 at 1:39 PM shane knapp wrote: > https://issues.apache.org/jira/browse/SPARK-25089 > > basically since these branches are old, and there will be a greater than > zero amount of work to get lint-r to pass (on the new ubuntu workers), sean > and i are proposing to remove