---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61427/#review182692
---
Ship it!
Applied and tested
- Zoltán Tóth
On Aug. 4, 2017
(original), 153 (patched)
<https://reviews.apache.org/r/61669/#comment259217>
I think if you would move the class variable at the beginning of the class
then it would improve the readability.
- Zoltán Tóth
On Aug. 15, 2017, 6:56 p.m., Szabolcs Vasas
It depends on your taste so feel free to choose your action.
- Zoltán Tóth
On Aug. 15, 2017, 6:56 p.m., Szabolcs Vasas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
appreciate your contribution. Now it is
really easy to run tests.
Cheers, Zoli
- Zoltán Tóth
On Oct. 4, 2017, 7:49 a.m., Szabolcs Vasas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
message is not neccessary then you can leave the exception to
be thrown to to the caller method.
- Zoltán Tóth
On Sept. 1, 2017, 9:30 a.m., Szabolcs Vasas wrote:
>
> ---
> This is an automatically generated e-mail.
unit and integration tests to make your
changes run smoothly and they did.
Cheers, Zoli
- Zoltán Tóth
On Aug. 30, 2017, 8:17 a.m., Szabolcs Vasas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62028/#review185068
---
Ship it!
Ship It!
- Zoltán Tóth
On Sept. 11, 2017, 9:58 a.m
/3/
Changes: https://reviews.apache.org/r/62057/diff/2-3/
Testing
---
I ran unit tests and integration tests as well. New test cases were added to
test the change
Thanks,
Zoltán Tóth
.
Use expected exception instead of try - catch. It makes the code more
readable.
src/test/com/cloudera/sqoop/TestParquetExport.java
Lines 614 (patched)
<https://reviews.apache.org/r/61522/#comment263686>
Same here. Please specify the exception and use expected exception inst
/mapreduce/db/DBRecordReader.java a78eb061
src/java/org/apache/sqoop/mapreduce/db/SQLServerDBRecordReader.java 9a3621b0
src/test/org/apache/sqoop/mapreduce/db/TestSQLServerDBRecordReader.java
PRE-CREATION
Diff: https://reviews.apache.org/r/61777/diff/1/
Testing
---
Thanks,
Zoltán Tóth
/mapreduce/db/TestSQLServerDBRecordReader.java
PRE-CREATION
Diff: https://reviews.apache.org/r/61777/diff/2/
Changes: https://reviews.apache.org/r/61777/diff/1-2/
Testing
---
Thanks,
Zoltán Tóth
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61933/#review184035
---
Ship it!
Hey Szabolcs, thanks for your contribution.
- Zoltán
/SqoopHCatImportHelper.java aba2458e
src/test/org/apache/sqoop/mapreduce/hcat/TestSqoopHCatImportHelper.java
PRE-CREATION
Diff: https://reviews.apache.org/r/62057/diff/1/
Testing
---
I ran unit tests and integration tests as well. New test cases were added to
test the change
Thanks,
Zoltán Tóth
tests successfully with your patch.
Thanks for your contribution
Cheers, Zoli
- Zoltán Tóth
On June 6, 2017, 10:29 a.m., Szabolcs Vasas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://review
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7135/#review12019
---
On Sept. 27, 2012, 3:47 p.m., Zoltán Tóth-Czifra wrote
or environment
object that could be injected to these classes as mocks that could take care of
time-related fixtures.
Thanks,
Zoltán Tóth-Czifra
or environment
object that could be injected to these classes as mocks that could take care of
time-related fixtures.
Thanks,
Zoltán Tóth-Czifra
there is no machine or environment
object that could be injected to these classes as mocks that could take care of
time-related fixtures.
Thanks,
Zoltán Tóth-Czifra
this difficult. Unfortunately there is no machine or environment
object that could be injected to these classes as mocks that could take care of
time-related fixtures.
Thanks,
Zoltán Tóth-Czifra
://reviews.apache.org/r/7135/#review13075
---
On Nov. 2, 2012, 12:32 p.m., Zoltán Tóth-Czifra wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/literal flag set./simpara/important
Thanks,
Zoltán Tóth-Czifra
(for example, literal--connect/literal,
literal--table/literal, etc).
Don#8217;t forget that these parameters only work with the
literal--direct/literal flag set./simpara/important
Thanks,
Zoltán Tóth-Czifra
22 matches
Mail list logo
