Re: Review Request 51854: Sqoop should not allow --as-parquetfile when job type is hcatalog

2016-09-16 Thread Sowmya Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51854/ --- (Updated Sept. 16, 2016, 8:09 p.m.) Review request for Sqoop and Venkat

Re: Review Request 51854: Sqoop should not allow --as-parquetfile when job type is hcatalog

2016-09-16 Thread Venkat Ranganathan
> On Sept. 15, 2016, 2:53 p.m., Venkat Ranganathan wrote: > > src/java/org/apache/sqoop/tool/BaseSqoopTool.java, line 1424 > > > > > > Sowmya, did you mean to say createhivetable here I mean to say -add a comment

Re: Review Request 51854: Sqoop should not allow --as-parquetfile when job type is hcatalog

2016-09-16 Thread Erzsebet Szilagyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51854/#review149195 --- Fix it, then Ship it!

Re: Review Request 51854: Sqoop should not allow --as-parquetfile when job type is hcatalog

2016-09-15 Thread Venkat Ranganathan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51854/#review149147 --- src/java/org/apache/sqoop/tool/BaseSqoopTool.java (line 1424)

Re: Review Request 51854: Sqoop should not allow --as-parquetfile when job type is hcatalog

2016-09-14 Thread Sowmya Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51854/ --- (Updated Sept. 14, 2016, 11:35 p.m.) Review request for Sqoop and Venkat

Re: Review Request 51854: Sqoop should not allow --as-parquetfile when job type is hcatalog

2016-09-14 Thread Sowmya Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51854/ --- (Updated Sept. 14, 2016, 6:27 p.m.) Review request for Sqoop and Venkat

Re: Review Request 51854: Sqoop should not allow --as-parquetfile when job type is hcatalog

2016-09-13 Thread Venkat Ranganathan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51854/#review148761 --- +1 otherwise. Please fix the indentations