Re: Review Request 52426: row key not added into column family using --hbase-bulkload

2016-10-13 Thread Szabolcs Vasas
> On Oct. 13, 2016, 12:38 p.m., Attila Szabo wrote: > > Hi Szabi, > > > > Thanks so much for the update, it seems to work on my side either. > > +1 for creating the JIRA tickets for cleaning up the profiles, especially > > because unittesting+3rd_party_testing with different profiles (without

Re: Review Request 52426: row key not added into column family using --hbase-bulkload

2016-10-13 Thread Attila Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52426/#review152486 --- Ship it! Hi Szabi, Thanks so much for the update, it seems to

Re: Review Request 52426: row key not added into column family using --hbase-bulkload

2016-10-10 Thread Szabolcs Vasas
> On Oct. 7, 2016, 1:26 p.m., Attila Szabo wrote: > > Hi Szabi, > > > > The general idea behind this solution seems to be correct. Also the > > solution seems to be valid for the first shot. > > However I was not able to run the HBaseImportAddRowKeyTest with your > > changes successfully (it's

Re: Review Request 52426: row key not added into column family using --hbase-bulkload

2016-10-10 Thread Szabolcs Vasas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52426/ --- (Updated Oct. 10, 2016, 1:42 p.m.) Review request for Sqoop and Attila Szabo.

Re: Review Request 52426: row key not added into column family using --hbase-bulkload

2016-10-10 Thread Szabolcs Vasas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52426/ --- (Updated Oct. 10, 2016, 1:41 p.m.) Review request for Sqoop and Attila Szabo.

Re: Review Request 52426: row key not added into column family using --hbase-bulkload

2016-10-07 Thread Attila Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52426/#review151787 --- Hi Szabi, The general idea behind this solution seems to be corre

Re: Review Request 52426: row key not added into column family using --hbase-bulkload

2016-10-07 Thread Attila Szabo
> On Sept. 30, 2016, 4:16 p.m., Erzsebet Szilagyi wrote: > > Out of curiosity: why are the imports moved around? > > Szabolcs Vasas wrote: > Thanks for reviewing it! > It was not intentional, I guess the IDE reformatting moved them around. I guess it's the kindness provided by IntelliJ

Re: Review Request 52426: row key not added into column family using --hbase-bulkload

2016-10-07 Thread Szabolcs Vasas
> On Sept. 30, 2016, 4:16 p.m., Erzsebet Szilagyi wrote: > > Out of curiosity: why are the imports moved around? Thanks for reviewing it! It was not intentional, I guess the IDE reformatting moved them around. - Szabolcs --- This is an

Re: Review Request 52426: row key not added into column family using --hbase-bulkload

2016-09-30 Thread Erzsebet Szilagyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52426/#review151030 --- Ship it! Out of curiosity: why are the imports moved around? -