Re: Review Request 66221: SQOOP-3301 Document SQOOP-3216 - metastore related change

2018-04-10 Thread Szabolcs Vasas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66221/#review200800
---


Ship it!




Ship It!

- Szabolcs Vasas


On April 9, 2018, 2:35 p.m., Fero Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66221/
> ---
> 
> (Updated April 9, 2018, 2:35 p.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3301
> https://issues.apache.org/jira/browse/SQOOP-3301
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> This is the documentation for the metastore related patch implemented by Zach 
> Berkowitz.
> 
> 
> Diffs
> -
> 
>   src/docs/man/sqoop-job.txt 8be57402 
>   src/docs/user/metastore-purpose.txt 95c2d774 
>   src/docs/user/saved-jobs.txt 6885079f 
> 
> 
> Diff: https://reviews.apache.org/r/66221/diff/4/
> 
> 
> Testing
> ---
> 
> ant docs ran successfully
> 
> 
> Thanks,
> 
> Fero Szabo
> 
>



Re: Review Request 66221: SQOOP-3301 Document SQOOP-3216 - metastore related change

2018-04-10 Thread Szabolcs Vasas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66221/#review200799
---




src/docs/user/metastore-purpose.txt
Line 30 (original), 29 (patched)


typo: nut


- Szabolcs Vasas


On April 9, 2018, 2:35 p.m., Fero Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66221/
> ---
> 
> (Updated April 9, 2018, 2:35 p.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3301
> https://issues.apache.org/jira/browse/SQOOP-3301
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> This is the documentation for the metastore related patch implemented by Zach 
> Berkowitz.
> 
> 
> Diffs
> -
> 
>   src/docs/man/sqoop-job.txt 8be57402 
>   src/docs/user/metastore-purpose.txt 95c2d774 
>   src/docs/user/saved-jobs.txt 6885079f 
> 
> 
> Diff: https://reviews.apache.org/r/66221/diff/4/
> 
> 
> Testing
> ---
> 
> ant docs ran successfully
> 
> 
> Thanks,
> 
> Fero Szabo
> 
>



Re: Review Request 66221: SQOOP-3301 Document SQOOP-3216 - metastore related change

2018-04-09 Thread Fero Szabo via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66221/
---

(Updated April 9, 2018, 2:35 p.m.)


Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.


Changes
---

Hi Szabi,

thanks for the thorough review, I've adjusted the text as you asked.


Bugs: SQOOP-3301
https://issues.apache.org/jira/browse/SQOOP-3301


Repository: sqoop-trunk


Description
---

This is the documentation for the metastore related patch implemented by Zach 
Berkowitz.


Diffs (updated)
-

  src/docs/man/sqoop-job.txt 8be57402 
  src/docs/user/metastore-purpose.txt 95c2d774 
  src/docs/user/saved-jobs.txt 6885079f 


Diff: https://reviews.apache.org/r/66221/diff/3/

Changes: https://reviews.apache.org/r/66221/diff/2-3/


Testing
---

ant docs ran successfully


Thanks,

Fero Szabo



Re: Review Request 66221: SQOOP-3301 Document SQOOP-3216 - metastore related change

2018-04-06 Thread Szabolcs Vasas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66221/#review200629
---




src/docs/user/metastore-purpose.txt
Lines 20 (patched)


do we need this extra new line here?



src/docs/user/metastore-purpose.txt
Line 26 (original), 30 (patched)


I think we should explicitly state that MySQL, MSSQL,  Hsqldb, PostgreSQL, 
Oracle and DB2 are supported since we only test these. Other RDBMSs might work 
but we should not confuse the users.



src/docs/user/saved-jobs.txt
Lines 160 (patched)


typo: paramter



src/docs/user/saved-jobs.txt
Lines 161 (patched)


typo: configuartion



src/docs/user/saved-jobs.txt
Lines 296 (patched)


I think we should explicitly state that MySQL, MSSQL,  Hsqldb, PostgreSQL, 
Oracle and DB2 are supported since we only test these. Other RDBMSs might work 
but we should not confuse the users.


- Szabolcs Vasas


On March 27, 2018, 11:48 a.m., Fero Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66221/
> ---
> 
> (Updated March 27, 2018, 11:48 a.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3301
> https://issues.apache.org/jira/browse/SQOOP-3301
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> This is the documentation for the metastore related patch implemented by Zach 
> Berkowitz.
> 
> 
> Diffs
> -
> 
>   src/docs/man/sqoop-job.txt 8be57402 
>   src/docs/user/metastore-purpose.txt 95c2d774 
>   src/docs/user/saved-jobs.txt 6885079f 
> 
> 
> Diff: https://reviews.apache.org/r/66221/diff/2/
> 
> 
> Testing
> ---
> 
> ant docs ran successfully
> 
> 
> Thanks,
> 
> Fero Szabo
> 
>



Re: Review Request 66221: SQOOP-3301 Document SQOOP-3216 - metastore related change

2018-03-27 Thread Szabolcs Vasas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66221/#review200035
---



Hi Feró,

Thank you for your effort improving our documentation! Please see my comments 
in-line.


src/docs/man/sqoop-metastore.txt
Lines 29 (patched)


I think there is some confusion here. The sqoop-metastore command is only 
for starting a shared metastore the meta-connect/meta-user/meta-password 
options are parameters for sqoop-job.
Even if sqoop-job supports connecting to many different types of RDBMSs, 
the sqoop-metastore can only start an HSQLDB database.
It could be great if you could clarify this in the docs.



src/docs/man/sqoop-metastore.txt
Lines 38 (patched)


These examples are great, but they should probably go to the sqoop-job man 
page and/or sqoop-job user guide page.



src/docs/man/sqoop-metastore.txt
Lines 41 (patched)


Typo: metastore



src/docs/man/sqoop-metastore.txt
Lines 45 (patched)


Typo: metastore



src/docs/user/metastore-purpose.txt
Line 20 (original), 20 (patched)


sqoop-metastore supports HSQLDB only.



src/docs/user/saved-jobs.txt
Line 231 (original), 231 (patched)


sqoop-metastore supports HSQLDB only.



src/docs/user/saved-jobs.txt
Line 247 (original), 247 (patched)


I would not delete this piece of information, it could be helpful for some 
users.



src/docs/user/saved-jobs.txt
Lines 250 (patched)


I think this information is really useful but I suggest putting it to the  
sqoop-job part of the documentation.


- Szabolcs Vasas


On March 22, 2018, 5:46 p.m., Fero Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66221/
> ---
> 
> (Updated March 22, 2018, 5:46 p.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3301
> https://issues.apache.org/jira/browse/SQOOP-3301
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> This is the documentation for the metastore related patch implemented by Zach 
> Berkowitz.
> 
> 
> Diffs
> -
> 
>   src/docs/man/sqoop-metastore.txt c10cc08d 
>   src/docs/user/metastore-purpose.txt 95c2d774 
>   src/docs/user/saved-jobs.txt 6885079f 
> 
> 
> Diff: https://reviews.apache.org/r/66221/diff/1/
> 
> 
> Testing
> ---
> 
> ant docs ran successfully
> 
> 
> Thanks,
> 
> Fero Szabo
> 
>



Re: Review Request 66221: SQOOP-3301 Document SQOOP-3216 - metastore related change

2018-03-26 Thread Boglarka Egyed

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66221/#review199945
---


Ship it!




Ship It!

- Boglarka Egyed


On March 22, 2018, 5:46 p.m., Fero Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66221/
> ---
> 
> (Updated March 22, 2018, 5:46 p.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3301
> https://issues.apache.org/jira/browse/SQOOP-3301
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> This is the documentation for the metastore related patch implemented by Zach 
> Berkowitz.
> 
> 
> Diffs
> -
> 
>   src/docs/man/sqoop-metastore.txt c10cc08d 
>   src/docs/user/metastore-purpose.txt 95c2d774 
>   src/docs/user/saved-jobs.txt 6885079f 
> 
> 
> Diff: https://reviews.apache.org/r/66221/diff/1/
> 
> 
> Testing
> ---
> 
> ant docs ran successfully
> 
> 
> Thanks,
> 
> Fero Szabo
> 
>