Re: Review Request 68277: Fix hive-exec dependency issues in Gradle

2018-08-10 Thread Denes Arvay via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68277/#review207064
---


Ship it!




Ship It!

- Denes Arvay


On Aug. 9, 2018, 1:49 p.m., Szabolcs Vasas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68277/
> ---
> 
> (Updated Aug. 9, 2018, 1:49 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3360
> https://issues.apache.org/jira/browse/SQOOP-3360
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> It turned out during making SQOOP-3345 work with Gradle that there are issues 
> with the dependency handling which cause problems with Gradle. Root cause of 
> the problem seems to be the hive-exec dependency which also contains its own 
> dependencies pulling in incorrect libs and versions runtime. This has to be 
> cleaned up via better dependency management.
> 
> 
> Diffs
> -
> 
>   build.gradle e2c4479d35cbf97c51de0d6a9c5192284d934dc9 
>   gradle.properties 2d6c259ff267b74410247d574af28c35d62a72e1 
>   ivy.xml 796ef70ae38f254169587ce7d3401646f4a80a3a 
>   ivy/libraries.properties d679b125f0e2a4f3c3c25c83a2640c3e713e6079 
> 
> 
> Diff: https://reviews.apache.org/r/68277/diff/1/
> 
> 
> Testing
> ---
> 
> Ran unit and third party tests with both Ant and Gradle.
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>

Re: Review Request 68277: Fix hive-exec dependency issues in Gradle

2018-08-10 Thread Denes Arvay via Review Board 


> On Aug. 9, 2018, 2:39 p.m., Denes Arvay wrote:
> > build.gradle
> > Lines 83 (patched)
> > 
> >
> > Guava is missing from the ant/ivy version, doesn't it cause any issues, 
> > doesn't it result in different guava version in ant/ivy?
> 
> Szabolcs Vasas wrote:
> This line just enforces Guava 14.0.1 in Gradle, Ant keeps 14.0.1 by 
> default so it does not need any enforcement (and I haven't really found any 
> nice way to do it in Ant).

I see, thanks! LGTM +1


- Denes


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68277/#review207021
---


On Aug. 9, 2018, 1:49 p.m., Szabolcs Vasas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68277/
> ---
> 
> (Updated Aug. 9, 2018, 1:49 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3360
> https://issues.apache.org/jira/browse/SQOOP-3360
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> It turned out during making SQOOP-3345 work with Gradle that there are issues 
> with the dependency handling which cause problems with Gradle. Root cause of 
> the problem seems to be the hive-exec dependency which also contains its own 
> dependencies pulling in incorrect libs and versions runtime. This has to be 
> cleaned up via better dependency management.
> 
> 
> Diffs
> -
> 
>   build.gradle e2c4479d35cbf97c51de0d6a9c5192284d934dc9 
>   gradle.properties 2d6c259ff267b74410247d574af28c35d62a72e1 
>   ivy.xml 796ef70ae38f254169587ce7d3401646f4a80a3a 
>   ivy/libraries.properties d679b125f0e2a4f3c3c25c83a2640c3e713e6079 
> 
> 
> Diff: https://reviews.apache.org/r/68277/diff/1/
> 
> 
> Testing
> ---
> 
> Ran unit and third party tests with both Ant and Gradle.
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>

Re: Review Request 68277: Fix hive-exec dependency issues in Gradle

2018-08-10 Thread Boglarka Egyed 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68277/#review207062
---


Ship it!




Thank you very much for the quick fix!

Ran tests with Ant and Gradle successfully.

- Boglarka Egyed


On Aug. 9, 2018, 11:49 a.m., Szabolcs Vasas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68277/
> ---
> 
> (Updated Aug. 9, 2018, 11:49 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3360
> https://issues.apache.org/jira/browse/SQOOP-3360
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> It turned out during making SQOOP-3345 work with Gradle that there are issues 
> with the dependency handling which cause problems with Gradle. Root cause of 
> the problem seems to be the hive-exec dependency which also contains its own 
> dependencies pulling in incorrect libs and versions runtime. This has to be 
> cleaned up via better dependency management.
> 
> 
> Diffs
> -
> 
>   build.gradle e2c4479d35cbf97c51de0d6a9c5192284d934dc9 
>   gradle.properties 2d6c259ff267b74410247d574af28c35d62a72e1 
>   ivy.xml 796ef70ae38f254169587ce7d3401646f4a80a3a 
>   ivy/libraries.properties d679b125f0e2a4f3c3c25c83a2640c3e713e6079 
> 
> 
> Diff: https://reviews.apache.org/r/68277/diff/1/
> 
> 
> Testing
> ---
> 
> Ran unit and third party tests with both Ant and Gradle.
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>

Re: Review Request 68277: Fix hive-exec dependency issues in Gradle

2018-08-09 Thread Szabolcs Vasas 


> On Aug. 9, 2018, 12:39 p.m., Denes Arvay wrote:
> > build.gradle
> > Lines 83 (patched)
> > 
> >
> > Guava is missing from the ant/ivy version, doesn't it cause any issues, 
> > doesn't it result in different guava version in ant/ivy?

This line just enforces Guava 14.0.1 in Gradle, Ant keeps 14.0.1 by default so 
it does not need any enforcement (and I haven't really found any nice way to do 
it in Ant).


- Szabolcs


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68277/#review207021
---


On Aug. 9, 2018, 11:49 a.m., Szabolcs Vasas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68277/
> ---
> 
> (Updated Aug. 9, 2018, 11:49 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3360
> https://issues.apache.org/jira/browse/SQOOP-3360
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> It turned out during making SQOOP-3345 work with Gradle that there are issues 
> with the dependency handling which cause problems with Gradle. Root cause of 
> the problem seems to be the hive-exec dependency which also contains its own 
> dependencies pulling in incorrect libs and versions runtime. This has to be 
> cleaned up via better dependency management.
> 
> 
> Diffs
> -
> 
>   build.gradle e2c4479d35cbf97c51de0d6a9c5192284d934dc9 
>   gradle.properties 2d6c259ff267b74410247d574af28c35d62a72e1 
>   ivy.xml 796ef70ae38f254169587ce7d3401646f4a80a3a 
>   ivy/libraries.properties d679b125f0e2a4f3c3c25c83a2640c3e713e6079 
> 
> 
> Diff: https://reviews.apache.org/r/68277/diff/1/
> 
> 
> Testing
> ---
> 
> Ran unit and third party tests with both Ant and Gradle.
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>

Re: Review Request 68277: Fix hive-exec dependency issues in Gradle

2018-08-09 Thread Denes Arvay via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68277/#review207021
---




build.gradle
Lines 83 (patched)


Guava is missing from the ant/ivy version, doesn't it cause any issues, 
doesn't it result in different guava version in ant/ivy?


- Denes Arvay


On Aug. 9, 2018, 1:49 p.m., Szabolcs Vasas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68277/
> ---
> 
> (Updated Aug. 9, 2018, 1:49 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3360
> https://issues.apache.org/jira/browse/SQOOP-3360
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> It turned out during making SQOOP-3345 work with Gradle that there are issues 
> with the dependency handling which cause problems with Gradle. Root cause of 
> the problem seems to be the hive-exec dependency which also contains its own 
> dependencies pulling in incorrect libs and versions runtime. This has to be 
> cleaned up via better dependency management.
> 
> 
> Diffs
> -
> 
>   build.gradle e2c4479d35cbf97c51de0d6a9c5192284d934dc9 
>   gradle.properties 2d6c259ff267b74410247d574af28c35d62a72e1 
>   ivy.xml 796ef70ae38f254169587ce7d3401646f4a80a3a 
>   ivy/libraries.properties d679b125f0e2a4f3c3c25c83a2640c3e713e6079 
> 
> 
> Diff: https://reviews.apache.org/r/68277/diff/1/
> 
> 
> Testing
> ---
> 
> Ran unit and third party tests with both Ant and Gradle.
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>