[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-02 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/storm/pull/1055#discussion_r51624916 --- Diff: storm-core/test/clj/org/apache/storm/clojure_test.clj --- @@ -19,7 +19,9 @@ [org.apache.storm.tuple Fields]) (:use

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1055#discussion_r51615044 --- Diff: storm-core/src/clj/org/apache/storm/command/rebalance.clj --- @@ -15,7 +15,8 @@ ;; limitations under the License. (ns

[jira] [Commented] (STORM-1504) AvroGenericRecordBolt will not work in a topology with multiple workers

2016-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128792#comment-15128792 ] ASF GitHub Bot commented on STORM-1504: --- Github user asfgit closed the pull request at:

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-02 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1055#issuecomment-178759128 For the most part it looks good. Just a few things to clean up. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm pull request: [storm-core] Added exception for emit to undec...

2016-02-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1031 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: [storm-core] Added exception for emit to undec...

2016-02-02 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1031#issuecomment-178807187 Thanks @mjsax just merged this into master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1055#discussion_r51615170 --- Diff: storm-core/src/clj/org/apache/storm/command/set_log_level.clj --- @@ -15,7 +15,8 @@ ;; limitations under the License. (ns

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-02 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/storm/pull/1055#discussion_r51619400 --- Diff: storm-core/test/clj/integration/org/apache/storm/integration_test.clj --- @@ -362,36 +428,6 @@ (checker 3) )))

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1055#discussion_r51614782 --- Diff: storm-core/src/clj/org/apache/storm/clojure.clj --- @@ -24,7 +24,7 @@ (:import [org.apache.storm.utils Utils]) (:import

[GitHub] storm pull request: [storm-core] Added exception for emit to undec...

2016-02-02 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1031#issuecomment-178800030 @mjsax if you want to, if you don't I am happy to merge it in just as a pull request. I just wanted to check. --- If your project is set up for it, you can reply to

[jira] [Commented] (STORM-1504) AvroGenericRecordBolt will not work in a topology with multiple workers

2016-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128699#comment-15128699 ] ASF GitHub Bot commented on STORM-1504: --- Github user dossett commented on a diff in the pull

Re: [DISCUSS] 1.0 Release/Clojure-Java Migration

2016-02-02 Thread Aaron . Dossett
Should back porting fixes from master to 1.0 be included as tasks under that epic? From: "P. Taylor Goetz" > Reply-To: > Date: Monday, February 1, 2016 at 7:23 PM To:

[GitHub] storm pull request: STORM-1504: Add Serializer and instruction for...

2016-02-02 Thread dossett
Github user dossett commented on a diff in the pull request: https://github.com/apache/storm/pull/1052#discussion_r51609059 --- Diff: external/storm-hdfs/README.md --- @@ -315,6 +314,18 @@ An `org.apache.avro.Schema` object cannot be directly provided since it does not The

[GitHub] storm pull request: STORM-1504: Add Serializer and instruction for...

2016-02-02 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/1052#issuecomment-178734184 Looks good. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1055#discussion_r51614106 --- Diff: storm-core/src/jvm/org/apache/storm/Thrift.java --- @@ -0,0 +1,351 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1055#discussion_r51615271 --- Diff: storm-core/src/clj/org/apache/storm/command/shell_submission.clj --- @@ -16,7 +16,8 @@ (ns org.apache.storm.command.shell-submission

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1055#discussion_r51615429 --- Diff: storm-core/src/clj/org/apache/storm/daemon/common.clj --- @@ -16,18 +16,20 @@ (ns org.apache.storm.daemon.common (:use [org.apache.storm

[GitHub] storm pull request: STORM-1504: Add Serializer and instruction for...

2016-02-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1052 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: [storm-core] Added exception for emit to undec...

2016-02-02 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/storm/pull/1031#issuecomment-178809384 Thanks :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Assigned] (STORM-1518) Backport STORM-1504 to 1.0 branch

2016-02-02 Thread Aaron Dossett (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aaron Dossett reassigned STORM-1518: Assignee: Aaron Dossett > Backport STORM-1504 to 1.0 branch >

[GitHub] storm pull request: STORM-1518: Backport of STORM-1504

2016-02-02 Thread dossett
GitHub user dossett opened a pull request: https://github.com/apache/storm/pull/1066 STORM-1518: Backport of STORM-1504 You can merge this pull request into a Git repository by running: $ git pull https://github.com/dossett/storm STORM-1518 Alternatively you can review and

[jira] [Commented] (STORM-1518) Backport STORM-1504 to 1.0 branch

2016-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129079#comment-15129079 ] ASF GitHub Bot commented on STORM-1518: --- GitHub user dossett opened a pull request:

[GitHub] storm pull request: STORM-1518: Backport of STORM-1504

2016-02-02 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1066#issuecomment-178853787 +1 looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (STORM-1518) Backport STORM-1504 to 1.0 branch

2016-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129143#comment-15129143 ] ASF GitHub Bot commented on STORM-1518: --- Github user revans2 commented on the pull request:

[GitHub] storm pull request: STORM-1515: Reset LocalState if corrupted afte...

2016-02-02 Thread torbiak
GitHub user torbiak opened a pull request: https://github.com/apache/storm/pull/1067 STORM-1515: Reset LocalState if corrupted after a hard reboot on Windows On Windows LocalState IO requests interrupted by a hard reboot can result in a file full of NULs, similar to the

[jira] [Commented] (STORM-1515) LocalState corruption after hard reboot on Windows

2016-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129184#comment-15129184 ] ASF GitHub Bot commented on STORM-1515: --- GitHub user torbiak opened a pull request:

[jira] [Created] (STORM-1518) Backport STORM-1504 to 1.0 branch

2016-02-02 Thread Aaron Dossett (JIRA)
Aaron Dossett created STORM-1518: Summary: Backport STORM-1504 to 1.0 branch Key: STORM-1518 URL: https://issues.apache.org/jira/browse/STORM-1518 Project: Apache Storm Issue Type: Sub-task

Re: [DISCUSS] 1.0 Release/Clojure-Java Migration

2016-02-02 Thread P. Taylor Goetz
Yes, please. -Taylor > On Feb 2, 2016, at 2:51 PM, Aaron.Dossett wrote: > > Should back porting fixes from master to 1.0 be included as tasks under that > epic? > > From: "P. Taylor Goetz" > > Reply-To:

[jira] [Created] (STORM-1519) Storm syslog logging not confirming to RFC5426 3.1

2016-02-02 Thread Boyang Jerry Peng (JIRA)
Boyang Jerry Peng created STORM-1519: Summary: Storm syslog logging not confirming to RFC5426 3.1 Key: STORM-1519 URL: https://issues.apache.org/jira/browse/STORM-1519 Project: Apache Storm

Re: zookeeper util methods

2016-02-02 Thread Anirudh Jayakumar
Hi Erik, Thanks a lot for the detailed reply. The links were really helpful. Thanks, Anirudh On Sun, Jan 31, 2016 at 4:07 PM, Erik Weathers < eweath...@groupon.com.invalid> wrote: > hey Anirudh, > > To decipher this code we need to first realize that the the `zk` in that > code refers to

[jira] [Commented] (STORM-1519) Storm syslog logging not confirming to RFC5426 3.1

2016-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129258#comment-15129258 ] ASF GitHub Bot commented on STORM-1519: --- GitHub user jerrypeng opened a pull request:

[jira] [Updated] (STORM-1519) Storm syslog logging not confirming to RFC5426 3.1

2016-02-02 Thread Boyang Jerry Peng (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Jerry Peng updated STORM-1519: - Description: AS per RFC 5426 section 3.1, there should be only one message per datagram:

[jira] [Commented] (STORM-1519) Storm syslog logging not confirming to RFC5426 3.1

2016-02-02 Thread Boyang Jerry Peng (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129257#comment-15129257 ] Boyang Jerry Peng commented on STORM-1519: -- though changing the syslog setting in cluster.xml

[GitHub] storm pull request: [STORM-1519] - Storm syslog logging not confir...

2016-02-02 Thread jerrypeng
GitHub user jerrypeng opened a pull request: https://github.com/apache/storm/pull/1068 [STORM-1519] - Storm syslog logging not confirming to RFC5426 3.1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jerrypeng/storm STORM-1519

[GitHub] storm pull request: [STORM-1519] - Storm syslog logging not confir...

2016-02-02 Thread erikdw
Github user erikdw commented on the pull request: https://github.com/apache/storm/pull/1068#issuecomment-178916497 This seems like it could have a *major* impact on performance, no? It's not clear to me what is so horrible in STORM-1519 that we need to force a disk write for every

[jira] [Commented] (STORM-1519) Storm syslog logging not confirming to RFC5426 3.1

2016-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129454#comment-15129454 ] ASF GitHub Bot commented on STORM-1519: --- Github user erikdw commented on the pull request:

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1055#discussion_r51615822 --- Diff: storm-core/src/clj/org/apache/storm/daemon/task.clj --- @@ -27,9 +27,11 @@ (:import [org.apache.storm.generated ShellComponent JavaObject])

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1055#discussion_r51615735 --- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj --- @@ -37,8 +37,8 @@ (:import [org.apache.storm.cluster ClusterStateContext

[GitHub] storm pull request: Storm 1226

2016-02-02 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/1043#discussion_r51616229 --- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java --- @@ -1382,5 +1422,438 @@ public static TopologyInfo getTopologyInfo(String name, String

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1055#discussion_r51616348 --- Diff: storm-core/test/clj/org/apache/storm/clojure_test.clj --- @@ -19,7 +19,9 @@ [org.apache.storm.tuple Fields]) (:use

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1055#discussion_r51616140 --- Diff: storm-core/test/clj/integration/org/apache/storm/integration_test.clj --- @@ -362,36 +428,6 @@ (checker 3) ))) -;;

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1055#discussion_r51616178 --- Diff: storm-core/test/clj/integration/org/apache/storm/integration_test.clj --- @@ -416,23 +452,6 @@ ) ))) -;; (deftest

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-02 Thread redsanket
Github user redsanket commented on the pull request: https://github.com/apache/storm/pull/1055#issuecomment-178787608 @revans2 Thanks for reviewing, guess this fixes all your concerns --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (STORM-1189) client.getClusterInfo() fails with Required field 'nimbus_uptime_secs' is unset!

2016-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127868#comment-15127868 ] ASF GitHub Bot commented on STORM-1189: --- Github user spicoflorin commented on the pull request:

[GitHub] storm pull request: STORM-1189: Maintain wire compatability with 0...

2016-02-02 Thread spicoflorin
Github user spicoflorin commented on the pull request: https://github.com/apache/storm/pull/868#issuecomment-178437230 Hi! I didn't solve it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Commented] (STORM-1505) Add map, flatMap and filter operations in trident api

2016-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128355#comment-15128355 ] ASF GitHub Bot commented on STORM-1505: --- Github user arunmahadevan commented on the pull request:

[GitHub] storm pull request: [STORM-1505] Add map, flatMap and filter funct...

2016-02-02 Thread arunmahadevan
Github user arunmahadevan commented on the pull request: https://github.com/apache/storm/pull/1050#issuecomment-178612406 @ptgoetz added the overloaded filter api. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm pull request: STORM-1504: Add Serializer and instruction for...

2016-02-02 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1052#issuecomment-178637591 @dossett storm-starter failed the same way in travis for both JDK8 and JDK7 something odd with logging. I will try to reproduce it and see if it is just a

[jira] [Commented] (STORM-1504) AvroGenericRecordBolt will not work in a topology with multiple workers

2016-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128399#comment-15128399 ] ASF GitHub Bot commented on STORM-1504: --- Github user revans2 commented on the pull request:

Re: [DISCUSS] 1.0 Release/Clojure-Java Migration

2016-02-02 Thread Bobby Evans
I agree that it has stabilized a lot recently. Taylor, in the past you have been the one that has done most of the release work.  I am fine with letting you continue that for the 1.x line if you like, or I am happy to do some of that too if you would rather off load it.  Please let me know

[GitHub] storm pull request: [storm-core] Added exception for emit to undec...

2016-02-02 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1031#issuecomment-178618849 +1 the change looks fine to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (STORM-1505) Add map, flatMap and filter operations in trident api

2016-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128298#comment-15128298 ] ASF GitHub Bot commented on STORM-1505: --- Github user ptgoetz commented on the pull request:

[GitHub] storm pull request: [storm-core] Added exception for emit to undec...

2016-02-02 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1031#issuecomment-178624815 @mjsax is there a JIRA associated with this change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Created] (STORM-1516) Topology with time based windowing bolts are not getting killed properly.

2016-02-02 Thread Satish Duggana (JIRA)
Satish Duggana created STORM-1516: - Summary: Topology with time based windowing bolts are not getting killed properly. Key: STORM-1516 URL: https://issues.apache.org/jira/browse/STORM-1516 Project:

Re: Emitting to non-declared output stream

2016-02-02 Thread Matthias J. Sax
Hi, I opened an PR for this two weeks ago. Would love to get some feedback about it: https://github.com/apache/storm/pull/1031 -Matthias On 01/19/2016 04:45 PM, Bobby Evans wrote: > I think this is something that we should be able to handle efficiently in all > cases. >

Re: [DISCUSS] 1.0 Release/Clojure-Java Migration

2016-02-02 Thread Abhishek Agarwal
Is it possible to make the type as Epic so that remaining filed issues can be directly linked? e.g. https://issues.apache.org/jira/browse/STORM-1455 On Tue, Feb 2, 2016 at 6:53 AM, P. Taylor Goetz wrote: > I think the 1.x-branch has stabilized enough that it’s safe to allow

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-02 Thread redsanket
Github user redsanket commented on the pull request: https://github.com/apache/storm/pull/1055#issuecomment-178648000 @revans2 Can you please take a look at this again. Addressed your comments --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (STORM-733) ShellBolts that don't respond to heartbeats are not being killed

2016-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128487#comment-15128487 ] ASF GitHub Bot commented on STORM-733: -- Github user reembs commented on the pull request:

[jira] [Commented] (STORM-733) ShellBolts that don't respond to heartbeats are not being killed

2016-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128488#comment-15128488 ] ASF GitHub Bot commented on STORM-733: -- Github user reembs closed the pull request at:

Re: [DISCUSS] 1.0 Release/Clojure-Java Migration

2016-02-02 Thread P. Taylor Goetz
Thanks Bobby. I don’t mind doing the release prep and testing. It seems like i’ve been focused on that while you’ve had more time to forge ahead with the JStorm migration, which feels like a natural way for us to divide and conquer. So far that seems to be working out well. -Taylor > On Feb

[GitHub] storm pull request: STORM-1504: Add Serializer and instruction for...

2016-02-02 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1052#issuecomment-178645013 @dossett yes I have been able to reproduce the error, and it appears to somehow be related to this pull request. ``` mvn clean install -DskipTests cd

[jira] [Commented] (STORM-1504) AvroGenericRecordBolt will not work in a topology with multiple workers

2016-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128420#comment-15128420 ] ASF GitHub Bot commented on STORM-1504: --- Github user revans2 commented on the pull request:

[jira] [Commented] (STORM-1504) AvroGenericRecordBolt will not work in a topology with multiple workers

2016-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128425#comment-15128425 ] ASF GitHub Bot commented on STORM-1504: --- Github user dossett commented on the pull request:

[GitHub] storm pull request: STORM-1504: Add Serializer and instruction for...

2016-02-02 Thread dossett
Github user dossett commented on the pull request: https://github.com/apache/storm/pull/1052#issuecomment-178648710 Thanks @revans2, I will check it out. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm pull request: STORM-1504: Add Serializer and instruction for...

2016-02-02 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1052#issuecomment-178649925 @dossett I did a difference for running mvn dependency:tree between master and this pull just in storm starter and this is what showed up. ``` -[INFO] | \-

[GitHub] storm pull request: STORM-1504: Add Serializer and instruction for...

2016-02-02 Thread dossett
Github user dossett commented on the pull request: https://github.com/apache/storm/pull/1052#issuecomment-178672701 @revans2 Spot on, I just pushed that change. Thanks for catching that. If the travis builds pass, I will commit today. --- If your project is set up for it, you can

[jira] [Commented] (STORM-1504) AvroGenericRecordBolt will not work in a topology with multiple workers

2016-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128496#comment-15128496 ] ASF GitHub Bot commented on STORM-1504: --- Github user dossett commented on the pull request:

[GitHub] storm pull request: [STORM-1505] Add map, flatMap and filter funct...

2016-02-02 Thread arunmahadevan
Github user arunmahadevan commented on the pull request: https://github.com/apache/storm/pull/1050#issuecomment-178511982 Raised a separate JIRA to track peek - https://issues.apache.org/jira/browse/STORM-1517 --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (STORM-1505) Add map, flatMap and filter operations in trident api

2016-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128074#comment-15128074 ] ASF GitHub Bot commented on STORM-1505: --- Github user arunmahadevan commented on the pull request:

[jira] [Created] (STORM-1517) Add peek api in trident stream

2016-02-02 Thread Arun Mahadevan (JIRA)
Arun Mahadevan created STORM-1517: - Summary: Add peek api in trident stream Key: STORM-1517 URL: https://issues.apache.org/jira/browse/STORM-1517 Project: Apache Storm Issue Type: Bug

[GitHub] storm pull request: [STORM-1517] add peek api in trident stream

2016-02-02 Thread arunmahadevan
GitHub user arunmahadevan opened a pull request: https://github.com/apache/storm/pull/1065 [STORM-1517] add peek api in trident stream Similar to the Java 8 peek, the peek api can be used to examine trident tuples at some point in the stream pipeline or execute some custom

[jira] [Commented] (STORM-1517) Add peek api in trident stream

2016-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128087#comment-15128087 ] ASF GitHub Bot commented on STORM-1517: --- GitHub user arunmahadevan opened a pull request:

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1055#discussion_r51603260 --- Diff: storm-core/src/clj/org/apache/storm/internal/thrift.clj --- @@ -0,0 +1,291 @@ +;; Licensed to the Apache Software Foundation (ASF) under one

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1055#discussion_r51601967 --- Diff: storm-core/src/jvm/org/apache/storm/Thrift.java --- @@ -0,0 +1,351 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Updated] (STORM-1511) min/max operations on trident stream

2016-02-02 Thread Satish Duggana (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated STORM-1511: -- Fix Version/s: 1.0.0 > min/max operations on trident stream >

[jira] [Updated] (STORM-1511) min/max operations on trident stream

2016-02-02 Thread Satish Duggana (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated STORM-1511: -- Component/s: storm-core > min/max operations on trident stream >

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1055#discussion_r51588295 --- Diff: storm-core/src/clj/org/apache/storm/internal/thrift.clj --- @@ -0,0 +1,291 @@ +;; Licensed to the Apache Software Foundation (ASF) under one

[GitHub] storm pull request: [STORM-733] ShellBolts that don't respond to h...

2016-02-02 Thread reembs
Github user reembs commented on the pull request: https://github.com/apache/storm/pull/489#issuecomment-178667030 @HeartSaVioR I see the original bug was already fixed. I like the PR code better, but that's esthetics. Not worth the hassle, Closing. --- If your project is set up for

[GitHub] storm pull request: [STORM-733] ShellBolts that don't respond to h...

2016-02-02 Thread reembs
Github user reembs closed the pull request at: https://github.com/apache/storm/pull/489 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1055#discussion_r51587449 --- Diff: storm-clojure/src/main/clj/org.apache.storm/thrift.clj --- @@ -38,6 +38,7 @@ args (map (memfn getFieldValue) (.get_args_list obj))]

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1055#discussion_r51587377 --- Diff: storm-clojure/src/main/clj/org.apache.storm/clojure.clj --- @@ -0,0 +1,201 @@ +;; Licensed to the Apache Software Foundation (ASF) under one

[jira] [Commented] (STORM-1504) AvroGenericRecordBolt will not work in a topology with multiple workers

2016-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128428#comment-15128428 ] ASF GitHub Bot commented on STORM-1504: --- Github user revans2 commented on the pull request:

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1055#discussion_r51593940 --- Diff: storm-core/src/clj/org/apache/storm/internal/thrift.clj --- @@ -0,0 +1,291 @@ +;; Licensed to the Apache Software Foundation (ASF) under one

[GitHub] storm pull request: [STORM-1505] Add map, flatMap and filter funct...

2016-02-02 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/1050#issuecomment-178707222 +1 Thanks @arunmahadevan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1055#discussion_r51604477 --- Diff: storm-core/src/jvm/org/apache/storm/Thrift.java --- @@ -0,0 +1,351 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-02 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/storm/pull/1055#discussion_r51604533 --- Diff: storm-core/src/clj/org/apache/storm/internal/thrift.clj --- @@ -0,0 +1,291 @@ +;; Licensed to the Apache Software Foundation (ASF) under one

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1055#discussion_r51604676 --- Diff: storm-core/src/jvm/org/apache/storm/Thrift.java --- @@ -0,0 +1,351 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1055#discussion_r51604769 --- Diff: storm-core/src/clj/org/apache/storm/internal/thrift.clj --- @@ -0,0 +1,291 @@ +;; Licensed to the Apache Software Foundation (ASF) under one

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1055#discussion_r51604911 --- Diff: storm-core/src/jvm/org/apache/storm/Thrift.java --- @@ -0,0 +1,351 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] storm pull request: STORM-1504: Add Serializer and instruction for...

2016-02-02 Thread ptgoetz
Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/1052#discussion_r51607023 --- Diff: external/storm-hdfs/README.md --- @@ -315,6 +314,18 @@ An `org.apache.avro.Schema` object cannot be directly provided since it does not The

[jira] [Commented] (STORM-1504) AvroGenericRecordBolt will not work in a topology with multiple workers

2016-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128669#comment-15128669 ] ASF GitHub Bot commented on STORM-1504: --- Github user ptgoetz commented on a diff in the pull

[GitHub] storm pull request: STORM-1504: Add Serializer and instruction for...

2016-02-02 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/1052#issuecomment-178722021 One minor issue with the markdown formatting in the README, but I'm +1 once that's fixed. --- If your project is set up for it, you can reply to this email and have

[jira] [Commented] (STORM-1504) AvroGenericRecordBolt will not work in a topology with multiple workers

2016-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128673#comment-15128673 ] ASF GitHub Bot commented on STORM-1504: --- Github user ptgoetz commented on the pull request:

Re: Performance Profiling - Storm core

2016-02-02 Thread Roshan Naik
Looks like the attachments were stripped off. So resending with links to profiler screenshots. Call tree: https://github.com/roshannaik/storm-benchmark-sol/blob/master/profiler/storm%20core%20-%20sol%20-%200%20acker/storm%20core%20-%20call%20tree.png Method stats:

[jira] [Updated] (STORM-1520) Nimbus Clojure/Zookeeper issue ("stateChanged" method not found)

2016-02-02 Thread P. Taylor Goetz (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] P. Taylor Goetz updated STORM-1520: --- Description: Placeholder until I can gather more information for reproducing the issue. The

[jira] [Updated] (STORM-1520) Nimbus Clojure/Zookeeper issue ("stateChanged" method not found)

2016-02-02 Thread P. Taylor Goetz (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] P. Taylor Goetz updated STORM-1520: --- Priority: Blocker (was: Major) > Nimbus Clojure/Zookeeper issue ("stateChanged" method not

[jira] [Commented] (STORM-1519) Storm syslog logging not confirming to RFC5426 3.1

2016-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129643#comment-15129643 ] ASF GitHub Bot commented on STORM-1519: --- Github user jerrypeng commented on the pull request:

[GitHub] storm pull request: [STORM-1519] - Storm syslog logging not confir...

2016-02-02 Thread jerrypeng
Github user jerrypeng commented on the pull request: https://github.com/apache/storm/pull/1068#issuecomment-178962569 Well this only changes that config for the syslog appender. The syslog appender writes data to a network socket. This doesn't change the other appenders that will

[jira] [Commented] (STORM-1519) Storm syslog logging not confirming to RFC5426 3.1

2016-02-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129642#comment-15129642 ] ASF GitHub Bot commented on STORM-1519: --- Github user jerrypeng commented on the pull request:

[GitHub] storm pull request: [STORM-1519] - Storm syslog logging not confir...

2016-02-02 Thread jerrypeng
Github user jerrypeng commented on the pull request: https://github.com/apache/storm/pull/1068#issuecomment-178963442 If a user has a log parser that adheres to RFC5426, then how log4j2 is configured to write to syslog is a problem. --- If your project is set up for it, you can

  1   2   >