Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77253867
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java ---
@@ -0,0 +1,629 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77260851
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java ---
@@ -0,0 +1,644 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1642
I think I have addressed most of the issues so far. I have been running
some manual tests and have run a cluster with run as user and cgroup
enforcement enabled. I plan on doing some more tests,
Stig Rohde Døssing created STORM-2076:
-
Summary: Supervisor sync-processes and sync-supervisor race when
downloading new topology code.
Key: STORM-2076
URL: https://issues.apache.org/jira/browse/STORM-2076
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1667
Hi @srdo,
Great catch and thanks for the contribution.
Btw, as we're continuously suffering race conditions in supervisor,
@revans2 proposed new supervisor design and submitted pull
[
https://issues.apache.org/jira/browse/STORM-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jungtaek Lim resolved STORM-2070.
-
Resolution: Fixed
Fix Version/s: 1.0.3
1.1.0
2.0.0
[
https://issues.apache.org/jira/browse/STORM-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jungtaek Lim closed STORM-2046.
---
Resolution: Duplicate
Duplicated via STORM-2040
> Errors when using
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1660
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/1667
STORM-2076: Add new atom to prevent sync-processes from deleting new â¦
â¦topology code
@HeartSaVioR Could you take a look at this? I'll make a similar change on
master if you think this is
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1668
STORM-2040 Fix bug on assert-can-serialize
* type of element of tuple-batch is changed to AddressedTuple but not
reflected to assert-can-serialize
* it only raises issue when
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/1670
[STORM-2079] - Unneccessary readStormConfig operation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jerrypeng/storm STORM-2079
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1670
+1 pending SD
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77245653
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/AdvancedFSOps.java ---
@@ -0,0 +1,314 @@
+/**
+ * Licensed to the Apache Software
Github user priyank5485 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1665#discussion_r77237088
--- Diff:
external/storm-kafka-monitor/src/main/java/org/apache/storm/kafka/monitor/KafkaOffsetLagUtil.java
---
@@ -89,6 +89,10 @@ public static void
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77141710
--- Diff:
storm-core/src/jvm/org/apache/storm/container/ResourceIsolationInterface.java
---
@@ -56,4 +64,13 @@
*/
List
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77154990
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java ---
@@ -0,0 +1,493 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77154288
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java ---
@@ -0,0 +1,493 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77143604
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/AdvancedFSOps.java ---
@@ -0,0 +1,314 @@
+/**
+ * Licensed to the Apache Software
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77144436
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/AdvancedFSOps.java ---
@@ -0,0 +1,314 @@
+/**
+ * Licensed to the Apache Software
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77144475
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/LocalContainer.java ---
@@ -0,0 +1,85 @@
+/**
+ * Licensed to the Apache Software
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77150344
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java ---
@@ -0,0 +1,644 @@
+/**
+ * Licensed to the Apache Software
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1667
@HeartSaVioR Sure, the new design looks much nicer. I agree that
backporting the new design if it works well makes more sense than to keep
patching these race conditions.
---
If your project is set
Tobias Maier created STORM-2077:
---
Summary: KafkaSpout doesn't retry failed tuples
Key: STORM-2077
URL: https://issues.apache.org/jira/browse/STORM-2077
Project: Apache Storm
Issue Type: Bug
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77151542
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java ---
@@ -0,0 +1,644 @@
+/**
+ * Licensed to the Apache Software
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1666
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/STORM-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jungtaek Lim resolved STORM-1459.
-
Resolution: Fixed
Fix Version/s: 1.1.0
2.0.0
Great work [~mauzhang], I
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1662
still +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1662
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user manuzhang commented on the issue:
https://github.com/apache/storm/pull/1671
Oh, I missed that. I will comment there and, FYI, some license headers are
not in the right form
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user manuzhang closed the pull request at:
https://github.com/apache/storm/pull/1671
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user manuzhang opened a pull request:
https://github.com/apache/storm/pull/1671
STORM-2080: storm-submit-tools license check failure
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manuzhang/storm STORM-2080
[
https://issues.apache.org/jira/browse/STORM-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jungtaek Lim closed STORM-2080.
---
Resolution: Duplicate
> storm-submit-tools license check failure
>
[
https://issues.apache.org/jira/browse/STORM-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jungtaek Lim resolved STORM-1344.
-
Resolution: Fixed
Assignee: Paul Poulosky
Fix Version/s: 1.0.3
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1648#discussion_r77280313
--- Diff:
external/storm-submit-tools/src/main/java/org/apache/storm/submit/dependency/Booter.java
---
@@ -37,16 +37,19 @@ public static
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1648
Also fixed license form as @manuzhang found.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Manu Zhang created STORM-2080:
-
Summary: storm-submit-tools license check failure
Key: STORM-2080
URL: https://issues.apache.org/jira/browse/STORM-2080
Project: Apache Storm
Issue Type: Bug
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1670
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1671
Duplicated #1648 (STORM-2054)
Actually there's also a bug which doesn't handle relative path vs absolute
path.
---
If your project is set up for it, you can reply to this email and have
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/storm/pull/1648#discussion_r77279412
--- Diff:
external/storm-submit-tools/src/main/java/org/apache/storm/submit/dependency/Booter.java
---
@@ -37,16 +37,19 @@ public static
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1648#discussion_r77279840
--- Diff:
external/storm-submit-tools/src/main/java/org/apache/storm/submit/dependency/Booter.java
---
@@ -37,16 +37,19 @@ public static
Hi devs,
I just created epic issue for Storm SQL phase 3 which tracks efforts for
adding available data sources for Storm SQL.
https://issues.apache.org/jira/browse/STORM-2075
Currently Storm SQL only supports Apache Kafka as producer (input table)
and consumer (output table) which is not
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1661
I would be happy to pull that fix back into a separate patch. @ppoulosk
this patch looks fine to me, my only concern would be documenting it a little
more explaining that the state change might not
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1565#discussion_r77186650
--- Diff: examples/storm-mqtt-examples/pom.xml ---
@@ -24,18 +24,24 @@
storm-mqtt-examples
-
-org.apache.storm
-
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1565
hi @HeartSaVioR
Of course, we should make sure that all examples are 'runnable'.
>profile trick to change scope of 'storm-core' : other modules use
'intellij' profile
Actually, I
Github user ppoulosk commented on the issue:
https://github.com/apache/storm/pull/1662
@abellina Yes. I've now pushed the change without the plugin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user abellina commented on the issue:
https://github.com/apache/storm/pull/1662
+1 Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
[
https://issues.apache.org/jira/browse/STORM-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455843#comment-15455843
]
Boyang Jerry Peng commented on STORM-2056:
--
[~kabhwan],
Thanks for merging in the fix! What
[
https://issues.apache.org/jira/browse/STORM-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Boyang Jerry Peng updated STORM-2056:
-
Comment: was deleted
(was: [~kabhwan],
Thanks for merging in the fix! What about 2.x
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77294478
--- Diff: storm-core/src/jvm/org/apache/storm/utils/ConfigUtils.java ---
@@ -512,6 +463,10 @@ public static String workerTmpRoot(Map conf, String
id) {
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77294585
--- Diff: storm-core/src/jvm/org/apache/storm/utils/ConfigUtils.java ---
@@ -353,25 +350,21 @@ public LocalState nimbusTopoHistoryStateImpl(Map
conf)
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77296684
--- Diff:
storm-core/test/jvm/org/apache/storm/daemon/supervisor/BasicContainerTest.java
---
@@ -0,0 +1,459 @@
+package
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1565
@vesense You can refer pom.xml of storm-starter to see the trick. It
determines whether we apply 'provided' or 'compile' via property and profile.
Alessandro Bellina created STORM-2078:
-
Summary: Enable paging in worker data tables
Key: STORM-2078
URL: https://issues.apache.org/jira/browse/STORM-2078
Project: Apache Storm
Issue
GitHub user abellina opened a pull request:
https://github.com/apache/storm/pull/1669
STORM-2078: enable paging in worker datatable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/abellina/storm
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1669
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user abellina commented on the issue:
https://github.com/apache/storm/pull/1662
@ppoulosk were you able to test without the plugin all together?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
[
https://issues.apache.org/jira/browse/STORM-2075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jungtaek Lim updated STORM-2075:
Description:
This epic tracks the effort of the phase III development of StormSQL.
For now Storm
1. git clone https://github.com/apache/storm.git storm-master
2. in storm-master -> mvn clean install -DskipTests=true -e
this command rise errors like bellow
[INFO] Building storm-hdfs 2.0.0-SNAPSHOT
[INFO]
[INFO]
[INFO]
Hi,
At first you would want to check if that machine can reach
http://repo1.maven.org/maven2/. If it's not you need to make sure or setup
mirror for maven repo.
And that fail occasionally happens (I mean intermittently) so you might
want to retry the build.
Hope this helps. Please let me know if
Github user ppoulosk commented on the issue:
https://github.com/apache/storm/pull/1662
@HeartSaVioR Thanks for the review!! I've squashed commits and added JIRA
to commit comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
60 matches
Mail list logo
