[GitHub] storm issue #1714: STORM-2125 Use Calcite's implementation of Rex Compiler

2016-10-12 Thread arunmahadevan
Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/1714 @HeartSaVioR I suggested to keep an option to plug our code generator. If you think calcites code generator (linq4j) addresses all the current cases then lets go with that. We can revisit

[GitHub] storm pull request #1714: STORM-2125 Use Calcite's implementation of Rex Com...

2016-10-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1714 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1714: STORM-2125 Use Calcite's implementation of Rex Compiler

2016-10-12 Thread arunmahadevan
Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/1714 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #1714: STORM-2125 Use Calcite's implementation of Rex Compiler

2016-10-12 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1714 @arunmahadevan Yes ideally we really want to have it. I just said that ExprCompiler seems not having a value to keep and maintain. Agreed with you. Thanks for reviewing! --- If your project is

[GitHub] storm issue #1714: STORM-2125 Use Calcite's implementation of Rex Compiler

2016-10-12 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1714 @arunmahadevan I'm not sure we can have our own expression compiler which supports features competitive to Calcite. It reminds me why this change is necessary. We have been leaving

[GitHub] storm issue #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch

2016-10-12 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1591 @hsun-cnnxty Sorry I lost tracking this. From the last time I tested on my local machine (via ThroughputVsLatency), before patching this works better than after patching this. My test

[GitHub] storm issue #1727: STORM-2136 Write some examples to show the usage of Storm...

2016-10-12 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1727 I'll just merge it since preconditions are met and this change is limited to documentation. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] storm issue #1725: STORM-2135 document covered features of SQL reference in ...

2016-10-12 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1725 I'll just merge it since preconditions are met and this change is limited to documentation. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] storm pull request #1725: STORM-2135 document covered features of SQL refere...

2016-10-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1725 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request #1727: STORM-2136 Write some examples to show the usage o...

2016-10-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1727 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1714: STORM-2125 Use Calcite's implementation of Rex Compiler

2016-10-12 Thread arunmahadevan
Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/1714 @HeartSaVioR with this change we are going to be heavily dependent on the calcite's code generator to translate expressions correct?. Just thinking if we should have an option to make the code

[GitHub] storm pull request #1340: STORM-1682: Refactor DynamicBrokersReader to looku...

2016-10-12 Thread srdo
Github user srdo closed the pull request at: https://github.com/apache/storm/pull/1340 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1340: STORM-1682: Refactor DynamicBrokersReader to lookup leade...

2016-10-12 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/1340 Closing this, we aren't using this spout anymore and it's a big change to fix some very minor pausing --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: [DISCUSS] Plan for merge SQE and Storm SQL

2016-10-12 Thread Haohui Mai
Please allow me to share some of the thoughts on this front: 1. The concepts of monotonic primary key is ensure forward progress for the query from the relational standpoints -- essentially the results are append-only streams. The key does not need to be tied to the data itself. It can be an