[GitHub] storm pull request #1755: error log for blobstore was missing a space betwee...

2016-11-01 Thread erikdw
GitHub user erikdw opened a pull request: https://github.com/apache/storm/pull/1755 error log for blobstore was missing a space between string 'key' and … …the actual key value Example: 2016-11-01 06:09:58.001 o.a.s.b.BlobStoreUtils [ERROR] Could not download

[GitHub] storm issue #1754: [STORM-2177][STORM-2173][SQL] Support TSV/CSV as input / ...

2016-11-01 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1754 I added STORM-2173 to current PR since it is on top of #1751 too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] storm pull request #1687: Apache master storm 1694 top storm 2097

2016-11-01 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1687#discussion_r85980640 --- Diff: examples/storm-starter/src/jvm/org/apache/storm/starter/trident/TridentKafkaClientWordCountWildcardTopics.java --- @@ -0,0 +1,51 @@ +/* + *

[GitHub] storm pull request #1757: Apache master storm 2182 top storm 1694

2016-11-01 Thread hmcl
GitHub user hmcl opened a pull request: https://github.com/apache/storm/pull/1757 Apache master storm 2182 top storm 1694 This patch complements addresses the code review comments in STORM-1694 concerning the examples. It was the cleanest way to address them was to create its own

[GitHub] storm pull request #1687: Apache master storm 1694 top storm 2097

2016-11-01 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1687#discussion_r85980768 --- Diff: examples/storm-starter/src/jvm/org/apache/storm/starter/trident/DebugMemoryMapState.java --- @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache

[GitHub] storm pull request #1687: Apache master storm 1694 top storm 2097

2016-11-01 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1687#discussion_r85981903 --- Diff: examples/storm-starter/src/jvm/org/apache/storm/starter/trident/TridentKafkaClientWordCountNamedTopics.java --- @@ -0,0 +1,122 @@ +/* + *

[GitHub] storm pull request #1687: Apache master storm 1694 top storm 2097

2016-11-01 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1687#discussion_r85983348 --- Diff: examples/storm-starter/src/jvm/org/apache/storm/starter/trident/TridentKafkaClientWordCountNamedTopics.java --- @@ -0,0 +1,122 @@ +/* + *

[GitHub] storm pull request #1687: Apache master storm 1694 top storm 2097

2016-11-01 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1687#discussion_r85983373 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutEmitter.java --- @@ -0,0 +1,187 @@ +/* + *

[GitHub] storm pull request #1687: Apache master storm 1694 top storm 2097

2016-11-01 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1687#discussion_r85983568 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutBatchMetadata.java --- @@ -0,0 +1,83 @@ +/* +

[GitHub] storm issue #1687: Apache master storm 1694 top storm 2097

2016-11-01 Thread hmcl
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/1687 @HeartSaVioR I believe I address your valid concerns about the kafka library versions in this [PR](https://github.com/apache/storm/pull/1757) --- If your project is set up for it, you can reply to

[GitHub] storm issue #1753: STORM-2180: KafkaSpout ack() should handle re-balance - 1...

2016-11-01 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1753 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #1752: STORM-2180: KafkaSpout ack() should handle re-balance

2016-11-01 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/1752 This is also fixed by https://github.com/apache/storm/pull/1696, please take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If