[GitHub] storm issue #1812: Updating Trident RAS Documentation.

2016-12-02 Thread jerrypeng
Github user jerrypeng commented on the issue: https://github.com/apache/storm/pull/1812 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #1764: STORM-2190: reduce contention between submission and sche...

2016-12-02 Thread jerrypeng
Github user jerrypeng commented on the issue: https://github.com/apache/storm/pull/1764 LGTM +1 @revans2 thanks for making the optimizations --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm issue #1812: Updating Trident RAS Documentation.

2016-12-02 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1812 +1 Thanks for the update. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

2016-12-02 Thread kosii
Github user kosii commented on the issue: https://github.com/apache/storm/pull/1470 @arunmahadevan yes, check #1811 please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm issue #1810: STORM-2204 Adding Bolt side caching for HBase Lookup Bolt...

2016-12-02 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1810 @ambud Code looks good, but indentation is really off. Could you take care of it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] storm pull request #1811: STORM-1886 Extend KeyValueState iface with delete

2016-12-02 Thread kosii
GitHub user kosii opened a pull request: https://github.com/apache/storm/pull/1811 STORM-1886 Extend KeyValueState iface with delete The same as #1470, just against the [1.x-branch](https://github.com/apache/storm/tree/1.x-branch) This pull request incorporates #1606 and

[GitHub] storm pull request #1810: STORM-2204 Adding Bolt side caching for HBase Look...

2016-12-02 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1810#discussion_r90638449 --- Diff: external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/HBaseLookupBolt.java --- @@ -56,6 +66,30 @@ public HBaseLookupBolt

[GitHub] storm pull request #1742: STORM-2170 [Storm SQL] Add built-in socket datasou...

2016-12-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1742 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1806: STORM-2226: Fix kafka spout offset lag ui for kerberized ...

2016-12-02 Thread satishd
Github user satishd commented on the issue: https://github.com/apache/storm/pull/1806 Thanks @priyank5485, merged into master and 1.x-branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm issue #1781: STORM-1369: Add MapState implementation to storm-cassandr...

2016-12-02 Thread mkoch1
Github user mkoch1 commented on the issue: https://github.com/apache/storm/pull/1781 Did not notice that, sorry. Replaced now with an external resource implementation. The code is not all that complex so it's not a big deal. One thing I should point out: I borrowed the base

[GitHub] storm issue #1764: STORM-2190: reduce contention between submission and sche...

2016-12-02 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1764 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1800: STORM-2217: Make DRPC pure java

2016-12-02 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1800 Shading Jersey is becoming rather difficult (lots of dependencies including aop and dependency injection. Splitting the DPRC server off into it's own location seems much simpler and less error

[GitHub] storm pull request #1802: STORM-2209: 1.x-branch Update documents adding new...

2016-12-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1802 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1776: STORM-2200 [Storm SQL] Drop Aggregate & Join support on T...

2016-12-02 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1776 I'd like to get this merged before releasing 1.1.0 so that users don't experience existing features are dropped. If someone can take a look I'd really appreciate it. --- If your project is set

[GitHub] storm issue #1764: STORM-2190: reduce contention between submission and sche...

2016-12-02 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1764 +1. Please apply the optimization to #1765 as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request #1795: STORM-2215: validate blobs are present before subm...

2016-12-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1795 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1795: STORM-2215: validate blobs are present before submitting

2016-12-02 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1795 +1 Thanks for the work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm issue #1767: STORM-2194: Report error and die, not report error or die

2016-12-02 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1767 We should be able to fix this with code like. ``` (if (or (exception-cause? InterruptedException error) (and (exception-cause?

[GitHub] storm issue #1767: STORM-2194: Report error and die, not report error or die

2016-12-02 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1767 @chawco Okay so I understand the issue better now. SocketTimeoutException is a subclass of InterruptedIOException.

[GitHub] storm issue #1764: STORM-2190: reduce contention between submission and sche...

2016-12-02 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1764 @ptgoetz @jerrypeng I made a few changes to thing. I fixed the race condition and I addressed the review comments, but I also put in some optimizations to storm submitter. We were

[GitHub] storm pull request #1812: Updating Trident RAS Documentation.

2016-12-02 Thread knusbaum
GitHub user knusbaum opened a pull request: https://github.com/apache/storm/pull/1812 Updating Trident RAS Documentation. Adding documentation for defaults, clarifying other parts. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] storm issue #913: Fix typo in get_jars_full

2016-12-02 Thread erikdw
Github user erikdw commented on the issue: https://github.com/apache/storm/pull/913 Pointer to the new PR referenced above: https://github.com/apache/storm/pull/924 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[BROKEN BUILD] - Master not compiling for me

2016-12-02 Thread Hugo Da Cruz Louro
[ERROR] /Users/hlouro/Apache/Dev/GitHub/hmcl/storm-apache/storm-core/src/jvm/org/apache/storm/daemon/nimbus/Nimbus.java:[2297,23] incompatible types: inferred type does not conform to upper bound(s) inferred: java.util.Map upper bound(s):

Re: [BROKEN BUILD] - Master not compiling for me

2016-12-02 Thread Hugo Da Cruz Louro
java version "1.8.0_45" Java(TM) SE Runtime Environment (build 1.8.0_45-b14) Java HotSpot(TM) 64-Bit Server VM (build 25.45-b02, mixed mode) On Dec 2, 2016, at 11:01 AM, P. Taylor Goetz > wrote: I’m able to build the master branch just fine. What JDK

Re: [BROKEN BUILD] - Master not compiling for me

2016-12-02 Thread P. Taylor Goetz
My guess is this bug: http://bugs.java.com/bugdatabase/view_bug.do?bug_id=8080645 I’m on Java(TM) SE Runtime Environment (build 1.8.0_112-b16) and it compiles for me. -Taylor > On Dec 2, 2016, at 2:07 PM, Hugo Da Cruz Louro

Re: [BROKEN BUILD] - FIXED with Latest JDK 8

2016-12-02 Thread Hugo Da Cruz Louro
It compiles upgrading to latest JDK 8 java version "1.8.0_112" Java(TM) SE Runtime Environment (build 1.8.0_112-b16) Java HotSpot(TM) 64-Bit Server VM (build 25.112-b16, mixed mode) On Dec 2, 2016, at 11:26 AM, P. Taylor Goetz > wrote: My guess is

Re: [BROKEN BUILD] - Master not compiling for me

2016-12-02 Thread P. Taylor Goetz
I’m able to build the master branch just fine. What JDK version are you using? -Taylor > On Dec 2, 2016, at 1:54 PM, Hugo Da Cruz Louro wrote: > > [ERROR] >

Re: topology.debug always true

2016-12-02 Thread Ohad Edelstein
I am embarrassed to say that you are right... thanks! But what is the difference between the two? Thanks From: Mostafa Gomaa > Reply-To: "u...@storm.apache.org" > Date: