[GitHub] storm issue #1785: [STORM-2201] Add dynamic scheduler configuration loading.

2016-12-14 Thread abellina
Github user abellina commented on the issue: https://github.com/apache/storm/pull/1785 @ppoulosk can we add a document as @revans2 suggested? A markdown file should do it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] storm pull request #1826: STORM-2087 1.x

2016-12-14 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/1826 STORM-2087 1.x Backport STORM-2087 to 1.x See https://github.com/apache/storm/pull/1679 for master version You can merge this pull request into a Git repository by running: $ git pull

[GitHub] storm issue #1825: STORM-2236 storm kafka client support manual partition ma...

2016-12-14 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/1825 Hi. STORM-2077 is being resolved here https://issues.apache.org/jira/browse/STORM-2087. Sorry for the inconvenience. I'm not sure I understand why adding manual partition management is

[GitHub] storm pull request #1827: STORM-2243: adds ip address to supervisor id

2016-12-14 Thread abellina
GitHub user abellina opened a pull request: https://github.com/apache/storm/pull/1827 STORM-2243: adds ip address to supervisor id The supervisor id is a simple UUID currently. If there are issues with the heartbeat messages from supervisor, looking at Zookeeper makes it hard to

[GitHub] storm issue #1818: STORM-2104 1.x

2016-12-14 Thread hmcl
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/1818 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1783: STORM-2204 Adding caching capabilities in HBaseLookupBolt

2016-12-14 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1783 @ambud Sorry for the delay response. Before we merge this in, can you replace all the tab space to white space? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm issue #1810: STORM-2204 Adding Bolt side caching for HBase Lookup Bolt...

2016-12-14 Thread ambud
Github user ambud commented on the issue: https://github.com/apache/storm/pull/1810 Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1825: STORM-2236 storm kafka client support manual partition ma...

2016-12-14 Thread liurenjie1024
Github user liurenjie1024 commented on the issue: https://github.com/apache/storm/pull/1825 Maybe we do not need to maintain two versions of `KafkaSpout` with same functionality. The main goal of automatic partition management is to ease fault tolerant in simple applications, not in

[GitHub] storm issue #1783: STORM-2204 Adding caching capabilities in HBaseLookupBolt

2016-12-14 Thread ambud
Github user ambud commented on the issue: https://github.com/apache/storm/pull/1783 Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1825: STORM-2236 storm kafka client support manual partition ma...

2016-12-14 Thread liurenjie1024
Github user liurenjie1024 commented on the issue: https://github.com/apache/storm/pull/1825 I think the behavior of consumer's automatic partition management is complicated and may lead to unpredictable behavior, which is quite important for many purposes like debugging, performance

[GitHub] storm pull request #1826: STORM-2087 1.x

2016-12-14 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1826#discussion_r92546386 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -77,7 +77,7 @@ private KafkaSpoutStreams

[GitHub] storm issue #1825: STORM-2236 storm kafka client support manual partition ma...

2016-12-14 Thread hmcl
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/1825 @liurenjie1024 putting aside for a second the discussion about the need to implement partition assignment, if we indeed agree that we should support it, I think that the `KafkaSpout` class is getting a