This vote is now closed and passes with 3 binding +1 votes, 1 non-binding +1
vote, and one non-binding 0 vote.
Vote tally (* denotes a binding vote):
+1:
Jungtaek Lim*
Stig Rohde Døssing*
Priank Shah
P. Taylor Goetz*
+0:
Alexandre Vermeerbergen
Thanks to everyone who took the time to
Thanks for the bump Jungtaek. I know my +1 vote would take this vote to the
necessary count, but my hope was that other PMC members would vote as well (I
like to see at least 3 binding +1s outside of the RM’s vote). Nonetheless…
+1 (binding)
Setup a multi-node cluster and rand my usual suite of
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2319
@danny0405 I am not concerned about the memory for the cache, because we
are already keeping all of that in memory while we schedule the topologies
anyways. If it does prove to be an issue we can
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138657756
--- Diff: storm-core/src/clj/org/apache/storm/cluster.clj ---
@@ -123,6 +133,7 @@
(def SUPERVISORS-SUBTREE (str "/" SUPERVISORS-ROOT))
(def
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138662036
--- Diff:
storm-core/src/jvm/org/apache/storm/assignments/AssignmentDistributionService.java
---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138663085
--- Diff:
storm-core/src/jvm/org/apache/storm/assignments/AssignmentDistributionService.java
---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138659723
--- Diff: storm-core/src/clj/org/apache/storm/cluster.clj ---
@@ -244,15 +255,19 @@
;; Watches should be used for optimization. When ZK is
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138659373
--- Diff: storm-core/src/clj/org/apache/storm/cluster.clj ---
@@ -244,15 +255,19 @@
;; Watches should be used for optimization. When ZK is
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138662304
--- Diff:
storm-core/src/jvm/org/apache/storm/assignments/AssignmentDistributionService.java
---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the Apache
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2156
@WolfeeTJ Thanks for trying this out. I think you are right that it's
because partition reassignment is happening at a bad time. I think we should
move reassignment to be the first thing in nextTuple
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2156
@WolfeeTJ I think it's fixed now, please take a look at the new commit.
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2324
---
Hi devs,
I have seen some old pull requests for bugfix and new feature going to be
stale. Some of us tried to ping to author several times but not respond in
some months. For new feature we may have to wait for authors, but for
bugfix waiting authors means we are aware of the bug but we don't fix
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138791919
--- Diff:
storm-core/src/jvm/org/apache/storm/assignments/AssignmentDistributionService.java
---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138780747
--- Diff: storm-core/src/clj/org/apache/storm/cluster.clj ---
@@ -244,15 +255,19 @@
;; Watches should be used for optimization. When ZK is
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138781163
--- Diff:
storm-core/src/jvm/org/apache/storm/assignments/AssignmentDistributionService.java
---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138781061
--- Diff: storm-core/src/clj/org/apache/storm/cluster.clj ---
@@ -244,15 +255,19 @@
;; Watches should be used for optimization. When ZK is
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm-site/pull/1
Which pair(s) of OS and Ruby version are you trying out?
I'm trying out the change but I'm experiencing crash on redcarpet.
(redcarpet.rb has `require 'redcarpet.so'` but there's no file)
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2319#discussion_r138780949
--- Diff: storm-core/src/clj/org/apache/storm/cluster.clj ---
@@ -123,6 +133,7 @@
(def SUPERVISORS-SUBTREE (str "/" SUPERVISORS-ROOT))
(def
Hi Bobby,
Thank you very much for the details. I'm not fixed on a specific version
yet, would prefer the latest. Is it possible to run with minimum network
usage, apart from receiving and delivering tuples, such as shutting down
ackers, running with no supervision, pros and cons of that, etc. Do
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2319
Before looking into detail, according to design doc, as I commented to the
JIRA issue, I don't see a reason to store cache to disk or so, since ZK is
still a source of truth and whenever process
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2324
+1
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2317
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2317
Built in my local and verified it passed with JDK 7. +1
---
Github user hmcc commented on the issue:
https://github.com/apache/storm/pull/2320
Rebased & squashed.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2320
Still +1
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2323
Still +1
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2323
---
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2319
@HeartSaVioR @revans2
i have change the default backend to memory one, also i change the
distribute mode to asynchronous
i chose a rocks-db backend because when the cluster goes to large,
Github user hmcc commented on the issue:
https://github.com/apache/storm/pull/2323
Rebased & squashed.
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2320
---
31 matches
Mail list logo
