[GitHub] storm pull request #2632: spelling fixes

2018-04-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2632 ---

[GitHub] storm pull request #2629: [STORM-3023] fix the issue that Storm UI not showi...

2018-04-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2629 ---

[GitHub] storm pull request #2634: [STORM-3021] Fix wrong usages of Config.TOPOLOGY_W...

2018-04-13 Thread Ethanlm
Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2634#discussion_r181472816 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java --- @@ -305,8 +305,9 @@ private void setupFlushTupleTimer(final Map

[GitHub] storm pull request #2634: [STORM-3021] Fix wrong usages of Config.TOPOLOGY_W...

2018-04-13 Thread agresch
Github user agresch commented on a diff in the pull request: https://github.com/apache/storm/pull/2634#discussion_r181480542 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java --- @@ -305,8 +305,9 @@ private void setupFlushTupleTimer(final Map

[GitHub] storm pull request #2628: STORM-2908 Document Metrics V2 for 2.0.0

2018-04-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2628 ---

[GitHub] storm issue #2632: spelling fixes

2018-04-13 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2632 Never mind. It is really tiny and doc change so might not matter anyway. ---

Configuration mapping between storm-kafka & storm-kafka-client

2018-04-13 Thread Srishty Agrawal
Hi, Is there a document which contains mapping of configurations from storm-kafka SpoutConfig to storm-kafka-client KafkaSpoutConfig? I am working towards migrating Storm-0.9.6 topologies to use Storm-1.0.6. I have compiled all the information I could find online in this gist

[GitHub] storm pull request #2634: [STORM-3021] Fix wrong usages of Config.TOPOLOGY_W...

2018-04-13 Thread erikdw
Github user erikdw commented on a diff in the pull request: https://github.com/apache/storm/pull/2634#discussion_r181535091 --- Diff: storm-client/src/jvm/org/apache/storm/Config.java --- @@ -372,9 +374,10 @@ /** * How many executors to spawn for ackers.

Re: New Committer/PMC Member: Roshan Naik

2018-04-13 Thread Srishty Agrawal
Congratulations Roshan! On Wed, Apr 11, 2018 at 11:50 AM, Seema Joshi wrote: > Congrats Roshan!! > > On Sat, Apr 7, 2018 at 12:15 AM, Roshan Naik > > wrote: > > > Thanks to everyone here and on the PMC list ! -Roshan > > > > > > Sent

[GitHub] storm issue #2000: STORM-2411 Setting topology.eventlogger.executors=0 in de...

2018-04-13 Thread roshannaik
Github user roshannaik commented on the issue: https://github.com/apache/storm/pull/2000 thanks. ---

[GitHub] storm pull request #2634: [STORM-3021] Fix wrong usages of Config.TOPOLOGY_W...

2018-04-13 Thread agresch
Github user agresch commented on a diff in the pull request: https://github.com/apache/storm/pull/2634#discussion_r181427545 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java --- @@ -305,8 +305,9 @@ private void setupFlushTupleTimer(final Map