[GitHub] storm issue #2066: [STORM-2472] kafkaspout should work normally in kerberos ...

2018-05-15 Thread aniketalhat
Github user aniketalhat commented on the issue: https://github.com/apache/storm/pull/2066 @liu-zhaokun how did you manage to solve this? Currently new storm-kafka-client isn't very stable and doesn't support the transactional spout. I've to connect to Kafka (0.11.0.2) via. Kerberos

[GitHub] storm issue #2066: [STORM-2472] kafkaspout should work normally in kerberos ...

2018-05-15 Thread liu-zhaokun
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2066 @aniketalhat You can look through my PR,and my intention was to export java.security.auth.login.config=the path to your keytab,and it works.You can try it. ---

[GitHub] storm-site pull request #5: Style tables so they appear similar to how they ...

2018-05-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm-site/pull/5 ---

[GitHub] storm-site issue #5: Style tables so they appear similar to how they look on...

2018-05-15 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm-site/pull/5 Thanks for the reviews, I'll merge and push this to the site. @erikdw I probably should have thought to include a screenshot, thanks :) ---

[GitHub] storm pull request #2674: STORM-3072: Reduce fork count for storm-sql-core t...

2018-05-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2674 ---

[GitHub] storm pull request #2676: STORM-3073: Uncap pendingEmits for bolt executors,...

2018-05-15 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2676 STORM-3073: Uncap pendingEmits for bolt executors, and prevent LoadSpout from overflowing pendingEmits in spout executors https://issues.apache.org/jira/browse/STORM-3073 The first commit

[GitHub] storm issue #2066: [STORM-2472] kafkaspout should work normally in kerberos ...

2018-05-15 Thread aniketalhat
Github user aniketalhat commented on the issue: https://github.com/apache/storm/pull/2066 Hello Liu, Thanks for your quick reply, my one concern is that your PR is for storm-kafka-client(new consumer) where as I'm looking for storm-kafka(old consumer) solution, what do

[GitHub] storm pull request #2669: [STORM-3055] remove conext connection cache

2018-05-15 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2669#discussion_r188377925 --- Diff: storm-client/src/jvm/org/apache/storm/messaging/IContext.java --- @@ -38,6 +38,7 @@ /** * This method establishes a server

[GitHub] storm issue #2669: [STORM-3055] remove conext connection cache

2018-05-15 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2669 As far as I can tell all connections are still being shut down with this change. The connections cached by WorkerState are closed during worker shutdown in

[GitHub] storm pull request #2669: [STORM-3055] remove conext connection cache

2018-05-15 Thread pczb
Github user pczb commented on a diff in the pull request: https://github.com/apache/storm/pull/2669#discussion_r188355473 --- Diff: storm-client/src/jvm/org/apache/storm/messaging/netty/Client.java --- @@ -451,7 +451,6 @@ public int getPort() { public void close() {

[GitHub] storm issue #2669: [STORM-3055] remove conext connection cache

2018-05-15 Thread pczb
Github user pczb commented on the issue: https://github.com/apache/storm/pull/2669 @srdo add doc specification, i was wonder if we need remove synchronized when bind port @revans2 just as srdo says the connection will be closed by the worker before worker shutdown. i will

[GitHub] storm issue #2677: STORM-3075 fix NPE

2018-05-15 Thread Ethanlm
Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2677 There might be a bug in the code: https://github.com/apache/storm/blob/master/storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java#L490-L497 ``` if (leaderElector ==

[GitHub] storm issue #2673: STORM-3070: Rewind buffer position if MessageDecoder enco...

2018-05-15 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2673 Okay, pretty sure I've seen this break now. Ran the TVL topology and got occasional worker crashes, e.g. ``` 2018-05-15 16:36:01.018 o.a.s.m.n.StormClientHandler client-worker-1 [INFO]

[GitHub] storm issue #2677: STORM-3075 fix NPE

2018-05-15 Thread agresch
Github user agresch commented on the issue: https://github.com/apache/storm/pull/2677 @Ethanlm - I see tc being null whenever I start nimbus (at least with no topologies). ---

[GitHub] storm pull request #2677: STORM-3075 fix NPE

2018-05-15 Thread agresch
GitHub user agresch opened a pull request: https://github.com/apache/storm/pull/2677 STORM-3075 fix NPE You can merge this pull request into a Git repository by running: $ git pull https://github.com/agresch/storm agresch_storm-3075 Alternatively you can review and apply

[GitHub] storm issue #2677: STORM-3075 fix NPE

2018-05-15 Thread Ethanlm
Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2677 It looks reasonable. But would like to understand more about it. Could you elaborate on in which case tc will be null? ---

[GitHub] storm issue #2677: STORM-3075 fix NPE

2018-05-15 Thread agresch
Github user agresch commented on the issue: https://github.com/apache/storm/pull/2677 @Ethanlm - nice catch. Will fix the source of the problem instead ---

[GitHub] storm issue #2677: STORM-3075 fix NPE

2018-05-15 Thread agresch
Github user agresch commented on the issue: https://github.com/apache/storm/pull/2677 @Ethanlm - please take a look. Thanks. ---